hgimenez-truncate_html 0.1.0 → 0.1.1

data/README.markdown

@@ -1,7 +1,7 @@
 TruncateHtml
 ============
 
-truncate_html is a Rails helper plugin that [cuts off](http://www.youtube.com/watch?v=6XG4DIOA7nU) a string of HTML and takes care of closing any lingering open tags. There are many possible solutions to this. This plugin does not have any dependencies, and does all it's work via regular expressions.
+truncate_html is a Rails helper plugin that [cuts off](http://www.youtube.com/watch?v=6XG4DIOA7nU) a string of HTML and takes care of closing any lingering open tags. There are many possible solutions to this. This plugin does not have any dependencies, and does all it's work via [regular expressions](http://xkcd.com/208/).
 
 The API is very similar to Rails' own truncate method.
 
@@ -26,10 +26,18 @@ A few notes:
 Installation
 ------------
 
-As a gem:
-<code>sudo gem install hgimenez-truncate_html</code>
+#### As a gem
+Add this to your <code>config/environment.rb</code>:
 
-As a plugin:
+    config.gem 'truncate_html',
+      :source => 'http://gemcutter.org'
+
+Then either
+<code>sudo rake gems:install</code>
+or
+<code>sudo gem install truncate_html</code>
+
+#### As a plugin:
 <code>script/plugin install git://github.com/hgimenez/truncate_html.git</code>
 
 Issues

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/lib/truncate_html/html_truncator.rb

@@ -27,7 +27,7 @@ module TruncateHtml
           result << str
         else
           result[-1] += options[:omission] unless options[:omission].nil?
-          @open_tags.reverse.each do |open_tag|
+          @open_tags.reverse_each do |open_tag|
             result << matching_close_tag(open_tag)
           end
           break
@@ -52,11 +52,11 @@ module TruncateHtml
     end
 
     def html_tag?(string)
-      if string =~ /<\/?[^>]+>/ then true else false end
+      string =~ /<\/?[^>]+>/ ? true : false
     end
 
     def open_tag?(html_tag)
-      if html_tag =~ /<(?!(?:#{UNPAIRED_TAGS.join('|')}|\/))[^\/>]+>/i then true else false end
+      html_tag =~ /<(?!(?:#{UNPAIRED_TAGS.join('|')}|\/))[^>]+>/i ? true : false
     end
 
     def remove_latest_open_tag(close_tag)

data/spec/helpers/truncate_html_helper_spec.rb

@@ -12,7 +12,7 @@ describe TruncateHtmlHelper do
 
     context 'truncating in the middle of a link' do
       before(:each) do
-        @html = '<div><ul><li>Look at <a href="foo">this</a> link <li></ul></div>'
+        @html = '<div><ul><li>Look at <a href="foo">this</a> link </li></ul></div>'
       end
 
       it 'should truncate, and close the <a>, and close any remaining open tags' do

data/spec/truncate_html/html_truncator_spec.rb

@@ -41,15 +41,15 @@ describe TruncateHtml::HtmlTruncator do
     end
 
     it 'should be true if the tag is an open tag, and has whitespace and html properties with either single or double quotes' do
-      @truncator.send(:open_tag?, ' <a href="whatever">').should be_true
-      @truncator.send(:open_tag?, " <a href='whatever' >").should be_true
+      @truncator.send(:open_tag?, ' <a href="http://awesomeful.net">').should be_true
+      @truncator.send(:open_tag?, " <a href='http://awesomeful.net' >").should be_true
     end
 
     it 'should be false if the tag is a close tag' do
       @truncator.send(:open_tag?, '</a>').should be_false
     end
 
-    it 'should be false if the string isnot an html tag' do
+    it 'should be false if the string is not an html tag' do
       @truncator.send(:open_tag?, 'foo bar').should be_false
     end
   end
@@ -68,28 +68,4 @@ describe TruncateHtml::HtmlTruncator do
     end
   end
 
-  #describe '#remove_open_tag' do
-
-    #before(:each) do
-      #@truncator = TruncateHtml::HtmlTruncator.new 'foo'
-      #@open_tags = ['<a>', '<p>', '<div>', '<h1>', '<div>']
-      #@truncator.instance_variable_set(:open_tags, @open_tags)
-    #end
-
-    #it 'should remove the latest matching tag' do
-      #@truncator.send(:remove_latest_open_tag, '</h1>').should == ['<a>', '<p>', '<div>', '<div>']
-      #@truncator.send(:remove_latest_open_tag, '</div>').should == ['<a>', '<p>', '<div>', '<h1>']
-    #end
-
-    #it 'should not modify @open_tags if the close tag parameter didn not match' do
-      #@truncator.send(:remove_latest_open_tag, '<strong>').should == @open_tags
-    #end
-
-    #it 'should raise an error if the close tag parameter is not an html tag' do
-      #lambda { @truncator.send(:remove_latest_open_tag, '<strong>') }.should raise_error
-    #end
-
-  #end
-
-
 end

data/truncate_html.gemspec

@@ -1,12 +1,12 @@
 # -*- encoding: utf-8 -*-
- 
+
 Gem::Specification.new do |s|
   s.name = %q{truncate_html}
-  s.version = "0.1.0"
+  s.version = "0.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["hgimenez"]
-  s.date = %q{2009-08-03}
+  s.date = %q{2009-08-25}
   s.description = %q{Truncates html so you don't have to}
   s.email = %q{harold.gimenez@gmail.com}
   s.extra_rdoc_files = [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: hgimenez-truncate_html
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - hgimenez
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-08-03 00:00:00 -07:00
+date: 2009-08-25 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -38,7 +38,6 @@ files:
 - uninstall.rb
 has_rdoc: false
 homepage: http://github.com/hgimenez/truncate_html
-licenses: 
 post_install_message: 
 rdoc_options: 
 - --charset=UTF-8
@@ -59,7 +58,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.2.0
 signing_key: 
 specification_version: 3
 summary: Uses an API similar to Rails' truncate helper to truncate HTML and close any lingering open tags.