hexx 0.1.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 328ff58d93538e10c8f80618deaf8c4e640f8ecf
-  data.tar.gz: 6b3957ae87b7f0dd01da5f5213acf9567df9e076
+  metadata.gz: 012517b45eeaa322d1d46183685969bb38abb240
+  data.tar.gz: 793d572f5092196bb9cc9651a7479fa21237ea4c
 SHA512:
-  metadata.gz: 24bedd30a43978ea114d5acff719bdb8416ff1ba0cdacfe75ca722163d67e4560dcfab4841a2965227626f182c15c4d0973a33efb87678bd35eb74e29772c0ba
-  data.tar.gz: 194270afa308dfdae9648aec04055b8ae99d539fc203df8efe83cd000662cc86a631cf353a73b03c93de9c3fb447c0d3881d0712495e6f50b89bfa289b8951c3
+  metadata.gz: 3286ecf42c146eaa615c104ad13caa867cb722de3b06e068e231d7bb131a1494c4daa24a4353c4d410b03221b68f9b1394d539d4d9fadc96de8dd3ef098a3d7b
+  data.tar.gz: 9f3e70de2e2ea1df43ca3d8d3e1d65f0c753ea77646bdf4bbc9944a4fd0c9ed0e336d08e307d5beb41a9b5e54900e77eae563f27d3049d7a8b3cc2c2deeebc4d

data/lib/hexx/exceptions/not_found_error.rb

@@ -9,8 +9,10 @@ module Hexx
   #
   class NotFoundError < RuntimeError
 
-    def message
-      "Not found: #{ errors.inspect }"
+    private
+
+    def default
+      "Not found"
     end
   end
 end

data/lib/hexx/exceptions/runtime_error.rb

@@ -7,18 +7,21 @@ module Hexx
   #
   class RuntimeError < ::RuntimeError
 
-    attr_reader :object
+    attr_reader :messages
 
     def initialize(object)
-      @object = object
+      fail ArgumentError unless object.is_a? UseCase
+      @messages ||= object.errors.messages.values
     end
 
-    def errors
-      object.errors if object
+    def message
+      @message ||= "#{ default }: #{ messages.join("; ") }"
     end
 
-    def message
-      "Runtime error: #{ errors.inspect }"
+    private
+
+    def default
+      "Runtime error"
     end
   end
 end

data/lib/hexx/exceptions/use_case_invalid.rb

@@ -9,8 +9,10 @@ module Hexx
   #
   class UseCaseInvalid < RuntimeError
 
-    def message
-      "Invalid use case: #{ errors.inspect }"
+    private
+
+    def default
+      "Use case invalid"
     end
   end
 end

data/lib/hexx/message.rb

@@ -6,7 +6,7 @@ module Hexx
     attr_reader :type, :text
 
     def initialize(type:, text:)
-      @type, @text = type.to_s, text.to_s
+      self.type, self.text = type, text
     end
 
     def type=(value)

data/lib/hexx/models.rb

@@ -2,10 +2,7 @@ require "active_support"
 
 module Hexx
 
-  # Module defines:
-  #
-  # * <tt>validate!</tt> public instance method
-  # * +attr_coerced+ public class methods.
+  # Contains +attr_coerced+ public class method.
   #
   # Include the module into the Rails model:
   #
@@ -22,13 +19,6 @@ module Hexx
   module Models
     extend ActiveSupport::Concern
 
-    # Runs validations and raises a RecordInvalid exceptions in case of
-    # an invalid case.
-    def validate!
-      return true if valid?
-      fail RecordInvalid.new self
-    end
-
     # Model class helpers for attributes coercion.
     module ClassMethods
 

data/lib/hexx/use_case.rb

@@ -224,9 +224,9 @@ module Hexx
     def run
       run!
     rescue Hexx::NotFoundError => error
-      finish_with :not_found, error.errors.values
+      finish_with :not_found, error.messages
     rescue Hexx::RuntimeError => error
-      finish_with :error, error.errors.values
+      finish_with :error, error.messages
     rescue StandardError => error
       finish_with :error, [error.message]
     end

data/lib/hexx/version.rb

@@ -1,4 +1,4 @@
 # Core classes to follow hexagonal domain architecture.
 module Hexx
-  VERSION = "0.1.1"
+  VERSION = "1.0.0"
 end

data/spec/hexx/exceptions/not_found_error_spec.rb

@@ -11,7 +11,11 @@ module Hexx
     end
 
     it "has customized message" do
-      expect(subject).to have_error_message "Not found"
+      use_case = Hexx::UseCase.new
+      allow(use_case)
+        .to receive_message_chain(:errors, :messages, :values)
+        .and_return %w(one two)
+      expect(subject.new(use_case).message).to eq "Not found: one; two"
     end
   end
 end

data/spec/hexx/exceptions/runtime_error_spec.rb

@@ -4,51 +4,39 @@ require "support/exception_matchers"
 module Hexx
   describe RuntimeError do
 
-    subject { RuntimeError }
-    let!(:object)  { double "object" }
-    let!(:errors)  { double "errors" }
-    before { allow(object).to receive(:errors) { errors } }
-
-    let!(:error)  { subject.new object }
+    subject        { RuntimeError }
+    let(:use_case) { Hexx::UseCase.new }
 
     it "inherits core RuntimeError" do
       expect(subject).to inherit ::RuntimeError
     end
 
-    it "has customized message" do
-      expect(subject).to have_error_message "Runtime error"
-    end
-
     describe ".new" do
 
-      it "initializes the object attribute" do
-        expect(subject).to respond_to(:new).with(1).argument
+      it "requires Hexx::UseCase as an argument" do
+        expect { subject.new use_case }.not_to raise_error
+        expect { subject.new "" }.to raise_error
+        expect { subject.new }.to raise_error
       end
     end
 
-    describe "#object" do
-
-      it "is public" do
-        expect(error).to respond_to :object
-      end
+    describe "#messages" do
 
-      it "initializes the #object attribute" do
-        expect(error.object).to eq object
+      it "returns use case's error messages" do
+        allow(use_case)
+          .to receive_message_chain(:errors, :messages, :values)
+          .and_return :messages
+        expect(subject.new(use_case).messages).to eq :messages
       end
     end
 
-    describe "#errors" do
-
-      it "is public" do
-        expect(error).to respond_to :errors
-      end
+    describe "#message" do
 
-      it "delegated to object" do
-        expect(error.errors).to eq errors
-      end
+      let!(:error) { subject.new use_case }
+      before { allow(error).to receive(:messages).and_return %w(one two) }
 
-      it "set to nil unless object is set" do
-        expect(subject.new(nil).errors).to be_nil
+      it "returns a proper text" do
+        expect(error.message).to eq "Runtime error: one; two"
       end
     end
   end

data/spec/hexx/exceptions/use_case_invalid_spec.rb

@@ -11,7 +11,11 @@ module Hexx
     end
 
     it "has customized message" do
-      expect(subject).to have_error_message "Invalid use case"
+      use_case = Hexx::UseCase.new
+      allow(use_case)
+        .to receive_message_chain(:errors, :messages, :values)
+        .and_return %w(one two)
+      expect(subject.new(use_case).message).to eq "Use case invalid: one; two"
     end
   end
 end

data/spec/hexx/models_spec.rb

@@ -29,34 +29,6 @@ module Hexx
     # Run tests
     # ==========================================================================
 
-    describe "#validate!" do
-
-      it "is public" do
-        expect(object).to respond_to(:validate!).with(0).arguments
-      end
-
-      context "with valid object" do
-
-        before { allow(object).to receive(:valid?) { true } }
-
-        it "returns true" do
-          expect(object.validate!).to be_truthy
-        end
-      end
-
-      context "with invalid object" do
-
-        before { allow(object).to receive(:valid?) { false } }
-
-        it "fails with Hexx::RecordInvalid" do
-          expect { object.validate! }.to raise_error do |error|
-            expect(error).to be_kind_of Hexx::RecordInvalid
-            expect(error.object).to eq object
-          end
-        end
-      end
-    end
-
     describe ".attr_coerced" do
 
       before { subject.send :attr_coerced, :name, type: TestAttribute }

data/spec/hexx/use_case_spec.rb

@@ -132,11 +132,8 @@ module Hexx
     describe "#run" do
 
       let!(:use_case) { subject.new }
-      let!(:object)   { double "entity" }
-      let!(:errors)   { { base: :invalid } }
       let!(:listener) { double "listener" }
 
-      before { allow(object).to receive(:errors) { errors } }
       before { use_case.subscribe listener }
 
       it "calls the #run!" do
@@ -157,7 +154,7 @@ module Hexx
       context "if the #run! raises NotFoundError" do
 
         before do
-          allow(use_case).to receive(:run!) { fail NotFoundError.new object }
+          allow(use_case).to receive(:run!) { fail NotFoundError.new use_case }
         end
 
         it "doesn't raise" do
@@ -165,10 +162,7 @@ module Hexx
         end
 
         it "publishes the :not_found notification" do
-          expect(listener).to receive(:not_found) do |messages|
-            expect(messages.map(&:type)).to eq ["error"]
-            expect(messages.map(&:text)).to eq ["invalid"]
-          end
+          expect(listener).to receive(:not_found)
           use_case.run
         end
 
@@ -180,7 +174,7 @@ module Hexx
       context "if the #run! raises another Hexx::Runtime error" do
 
         before do
-          allow(use_case).to receive(:run!) { fail RuntimeError.new object }
+          allow(use_case).to receive(:run!) { fail RuntimeError.new use_case }
         end
 
         it "doesn't raise" do
@@ -188,10 +182,7 @@ module Hexx
         end
 
         it "publishes the :error notification" do
-          expect(listener).to receive(:error) do |messages|
-            expect(messages.map(&:type)).to eq ["error"]
-            expect(messages.map(&:text)).to eq ["invalid"]
-          end
+          expect(listener).to receive(:error)
           use_case.run
         end
 

data/spec/support/exception_matchers.rb

@@ -5,16 +5,3 @@ RSpec::Matchers.define :inherit do |ancestor|
     expect(subject.ancestors).to be_include ancestor
   end
 end
-
-RSpec::Matchers.define :have_error_message do |header|
-  match do |subject|
-    object = double "object"
-    errors = double "errors"
-    allow(object).to receive(:errors) { errors }
-    begin
-      fail subject.new(object)
-    rescue => error
-      expect(error.message).to eq "#{ header }: #{ errors.inspect }"
-    end
-  end
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hexx
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Andrew Kozin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-13 00:00:00.000000000 Z
+date: 2014-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -210,7 +210,6 @@ files:
 - lib/generators/use_case/use_case.rb
 - lib/hexx.rb
 - lib/hexx/exceptions/not_found_error.rb
-- lib/hexx/exceptions/record_invalid.rb
 - lib/hexx/exceptions/runtime_error.rb
 - lib/hexx/exceptions/use_case_invalid.rb
 - lib/hexx/message.rb
@@ -219,7 +218,6 @@ files:
 - lib/hexx/use_case.rb
 - lib/hexx/version.rb
 - spec/hexx/exceptions/not_found_error_spec.rb
-- spec/hexx/exceptions/record_invalid_spec.rb
 - spec/hexx/exceptions/runtime_error_spec.rb
 - spec/hexx/exceptions/use_case_invalid_spec.rb
 - spec/hexx/message_spec.rb
@@ -262,7 +260,6 @@ test_files:
 - spec/spec_helper.rb
 - spec/hexx/message_spec.rb
 - spec/hexx/settings_spec.rb
-- spec/hexx/exceptions/record_invalid_spec.rb
 - spec/hexx/exceptions/not_found_error_spec.rb
 - spec/hexx/exceptions/use_case_invalid_spec.rb
 - spec/hexx/exceptions/runtime_error_spec.rb

data/lib/hexx/exceptions/record_invalid.rb

@@ -1,16 +0,0 @@
-require_relative "runtime_error"
-
-module Hexx
-
-  # An exception to be raised by the <tt>Hexx::Models#validate!</tt> method.
-  #
-  # It is expected, that the object stores error messages in its <tt>errors</tt>
-  # collection.
-  #
-  class RecordInvalid < RuntimeError
-
-    def message
-      "Record invalid: #{ errors.inspect }"
-    end
-  end
-end

data/spec/hexx/exceptions/record_invalid_spec.rb

@@ -1,17 +0,0 @@
-require "spec_helper"
-require "support/exception_matchers"
-
-module Hexx
-  describe RecordInvalid do
-
-    subject { RecordInvalid }
-
-    it "inherits RuntimeError" do
-      expect(subject).to inherit Hexx::RuntimeError
-    end
-
-    it "has customized message" do
-      expect(subject).to have_error_message "Record invalid"
-    end
-  end
-end