hexapdf 0.47.0 → 1.0.1

data/test/hexapdf/task/test_merge_acro_form.rb

@@ -0,0 +1,104 @@
+# -*- encoding: utf-8 -*-
+
+require 'test_helper'
+require 'hexapdf/document'
+require 'hexapdf/task/merge_acro_form'
+
+describe HexaPDF::Task::MergeAcroForm do
+  before do
+    @doc = HexaPDF::Document.new
+    @doc.pages.add
+    @doc.pages.add
+    form = @doc.acro_form(create: true)
+    field = form.create_text_field("Text")
+    field.create_widget(@doc.pages[0], Rect: [0, 0, 0, 0])
+    field.create_widget(@doc.pages[1], Rect: [0, 0, 0, 0])
+
+    form.create_text_field("Calc.Field a")
+    form.create_text_field("Calc.Field b")
+    field = form.create_text_field('Other.Calculation 1')
+    field.set_calculate_action(:sum, fields: ["Calc.Field a", "Calc.Field b"])
+    field.create_widget(@doc.pages[1])
+    field = form.create_text_field('Other.Calculation 2')
+    field.set_calculate_action(:sfn, fields: "Calc.Field\\ a + Calc.Field\\ b")
+    field.create_widget(@doc.pages[1])
+
+    @root_fields = @doc.acro_form.root_fields
+
+    @doc.dispatch_message(:complete_objects)
+    @doc.validate
+    @doc1 = @doc.duplicate
+    @pages = []
+    @pages << @doc.pages.add(@doc.import(@doc1.pages[0]))
+    @pages << @doc.pages.add(@doc.import(@doc1.pages[1]))
+  end
+
+  it "selects a unique name for the root field" do
+    @doc.task(:merge_acro_form, source: @doc1, pages: @pages)
+    assert_equal('merged_1', @root_fields[3][:T])
+
+    @root_fields << @doc.wrap({T: 'merged_23'})
+    @doc.task(:merge_acro_form, source: @doc1, pages: @pages)
+    assert_equal('merged_24', @root_fields[5][:T])
+  end
+
+  it "merges the /DR entry of the main AcroForm dictionary" do
+    @doc.task(:merge_acro_form, source: @doc1, pages: @pages)
+    assert(@doc.acro_form.default_resources[:Font].key?(:F2))
+  end
+
+  it "updates the /SigFlags if necessary" do
+    @doc.task(:merge_acro_form, source: @doc1, pages: [@pages[0]])
+    refute(@doc.acro_form.signature_flag?(:signatures_exist))
+
+    @pages[0][:Annots][0].form_field[:FT] = :Sig
+    @doc.task(:merge_acro_form, source: @doc1, pages: [@pages[0]])
+    refute(@doc.acro_form.signature_flag?(:signatures_exist))
+
+    @doc1.acro_form.signature_flag(:signatures_exist)
+    @doc.task(:merge_acro_form, source: @doc1, pages: [@pages[0]])
+    assert(@doc.acro_form.signature_flag?(:signatures_exist))
+  end
+
+  it "applies the /DA and /Q entries of the source AcroForm to the created root field" do
+    @doc1.acro_form.set_default_appearance_string
+    @doc1.acro_form[:Q] = @doc1.add(5)
+    @doc.task(:merge_acro_form, source: @doc1, pages: [@pages[0]])
+    assert_equal('0.0 g /F2 0 Tf', @root_fields[3][:DA])
+    assert_equal(5, @root_fields[3][:Q])
+  end
+
+  it "merges only the fields references in the given pages" do
+    @doc.task(:merge_acro_form, source: @doc1, pages: [@pages[0]])
+    assert_equal('merged_1', @root_fields[3][:T])
+    assert_equal(1, @root_fields[3][:Kids].size)
+  end
+
+  it "only merges fields that have at least one widget" do
+    @doc.task(:merge_acro_form, source: @doc1, pages: @pages)
+    assert_equal(2, @root_fields[3][:Kids].size)
+    assert_nil(@doc.acro_form.field_by_name('merged_1.Calc'))
+  end
+
+  it "updates the /DA entries of widgets and fields" do
+    @pages[0][:Annots][0][:DA] = '/F1 10 Tf'
+    @doc.task(:merge_acro_form, source: @doc1, pages: @pages)
+    field = @doc.acro_form.field_by_name('merged_1.Text')
+    assert_equal('0.0 g /F2 0 Tf', field[:DA])
+    assert_equal('/F2 10 Tf', field.each_widget.to_a[0][:DA])
+  end
+
+  it "doesn't update the calculation actions if no field with one is merged" do
+    @doc.task(:merge_acro_form, source: @doc1, pages: [@pages[0]])
+    assert_equal(2, @doc.acro_form[:CO].size)
+  end
+
+  it "updates the field names in known calculation actions" do
+    @doc.task(:merge_acro_form, source: @doc1, pages: @pages)
+    assert_equal(4, @doc.acro_form[:CO].size)
+    js = @doc.acro_form.field_by_name('merged_1.Other.Calculation 1')[:AA][:C][:JS]
+    assert_match(/merged_1.Calc.Field a/, js)
+    js = @doc.acro_form.field_by_name('merged_1.Other.Calculation 2')[:AA][:C][:JS]
+    assert_match(/merged_1.Calc.Field a/, js)
+  end
+end

data/test/hexapdf/test_composer.rb

@@ -63,6 +63,14 @@ describe HexaPDF::Composer do
     end
   end
 
+  it "writes the document to a string" do
+    pdf = HexaPDF::Composer.new
+    pdf.new_page
+    str = pdf.write_to_string
+    doc = HexaPDF::Document.new(io: StringIO.new(str))
+    assert_equal(2, doc.pages.count)
+  end
+
   describe "new_page" do
     it "creates a new page" do
       c = HexaPDF::Composer.new(page_size: [0, 0, 50, 100], margin: 10)

data/test/hexapdf/test_document.rb

@@ -595,4 +595,13 @@ describe HexaPDF::Document do
       refute(dupped.encrypted?)
     end
   end
+
+  it "writes the document to a string" do
+    doc = HexaPDF::Document.new
+    doc.trailer.info[:test] = :test
+    str = doc.write_to_string(update_fields: false)
+    assert_equal(Encoding::ASCII_8BIT, str.encoding)
+    doc = HexaPDF::Document.new(io: StringIO.new(str))
+    assert_equal(:test, doc.trailer.info[:test])
+  end
 end

data/test/hexapdf/test_parser.rb

@@ -33,18 +33,23 @@ describe HexaPDF::Parser do
       endstream
       endobj
 
+      5 0 obj
+      1 0 R
+      endobj
+
       xref
       0 4
       0000000000 65535 f 
       0000000010 00000 n 
       0000000029 00000 n 
       0000000000 65535 f 
-      3 1
+      3 2
       0000000556 00000 n 
+      0000000308 00000 n
       trailer
       << /Test (now) >>
       startxref
-      308
+      330
       %%EOF
     EOF
   end
@@ -152,6 +157,13 @@ describe HexaPDF::Parser do
       assert_equal('12', collector(stream.fiber))
     end
 
+    it "recovers from a non-existing indirect reference to a stream length value" do
+      create_parser("1 0 obj<</Length 2 0 R>> stream\n12(ab\nendstream endobj")
+      obj, _, _, stream = @parser.parse_indirect_object
+      assert_equal(5, obj[:Length])
+      assert_equal('12(ab', collector(stream.fiber))
+    end
+
     it "works even if the keyword endobj is missing or mangled" do
       create_parser("1 0 obj<</Length 4>>5")
       object, * = @parser.parse_indirect_object
@@ -298,6 +310,11 @@ describe HexaPDF::Parser do
       assert_equal(0, obj.gen)
     end
 
+    it "handles the case of the value of an indirect object being an indirect reference" do
+      obj = @parser.load_object(HexaPDF::XRefSection.in_use_entry(5, 0, 308))
+      assert_equal(1, obj.oid)
+    end
+
     describe "with strict parsing" do
       it "raises an error if an indirect object has an offset of 0" do
         @document.config['parser.on_correctable_error'] = proc { true }
@@ -336,13 +353,13 @@ describe HexaPDF::Parser do
 
   describe "startxref_offset" do
     it "caches the offset value" do
-      assert_equal(308, @parser.startxref_offset)
-      @parser.instance_eval { @io }.string.sub!(/308\n/, "309\n")
-      assert_equal(308, @parser.startxref_offset)
+      assert_equal(330, @parser.startxref_offset)
+      @parser.instance_eval { @io }.string.sub!(/330\n/, "309\n")
+      assert_equal(330, @parser.startxref_offset)
     end
 
     it "returns the correct offset" do
-      assert_equal(308, @parser.startxref_offset)
+      assert_equal(330, @parser.startxref_offset)
     end
 
     it "ignores garbage at the end of the file" do

data/test/hexapdf/test_writer.rb

@@ -48,10 +48,15 @@ describe HexaPDF::Writer do
       trailer
       <</Size 4/Root<</Type/Catalog>>/Info 3 0 R/Prev 219>>
       startxref
-      349
+      #{343 + HexaPDF::VERSION.length}
       %%EOF
     EOF
 
+    xref_stream = case HexaPDF::VERSION.length
+                  when 5 then "x\xDAcbdlg``b`\xB0\x04\x93\x93\x19\x18\x00\f\x1E\x01\\"
+                  when 6 then "x\xDAcbd\xEC```b`\xB0\x04\x93\x93\x18\x18\x00\f*\x01\\"
+                  else fail
+                  end
     @compressed_input_io = StringIO.new(<<~EOF.force_encoding(Encoding::BINARY))
       %PDF-1.7
       %\xCF\xEC\xFF\xE8\xD7\xCB\xCD
@@ -64,8 +69,8 @@ describe HexaPDF::Writer do
       20
       endobj
       3 0 obj
-      <</Size 6/Type/XRef/W[1 1 2]/Index[0 4 5 1]/Filter/FlateDecode/DecodeParms<</Columns 4/Predictor 12>>/Length 31>>stream
-      x\xDAcb`\xF8\xFF\x9F\x89\x89\x95\x91\x91\xE9\x7F\x19\x03\x03\x13\x83\x10\x88he`\x00\x00B4\x04\x1E
+      <</Size 6/Type/XRef/W[1 1 2]/Index[0 6]/Filter/FlateDecode/DecodeParms<</Columns 4/Predictor 12>>/Length 36>>stream
+      x\xDAcb`\xF8\xFF\x9F\x89\x89\x95\x91\x91\xE9\x7F\x19\x03\x03\x13\x83\x10\x90\xF8_\f\x14c\x14bd\x04\x00lk\a 
       endstream
       endobj
       startxref
@@ -81,11 +86,11 @@ describe HexaPDF::Writer do
       endobj
       4 0 obj
       <</Size 7/Root<</Type/Catalog>>/Info 6 0 R/Prev 141/Type/XRef/W[1 2 2]/Index[2 1 4 1 6 1]/Filter/FlateDecode/DecodeParms<</Columns 5/Predictor 12>>/Length 22>>stream
-      x\xDAcbdlg``b`\xB0\x04\x93\x93\x18\x18\x00\f\e\x01[
+      #{xref_stream}
       endstream
       endobj
       startxref
-      448
+      #{443 + HexaPDF::VERSION.length}
       %%EOF
     EOF
   end

data/test/hexapdf/test_xref_section.rb

@@ -57,5 +57,20 @@ describe HexaPDF::XRefSection do
       @xref_section.add_in_use_entry(20, 0, 0)
       assert_subsections([[1, 2], [10, 11], [20]])
     end
+
+    it "yields a single subsection if the section was marked as the initial one" do
+      @xref_section.mark_as_initial_section!
+      @xref_section.add_in_use_entry(6, 0, 0)
+      @xref_section.add_in_use_entry(7, 0, 0)
+      @xref_section.add_in_use_entry(9, 0, 0)
+      @xref_section.add_in_use_entry(1, 0, 0)
+      @xref_section.add_in_use_entry(2, 0, 0)
+      result = @xref_section.each_subsection.map {|s| s.map {|e| [e.oid, e.type] }}
+      assert_equal([[[1, :in_use], [2, :in_use],
+                     [3, :free], [4, :free], [5, :free],
+                     [6, :in_use], [7, :in_use],
+                     [8, :free],
+                     [9, :in_use]]], result)
+    end
   end
 end

data/test/hexapdf/type/acro_form/test_appearance_generator.rb

@@ -549,7 +549,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:left)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 2, 6.41]],
+                           [:move_text, [2, 6.41]],
                            range: 7)
         end
 
@@ -557,7 +557,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:right)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 78.55, 6.41]],
+                           [:move_text, [78.55, 6.41]],
                            range: 7)
         end
 
@@ -565,7 +565,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:center)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 40.275, 6.41]],
+                           [:move_text, [40.275, 6.41]],
                            range: 7)
         end
 
@@ -576,7 +576,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
 
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 2, 6.41]],
+                           [:move_text, [2, 6.41]],
                            range: 7)
         ensure
           font_metrics.cap_height = cap_height
@@ -586,7 +586,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @widget[:Rect].height = 5
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 2, 3.07]],
+                           [:move_text, [2, 3.07]],
                            range: 7)
         end
       end
@@ -614,7 +614,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
                           [:set_font_and_size, [:F1, 10]],
                           [:set_device_rgb_non_stroking_color, [1.0, 0.0, 0.0]],
                           [:begin_text],
-                          [:set_text_matrix, [1, 0, 0, 1, 2, 2.035]],
+                          [:move_text, [2, 2.035]],
                           [:show_text, ["Te "]],
                           [:set_font_and_size, [:F2, 10]],
                           [:move_text, [14.45, 0]],
@@ -645,7 +645,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:left)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 2, 16.195]],
+                           [:move_text, [2, 16.195]],
                            range: 9)
         end
 
@@ -653,7 +653,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:right)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 78.55, 16.195]],
+                           [:move_text, [78.55, 16.195]],
                            range: 9)
         end
 
@@ -661,7 +661,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:center)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 40.275, 16.195]],
+                           [:move_text, [40.275, 16.195]],
                            range: 9)
         end
       end
@@ -681,7 +681,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
                           [:set_font_and_size, [:F1, 10]],
                           [:set_device_rgb_non_stroking_color, [1.0, 0.0, 0.0]],
                           [:begin_text],
-                          [:set_text_matrix, [1, 0, 0, 1, 2, 16.195]],
+                          [:move_text, [2, 16.195]],
                           [:show_text, ['Test']],
                           [:move_text_next_line],
                           [:show_text, ['Value']],
@@ -703,7 +703,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
                           [:set_leading, [9.25]],
                           [:set_font_and_size, [:F1, 8]],
                           [:begin_text],
-                          [:set_text_matrix, [1, 0, 0, 1, 2, 18.556]],
+                          [:move_text, [2, 18.556]],
                           [:show_text, ['Test']],
                           [:move_text_next_line],
                           [:show_text, ['Test']],
@@ -734,7 +734,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:left)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 2.945, 6.41]],
+                           [:move_text, [2.945, 6.41]],
                            range: 7)
         end
 
@@ -742,7 +742,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:right)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 62.945, 6.41]],
+                           [:move_text, [62.945, 6.41]],
                            range: 7)
         end
 
@@ -750,7 +750,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:center)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 32.945, 6.41]],
+                           [:move_text, [32.945, 6.41]],
                            range: 7)
         end
 
@@ -759,7 +759,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
           @field.text_alignment(:center)
           @generator.create_appearances
           assert_operators(@widget[:AP][:N].stream,
-                           [:set_text_matrix, [1, 0, 0, 1, 22.39, 6.41]],
+                           [:move_text, [22.39, 6.41]],
                            range: 7)
         end
       end
@@ -777,7 +777,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
                           [:set_font_and_size, [:F1, 10]],
                           [:set_device_rgb_non_stroking_color, [1.0, 0.0, 0.0]],
                           [:begin_text],
-                          [:set_text_matrix, [1, 0, 0, 1, 2.945, 6.41]],
+                          [:move_text, [2.945, 6.41]],
                           [:show_text_with_positioning, [['T', -416.5, 'e', -472, 'x', -611, 't']]],
                           [:end_text],
                           [:restore_graphics_state],
@@ -789,7 +789,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
         @generator.create_appearances
         assert_operators(@widget[:AP][:N].stream,
                          [[:begin_text],
-                          [:set_text_matrix, [1, 0, 0, 1, 2, 6.41]],
+                          [:move_text, [2, 6.41]],
                           [:end_text]], range: 6..8)
       end
 
@@ -870,7 +870,7 @@ describe HexaPDF::Type::AcroForm::AppearanceGenerator do
                             [:set_font_and_size, [:F1, 12]],
                             [:set_device_rgb_non_stroking_color, [1.0, 0.0, 0.0]],
                             [:begin_text],
-                            [:set_text_matrix, [1, 0, 0, 1, 2, 23.609]],
+                            [:move_text, [2, 23.609]],
                             [:show_text, ["a"]],
                             [:move_text_next_line],
                             [:show_text, ["b"]],

data/test/hexapdf/type/acro_form/test_form.rb

@@ -159,11 +159,16 @@ describe HexaPDF::Type::AcroForm::Form do
     end
 
     def applies_variable_text_properties(method, **args)
-      field = @acro_form.send(method, "field", **args, font: 'Times')
+      field = @acro_form.send(method, "field", **args)
       font_name, font_size, font_color = field.parse_default_appearance_string
-      assert_equal(:'Times-Roman', @acro_form.default_resources.font(font_name)[:BaseFont])
+      assert_equal(:'Helvetica', @acro_form.default_resources.font(font_name)[:BaseFont])
       assert_equal(0, font_size)
       assert_equal(HexaPDF::Content::ColorSpace::DeviceGray.new.color(0), font_color)
+      assert_equal(0, field.value[:Q])
+
+      field = @acro_form.send(method, "field", **args, font: 'Times')
+      font_name, font_size, font_color = field.parse_default_appearance_string
+      assert_equal(:'Times-Roman', @acro_form.default_resources.font(font_name)[:BaseFont])
 
       field = @acro_form.send(method, "field", **args, font_options: {variant: :bold})
       font_name, = field.parse_default_appearance_string
@@ -171,7 +176,6 @@ describe HexaPDF::Type::AcroForm::Form do
 
       field = @acro_form.send(method, "field", **args, font_size: 10)
       font_name, font_size = field.parse_default_appearance_string
-      assert_equal(:Helvetica, @acro_form.default_resources.font(font_name)[:BaseFont])
       assert_equal(10, font_size)
 
       field = @acro_form.send(method, "field", **args, font_color: "red")

data/test/hexapdf/type/actions/test_launch.rb

@@ -14,10 +14,14 @@ describe HexaPDF::Type::Actions::Launch do
     it "needs a launch target" do
       refute(@action.validate)
 
-      @action.value = {F: {}}
+      @action.value = {Win: {F: "test.exe"}}
+      assert(@action.validate)
+      @action.value = {Mac: 'test'}
+      assert(@action.validate)
+      @action.value = {Unix: 'test'}
       assert(@action.validate)
 
-      @action.value = {Win: {F: "test.exe"}}
+      @action.value = {F: {}}
       assert(@action.validate)
     end
   end

data/test/hexapdf/type/test_font_type1.rb

@@ -138,5 +138,10 @@ describe HexaPDF::Type::FontType1 do
       @embedded_font.delete(:FontDescriptor)
       refute(@embedded_font.validate)
     end
+
+    it "ensures a correct Symbol value for the /Encoding key" do
+      @font[:Encoding] = :Other
+      refute(@font.validate)
+    end
   end
 end

data/test/hexapdf/type/test_form.rb

@@ -57,7 +57,7 @@ describe HexaPDF::Type::Form do
     it "creates the resource dictionary if it is not found" do
       resources = @form.resources
       assert_equal(:XXResources, resources.type)
-      assert_equal({ProcSet: [:PDF, :Text, :ImageB, :ImageC, :ImageI]}, resources.value)
+      assert_equal({}, resources.value)
     end
 
     it "returns the already used resource dictionary" do

data/test/hexapdf/type/test_page.rb

@@ -358,6 +358,12 @@ describe HexaPDF::Type::Page do
       page[:Contents] = [@doc.wrap({}, stream: 'q 10'), @doc.wrap({}, stream: 'w Q')]
       assert_equal('q 10 w Q', page.contents)
     end
+
+    it "handles null objects in the /Contents array" do
+      page = @doc.pages.add
+      page[:Contents] = [@doc.wrap({}, stream: 'q 10'), nil]
+      assert_equal('q 10 ', page.contents)
+    end
   end
 
   describe "contents=" do
@@ -389,7 +395,7 @@ describe HexaPDF::Type::Page do
       page = @doc.add({Type: :Page, Parent: @doc.pages.root})
       resources = page.resources
       assert_equal(:XXResources, resources.type)
-      assert_equal({ProcSet: [:PDF, :Text, :ImageB, :ImageC, :ImageI]}, resources.value)
+      assert_equal({}, resources.value)
     end
 
     it "returns the already used resource dictionary" do

data/test/hexapdf/utils/test_sorted_tree_node.rb

@@ -12,10 +12,12 @@ describe HexaPDF::Utils::SortedTreeNode do
   end
 
   def add_multilevel_entries
-    @kid11 = @doc.add({Limits: ['c', 'f'], Names: ['c', 1, 'f', 1]}, type: HexaPDF::NameTreeNode)
+    item = @doc.add(1)
+    @item_ref = HexaPDF::Reference.new(item.oid, item.gen)
+    @kid11 = @doc.add({Limits: ['c', 'f'], Names: ['c', @item_ref, 'f', 1]}, type: HexaPDF::NameTreeNode)
     @kid12 = @doc.add({Limits: ['i', 'm'], Names: ['i', 1, 'm', 1]}, type: HexaPDF::NameTreeNode)
     ref = HexaPDF::Reference.new(@kid11.oid, @kid11.gen)
-    @kid1 = @doc.add({Limits: ['c', 'm'], Kids: [ref, @kid12]}, type: HexaPDF::NameTreeNode)
+    @kid1 = @doc.add({Limits: ['c', 'm'], Kids: [ref, @kid12]})
     @kid21 = @doc.add({Limits: ['o', 'q'], Names: ['o', 1, 'q', 1]}, type: HexaPDF::NameTreeNode)
     @kid221 = @doc.add({Limits: ['s', 'u'], Names: ['s', 1, 'u', 1]}, type: HexaPDF::NameTreeNode)
     @kid22 = @doc.add({Limits: ['s', 'u'], Kids: [@kid221]}, type: HexaPDF::NameTreeNode)
@@ -75,7 +77,7 @@ describe HexaPDF::Utils::SortedTreeNode do
       @root.add_entry('v', 1)
       assert_equal(['a', 'm'], @kid1[:Limits].value)
       assert_equal(['a', 'f'], @kid11[:Limits].value)
-      assert_equal(['a', 1, 'c', 1, 'e', 1, 'f', 1], @kid11[:Names].value)
+      assert_equal(['a', 1, 'c', @item_ref, 'e', 1, 'f', 1], @kid11[:Names].value)
       assert_equal(['g', 'm'], @kid12[:Limits].value)
       assert_equal(['g', 1, 'i', 1, 'j', 1, 'm', 1], @kid12[:Names].value)
       assert_equal(['n', 'v'], @kid2[:Limits].value)
@@ -203,13 +205,12 @@ describe HexaPDF::Utils::SortedTreeNode do
     end
 
     it "checks that all kid objects are indirect objects" do
-      @root[:Kids][0] = ref = HexaPDF::Reference.new(@kid1.oid, @kid1.gen)
       assert(@root.validate)
 
-      @root[:Kids][0] = ref
+      @root[:Kids][0] = @kid1
       @kid1.oid = 0
       assert(@root.validate do |message, c|
-               assert_match(/must be an indirect object/, message)
+               assert_match(/children.*must be indirect/i, message)
                assert(c)
              end)
       assert(@kid1.indirect?)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hexapdf
 version: !ruby/object:Gem::Version
-  version: 0.47.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Thomas Leitner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-07 00:00:00.000000000 Z
+date: 2024-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cmdparse
@@ -469,6 +469,7 @@ files:
 - lib/hexapdf/stream.rb
 - lib/hexapdf/task.rb
 - lib/hexapdf/task/dereference.rb
+- lib/hexapdf/task/merge_acro_form.rb
 - lib/hexapdf/task/optimize.rb
 - lib/hexapdf/task/pdfa.rb
 - lib/hexapdf/test_utils.rb
@@ -728,6 +729,7 @@ files:
 - test/hexapdf/layout/test_text_shaper.rb
 - test/hexapdf/layout/test_width_from_polygon.rb
 - test/hexapdf/task/test_dereference.rb
+- test/hexapdf/task/test_merge_acro_form.rb
 - test/hexapdf/task/test_optimize.rb
 - test/hexapdf/task/test_pdfa.rb
 - test/hexapdf/test_composer.rb