hexapdf 0.44.0 → 0.46.0

data/lib/hexapdf/layout/inline_box.rb

@@ -43,14 +43,12 @@ module HexaPDF
     # An InlineBox wraps a regular Box so that it can be used as an item for a Line. This enables
     # inline graphics.
     #
-    # Complete box auto-sizing is not possible since the available space cannot be determined
-    # beforehand! This means the box *must* have at least its width set. The height may either also
-    # be set or determined during fitting.
+    # When an inline box gets placed on a line, the method #fit_wrapped_box is called to fit the
+    # wrapped box. This allows the wrapped box to correctly set its width and height which are
+    # needed by the TextLayouter algorithm.
     #
-    # Fitting of the wrapped box via #fit_wrapped_box needs to be done before accessing any other
-    # method that uses the wrapped box. For fitting, a frame is used that has the width of the
-    # wrapped box and its height, or if not set, a practically infinite height. In the latter case
-    # the height *must* be set during fitting.
+    # Note: It is *mandatory* that the wrapped box sets its width and height without relying on the
+    # dimensions of the frame's current region.
     class InlineBox
 
       # Creates an InlineBox that wraps a basic Box. All arguments (except +valign+) and the block
@@ -74,7 +72,6 @@ module HexaPDF
       # The +valign+ argument can be used to specify the vertical alignment of the box relative to
       # other items in the Line.
       def initialize(box, valign: :baseline)
-        raise HexaPDF::Error, "Width of box not set" if box.width == 0
         @box = box
         @valign = valign
       end
@@ -102,8 +99,7 @@ module HexaPDF
       # Draws the wrapped box. If the box has margins specified, the x and y offsets are correctly
       # adjusted.
       def draw(canvas, x, y)
-        canvas.translate(x - @fit_result.x + box.style.margin.left,
-                         y - @fit_result.y + box.style.margin.bottom) { @fit_result.draw(canvas) }
+        @fit_result.draw(canvas, dx: x, dy: y)
       end
 
       # The minimum x-coordinate which is always 0.
@@ -129,19 +125,17 @@ module HexaPDF
       # Fits the wrapped box.
       #
       # If the +frame+ argument is +nil+, a custom frame is created. Otherwise the given +frame+ is
-      # used for the fitting operation.
-      def fit_wrapped_box(frame)
-        frame = if frame
-                  frame.child_frame(0, 0, box.width, box.height == 0 ? 100_000 : box.height)
-                else
-                  Frame.new(0, 0, box.width, box.height == 0 ? 100_000 : box.height)
-                end
-        @fit_result = frame.fit(box)
-        if !@fit_result.success?
-          raise HexaPDF::Error, "Box for inline use could not be fit"
-        elsif box.height > 99_000
-          raise HexaPDF::Error, "Box for inline use has no valid height set after fitting"
-        end
+      # used for creating an appropriate child frame for the fitting operation.
+      #
+      # After this operation the caller is responsible for checking the actual width and height of
+      # the inline box and whether it really fits.
+      def fit_wrapped_box(frame = nil)
+        @fit_result = box.fit(100_000, 100_000, frame || Frame.new(0, 0, 100_000, 100_000))
+        margin = box.style.margin if box.style.margin?
+        @fit_result.x = margin&.left.to_i
+        @fit_result.y = margin&.bottom.to_i
+        @fit_result.mask = Geom2D::Rectangle(0, 0, @fit_result.x + box.width + margin&.right.to_i,
+                                             @fit_result.y + box.height + margin&.top.to_i)
       end
 
     end

data/lib/hexapdf/layout/list_box.rb

@@ -189,19 +189,9 @@ module HexaPDF
       private
 
       # Fits the list box into the current region of the frame.
-      def fit_content(available_width, available_height, frame)
-        @width = if @initial_width > 0
-                   @initial_width
-                 else
-                   (style.position == :flow ? frame.width : available_width)
-                 end
-        height = if @initial_height > 0
-                   @initial_height - reserved_height
-                 else
-                   (style.position == :flow ? frame.y - frame.bottom : available_height) - reserved_height
-                 end
-
+      def fit_content(_available_width, _available_height, frame)
         width = @width - reserved_width
+        height = @height - reserved_height
         left = (style.position == :flow ? frame.left : frame.x) + reserved_width_left
         top = frame.y - reserved_height_top
 
@@ -245,7 +235,7 @@ module HexaPDF
           Array(child).each {|ibox| box_fitter.fit(ibox) }
           item_result.box_fitter = box_fitter
           item_result.height = [item_result.height.to_i, box_fitter.content_heights[0]].max
-          @results << item_result
+          @results << item_result unless box_fitter.fit_results.empty?
 
           top -= item_result.height + item_spacing
           height -= item_result.height + item_spacing
@@ -253,7 +243,7 @@ module HexaPDF
           break if !box_fitter.success? || height <= 0
         end
 
-        @height = @results.sum(&:height) + (@results.count - 1) * item_spacing + reserved_height
+        update_content_height { @results.sum(&:height) + (@results.count - 1) * item_spacing }
 
         if @results.size == @children.size && @results.all? {|r| r.box_fitter.success? }
           fit_result.success!
@@ -326,37 +316,32 @@ module HexaPDF
       def item_marker_box(document, index)
         return @marker_type.call(document, self, index) if @marker_type.kind_of?(Proc)
 
-        unless (fragment = @item_marker_fragment)
+        unless (items = @item_marker_items)
           marker_style = {
-            font: style.font? ? style.font : document.fonts.add("Times"),
-            font_size: style.font_size || 10, fill_color: style.fill_color
+            font_size: style.font_size || 10,
+            fill_color: style.fill_color,
           }
-          fragment = case @marker_type
-                     when :disc
-                       TextFragment.create("•", marker_style)
-                     when :circle
-                       unless marker_style[:font].decode_codepoint("❍".ord).valid?
-                         marker_style[:font] = document.fonts.add("ZapfDingbats")
-                       end
-                       TextFragment.create("❍", **marker_style,
-                                           font_size: style.font_size / 2.0,
-                                           text_rise: -style.font_size / 1.8)
-                     when :square
-                       unless marker_style[:font].decode_codepoint("■".ord).valid?
-                         marker_style[:font] = document.fonts.add("ZapfDingbats")
-                       end
-                       TextFragment.create("■", **marker_style,
-                                           font_size: style.font_size / 2.0,
-                                           text_rise: -style.font_size / 1.8)
-                     when :decimal
-                       text = (@start_number + index).to_s << "."
-                       TextFragment.create(text, marker_style)
-                     else
-                       raise HexaPDF::Error, "Unknown list marker type #{@marker_type.inspect}"
-                     end
-          @item_marker_fragment = fragment unless @marker_type == :decimal
+          marker_style[:font] = style.font if style.font?
+          items = case @marker_type
+                  when :disc
+                    document.layout.text_fragments("•", style: marker_style)
+                  when :circle
+                    document.layout.text_fragments("❍", style: marker_style,
+                                                   font_size: style.font_size / 2.0,
+                                                   text_rise: -style.font_size / 1.8)
+                  when :square
+                    document.layout.text_fragments("■", style: marker_style,
+                                                   font_size: style.font_size / 2.0,
+                                                   text_rise: -style.font_size / 1.8)
+                  when :decimal
+                    text = (@start_number + index).to_s << "."
+                    document.layout.text_fragments(text, style: marker_style)
+                  else
+                    raise HexaPDF::Error, "Unknown list marker type #{@marker_type.inspect}"
+                  end
+          @item_marker_items = items unless @marker_type == :decimal
         end
-        TextBox.new(items: [fragment], style: {text_align: :right, padding: [0, 5, 0, 0]})
+        TextBox.new(items: items, style: {text_align: :right, padding: [0, 5, 0, 0]})
       end
 
       # Draws the list items onto the canvas at position [x, y].

data/lib/hexapdf/layout/page_style.rb

@@ -41,7 +41,10 @@ require 'hexapdf/layout/frame'
 module HexaPDF
   module Layout
 
-    # A PageStyle defines the initial look of a page and the placement of one or more frames.
+    # A PageStyle defines the dimensions of a page, its initial look, the Frame for object placement
+    # and which page style should be used next.
+    #
+    # This class is used by HexaPDF::Composer to style the individual pages.
     class PageStyle
 
       # The page size.
@@ -65,14 +68,15 @@ module HexaPDF
       # The callable object is given a canvas and the page style as arguments. It needs to draw the
       # initial content of the page. Note that the graphics state of the canvas is *not* saved
       # before executing the template code and restored afterwards. If this is needed, the object
-      # needs to do it itself.
+      # needs to do it itself. The #next_style attribute can optionally be set.
       #
-      # Furthermore it should set the #frame and #next_style attributes appropriately, if not done
-      # beforehand. The #create_frame method can be used for easily creating a rectangular frame.
+      # Furthermore, the callable object should set the #frame that defines the area on the page
+      # where content should be placed. The #create_frame method can be used for easily creating a
+      # rectangular frame.
       #
       # Example:
       #
-      #   page_style.template = lambda do |canvas, style
+      #   page_style.template = lambda do |canvas, style|
       #     box = canvas.context.box
       #     canvas.fill_color("fd0") do
       #       canvas.rectangle(0, 0, box.width, box.height).fill
@@ -81,22 +85,24 @@ module HexaPDF
       #   end
       attr_accessor :template
 
-      # The HexaPDF::Layout::Frame object that defines the area on the page where content should be
-      # placed.
+      # The Frame object that defines the area for the last page created with #create_page where
+      # content should be placed.
       #
-      # This can either be set beforehand or during execution of the #template.
-      #
-      # If no frame has been set, a frame covering the page except for a default margin on all sides
-      # is set during #create_page.
+      # This value is usually updated during execution of the #template. If the value is not
+      # updated, a frame covering the page except for a default margin on all sides is set during
+      # #create_page.
       attr_accessor :frame
 
       # Defines the name of the page style that should be used for the next page.
       #
+      # Note that this value can be different each time a new page is created via #create_page.
+      #
       # If this attribute is +nil+ (the default), it means that this style should be used again.
       attr_accessor :next_style
 
       # Creates a new page style instance for the given page size, orientation and next style
-      # values. If a block is given, it is used as template for defining the initial content.
+      # values. If a block is given, it is used as #template for defining the initial content of a
+      # page.
       #
       # Example:
       #
@@ -113,14 +119,15 @@ module HexaPDF
         @next_style = next_style
       end
 
-      # Creates a new page in the given document with this page style and returns it.
+      # Creates a new page in the given document using this page style and returns it.
       #
-      # If #frame has not been set beforehand or during execution of the #template, a default frame
-      # covering the whole page except a margin of 36 is created.
+      # If the #frame has not changed during execution of the #template, a default frame covering
+      # the whole page except a margin of 36 is assigned.
       def create_page(document)
+        frame_before = @frame
         page = document.pages.create(media_box: page_size, orientation: orientation)
         template&.call(page.canvas, self)
-        self.frame ||= create_frame(page, 36)
+        self.frame = create_frame(page, 36) if @frame.equal?(frame_before)
         page
       end
 

data/lib/hexapdf/layout/style.rb

@@ -393,7 +393,7 @@ module HexaPDF
       # The object resolved in this way needs to respond to #call(canvas, box) where +canvas+ is the
       # HexaPDF::Content::Canvas object on which it should be drawn and +box+ is a box-like object
       # (e.g. Box or TextFragment). The coordinate system is translated so that the origin is at the
-      # bottom left corner of the box during the drawing operations.
+      # bottom-left corner of the box during the drawing operations.
       class Layers
 
         # Creates a new Layers object popuplated with the given +layers+.
@@ -1268,8 +1268,8 @@ module HexaPDF
       #       composer.lorem_ipsum(position: :flow)
       #
       # [x, y]::
-      #     Position the box with the bottom left corner at the given absolute position relative to
-      #     the bottom left corner of the frame.
+      #     Position the box with the bottom-left corner at the given absolute position relative to
+      #     the bottom-left corner of the frame.
       #
       #     Examples:
       #
@@ -1369,8 +1369,8 @@ module HexaPDF
       #       composer.text('Text underneath')
       #
       # :fill_frame_horizontal::
-      #     The mask covers the box including the margin around the box and the space to the left
-      #     and right in the frame.
+      #     The mask covers the box including the margin around the box, the space to the left and
+      #     right in the frame and the space to the top of the current region.
       #
       #     Examples:
       #

data/lib/hexapdf/layout/table_box.rb

@@ -228,18 +228,22 @@ module HexaPDF
           case children
           when Box
             child_result = frame.fit(children)
-            @preferred_width = child_result.x + child_result.box.width + reserved_width
-            @height = @preferred_height = child_result.box.height + reserved_height
-            @fit_results = [child_result]
-            fit_result.success! if child_result.success?
+            if child_result.success?
+              @preferred_width = child_result.x + child_result.box.width + reserved_width
+              @height = @preferred_height = child_result.box.height + reserved_height
+              @fit_results = [child_result]
+              fit_result.success!
+            end
           when Array
             box_fitter = BoxFitter.new([frame])
             children.each {|box| box_fitter.fit(box) }
-            max_x_result = box_fitter.fit_results.max_by {|result| result.x + result.box.width }
-            @preferred_width = max_x_result.x + max_x_result.box.width + reserved_width
-            @height = @preferred_height = box_fitter.content_heights[0] + reserved_height
-            @fit_results = box_fitter.fit_results
-            fit_result.success! if box_fitter.success?
+            if box_fitter.success?
+              max_x_result = box_fitter.fit_results.max_by {|result| result.x + result.box.width }
+              @preferred_width = max_x_result.x + max_x_result.box.width + reserved_width
+              @height = @preferred_height = box_fitter.content_heights[0] + reserved_height
+              @fit_results = box_fitter.fit_results
+              fit_result.success!
+            end
           else
             @preferred_width = reserved_width
             @height = @preferred_height = reserved_height
@@ -590,7 +594,7 @@ module HexaPDF
       def fit_content(_available_width, _available_height, frame)
         # Adjust reserved width/height to include space used by the edge cells for their border
         # since cell borders are drawn on the bounds and not inside.
-        # This uses the top left and bottom right cells and so might not be correct in all cases.
+        # This uses the top-left and bottom-right cells and so might not be correct in all cases.
         @cell_tl_border_width = @cells[0, 0].style.border.width
         cell_br_border_width = @cells[-1, -1].style.border.width
         rw = (@cell_tl_border_width.left + cell_br_border_width.right) / 2.0

data/lib/hexapdf/layout/text_box.rb

@@ -42,12 +42,46 @@ module HexaPDF
     # A TextBox is used for drawing text, either inside a rectangular box or by flowing it around
     # objects of a Frame.
     #
+    # The standard usage is through the helper methods Document::Layout#text and
+    # Document::Layout#formatted_text.
+    #
     # This class uses TextLayouter behind the scenes to do the hard work.
     #
     # == Used Box Properties
     #
     # The spacing after the last line can be controlled via the style property +last_line_gap+. Also
     # see TextLayouter#style for other style properties taken into account.
+    #
+    # == Limitations
+    #
+    # When setting the style property 'position' to +:flow+, padding and border to the left and
+    # right as well as a predefined fixed width are not respected and the result will look wrong.
+    #
+    # == Examples
+    #
+    # Showing some text:
+    #
+    #   #>pdf-composer
+    #   composer.box(:text, items: layout.text_fragments("This is some text."))
+    #   # Or easier with the provided convenience method
+    #   composer.text("This is also some text")
+    #
+    # It is possible to flow the text around other objects by using the style property
+    # 'position' with the value +:flow+:
+    #
+    #   #>pdf-composer
+    #   composer.box(:base, width: 30, height: 30,
+    #                style: {margin: 5, position: :float, background_color: "hp-blue-light"})
+    #   composer.text("This is some text. " * 20, position: :flow)
+    #
+    # While top and bottom padding and border can be used with flow positioning, left and right
+    # padding and border are not supported and the result will look wrong:
+    #
+    #   #>pdf-composer
+    #   composer.box(:base, width: 30, height: 30,
+    #                style: {margin: 5, position: :float, background_color: "hp-blue-light"})
+    #   composer.text("This is some text. " * 20, padding: 10, position: :flow,
+    #                 text_align: :justify)
     class TextBox < Box
 
       # Creates a new TextBox object with the given inline items (e.g. TextFragment and InlineBox
@@ -72,11 +106,6 @@ module HexaPDF
         true
       end
 
-      # :nodoc:
-      def draw(canvas, x, y)
-        super(canvas, x + @x_offset, y)
-      end
-
       # :nodoc:
       def empty?
         super && (!@result || @result.lines.empty?)
@@ -89,40 +118,35 @@ module HexaPDF
       # Depending on the 'position' style property, the text is either fit into the current region
       # of the frame using +available_width+ and +available_height+, or fit to the shape of the
       # frame starting from the top (when 'position' is set to :flow).
-      def fit_content(available_width, available_height, frame)
+      def fit_content(_available_width, _available_height, frame)
         frame = frame.child_frame(box: self)
-        @width = @x_offset = @height = 0
+        @x_offset = 0
 
-        @result = if style.position == :flow
-                    @tl.fit(@items, frame.width_specification, frame.shape.bbox.height,
+        if style.position == :flow
+          height = (@initial_height > 0 ? @initial_height : frame.shape.bbox.height) - reserved_height
+          @result = @tl.fit(@items, frame.width_specification(reserved_height_top), height,
+                            apply_first_text_indent: !split_box?, frame: frame)
+          min_x = +Float::INFINITY
+          max_x = -Float::INFINITY
+          @result.lines.each do |line|
+            min_x = [min_x, line.x_offset].min
+            max_x = [max_x, line.x_offset + line.width].max
+          end
+          @width = (min_x.finite? ? max_x - min_x : 0) + reserved_width
+          fit_result.x = @x_offset = min_x
+          @height = @initial_height > 0 ? @initial_height : @result.height + reserved_height
+        else
+          @result = @tl.fit(@items, @width - reserved_width, @height - reserved_height,
                             apply_first_text_indent: !split_box?, frame: frame)
-                  else
-                    @width = reserved_width
-                    @height = reserved_height
-                    width = (@initial_width > 0 ? @initial_width : available_width) - @width
-                    height = (@initial_height > 0 ? @initial_height : available_height) - @height
-                    @tl.fit(@items, width, height, apply_first_text_indent: !split_box?, frame: frame)
-                  end
-
-        @width += if @initial_width > 0 || style.text_align == :center || style.text_align == :right
-                    width
-                  elsif style.position == :flow
-                    min_x = +Float::INFINITY
-                    max_x = -Float::INFINITY
-                    @result.lines.each do |line|
-                      min_x = [min_x, line.x_offset].min
-                      max_x = [max_x, line.x_offset + line.width].max
-                    end
-                    min_x.finite? ? (@x_offset = min_x; max_x - min_x) : 0
-                  else
-                    @result.lines.max_by(&:width)&.width || 0
-                  end
-        @height += if @initial_height > 0 || style.text_valign == :center || style.text_valign == :bottom
-                     height
-                   else
-                     @result.height
-                   end
-        if style.last_line_gap && @result.lines.last
+          if style.text_align == :left && @initial_width == 0
+            @width = (@result.lines.max_by(&:width)&.width || 0) + reserved_width
+          end
+          if style.text_valign == :top && @initial_height == 0
+            @height = @result.height + reserved_height
+          end
+        end
+
+        if style.last_line_gap && @result.lines.last && @initial_height == 0
           @height += style.line_spacing.gap(@result.lines.last, @result.lines.last)
         end
 

data/lib/hexapdf/layout/text_fragment.rb

@@ -52,7 +52,7 @@ module HexaPDF
     # The items of a text fragment may be frozen to indicate that the fragment is potentially used
     # multiple times.
     #
-    # The rectangle with the bottom left corner (#x_min, #y_min) and the top right corner (#x_max,
+    # The rectangle with the bottom-left corner (#x_min, #y_min) and the top-right corner (#x_max,
     # #y_max) describes the minimum bounding box of the whole text fragment and is usually *not*
     # equal to the box (0, 0)-(#width, #height).
     class TextFragment

data/lib/hexapdf/layout/text_layouter.rb

@@ -218,7 +218,10 @@ module HexaPDF
 
         # Breaks are detected at: space, tab, zero-width-space, non-breaking space, hyphen,
         # soft-hypen and any valid Unicode newline separator
-        BREAK_RE = /[ \u{A}-\u{D}\u{85}\u{2028}\u{2029}\t\u{200B}\u{00AD}\u{00A0}-]/
+        BREAK_CHARS = {}
+        " \u{A}\u{B}\u{C}\u{D}\u{85}\u{2028}\u{2029}\t\u{200B}\u{00AD}\u{00A0}-".each_char do |c|
+          BREAK_CHARS[c] = true
+        end
 
         # Breaks the items (an array of InlineBox and TextFragment objects) into atomic pieces
         # wrapped by Box, Glue or Penalty items, and returns those as an array.
@@ -235,7 +238,7 @@ module HexaPDF
                 # Collect characters and kerning values until break character is encountered
                 box_items = []
                 while (glyph = item.items[i]) &&
-                    (glyph.kind_of?(Numeric) || !BREAK_RE.match?(glyph.str))
+                    (glyph.kind_of?(Numeric) || !BREAK_CHARS.key?(glyph.str))
                   box_items << glyph
                   i += 1
                 end
@@ -428,9 +431,7 @@ module HexaPDF
           end
 
           line = create_unjustified_line
-          last_line_used = true
-          last_line_used = yield(line, nil) if item.nil? && !line.items.empty?
-
+          last_line_used = (item.nil? && !line.items.empty? ? yield(line, nil) : true)
           item.nil? && last_line_used ? [] : @items[@beginning_of_line_index..-1]
         end
 
@@ -500,9 +501,7 @@ module HexaPDF
           end
 
           line = create_unjustified_line
-          last_line_used = true
-          last_line_used = yield(line, nil) if item.nil? && !line.items.empty?
-
+          last_line_used = (item.nil? && !line.items.empty? ? yield(line, nil) : true)
           item.nil? && last_line_used ? [] : @items[@beginning_of_line_index..-1]
         end
 

data/lib/hexapdf/parser.rb

@@ -71,6 +71,10 @@ module HexaPDF
     end
 
     # Returns +true+ if the PDF file is a linearized file.
+    #
+    # Note: The method uses heuristics to determine whether a PDF file is linearized. In case of
+    # slightly invalid or damaged PDFs that HexaPDF can recover from it is possible that this method
+    # returns +true+ even though the PDF isn't actually linearized.
     def linearized?
       @linearized ||=
         begin
@@ -293,7 +297,7 @@ module HexaPDF
             next
           elsif type == 'n'
             if pos == 0 || gen > 65535
-              maybe_raise("Invalid in use cross-reference entry",
+              maybe_raise("Invalid in use cross-reference entry for object number #{oid}",
                           pos: @tokenizer.pos)
               xref.add_free_entry(oid, gen)
             else

data/lib/hexapdf/rectangle.rb

@@ -48,8 +48,8 @@ module HexaPDF
   #
   #   [left, bottom, right, top]
   #
-  # where +left+ is the bottom left x-coordinate, +bottom+ is the bottom left y-coordinate, +right+
-  # is the top right x-coordinate and +top+ is the top right y-coordinate.
+  # where +left+ is the bottom-left x-coordinate, +bottom+ is the bottom-left y-coordinate, +right+
+  # is the top-right x-coordinate and +top+ is the top-right y-coordinate.
   #
   # See: PDF2.0 s7.9.5
   class Rectangle < HexaPDF::PDFArray
@@ -119,8 +119,8 @@ module HexaPDF
     #:nodoc:
     RECTANGLE_ERROR_MSG = "A PDF rectangle structure must contain an array of four numbers"
 
-    # Ensures that the value is an array containing four numbers that specify the bottom left and
-    # top right corner.
+    # Ensures that the value is an array containing four numbers that specify the bottom-left and
+    # top-right corners.
     def after_data_change
       super
       unless value.size == 4 && all? {|v| v.kind_of?(Numeric) }

data/lib/hexapdf/revisions.rb

@@ -97,7 +97,7 @@ module HexaPDF
               merge_revision = offset
             end
 
-            if merge_revision == offset
+            if merge_revision == offset && !revisions.empty?
               xref_section.merge!(revisions.first.xref_section)
               offset = trailer[:Prev] # Get possible next offset before overwriting trailer
               trailer = revisions.first.trailer

data/lib/hexapdf/stream.rb

@@ -51,6 +51,9 @@ module HexaPDF
   # normalized to arrays on assignment to ease further processing.
   class StreamData
 
+    # The source.
+    attr_reader :source
+
     # The filter(s) that need to be applied for getting the decoded stream data.
     attr_reader :filter
 
@@ -110,9 +113,6 @@ module HexaPDF
 
     protected
 
-    # The source.
-    attr_reader :source
-
     # The optional offset into the bytes provided by source.
     attr_reader :offset
 

data/lib/hexapdf/tokenizer.rb

@@ -82,6 +82,7 @@ module HexaPDF
     # correctable situations are only raised if the return value of calling the object is +true+.
     def initialize(io, on_correctable_error: nil)
       @io = io
+      @io_chunk = String.new(''.b)
       @ss = StringScanner.new(''.b)
       @original_pos = -1
       @on_correctable_error = on_correctable_error || proc { false }
@@ -439,9 +440,9 @@ module HexaPDF
       @io.seek(@next_read_pos)
       return false if @io.eof?
 
-      @ss << @io.read(8192)
+      @ss << @io.read(8192, @io_chunk)
       if @ss.pos > 8192 && @ss.string.length > 16384
-        @ss.string.slice!(0, 8192)
+        @ss.string.replace(@ss.string.byteslice(8192..-1))
         @ss.pos -= 8192
         @original_pos += 8192
       end

data/lib/hexapdf/type/acro_form/button_field.rb

@@ -65,6 +65,8 @@ module HexaPDF
       #
       # == Type Specific Field Flags
       #
+      # See the class description for Field for the general field flags.
+      #
       # :no_toggle_to_off:: Only used with radio buttons fields. If this flag is set, one button
       #                     needs to be selected at all times. Otherwise, clicking on the selected
       #                     button deselects it.

data/lib/hexapdf/type/acro_form/choice_field.rb

@@ -51,6 +51,8 @@ module HexaPDF
       #
       # == Type Specific Field Flags
       #
+      # See the class description for Field for the general field flags.
+      #
       # :combo:: If set, the field represents a combo box.
       #
       # :edit:: If set, the combo box includes an editable text box for entering arbitrary values.