hexapdf 0.39.0 → 0.39.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0a43d232528df9bfc4a2c9baddd9cd1ddbd33fe7cce9d146b4e25760f25429b
-  data.tar.gz: 37cb10752d22bbc89fd18a779152ef7b5e02e6237318006a4b0e0a420d2890e2
+  metadata.gz: 07f7fd9468ec9c36993f4b1f2189704d65c1c73f7fa1ea30d44f6cb0a67fa92c
+  data.tar.gz: 1cad88a48910fd65a9dae7a90dcfe6ac34ef5ba9f69172a18bd52052fb10b99c
 SHA512:
-  metadata.gz: 79a27b101c502261e1bca7a25fa26fa434d38cec09a2ccb28a698a4364d8ed337ee63d82ce8cd4dd3097334ed54f0877565c25e20c2494c0ae7029156dc188ef
-  data.tar.gz: 69befc3a7066eb90a58ad4a65243939930f26ecc461e0f6f7c9bf0894ddfa58bf1a02567563caa453b0c6e745421de75e7dd433926d2a56b96aa4d71557059f5
+  metadata.gz: eeee46c22616abbca812ef441100e33534384db831aadf04df9b9382920aa58105be04046a76a9da76951c1d0bc39126e4ef33c43fa3401077c34604ff414acc
+  data.tar.gz: 1cd42546ff96980f6fbfeaae450a7f8657350ce3b23692b508b87718028e68fe50acd9ca8b744bc755f9b79029ecd41f5cb1cedc046209336594c3fba5a1807b

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.39.1 - 2024-03-20
+
+### Fixed
+
+* [HexaPDF::Layout::TableBox] to correctly split tables when a row span with a
+  too high cell is involved
+
+
 ## 0.39.0 - 2024-03-18
 
 ### Added

data/lib/hexapdf/layout/table_box.rb

@@ -417,7 +417,8 @@ module HexaPDF
               break
             end
           end
-          [height - available_height, last_fitted_row_index]
+
+          [height - available_height, last_fitted_row_index < start_row ? -1 : last_fitted_row_index]
         end
 
         # Draws the rows from +start_row+ to +end_row+ on the given +canvas+, with the top-left
@@ -647,7 +648,7 @@ module HexaPDF
         end
       end
 
-      # Splits the content of the column box. This method is called from Box#split.
+      # Splits the content of the table box. This method is called from Box#split.
       def split_content(_available_width, _available_height, _frame)
         if @special_cells_fit_not_successful || @last_fitted_row_index < 0
           [nil, self]

data/lib/hexapdf/type/acro_form/field.rb

@@ -284,7 +284,7 @@ module HexaPDF
         end
 
         # Creates a new widget annotation for this form field (must be a terminal field!) on the
-        # given +page+, adding the +values+ to the created widget annotation oject.
+        # given +page+, adding the +values+ to the created widget annotation object.
         #
         # If +allow_embedded+ is +false+, embedding the first widget in the field itself is not
         # allowed.

data/lib/hexapdf/version.rb

@@ -37,6 +37,6 @@
 module HexaPDF
 
   # The version of HexaPDF.
-  VERSION = '0.39.0'
+  VERSION = '0.39.1'
 
 end

data/test/hexapdf/layout/test_table_box.rb

@@ -362,8 +362,8 @@ describe HexaPDF::Layout::TableBox do
     @doc = HexaPDF::Document.new
     @page = @doc.pages.add
     @frame = HexaPDF::Layout::Frame.new(0, 0, 160, 100, context: @page)
-    draw_block = lambda {|canvas, _box| canvas.move_to(0, 0).end_path }
-    @fixed_size_boxes = 15.times.map { HexaPDF::Layout::Box.new(width: 20, height: 10, &draw_block) }
+    @draw_block = lambda {|canvas, _box| canvas.move_to(0, 0).end_path }
+    @fixed_size_boxes = 15.times.map { HexaPDF::Layout::Box.new(width: 20, height: 10, &@draw_block) }
   end
 
   def create_box(**kwargs)
@@ -561,6 +561,30 @@ describe HexaPDF::Layout::TableBox do
       assert_equal(-1, box_b.last_fitted_row_index)
     end
 
+    it "splits the table correctly when row spans and a too-high cell are involved" do
+      cells = [[@fixed_size_boxes[0], @fixed_size_boxes[1]],
+               [{row_span: 2, content: @fixed_size_boxes[2]}, @fixed_size_boxes[3]],
+               [HexaPDF::Layout::Box.new(width: 20, height: 150, &@draw_block)]]
+      box = create_box(cells: cells)
+
+      refute(box.fit(100, 100, @frame))
+      box_a, box_b = box.split(100, 100, @frame)
+      assert_same(box_a, box)
+      assert(box_b.split_box?)
+      assert_equal(0, box_a.start_row_index)
+      assert_equal(0, box_a.last_fitted_row_index)
+      assert_equal(1, box_b.start_row_index)
+      assert_equal(-1, box_b.last_fitted_row_index)
+
+      refute(box_b.fit(100, 100, @frame))
+      box_c, box_d = box_b.split(100, 100, @frame)
+      assert_nil(box_c)
+      assert_same(box_d, box_b)
+      assert(box_d.split_box?)
+      assert_equal(1, box_d.start_row_index)
+      assert_equal(-1, box_d.last_fitted_row_index)
+    end
+
     it "splits the table if the header or footer rows don't fit" do
       cells_creator = lambda {|_| [@fixed_size_boxes[10, 2]] }
       [{header: cells_creator}, {footer: cells_creator}].each do |args|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hexapdf
 version: !ruby/object:Gem::Version
-  version: 0.39.0
+  version: 0.39.1
 platform: ruby
 authors:
 - Thomas Leitner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-18 00:00:00.000000000 Z
+date: 2024-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cmdparse