hexapdf 0.29.0 → 0.31.0

data/test/hexapdf/type/test_object_stream.rb

@@ -123,12 +123,21 @@ describe HexaPDF::Type::ObjectStream do
     end
   end
 
-  it "fails validation if gen != 0" do
-    assert(@obj.validate(auto_correct: false))
-    @obj.gen = 1
-    refute(@obj.validate(auto_correct: false) do |msg, correctable|
-             assert_match(/invalid generation/, msg)
-             refute(correctable)
-           end)
+  describe "perform_validation" do
+    it "fails validation if gen != 0" do
+      assert(@obj.validate(auto_correct: false))
+      @obj.gen = 1
+      refute(@obj.validate(auto_correct: false) do |msg, correctable|
+        assert_match(/invalid generation/, msg)
+        refute(correctable)
+      end)
+    end
+
+    it "sets the /N and /First entries to dummy values so that validation works" do
+      @obj = HexaPDF::Type::ObjectStream.new({}, oid: 1, document: @doc)
+      assert(@obj.validate(auto_correct: false))
+      assert_equal(0, @obj[:N])
+      assert_equal(0, @obj[:First])
+    end
   end
 end

data/test/hexapdf/type/test_outline.rb

@@ -30,11 +30,12 @@ describe HexaPDF::Type::Outline do
 
   describe "perform_validation" do
     before do
-      5.times { @outline.add_item("Test1") }
+      @outline_items = 5.times.map { @outline.add_item("Test1") }
     end
 
     it "fixes a missing /First entry" do
       @outline.delete(:First)
+      @outline_items[0][:Prev] = HexaPDF::Reference.new(100)
       called = false
       @outline.validate do |msg, correctable, _|
         called = true
@@ -46,6 +47,7 @@ describe HexaPDF::Type::Outline do
 
     it "fixes a missing /Last entry" do
       @outline.delete(:Last)
+      @outline_items[4][:Next] = HexaPDF::Reference.new(100)
       called = false
       @outline.validate do |msg, correctable, _|
         called = true

data/test/hexapdf/type/test_outline_item.rb

@@ -276,12 +276,13 @@ describe HexaPDF::Type::OutlineItem do
 
   describe "perform_validation" do
     before do
-      5.times { @item.add_item("Test1") }
+      @outline_items = 5.times.map { @item.add_item("Test1") }
       @item[:Parent] = @doc.add({})
     end
 
     it "fixes a missing /First entry" do
       @item.delete(:First)
+      @outline_items[0][:Prev] = HexaPDF::Reference.new(100)
       called = false
       @item.validate do |msg, correctable, _|
         called = true
@@ -293,6 +294,7 @@ describe HexaPDF::Type::OutlineItem do
 
     it "fixes a missing /Last entry" do
       @item.delete(:Last)
+      @outline_items[4][:Next] = HexaPDF::Reference.new(100)
       called = false
       @item.validate do |msg, correctable, _|
         called = true

data/test/hexapdf/type/test_page.rb

@@ -19,9 +19,21 @@ describe HexaPDF::Type::Page do
       assert_equal([0, 0, 842, 595], HexaPDF::Type::Page.media_box(:A4, orientation: :landscape))
     end
 
+    it "works with a paper size array" do
+      assert_equal([0, 0, 842, 595], HexaPDF::Type::Page.media_box([0, 0, 842, 595]))
+    end
+
     it "fails if the paper size is unknown" do
       assert_raises(HexaPDF::Error) { HexaPDF::Type::Page.media_box(:Unknown) }
     end
+
+    it "fails if the array doesn't contain four numbers" do
+      assert_raises(HexaPDF::Error) { HexaPDF::Type::Page.media_box([0, 1, 2]) }
+    end
+
+    it "fails if the array doesn't contain only numbers" do
+      assert_raises(HexaPDF::Error) { HexaPDF::Type::Page.media_box([0, 1, 2, 'a']) }
+    end
   end
 
   # Asserts that the page's contents contains the operators.
@@ -70,22 +82,41 @@ describe HexaPDF::Type::Page do
     end
   end
 
-  describe "validation" do
+  describe "perform_validation" do
     it "only does validation if the page is in the document's page tree" do
       page = @doc.add({Type: :Page})
+      assert(page.validate(auto_correct: false))
+      page[:Parent] = @doc.add({Type: :Pages, Kids: [page], Count: 1})
+      assert(page.validate(auto_correct: false))
+      @doc.pages.add(page)
+      refute(page.validate(auto_correct: false))
+    end
+
+    it "validates that the required inheritable field /Resources is set" do
+      page = @doc.pages.add
+      page.delete(:Resources)
+      refute(page.validate(auto_correct: false))
       assert(page.validate)
-      page[:Parent] = @doc.add({Type: :Pages, Kids: [page]})
-      assert(page.validate)
-      page[:Parent] = @doc.catalog.pages
-      refute(page.validate)
+      assert_kind_of(HexaPDF::Dictionary, page[:Resources])
     end
 
-    it "fails if a required inheritable field is not set" do
-      root = @doc.catalog[:Pages] = @doc.add({Type: :Pages})
-      page = @doc.add({Type: :Page, Parent: root})
-      message = ''
-      refute(page.validate {|m, _| message = m })
-      assert_match(/inheritable.*MediaBox/i, message)
+    it "validates that the required inheritable field /MediaBox is set" do
+      page1 = @doc.pages.add(:Letter)
+      page2 = @doc.pages.add(:Letter)
+      page3 = @doc.pages.add(:Letter)
+
+      [page1, page2, page3].each do |page|
+        page.delete(:MediaBox)
+        refute(page.validate(auto_correct: false))
+        assert(page.validate)
+        assert_equal([0, 0, 612, 792], page[:MediaBox])
+      end
+
+      page2.delete(:MediaBox)
+      page1[:MediaBox] = [0, 0, 1, 1]
+      refute(page2.validate(auto_correct: false))
+      assert(page2.validate)
+      assert_equal([0, 0, 595, 842], page2[:MediaBox])
     end
   end
 

data/test/hexapdf/type/test_xref_stream.rb

@@ -6,9 +6,10 @@ require 'hexapdf/type/xref_stream'
 describe HexaPDF::Type::XRefStream do
   before do
     @doc = Object.new
+    @doc.instance_variable_set(:@version, '1.5')
     def (@doc).deref(obj); obj; end
     def (@doc).wrap(obj, **); obj; end
-    @obj = HexaPDF::Type::XRefStream.new({}, oid: 1, document: @doc)
+    @obj = HexaPDF::Type::XRefStream.new({}, oid: 1, document: @doc, stream: '')
   end
 
   describe "xref_section" do
@@ -141,4 +142,8 @@ describe HexaPDF::Type::XRefStream do
       assert_raises(HexaPDF::Error) { @obj.update_with_xref_section_and_trailer(@section, {}) }
     end
   end
+
+  it "sets /Size and /W to dummy values to make validation work" do
+    assert(@obj.validate(auto_correct: false))
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hexapdf
 version: !ruby/object:Gem::Version
-  version: 0.29.0
+  version: 0.31.0
 platform: ruby
 authors:
 - Thomas Leitner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-30 00:00:00.000000000 Z
+date: 2023-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cmdparse
@@ -428,6 +428,7 @@ files:
 - lib/hexapdf/layout/line.rb
 - lib/hexapdf/layout/list_box.rb
 - lib/hexapdf/layout/numeric_refinements.rb
+- lib/hexapdf/layout/page_style.rb
 - lib/hexapdf/layout/style.rb
 - lib/hexapdf/layout/text_box.rb
 - lib/hexapdf/layout/text_fragment.rb
@@ -679,6 +680,7 @@ files:
 - test/hexapdf/layout/test_inline_box.rb
 - test/hexapdf/layout/test_line.rb
 - test/hexapdf/layout/test_list_box.rb
+- test/hexapdf/layout/test_page_style.rb
 - test/hexapdf/layout/test_style.rb
 - test/hexapdf/layout/test_text_box.rb
 - test/hexapdf/layout/test_text_fragment.rb