hexapdf 0.21.1 → 0.24.0

data/test/hexapdf/type/acro_form/test_text_field.rb

@@ -115,6 +115,16 @@ describe HexaPDF::Type::AcroForm::TextField do
       @field.flag(:password)
       assert_raises(HexaPDF::Error) { @field.field_value = 'test' }
     end
+
+    it "fails if it is a comb text field without a /MaxLen entry" do
+      @field.initialize_as_comb_text_field
+      assert_raises(HexaPDF::Error) { @field.field_value = 'test' }
+    end
+
+    it "fails if the value exceeds the length set by /MaxLen" do
+      @field[:MaxLen] = 5
+      assert_raises(HexaPDF::Error) { @field.field_value = 'testdf' }
+    end
   end
 
   it "sets and returns the default field value" do
@@ -197,5 +207,12 @@ describe HexaPDF::Type::AcroForm::TextField do
       @field[:V] = nil
       assert(@field.validate)
     end
+
+    it "checks that /MaxLen is set for comb text fields" do
+      @field.initialize_as_comb_text_field
+      refute(@field.validate)
+      @field[:MaxLen] = 2
+      assert(@field.validate)
+    end
   end
 end

data/test/hexapdf/type/test_catalog.rb

@@ -21,6 +21,14 @@ describe HexaPDF::Type::Catalog do
     assert_equal(:Pages, pages.type)
   end
 
+  it "creates the name dictionary on access" do
+    assert_nil(@catalog[:Names])
+    names = @catalog.names
+    assert_equal(:XXNames, names.type)
+    other = @catalog.names
+    assert_same(other, names)
+  end
+
   describe "acro_form" do
     it "returns an existing form object" do
       @catalog[:AcroForm] = :test

data/test/hexapdf/type/test_image.rb

@@ -115,16 +115,42 @@ describe HexaPDF::Type::Image do
       assert(info.indexed)
       assert(info.writable)
 
-      @image[:ColorSpace] = :ICCBased
+      @image[:ColorSpace] = [:ICCBased, {N: 3}]
       info = @image.info
-      assert_equal(:other, info.color_space)
-      assert_equal(-1, info.components)
+      assert_equal(:icc, info.color_space)
+      assert_equal(3, info.components)
+      assert(info.writable)
+      @image[:ColorSpace] = [:ICCBased, {N: 4}]
+      info = @image.info
+      refute(info.writable)
     end
 
     it "processes the SMask entry" do
-      @image[:SMask] = :something
-      info = @image.info
-      refute(info.writable)
+      @image[:SMask] = {BitsPerComponent: 8, Width: 10, Height: 5}
+
+      @image[:BitsPerComponent] = 8
+      assert(@image.info.writable)
+
+      @image[:BitsPerComponent] = 16
+      refute(@image.info.writable)
+      @image[:SMask][:BitsPerComponent] = 16
+      assert(@image.info.writable)
+
+      @image[:BitsPerComponent] = 4
+      refute(@image.info.writable)
+      @image[:SMask][:BitsPerComponent] = 4
+      refute(@image.info.writable)
+
+      @image[:BitsPerComponent] = @image[:SMask][:BitsPerComponent] = 8
+      @image[:SMask][:Width] = 8
+      refute(@image.info.writable)
+
+      @image[:SMask][:Width] = 10
+      @image[:SMask][:Height] = 8
+      refute(@image.info.writable)
+
+      @image[:SMask][:Height] = 5
+      assert(@image.info.writable)
     end
   end
 
@@ -184,7 +210,7 @@ describe HexaPDF::Type::Image do
     end
 
     Dir.glob(File.join(TEST_DATA_DIR, 'images', '*.png')).each do |png_file|
-      next if png_file =~ /alpha/
+      next if png_file =~ /indexed-alpha/
       it "writes #{File.basename(png_file)} correctly as PNG file" do
         image = @doc.images.add(png_file)
         if png_file =~ /greyscale-1bit.png/ # force use of arrays for one image
@@ -208,6 +234,7 @@ describe HexaPDF::Type::Image do
         else
           assert_nil(new_image[:Mask], "file: #{png_file}")
         end
+        assert(new_image[:SMask]) if png_file =~ /alpha/
         assert_equal(image.stream, new_image.stream, "file: #{png_file}")
 
         # ColorSpace is currently not always preserved, e.g. with CalRGB
@@ -236,6 +263,15 @@ describe HexaPDF::Type::Image do
       assert_equal(image.stream, new_image.stream)
     end
 
+    it "works for images with an ICCBased color space" do
+      image = @doc.add({Type: :XObject, Subtype: :Image, Width: 2, Height: 2, BitsPerComponent: 2,
+                        ColorSpace: [:ICCBased, @doc.wrap({}, stream: 'abcd')]})
+      image.stream = HexaPDF::StreamData.new(filter: :ASCIIHexDecode) { "10 B0".b }
+      image.write(@file.path)
+      assert_valid_png(@file.path)
+      assert_match(/iCCPICCProfile\x00\x00/, File.binread(@file.path))
+    end
+
     it "fails if an unsupported stream filter is used" do
       image = @doc.images.add(@jpg)
       image.set_filter([:DCTDecode, :ASCIIHexDecode])
@@ -244,13 +280,13 @@ describe HexaPDF::Type::Image do
 
     it "fails if an unsupported colorspace is used" do
       image = @doc.add({Type: :XObject, Subtype: :Image, Width: 1, Height: 1, BitsPerComponent: 8,
-                        ColorSpace: :ICCBased})
+                        ColorSpace: :Unknown})
       assert_raises(HexaPDF::Error) { image.write(@file) }
     end
 
     it "fails if an indexed image with an unsupported colorspace is used" do
       image = @doc.add({Type: :XObject, Subtype: :Image, Width: 1, Height: 1, BitsPerComponent: 8,
-                        ColorSpace: [:Indexed, :ICCBased, 0, "0"]})
+                        ColorSpace: [:Indexed, :Unknown, 0, "0"]})
       assert_raises(HexaPDF::Error) { image.write(@file) }
     end
   end

data/test/hexapdf/type/test_names.rb

@@ -0,0 +1,20 @@
+# -*- encoding: utf-8 -*-
+
+require 'test_helper'
+require 'hexapdf/document'
+require 'hexapdf/type/names'
+
+describe HexaPDF::Type::Names do
+  before do
+    @doc = HexaPDF::Document.new
+    @names = @doc.add({}, type: :XXNames)
+  end
+
+  it "returns the name tree for the /Dests entry" do
+    refute(@names.key?(:Dests))
+    dests = @names.destinations
+    assert_kind_of(HexaPDF::NameTreeNode, dests)
+    assert_same(dests, @names[:Dests])
+    assert_same(dests, @names.destinations)
+  end
+end

data/test/hexapdf/type/test_page_tree_node.rb

@@ -217,9 +217,19 @@ describe HexaPDF::Type::PageTreeNode do
       assert(@root.validate)
     end
 
+    it "works if the location stays the same" do
+      @root.move_page(3, 3)
+      assert_equal(@pages, @root.each_page.to_a)
+      assert(@root.validate)
+
+      @root.move_page(-2, -2)
+      assert_equal(@pages, @root.each_page.to_a)
+      assert(@root.validate)
+    end
+
     it "moves the page to the correct location with a positive index" do
       @root.move_page(1, 3)
-      assert_equal([@pages[0], @pages[2], @pages[1], *@pages[3..-1]], @root.each_page.to_a)
+      assert_equal([@pages[0], @pages[2], @pages[3], @pages[1], *@pages[4..-1]], @root.each_page.to_a)
       assert(@root.validate)
     end
 
@@ -229,6 +239,16 @@ describe HexaPDF::Type::PageTreeNode do
       assert(@root.validate)
     end
 
+    it "moves the page to the correct location within the same parent node" do
+      @root.move_page(2, 4)
+      assert_equal([@pages[0], @pages[1], @pages[3], @pages[4], @pages[2], *@pages[5..-1]], @root.each_page.to_a)
+      assert(@root.validate)
+
+      @root.move_page(4, 3)
+      assert_equal([@pages[0], @pages[1], @pages[3], @pages[2], @pages[4], *@pages[5..-1]], @root.each_page.to_a)
+      assert(@root.validate)
+    end
+
     it "fails if the index to the moving page is invalid" do
       assert_raises(HexaPDF::Error) { @root.move_page(10, 0) }
     end

data/test/hexapdf/type/test_trailer.rb

@@ -25,7 +25,7 @@ describe HexaPDF::Type::Trailer do
 
   it "returns the catalog object, creating it if needed" do
     doc = Minitest::Mock.new
-    doc.expect(:add, :val, [{Type: :Catalog}])
+    doc.expect(:add, :val, [{Type: :Catalog}], type: :Catalog)
     trailer = HexaPDF::Type::Trailer.new({}, document: doc)
     assert_equal(:val, trailer.catalog)
     doc.verify
@@ -34,7 +34,7 @@ describe HexaPDF::Type::Trailer do
 
   it "returns the info object, creating it if needed" do
     doc = Minitest::Mock.new
-    doc.expect(:add, :val, [{}, type: :XXInfo])
+    doc.expect(:add, :val, [{}], type: :XXInfo)
     trailer = HexaPDF::Type::Trailer.new({}, document: doc)
     assert_equal(:val, trailer.info)
     doc.verify
@@ -89,7 +89,7 @@ describe HexaPDF::Type::Trailer do
     it "corrects a missing Catalog entry" do
       @obj.delete(:Root)
       @obj.set_random_id
-      def (@doc).add(val) HexaPDF::Object.new(val, oid: 3) end
+      def (@doc).add(val, type:); type.to_s; HexaPDF::Object.new(val, oid: 3) end
 
       message = ''
       refute(@obj.validate(auto_correct: false) {|m, _| message = m })

data/test/hexapdf/type/test_xref_stream.rb

@@ -88,10 +88,11 @@ describe HexaPDF::Type::XRefStream do
       @obj[:Index] = [0, 5]
       @obj[:W] = [1, 2, 2]
       dict = @obj.trailer
-      assert_equal(3, dict.length)
+      assert_equal(4, dict.length)
       assert_equal(5, dict[:Size])
       assert_equal(["a", "b"], dict[:ID])
       assert_equal('x', dict[:Root])
+      assert_equal(:XRef, dict[:Type])
     end
   end
 

data/test/hexapdf/utils/test_sorted_tree_node.rb

@@ -135,7 +135,17 @@ describe HexaPDF::Utils::SortedTreeNode do
       assert_nil(@root.find_entry('non'))
     end
 
-    it "works when no entry exists" do
+    it "works when no entry exists and neither /Names nor /Kids are set" do
+      assert_nil(@root.find_entry('non'))
+    end
+
+    it "works when no entry exists and /Names is set" do
+      @root[:Names] = []
+      assert_nil(@root.find_entry('non'))
+    end
+
+    it "works when no entry exists and /Kids is set" do
+      @root[:Kids] = []
       assert_nil(@root.find_entry('non'))
     end
   end

data/test/test_helper.rb

@@ -3,7 +3,9 @@
 begin
   require 'simplecov'
   SimpleCov.start do
+    minimum_coverage line: 100
     add_filter '/test/'
+    add_filter '/fast_arc4.rb'
   end
 rescue LoadError
 end
@@ -14,10 +16,12 @@ require 'fiber'
 require 'zlib'
 
 TEST_DATA_DIR = File.join(__dir__, 'data')
-MINIMAL_PDF = File.read(File.join(TEST_DATA_DIR, 'minimal.pdf')).freeze
+MINIMAL_PDF = File.binread(File.join(TEST_DATA_DIR, 'minimal.pdf')).freeze
 
 Minitest::Test.make_my_diffs_pretty!
 
+ENV['TZ'] = 'UTC'
+
 module TestHelper
 
   # Asserts that the method +name+ of +object+ gets invoked with the +expected_values+ when

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hexapdf
 version: !ruby/object:Gem::Version
-  version: 0.21.1
+  version: 0.24.0
 platform: ruby
 authors:
 - Thomas Leitner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-12 00:00:00.000000000 Z
+date: 2022-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cmdparse
@@ -58,6 +58,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.16'
 - !ruby/object:Gem::Dependency
   name: reline
   requirement: !ruby/object:Gem::Requirement
@@ -218,6 +232,7 @@ files:
 - examples/018-composer.rb
 - examples/019-acro_form.rb
 - examples/020-column_box.rb
+- examples/021-list_box.rb
 - examples/emoji-smile.png
 - examples/emoji-wink.png
 - examples/machupicchu.jpg
@@ -256,9 +271,11 @@ files:
 - lib/hexapdf/dictionary.rb
 - lib/hexapdf/dictionary_fields.rb
 - lib/hexapdf/document.rb
+- lib/hexapdf/document/destinations.rb
 - lib/hexapdf/document/files.rb
 - lib/hexapdf/document/fonts.rb
 - lib/hexapdf/document/images.rb
+- lib/hexapdf/document/layout.rb
 - lib/hexapdf/document/pages.rb
 - lib/hexapdf/document/signatures.rb
 - lib/hexapdf/encryption.rb
@@ -334,11 +351,13 @@ files:
 - lib/hexapdf/importer.rb
 - lib/hexapdf/layout.rb
 - lib/hexapdf/layout/box.rb
+- lib/hexapdf/layout/box_fitter.rb
 - lib/hexapdf/layout/column_box.rb
 - lib/hexapdf/layout/frame.rb
 - lib/hexapdf/layout/image_box.rb
 - lib/hexapdf/layout/inline_box.rb
 - lib/hexapdf/layout/line.rb
+- lib/hexapdf/layout/list_box.rb
 - lib/hexapdf/layout/numeric_refinements.rb
 - lib/hexapdf/layout/style.rb
 - lib/hexapdf/layout/text_box.rb
@@ -506,9 +525,11 @@ files:
 - test/hexapdf/content/test_parser.rb
 - test/hexapdf/content/test_processor.rb
 - test/hexapdf/content/test_transformation_matrix.rb
+- test/hexapdf/document/test_destinations.rb
 - test/hexapdf/document/test_files.rb
 - test/hexapdf/document/test_fonts.rb
 - test/hexapdf/document/test_images.rb
+- test/hexapdf/document/test_layout.rb
 - test/hexapdf/document/test_pages.rb
 - test/hexapdf/document/test_signatures.rb
 - test/hexapdf/encryption/common.rb
@@ -573,10 +594,13 @@ files:
 - test/hexapdf/image_loader/test_pdf.rb
 - test/hexapdf/image_loader/test_png.rb
 - test/hexapdf/layout/test_box.rb
+- test/hexapdf/layout/test_box_fitter.rb
+- test/hexapdf/layout/test_column_box.rb
 - test/hexapdf/layout/test_frame.rb
 - test/hexapdf/layout/test_image_box.rb
 - test/hexapdf/layout/test_inline_box.rb
 - test/hexapdf/layout/test_line.rb
+- test/hexapdf/layout/test_list_box.rb
 - test/hexapdf/layout/test_style.rb
 - test/hexapdf/layout/test_text_box.rb
 - test/hexapdf/layout/test_text_fragment.rb
@@ -638,6 +662,7 @@ files:
 - test/hexapdf/type/test_form.rb
 - test/hexapdf/type/test_image.rb
 - test/hexapdf/type/test_info.rb
+- test/hexapdf/type/test_names.rb
 - test/hexapdf/type/test_object_stream.rb
 - test/hexapdf/type/test_page.rb
 - test/hexapdf/type/test_page_tree_node.rb
@@ -673,7 +698,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: HexaPDF - A Versatile PDF Creation and Manipulation Library For Ruby