heroku_hatchet 8.0.2 → 8.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c72d006f643f893a0347e7c7ce5fae2e128d4a94fea501d957afb6738cc9374f
-  data.tar.gz: a507cd401042cf6e245b63824b9cbb30b79aa56541bc604f2c92b54d23413cbd
+  metadata.gz: e8d54466a86a51ed1f418e8786e18aa62c97439dbdc1836f74e3455ea1e0542f
+  data.tar.gz: 938be3cf7fe5b3c985c430350cca348c3390b80d3eb19544f2249b7c9b2cdc9a
 SHA512:
-  metadata.gz: 6ba49829178ac76fe6a62faf32afbef57a828dc4fd390d50887f2b2c50f30a8359ad6f9639ad34b258a2594a885333e8a704b59f93e3bdf80cb87ce897f5a4c1
-  data.tar.gz: a54f637129f9b57f296f405e374082573b584b3c960bab387723f19f87bf8ee63562022a94ee08aa9e75bf3badffd63fdeec805897b71db30e15b74aaf5384c6
+  metadata.gz: 5117cc22b180827b704ddb83dfb16a160706a8f27132ab85660066785574c0bb20d1fcffbffc83acbad1ee01f646bb200832b547d29fa8b0c7aa148be15809e9
+  data.tar.gz: c25a47e3778c54ab8f17a79b97e6567ae577e0ec1e09a1eabef72606047bd2e1e14a11354987401a9d270e74609437a6e01b26c9be7625bf521c471c0c75b294

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+* @heroku/languages

data/.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ["2.7", "3.0", "3.1"]
+        ruby-version: ["2.7", "3.0", "3.1", "3.2", "3.3"]
     runs-on: ubuntu-22.04
     env:
       HATCHET_APP_LIMIT: 100

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## HEAD
 
+## 8.0.4
+
+- Any 404 when trying to delete an application will be considered duplicate (https://github.com/heroku/hatchet/pull/210)
+
+## 8.0.3
+
+- Add support for Ruby 3.2 and 3.3 (https://github.com/heroku/hatchet/pull/203 and https://github.com/heroku/hatchet/pull/208)
+
 ## 8.0.2
 
 - Bugfix: Allow nested deploy blocks with new teardown logic (https://github.com/heroku/hatchet/pull/201)

data/etc/ci_setup.rb

@@ -12,7 +12,7 @@ end
 puts "== Setting Up CI =="
 
 netrc_file = "#{ENV['HOME']}/.netrc"
-unless File.exists?(netrc_file)
+unless File.exist?(netrc_file)
   File.open(netrc_file, 'w') do |file|
     file.write <<-EOF
 machine git.heroku.com

data/lib/hatchet/reaper.rb

@@ -187,18 +187,10 @@ module Hatchet
       @api_rate_limit.call.app.delete(id)
 
       io.puts message
-    rescue Excon::Error::NotFound => e
-      body = e.response.body
+    rescue Excon::Error::NotFound, Excon::Error::Forbidden => e
+      status = e.response.status
       request_id = e.response.headers["Request-Id"]
-      if body =~ /Couldn\'t find that app./
-        message = "Duplicate destroy attempted #{name.inspect}: #{id}, status: 404, request_id: #{request_id}"
-        raise AlreadyDeletedError.new(message)
-      else
-        raise e
-      end
-    rescue Excon::Error::Forbidden => e
-      request_id = e.response.headers["Request-Id"]
-      message = "Duplicate destroy attempted #{name.inspect}: #{id}, status: 403, request_id: #{request_id}"
+      message = "Possible duplicate destroy attempted #{name.inspect}: #{id}, status: #{status}, request_id: #{request_id}"
       raise AlreadyDeletedError.new(message)
     end
   end

data/lib/hatchet/version.rb

@@ -1,3 +1,3 @@
 module Hatchet
-  VERSION = "8.0.2"
+  VERSION = "8.0.4"
 end

data/spec/hatchet/app_spec.rb

@@ -29,19 +29,6 @@ describe "AppTest" do
     expect(app.platform_api.app.info(app.name)["build_stack"]["name"]).to eq(stack)
   end
 
-  it "create app with HATCHET_DEFAULT_STACK set" do
-    begin
-      original_default_stack = ENV["HATCHET_DEFAULT_STACK"]
-      default_stack = "heroku-18"
-      ENV["HATCHET_DEFAULT_STACK"] = default_stack
-      app = Hatchet::App.new("default_ruby")
-      app.create_app
-      expect(app.platform_api.app.info(app.name)["build_stack"]["name"]).to eq(default_stack)
-    ensure
-      ENV["HATCHET_DEFAULT_STACK"] = original_default_stack
-    end
-  end
-
   describe "before deploy" do
     it "dir" do
       @called = false

data/spec/hatchet/ci_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
-describe "CIFourTest" do
-  it "error with bad app" do
+describe "CI" do
+  it "runs rakefile contents" do
     string = SecureRandom.hex
 
     app = Hatchet::GitApp.new("default_ruby")
@@ -17,47 +17,4 @@ describe "CIFourTest" do
       expect(test_run.output).to_not match("Installing rake")
     end
   end
-
-  it "error with bad app" do
-    pending("upgrade rails 5 app to newer")
-
-    expect {
-      Hatchet::GitApp.new("rails5_ci_fails_no_database", stack: "heroku-18").run_ci { }
-    }.to raise_error(/PG::ConnectionBad: could not connect to server/)
-  end
-
-  it "error with bad app" do
-    @before_deploy_called = false
-    @before_deploy_dir_pwd = nil
-
-    before_deploy = -> do
-      @before_deploy_called = true
-      @before_deploy_dir_pwd = Dir.pwd
-    end
-
-    Hatchet::GitApp.new("rails5_ci_fails_no_database", stack: "heroku-18", allow_failure: true, before_deploy: before_deploy).run_ci do |test_run|
-      expect(test_run.status).to eq(:errored)
-      expect(@before_deploy_dir_pwd).to eq(Dir.pwd)
-      expect(@before_deploy_called).to be_truthy
-    end
-
-    expect(@before_deploy_dir_pwd).to_not eq(Dir.pwd)
-  end
-
-  it "ci create app with stack" do
-    pending("upgrade rails 5 app to newer")
-
-    app = Hatchet::GitApp.new("rails5_ruby_schema_format")
-    app.run_ci do |test_run|
-      expect(test_run.output).to match("Ruby buildpack tests completed successfully")
-      expect(test_run.status).to eq(:succeeded)
-      expect(app.pipeline_id).to_not be_nil
-
-      api_rate_limit = app.api_rate_limit.call
-      couplings = api_rate_limit.pipeline_coupling.list_by_pipeline(app.pipeline_id)
-      coupled_app = api_rate_limit.app.info(couplings.first["app"]["id"])
-      expect(coupled_app["name"]).to eq(app.name)
-    end
-    expect(app.pipeline_id).to be_nil
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: heroku_hatchet
 version: !ruby/object:Gem::Version
-  version: 8.0.2
+  version: 8.0.4
 platform: ruby
 authors:
 - Richard Schneeman
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-06 00:00:00.000000000 Z
+date: 2024-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: platform-api
@@ -158,6 +158,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/CODEOWNERS"
 - ".github/workflows/check_changelog.yml"
 - ".github/workflows/ci.yml"
 - ".github/workflows/hatchet_app_cleaner.yml"
@@ -233,7 +234,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: Hatchet is a an integration testing library for developing Heroku buildpacks.