heroku_hatchet 7.3.1 → 7.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c1b161f5f43f135f7eb4e6c803b6228b15e51904001a744572cca572e26a799
-  data.tar.gz: e804ea689f9934308978e4804799fee00a0d252d3e64cb62eb29a20c4d05659f
+  metadata.gz: 960b3c8f2eee0b1252df5b2e6ce23b718de130d099f913812bd5fbb196c3b006
+  data.tar.gz: 3dec91bb9b7de86d3aef2ef78086f29239f078d1c6c004244b3ead7aaf139a58
 SHA512:
-  metadata.gz: b2b9364b374e384b3e5d16f159774d4b1da90d3a79c5c3afad6092d05209a13bd8d52c2d34c97feb4da0b989339d120a4562c65b121e7ec6b3d843ae3657cefe
-  data.tar.gz: '026904fd62500a2874d57f9c8462aee651f62dd1467c6281bc7061312d2a683203f8e1237577d2bb66ab3f4d5174bdf2fe408e3c165a950a1cf4a386673f4a29'
+  metadata.gz: b19e39c4963c64a5448f5b4ff4961722e1c17b020d3c6a8f3ef102a1bb136ba2feb504afddc8cbb6a286f384806776ebfdfebb76834f3d1a3eb37af36cbe4532
+  data.tar.gz: 3cc4cb2320f711e1d5fbb2024dc7a7ff1d734158b2f89322104a162fc00a2cb21940cf520f64e679b948c1a9be4bedeb3735c447c8287496438d1265bd372104

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## HEAD
 
+## 7.3.2
+
+- Fix App#in_directory_fork not receiving debugging output when an error is raised (https://github.com/heroku/hatchet/pull/146)
+- Do not create CI tarball inside cwd to prevent tar "file changed as we read it" warnings.
+
 ## 7.3.1
 
 - Fix Ruby incompatibility introduced by using `&.` and `rescue` without

data/lib/hatchet/app.rb

@@ -387,8 +387,8 @@ module Hatchet
     def in_directory_fork(&block)
       Tempfile.create("stdout") do |tmp_file|
         pid = fork do
-          $stdout.reopen(tmp_file, "w")
-          $stderr.reopen(tmp_file, "w")
+          $stdout.reopen(tmp_file, "a")
+          $stderr.reopen(tmp_file, "a")
           $stdout.sync = true
           $stderr.sync = true
           in_directory do |dir|

data/lib/hatchet/test_run.rb

@@ -1,3 +1,5 @@
+require "tempfile"
+
 module Hatchet
   class FailedTestError < StandardError
     def initialize(app, output)
@@ -177,15 +179,17 @@ module Hatchet
         app_json["stack"]                              ||= @app.stack if @app.stack && !@app.stack.empty?
         File.open("app.json", "w") {|f| f.write(JSON.generate(app_json)) }
 
-        out = `tar c . | gzip -9 > slug.tgz`
-        raise "Tar command failed: #{out}" unless $?.success?
-
-        source_put_url = @app.create_source
-        Hatchet::RETRIES.times.retry do
-          PlatformAPI.rate_throttle.call do
-            Excon.put(source_put_url,
-                      expects: [200],
-                      body:    File.read('slug.tgz'))
+        Tempfile.create("slug.tgz") do |slug|
+          out = `tar c . | gzip -9 > #{slug.path}`
+          raise "Tar command failed: #{out}" unless $?.success?
+
+          source_put_url = @app.create_source
+          Hatchet::RETRIES.times.retry do
+            PlatformAPI.rate_throttle.call do
+              Excon.put(source_put_url,
+                        expects: [200],
+                        body:    slug.read)
+            end
           end
         end
       end

data/lib/hatchet/version.rb

@@ -1,3 +1,3 @@
 module Hatchet
-  VERSION = "7.3.1"
+  VERSION = "7.3.2"
 end

data/spec/hatchet/local_repo_spec.rb

@@ -11,6 +11,15 @@ describe "LocalRepoTest" do
     expect(ENV[env_name]).to eq(env_name)
   end
 
+  it "in directory fork captures stdout even when there is an error" do
+    expect {
+      Hatchet::App.new("default_ruby").in_directory_fork do
+        puts "hello_there"
+        raise "error"
+      end
+    }.to raise_error(/hello_there/)
+  end
+
   it "repos checked into git" do
     begin
       fixture_dir = "repo_fixtures/different-folder-for-checked-in-repos/default_ruby"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: heroku_hatchet
 version: !ruby/object:Gem::Version
-  version: 7.3.1
+  version: 7.3.2
 platform: ruby
 authors:
 - Richard Schneeman
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-05 00:00:00.000000000 Z
+date: 2020-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: platform-api