heroku_config_vars 1.0.2 → 1.1.0

data/spec/models/heroku_config_vars/heroku_app_spec.rb

@@ -2,24 +2,11 @@ require 'spec_helper'
 
 module HerokuConfigVars
   describe HerokuApp do
+    subject(:app) { described_class.new args }
 
-    let(:app_name) { 'valid-app-name' }
-    let(:api_key)  { 'valid-api-key' }
-    let(:auth)     { 'Basic ' << Base64::strict_encode64(':' << api_key) }
-
-    before do
-      stub_request(:get, "https://api.heroku.com/apps/#{app_name}/config_vars").
-        with(:headers => {'Authorization'=>auth}).
-        to_return(:body => <<-RESPONSE
-          {
-            "DATABASE_URL": "postgres://xxx:xxx@ec2-54-243-229-75.compute-1.amazonaws.com:5432/d26ti1mqt7h24",
-            "HEROKU_POSTGRESQL_MAROON_URL": "postgres://xxx:xxx@ec2-54-243-229-75.compute-1.amazonaws.com:5432/d26ti1mqt7h24",
-            "HEROKU_APP_NAME": "#{app_name}",
-            "HEROKU_API_KEY": "#{api_key}"
-          }
-        RESPONSE
-        )
-    end
+    let(:args) { Hash.new } 
+
+    stub_heroku_responses
 
     describe '::find' do
       subject { described_class.find }
@@ -40,146 +27,79 @@ module HerokuConfigVars
       end
 
       context 'with valid ENV set' do
-        before do
-          ENV['HEROKU_APP_NAME'] = app_name
-          ENV['HEROKU_API_KEY']  = api_key
-        end
+        setup_app
 
         it { should be_a_kind_of HerokuApp }
         it { should be_loaded }
 
-        its(:api_key) { should eq api_key }
-        its(:app_name) { should eq app_name }        
+        its(:api_key) { should eq valid_api_key }
+        its(:app_name) { should eq valid_app_name }        
       end
 
     end
 
-    describe '::new' do
-      subject { described_class.new args }
+    context 'with no args' do
+      before { app.valid? }
 
-      context 'with no args' do
-        let(:args) do
-          {}
-        end
+      it { should_not be_valid }
+      its(:errors) { should include :app_name }
+      its(:errors) { should include :api_key }
+      it { should_not be_loaded }
+      its(:vars) { should be_empty }
+    end
 
-        it { should_not be_valid }
-        it { should have(1).error_on(:app_name) }
-        it { should have(1).error_on(:api_key) }
-        it { should_not be_loaded }
-        its(:vars) { should be_empty }
+    context 'with valid credentials' do
+      let(:args) do
+        {
+          :api_key  => valid_api_key,
+          :app_name => valid_app_name,
+        }
       end
 
-      context 'with valid credentials' do
-        let(:args) do
-          {
-            :api_key  => api_key,
-            :app_name => app_name,
-          }
-        end
-
-        it { should be_valid }
-        it { should_not be_loaded }
-        its(:vars) { should include 'HEROKU_APP_NAME' }
-        its(:vars) { should include 'HEROKU_API_KEY' }
-      end
+      it { should be_valid }
+      it { should_not be_loaded }
+      its(:vars) { should include 'HEROKU_APP_NAME' }
+      its(:vars) { should include 'HEROKU_API_KEY' }
     end
 
+
     describe '#attributes=' do
-      subject(:app) { described_class.new }
       before { app.attributes = {:api_key => 'foo'} }
 
       its(:api_key) { should eq 'foo' }
     end
 
     describe '#load_vars' do
-      context 'with non-existent app name'
-      context 'with unauthorized app name'
-      context 'with invalid api key'
-      context 'with no config set'
-      context 'with config'
-    end
+      before { app.load_vars }
 
-    describe '#save'
+      context 'with non-existent app name' do
+        let(:args) do
+          { app_name: 'xxx', api_key: valid_api_key }
+        end
 
-    context 'with changed `vars`' do
-      before do
-        stub_request(:get, "https://api.heroku.com/apps/#{app_name}/config_vars").
-          with(headers: {'Authorization'=>auth}).
-          to_return(headers: {
-            'Content-Type' => 'application/json'
-          }, body: <<-RESPONSE
-            {
-              'VAR1': 'value 1',
-              'VAR2': 'value 2',
-              'VAR3': 'value 3',
-              'VAR4': 'value 4',
-            }
-          RESPONSE
-          )
+        its(:errors) { should include :app_name }
       end
 
-      let(:app) { described_class.new(api_key: api_key, app_name: app_name) { |app| app.load_vars } }
+      context 'with unauthorized app name' do
+        let(:args) do
+          { app_name: other_app_name, api_key: valid_api_key }
+        end
 
-      before do
-        puts app.vars
-        app.vars = {
-          'VAR2' => 'value 2',
-          'VAR3' => 'value 33',
-          'VAR4' => 'value 44',
-          'VAR5' => 'value 5'
-        }
+        its(:errors) { should include :app_name }
       end
 
-      describe '#removed_vars'
-      describe '#added_vars'
-      describe '#kept_vars'
-      describe '#updated_vars'
-      describe '#updated_and_added_vars'
-      describe '#changes'
-    end
+      context 'with invalid api key' do
+        let(:args) do
+          { app_name: valid_app_name, api_key: 'xxx' }
+        end
+
+        its(:errors) { should include :api_key }
+      end
 
-#    context 'with an invalid api_key' do
-#      let(:args) do
-#        {
-#          :api_key  => 'xxx',
-#          :app_name => app_name,
-#        }
-#      end
-#
-#      it { should_not be_valid }
-#      it { should have(1).error_on(:api_key) }
-#    end
-#
-#    context 'with an invalid app_name' do
-#      let(:args) do
-#        {
-#          :api_key  => api_key,
-#          :app_name => 'xxx',
-#        }
-#      end
-#
-#      it { should_not be_valid }
-#      it { should have(1).error_on(:app_name) }
-#    end
-#    specify('no request made') do
-#      expect(a_request :any, "api.heroku.com").not_to have_been_made
-#    end
-#
-#    context 'with an invalid ENV' do
-#      before do
-#        ENV['HEROKU_APP_NAME'] = 'xxx'
-#        ENV['HEROKU_API_KEY']  = 'xxx'
-#      end
-#
-#      it { should be_a_kind_of HerokuApp }
-#      it { should be_loaded }
-#
-#      its(:vars) { should be_present }
-#      its(:api_key) { should eq api_key }
-#      its(:app_name) { should eq app_name }
-#      its(:errors) { should be_blank }
-#    end
+      context 'when heroku is down'
+    end
 
+    describe '#save'
 
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,13 @@
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 ENV["RAILS_ENV"] ||= 'test'
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start 'rails'
 
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 require 'rspec/rails'

data/spec/support/heroku_responses.rb

@@ -4,12 +4,24 @@ module HerokuResponses
     def stub_heroku_responses
       let(:valid_app_name) { 'valid_app_name' }
       let(:valid_api_key)  { 'valid_api_key' }
+      let(:other_app_name) { 'other_app_name' }
       let(:valid_auth)     { 'Basic ' << Base64::strict_encode64(':' << valid_api_key) }
       let(:live_vars)      { {"HEROKU_APP_NAME" => valid_app_name, "HEROKU_API_KEY" => valid_api_key } }
       let(:set_vars)       { Hash.new }
       let(:delete_var)     { '' }
 
       before do
+        stub_request(:any, %r[https://api.heroku.com/.*]).
+         to_return(status: 401)
+
+        stub_request(:any, %r[https://api.heroku.com/apps/.*]).
+         with(headers: { 'Authorization' => valid_auth }).
+         to_return(status: 404)
+
+       stub_request(:any, %r[https://api.heroku.com/apps/#{other_app_name}/.*]).
+         with(headers: { 'Authorization' => valid_auth }).
+         to_return(status: 403)
+
         stub_request(:get, "https://api.heroku.com/apps/#{valid_app_name}/config_vars").
           with(headers: { 'Authorization' => valid_auth }).
           to_return(body: live_vars.to_json)
@@ -17,11 +29,11 @@ module HerokuResponses
         stub_request(:put, "https://api.heroku.com/apps/#{valid_app_name}/config_vars").
           with(headers: { 'Authorization' => valid_auth }).
           with(body: set_vars.to_json).
-          to_return(:status => 200, :body => "", :headers => {})
+          to_return(status: 200)
 
         stub_request(:delete, "https://api.heroku.com/apps/#{valid_app_name}/config_vars/#{delete_var}").
           with(headers: { 'Authorization' => valid_auth }).
-          to_return(:status => 200, :body => "", :headers => {})
+          to_return(status: 200)
       end
     end
 

metadata

@@ -1,144 +1,127 @@
 --- !ruby/object:Gem::Specification
 name: heroku_config_vars
 version: !ruby/object:Gem::Version
-  prerelease: 
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Daniel Fone
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-21 00:00:00.000000000 Z
+date: 2014-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    none: false
-  prerelease: false
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
-    none: false
+        version: '3.1'
   type: :runtime
-- !ruby/object:Gem::Dependency
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
-    none: false
-  prerelease: false
+        version: '3.1'
+- !ruby/object:Gem::Dependency
   name: sass-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
-    none: false
+        version: '0'
   type: :runtime
-- !ruby/object:Gem::Dependency
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.3'
-    none: false
-  prerelease: false
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: heroku-api
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.3'
-    none: false
   type: :runtime
-- !ruby/object:Gem::Dependency
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
-    none: false
-  prerelease: false
-  name: rails
+        version: '0.3'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
-    none: false
+        version: 2.14.0
   type: :development
-- !ruby/object:Gem::Dependency
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.13.0
-    none: false
-  prerelease: false
-  name: rspec-rails
+        version: 2.14.0
+- !ruby/object:Gem::Dependency
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.13.0
-    none: false
+        version: 1.17.0
   type: :development
-- !ruby/object:Gem::Dependency
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
-    none: false
-  prerelease: false
-  name: webmock
+        version: 1.17.0
+- !ruby/object:Gem::Dependency
+  name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
-    none: false
+        version: 2.2.0
   type: :development
-- !ruby/object:Gem::Dependency
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
-    none: false
-  prerelease: false
-  name: capybara
+        version: 2.2.0
+- !ruby/object:Gem::Dependency
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
-    none: false
+        version: 0.7.0
   type: :development
-- !ruby/object:Gem::Dependency
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
-    none: false
-  prerelease: false
-  name: launchy
+        version: 0.7.0
+- !ruby/object:Gem::Dependency
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.0
-    none: false
+        version: 0.5.2
   type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.2
 description: Engine to manage Heroku configuration variables from within your application
 email:
 - daniel@fone.net.nz
@@ -146,6 +129,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- MIT-LICENSE
+- README.md
+- Rakefile
 - app/assets/javascripts/heroku_config_vars/application.js
 - app/assets/javascripts/heroku_config_vars/var_form.js
 - app/assets/stylesheets/heroku_config_vars/application.css
@@ -165,42 +151,18 @@ files:
 - app/views/heroku_config_vars/heroku_apps/show.html.erb
 - app/views/layouts/heroku_config_vars/application.html.erb
 - config/routes.rb
+- lib/heroku_config_vars.rb
 - lib/heroku_config_vars/engine.rb
 - lib/heroku_config_vars/version.rb
-- lib/heroku_config_vars.rb
 - lib/tasks/heroku_config_vars_tasks.rake
-- MIT-LICENSE
-- Rakefile
-- README.md
-- spec/dummy/app/assets/javascripts/application.js
-- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/Rakefile
 - spec/dummy/app/controllers/application_controller.rb
-- spec/dummy/app/helpers/application_helper.rb
-- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
 - spec/dummy/config/environment.rb
-- spec/dummy/config/environments/development.rb
-- spec/dummy/config/environments/test.rb
-- spec/dummy/config/initializers/backtrace_silencers.rb
-- spec/dummy/config/initializers/heroku_config_vars.rb
-- spec/dummy/config/initializers/inflections.rb
-- spec/dummy/config/initializers/mime_types.rb
-- spec/dummy/config/initializers/secret_token.rb
-- spec/dummy/config/initializers/session_store.rb
-- spec/dummy/config/initializers/wrap_parameters.rb
-- spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
-- spec/dummy/config.ru
-- spec/dummy/log/production.log
 - spec/dummy/log/test.log
-- spec/dummy/public/404.html
-- spec/dummy/public/422.html
-- spec/dummy/public/500.html
-- spec/dummy/public/favicon.ico
-- spec/dummy/Rakefile
-- spec/dummy/README.rdoc
-- spec/dummy/script/rails
 - spec/dummy/tmp/cache/assets/C20/540/sprockets%2F9f7052464a49612e023f9088fa442053
 - spec/dummy/tmp/cache/assets/C97/2C0/sprockets%2F3945d527e8ea800568e77dd095c67391
 - spec/dummy/tmp/cache/assets/C9B/060/sprockets%2Fa20484759fec963d3f51839934c3848f
@@ -248,64 +210,36 @@ files:
 - spec/views/heroku_config_vars/application/recommend_https_spec.rb
 homepage: https://github.com/danielfone/heroku_config_vars
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3022254310143536717
-  none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3022254310143536717
-  none: false
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.2.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Engine to manage Heroku configuration variables from within your application
 test_files:
-- spec/dummy/app/assets/javascripts/application.js
-- spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
-- spec/dummy/app/helpers/application_helper.rb
-- spec/dummy/app/views/layouts/application.html.erb
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
 - spec/dummy/config/environment.rb
-- spec/dummy/config/environments/development.rb
-- spec/dummy/config/environments/test.rb
-- spec/dummy/config/initializers/backtrace_silencers.rb
-- spec/dummy/config/initializers/heroku_config_vars.rb
-- spec/dummy/config/initializers/inflections.rb
-- spec/dummy/config/initializers/mime_types.rb
-- spec/dummy/config/initializers/secret_token.rb
-- spec/dummy/config/initializers/session_store.rb
-- spec/dummy/config/initializers/wrap_parameters.rb
-- spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config.ru
-- spec/dummy/log/production.log
 - spec/dummy/log/test.log
-- spec/dummy/public/404.html
-- spec/dummy/public/422.html
-- spec/dummy/public/500.html
-- spec/dummy/public/favicon.ico
 - spec/dummy/Rakefile
-- spec/dummy/README.rdoc
-- spec/dummy/script/rails
 - spec/dummy/tmp/cache/assets/C20/540/sprockets%2F9f7052464a49612e023f9088fa442053
 - spec/dummy/tmp/cache/assets/C97/2C0/sprockets%2F3945d527e8ea800568e77dd095c67391
 - spec/dummy/tmp/cache/assets/C9B/060/sprockets%2Fa20484759fec963d3f51839934c3848f