heroku-domainr 0.1.0 → 0.1.1

data/lib/heroku/plugins/domainr/version.rb

@@ -1,7 +1,7 @@
 module Heroku
   module Plugins
     module Domainr
-      VERSION = "0.1.0"
+      VERSION = "0.1.1"
     end
   end
 end

data/lib/heroku/plugins/heroku_domainr.rb

@@ -7,20 +7,34 @@ module Heroku
       @@heroku_client = nil
 
       def domains_add(domain)
-        heroku_client.add_domain(Heroku::Plugins::Domainr::Config.heroku_app, domain)
+        unless config_not_defined?
+          heroku_client.add_domain(Heroku::Plugins::Domainr::Config.heroku_app, domain)
+        else
+          log("Skipping domain #{domain} creation because config is not defined")
+        end
       end
 
       def domains_remove(domain)
-        heroku_client.remove_domain(Heroku::Plugins::Domainr::Config.heroku_app, domain)
+        unless config_not_defined?
+          heroku_client.remove_domain(Heroku::Plugins::Domainr::Config.heroku_app, domain)
+        else
+          log("Skipping domain #{domain} removal because config is not defined")
+        end
       end
 
       def domains_clear()
-        heroku_client.remove_domains(Heroku::Plugins::Domainr::Config.heroku_app)
+        unless config_not_defined?
+          heroku_client.remove_domains(Heroku::Plugins::Domainr::Config.heroku_app)
+        else
+          log("Skipping domain clearing because config is not defined")
+        end
       end
 
       def heroku_client
-        @@heroku_client || @@heroku_client = Heroku::Client.new(Heroku::Plugins::Domainr::Config.heroku_user,
-                                                                Heroku::Plugins::Domainr::Config.heroku_pass)
+        unless config_not_defined?
+          @@heroku_client || @@heroku_client = Heroku::Client.new(Heroku::Plugins::Domainr::Config.heroku_user,
+                                                                  Heroku::Plugins::Domainr::Config.heroku_pass)
+        end
       end
 
       def self.config
@@ -28,6 +42,9 @@ module Heroku
       end
 
       private
+      def config_not_defined?
+        Heroku::Plugins::Domainr::Config.heroku_user.nil? || Heroku::Plugins::Domainr::Config.heroku_pass.nil? || Heroku::Plugins::Domainr::Config.heroku_app.nil?
+      end
 
       def log(message)
         if defined?(Rails)

data/spec/heroku_domainr_spec.rb

@@ -6,7 +6,9 @@ RSpec.configure do |config|
 end
 
 Heroku::Plugins::Domainr.config do |c|
-  c.heroku_app  = "app_name"
+  c.heroku_app   = "app_name"
+  c.heroku_user  = "jan"
+  c.heroku_pass  = "haslo"
 end
 
 class DomainrImpl
@@ -34,4 +36,13 @@ describe Heroku::Plugins::Domainr do
     mock(@fake_heroku_client).remove_domains("app_name")
     @domainr.domains_clear()
   end
+
+  it "should not call heroku client if app name is not specified" do
+    Heroku::Plugins::Domainr.config do |c|
+      c.heroku_app  = nil
+    end
+    @domainr.domains_add("alamakota")
+    @domainr.domains_remove("alamakota")
+    @domainr.domains_clear()
+  end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Marcin Naglik
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-09 00:00:00 +02:00
+date: 2011-05-11 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency