heroku-api 0.2.4 → 0.2.5

data/changelog.txt

@@ -1,3 +1,10 @@
+0.2.5 06/13/2012
+================
+
+make post_release release param optional (defaults to latest)
+fix for contructing addon_params
+fail gracefully on non-http-status errors
+
 0.2.4 05/31/2012
 ================
 

data/lib/heroku/api/releases.rb

@@ -20,7 +20,7 @@ module Heroku
     end
 
     # POST /apps/:app/releases/:release
-    def post_release(app, release)
+    def post_release(app, release=nil)
       request(
         :expects  => 200,
         :method   => :post,

data/lib/heroku/api/version.rb

@@ -1,5 +1,5 @@
 module Heroku
   class API
-    VERSION = "0.2.4"
+    VERSION = "0.2.5"
   end
 end

data/lib/heroku/api.rb

@@ -58,9 +58,7 @@ module Heroku
     def request(params, &block)
       begin
         response = @connection.request(params, &block)
-      rescue Excon::Errors::SocketError => error
-        raise error
-      rescue Excon::Errors::Error => error
+      rescue Excon::Errors::HTTPStatusError => error
         klass = case error.response.status
           when 401 then Heroku::API::Errors::Unauthorized
           when 402 then Heroku::API::Errors::VerificationRequired
@@ -106,7 +104,10 @@ module Heroku
     end
 
     def addon_params(params)
-      {:config => params}
+      params.inject({}) do |accum, (key, value)|
+        accum["config[#{key}]"] = value
+        accum
+      end
     end
 
     def ps_options(params)

data/test/test_addons.rb

@@ -101,6 +101,18 @@ class TestAddons < MiniTest::Unit::TestCase
     end
   end
 
+  def test_post_add_on_with_config_parses_config_correctly
+    with_app do |app_data|
+      addon_post_path = "/apps/#{app_data['name']}/addons/deployhooks:http"
+      Excon.stub({:method => :post, :path => addon_post_path}) do |params|
+        {:body => params[:query], :status => 200}
+      end
+      response = heroku.post_addon(app_data['name'], 'deployhooks:http', {"url"=>"http://example.com"})
+      assert_equal({ "config[url]" => "http://example.com"}, response.body)
+    end
+    Excon.stubs.shift
+  end
+
   def test_post_addon_addon_already_installed
     with_app do |app_data|
       assert_raises(Heroku::API::Errors::RequestFailed) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: heroku-api
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-31 00:00:00.000000000 Z
+date: 2012-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
-  requirement: &70256555193800 !ruby/object:Gem::Requirement
+  requirement: &70106232313520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 0.14.0
   type: :runtime
   prerelease: false
-  version_requirements: *70256555193800
+  version_requirements: *70106232313520
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70256555193240 !ruby/object:Gem::Requirement
+  requirement: &70106232312560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256555193240
+  version_requirements: *70106232312560
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70256555192640 !ruby/object:Gem::Requirement
+  requirement: &70106232311820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256555192640
+  version_requirements: *70106232311820
 description: Ruby Client for the Heroku API
 email:
 - wesley@heroku.com
@@ -119,12 +119,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1608937311142232836
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1608937311142232836
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.15