hermod 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 007bbe64b27318ad3c57e53eb766f0e96036d19e
-  data.tar.gz: 9f3d1ad9465d5146f800791b413d850274a42760
+  metadata.gz: cdd493e70d309b8dddb2c9ec72d3f7bbf3f1382d
+  data.tar.gz: 15b69c23091b9323b477cf2a745469c02fd421ed
 SHA512:
-  metadata.gz: 2854aafc9bb97ae8db69a86ff550601b39789e8c262b366ab6ebc2f83247338f688abf83a9fa5e8a9ae58db80b9d685242908db45dd83b036599f6739e239e40
-  data.tar.gz: c15b093a474a529636d39367867cfb020c9cfc2751203b11869008e546547e4b4de213858c3d48d0ad5f86407a05f1a0a62a86b8caa75659288ba4ea91b0b90e
+  metadata.gz: f2b8af05d20e045cca9b2319ddd33561f828535db9bed7696a8b85c3e87b9c7e7660d99bfc1ce7dc24957d80a245ae71ea8ddb01fb6e3d7dede3c957848195b3
+  data.tar.gz: eef967388b2e6302cdcc177056a37582c65a298a82d5696255847d2326956778f97b811535b7255203aa0f5ce257708e3cf79660079bf4d40692e8fd275149a9

data/lib/hermod/validators/type_checker.rb

@@ -24,7 +24,7 @@ module Hermod
       private
 
       def test
-        checker.call(value)
+        value.blank? || checker.call(value)
       end
 
       def message

data/lib/hermod/version.rb

@@ -1,3 +1,3 @@
 module Hermod
-  VERSION = "1.2.3"
+  VERSION = "1.2.4"
 end

data/lib/hermod/xml_section_builder.rb

@@ -108,7 +108,7 @@ module Hermod
       end
 
       create_method(name, [], validators, options) do |value, attributes|
-        [value.strftime(format_for(:date)), attributes]
+        [(value ? value.strftime(format_for(:date)) : nil), attributes]
       end
     end
 

data/spec/hermod/validators/type_checker_spec.rb

@@ -10,11 +10,14 @@ module Hermod
       end
 
       it "allows you to give a block to be more discerning" do
-        checker = TypeChecker.new(Date) {|val| val.respond_to? :strftime }
-        dateish = Minitest::Mock.new
-        dateish.expect :strftime, "today"
-        checker.valid?(dateish, {}).must_equal true
-        proc { checker.valid?(Minitest::Mock.new, {}) }.must_raise InvalidInputError
+        checker = TypeChecker.new(Integer) { |val| val > 0 }
+        checker.valid?(5, {}).must_equal true
+        proc { checker.valid?(-2, {}) }.must_raise InvalidInputError
+      end
+
+      it "ignores blank values" do
+        checker = TypeChecker.new(Integer)
+        checker.valid?(nil, {}).must_equal true
       end
 
       it "gives the correct message" do

data/spec/hermod/xml_section_builder/date_node_spec.rb

@@ -5,7 +5,7 @@ module Hermod
 
     DateXml = XmlSection.build(formats: {date: "%Y-%m-%d"}) do |builder|
       builder.date_node :date_of_birth
-      builder.date_node :anniversary
+      builder.date_node :anniversary, optional: true
     end
 
     describe "Date nodes" do
@@ -22,6 +22,11 @@ module Hermod
       it "should raise an error if given something that isn't a date" do
         proc { subject.anniversary "yesterday" }.must_raise InvalidInputError
       end
+
+      it "should ignore blank dates if the date is optional" do
+        subject.anniversary nil
+        nodes("Anniversary").must_be_empty
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hermod
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Harry Mills
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-31 00:00:00.000000000 Z
+date: 2014-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: libxml-ruby