hermes 0.5.1 → 0.6.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 5f19fa4dfd6cb0dcbbf56afd43753ea94608bfc3
+  data.tar.gz: 300bb3a223a40139e27fa9f181a0828cf938facc
+SHA512:
+  metadata.gz: 32576daed8c2a3dcf369b4a8f2af41ed64156f1a31ff7c28d3090ebd59b367dae31df3bcb3246f17ce37b87aa992dc0b3e28a2aad26187dd6b6269a90e5de164
+  data.tar.gz: dbf442c93afe4441b543b407eccbe9fea2c7c2a36a694ba286808ac1b29e10b1afd8f46d1470bf02bab24617cc59968b8cb7b51c3826127f23a109eafc116a87

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2011 PlataformaTec http://blog.plataformatec.com.br/
+Copyright 2011 Plataformatec http://blog.plataformatec.com.br/
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.rdoc

@@ -2,7 +2,7 @@
 
 A few testing facilities built on top of Capybara and ActiveSupport::TestCase.
 
-Requires Rails >= 3.1 and Capybara >= 1.0.
+Requires Rails >= 4 and Capybara >= 2.2.
 
 == TODO
 
@@ -12,6 +12,15 @@ Requires Rails >= 3.1 and Capybara >= 1.0.
 
 Require perf optimization for your test suite with "hermes/perf"
 
+== Capybara tips
+
+We recommend adding this to `spec/support`:
+
+    Capybara.add_selector :record do
+      xpath { |record| XPath.css("#" + ActionView::RecordIdentifier.dom_id(record)) }
+      match { |record| record.is_a?(ActiveRecord::Base) }
+    end
+
 == Bugs and Features
 
 If you discover any bugs or add any features, please let us know using GitHub's tracker.
@@ -20,4 +29,4 @@ http://github.com/plataformatec/hermes/issues
 
 == License
 
-MIT License. Copyright 2011 Plataforma Tecnologia. http://blog.plataformatec.com.br
+MIT License. Copyright 2011 Plataformatec. http://blog.plataformatec.com.br

data/lib/hermes.rb

@@ -3,6 +3,5 @@ module Hermes
   autoload :IntegrationCase, 'hermes/integration_case'
   autoload :Actions, 'hermes/actions'
   autoload :Builders, 'hermes/builders'
-  autoload :Scopes, 'hermes/scopes'
   autoload :Assertions, 'hermes/assertions'
 end

data/lib/hermes/actions.rb

@@ -40,11 +40,9 @@ module Hermes
 
     def find_and_select_option(select_prefix, postfix, value)
       full = "#{select_prefix}_#{postfix}"
-      no_select_msg = "cannot select option, no select box with id '#{full}' found"
-      no_option_msg = "cannot select option, no option with text '#{value}' in select box '#{full}'"
 
-      select = find(:css, "##{full}", :message => no_select_msg)
-      select.find(:xpath, ".//option[contains(./@value, '#{value}')]", :message => no_option_msg).select_option
+      select = find(:css, "##{full}")
+      select.find(:xpath, ".//option[contains(./@value, '#{value}')]").select_option
     end
 
     def string_with_double_digits(number)
@@ -63,11 +61,9 @@ module Hermes
     end
 
     def find_prefix_by_label(label)
-      message = "cannot select option, select with label '#{label}' not found"
       find(:xpath,
-           "//label[contains(normalize-space(string(.)), '#{label}')]/@for",
-           :message => message
-          ).text.sub(/_\di$/, '')
+           "//label[contains(normalize-space(string(.)), '#{label}')]"
+          )['for'].sub(/_\di$/, '')
     end
   end
 end

data/lib/hermes/assertions.rb

@@ -85,5 +85,11 @@ module Hermes
     def body_inner_text
       Nokogiri::HTML(page.body).inner_text.gsub(/^\s*$/, "").squeeze("\n")
     end
+
+    private
+
+    def assert_block(message)
+      assert yield, message
+    end
   end
 end

data/lib/hermes/builders.rb

@@ -1,5 +1,5 @@
-# Rails developers have had bad experience with fixtures since a long time
-# due to several reasons, including misuse.
+# Rails developers have had bad experience with fixtures for a long time
+# due to misuse.
 #
 # This misuse of fixtures is often characterized by a huge ammount of
 # fixtures, causing a lot of data to maintain and dependence between tests.
@@ -9,14 +9,14 @@
 # An example of such tests is a test that assures a given SQL query with
 # GROUP BY and ORDER BY conditions returns the correct result set. As expected,
 # we need a huge amount of data in this test which we usually don't need in
-# order tests.
+# other tests.
 #
 # For such scenarios, factories are a fine solution. They won't clutter
 # all your database since they are created for these specific tests and they
 # are also easier to maintain.
 #
 # I believe this was the primary reason for the Rails community to strongly
-# adopt factories builders as we saw in the couple two years ago.
+# adopt factories builders as we saw in the last years.
 #
 # However, factories are also misused. It is common to see people creating
 # a huge amount of data with factories before each test in their integration
@@ -105,7 +105,11 @@ module Hermes
         if builder = @@builders[name.to_sym]
           klass, block = builder
 
-          hash = block ? block.bind(scope).call : {}
+          hash = if block
+                   scope.instance_exec(&block)
+                 else
+                   {}
+                 end
           hash.symbolize_keys!
           hash.merge!(options || {})
           hash.delete(:id)
@@ -123,7 +127,7 @@ module Hermes
       end
     end
 
-    def respond_to?(method)
+    def respond_to?(method, include_private=false)
       case method.to_s
       when BUILDER_REGEX
         Builders.has_builder?($2)
@@ -140,7 +144,7 @@ module Hermes
         return super unless Builders.has_builder?($2)
         klass, hash = Builders.retrieve(self, $2, method, args.first)
         object = klass.new
-        object.assign_attributes hash, :without_protection => true
+        object.assign_attributes hash
         object.send("save#{$3}") if $1 == "create"
         object
       when ATTRIBUTES_REGEX

data/lib/hermes/integration_case.rb

@@ -1,13 +1,12 @@
 class Hermes::IntegrationCase < ActiveSupport::TestCase
   include Capybara::DSL
-  include ActionController::RecordIdentifier
+  include ActionView::RecordIdentifier
   include Rails.application.routes.url_helpers
 
   extend Hermes::Context
 
   include Hermes::Assertions
   include Hermes::Actions
-  include Hermes::Scopes
   include Hermes::Builders
 
   teardown { Capybara.reset_sessions! }

data/lib/hermes/perf/scrub.rb

@@ -1,14 +1,14 @@
 # Scrub instance variables as in
 # http://37signals.com/svn/posts/2742-the-road-to-faster-tests
 
-ActiveSupport::TestCase.class_eval do
+class ActiveSupport::TestCase
   teardown :scrub_instance_variables
 
   @@reserved_ivars = %w(@loaded_fixtures @test_passed @fixture_cache @method_name @_assertion_wrapped @_result)
 
   def scrub_instance_variables
-    (instance_variables - @@reserved_ivars).each do |ivar|
+    (instance_variable_names - @@reserved_ivars).each do |ivar|
       instance_variable_set(ivar, nil)
     end
   end
-end
+end

data/lib/hermes/version.rb

@@ -1,3 +1,3 @@
 module Hermes
-  VERSION = "0.5.1".freeze
-end
+  VERSION = "0.6.0".freeze
+end

data/test/hermes/actions_test.rb

@@ -95,7 +95,7 @@ class ActionsTest < Hermes::IntegrationCase
   end
 
   test "select date and time didn't find the label" do
-    msg = "cannot select option, select with label 'Unexistant' not found"
+    msg = %Q(Unable to find xpath "//label[contains(normalize-space(string(.)), 'Unexistant')]")
     visit '/users/new'
     assert_raise_with_message Capybara::ElementNotFound, msg do
       select_datetime(Time.current, :from => 'Unexistant')
@@ -103,7 +103,7 @@ class ActionsTest < Hermes::IntegrationCase
   end
 
   test "select date and time didn't find the id prefix" do
-    msg = "cannot select option, no select box with id 'unexistant_4i' found"
+    msg = 'Unable to find css "#unexistant_4i"'
     visit '/users/new'
     assert_raise_with_message Capybara::ElementNotFound, msg do
       select_datetime(Time.current, :id_prefix => 'unexistant')

data/test/hermes/assertions_test.rb

@@ -13,7 +13,7 @@ class AssertionsTest < Hermes::IntegrationCase
     end
 
     test 'refuse different path' do
-      msg = %Q(<"/not_a_valid_path"> expected but was\n<"/users">.)
+      msg = %Q(Expected: "/not_a_valid_path"\n  Actual: "/users")
 
       assert_failure(msg) do
         assert_current_path '/not_a_valid_path'
@@ -27,15 +27,14 @@ class AssertionsTest < Hermes::IntegrationCase
     end
 
     test 'assert difference exists on click button' do
-      fill_in :name, :with => 'User'
+      fill_in 'Name', :with => 'User'
       assert_difference_on_click_button('Submit', 'User.count')
     end
 
     test "refuse if difference doesn't exist" do
       # There's already a user in fixtures
       msg = "\"User.count\" didn't change by 1.\n" <<
-            "<2> expected but was\n" <<
-            "<1>."
+            "Expected: 2\n  Actual: 1"
 
       assert_failure msg do
         assert_difference_on_click_button('Submit', 'User.count')
@@ -53,8 +52,7 @@ class AssertionsTest < Hermes::IntegrationCase
 
     test "refuse if difference doesn't exist" do
       msg = "\"User.blocked.count\" didn't change by 1.\n" <<
-            "<1> expected but was\n" <<
-            "<0>."
+            "Expected: 1\n  Actual: 0"
 
       create_user
       visit '/users'
@@ -380,7 +378,7 @@ class AssertionsTest < Hermes::IntegrationCase
     test 'assert_table on success' do
       visit '/users/new'
 
-      assert_table "Useless Table", :rows => table_rows
+      assert_table "Useless Table"
     end
 
     test 'refuse table that does not exist' do
@@ -407,7 +405,7 @@ class AssertionsTest < Hermes::IntegrationCase
       visit '/users/new'
 
       assert_failure(/Expected to have no table/) do
-        assert_no_table "Useless Table", :rows => table_rows
+        assert_no_table "Useless Table"
       end
     end
   end
@@ -425,7 +423,7 @@ class AssertionsTest < Hermes::IntegrationCase
 
     test 'refuse verification with different deliveries' do
       msg = %Q("ActionMailer::Base.deliveries.size" didn't change by 1.\n) <<
-            "<1> expected but was\n<2>."
+            "Expected: 1\n  Actual: 2"
 
       assert_failure(msg) do
         assert_mail_deliveries do
@@ -442,7 +440,7 @@ class AssertionsTest < Hermes::IntegrationCase
 
     test 'refuse verification with custom size' do
       msg = %Q("ActionMailer::Base.deliveries.size" didn't change by 2.\n) <<
-            "<2> expected but was\n<3>."
+            "Expected: 2\n  Actual: 3"
 
       assert_failure(msg) do
         assert_mail_deliveries(2) do
@@ -485,11 +483,4 @@ class AssertionsTest < Hermes::IntegrationCase
   def random_string(length=20)
     Array.new(length) { rand(36).to_s(36) }.join
   end
-
-  def table_rows
-    [
-      ['Cuba Pete', 'King of the Ramba beat'],
-      ['Lou Bega', 'Mambo No. 5']
-    ]
-  end
 end

data/test/hermes/builders_test.rb

@@ -56,6 +56,10 @@ class BuildersTest < Hermes::IntegrationCase
       assert respond_to?(:create_user)
     end
 
+    test 'respond_to accepts include_private argument' do
+      assert !respond_to?(:not_existing_method, true)
+    end
+
     test 'blocks are lazily evaluated' do
       user = new_user
       assert_not_equal user.counter, new_user.counter

data/test/rails_app/app/controllers/users_controller.rb

@@ -10,7 +10,7 @@ class UsersController < ApplicationController
   end
 
   def create
-    User.create(params[:user])
+    User.create(user_params)
     redirect_to users_path
   end
 
@@ -20,4 +20,10 @@ class UsersController < ApplicationController
 
     redirect_to users_path
   end
+
+  private
+
+  def user_params
+    params.require(:user).permit([:name, :active_at])
+  end
 end

data/test/rails_app/app/models/user.rb

@@ -1,7 +1,6 @@
 class User < ActiveRecord::Base
   validates_presence_of :name
 
-  attr_protected :protected_attr
   attr_accessor :protected_attr
 
   def self.blocked

data/test/rails_app/config/environments/development.rb

@@ -1,14 +1,13 @@
 RailsApp::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
+  config.eager_load = false
+
   # In the development environment your application's code is reloaded on
   # every request.  This slows down response time but is perfect for development
   # since you don't have to restart the webserver when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_view.debug_rjs             = true

data/test/rails_app/config/environments/production.rb

@@ -1,6 +1,8 @@
 RailsApp::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
+  config.eager_load = true
+
   # The production environment is meant for finished, "live" apps.
   # Code is not reloaded between requests
   config.cache_classes = true

data/test/rails_app/config/environments/test.rb

@@ -1,15 +1,14 @@
 RailsApp::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
+  config.eager_load = false
+
   # The test environment is used exclusively to run your application's
   # test suite.  You never need to work with it otherwise.  Remember that
   # your test database is "scratch space" for the test suite and is wiped
   # and recreated between test runs.  Don't rely on the data there!
   config.cache_classes = true
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false

data/test/rails_app/config/initializers/secret_token.rb

@@ -2,6 +2,11 @@
 
 # Your secret key for verifying the integrity of signed cookies.
 # If you change this key, all old signed cookies will become invalid!
+
 # Make sure the secret is at least 30 characters and all random,
 # no regular words or you'll be exposed to dictionary attacks.
-RailsApp::Application.config.secret_token = 'ff1ab9b0047f514a5c8e569058802919d7b2f47805b52ee52d216ecb28191842ded2a4222a6b14ec4efa4ba2402987aee81ce97a55f014ccb842f4c730736beb'
+# You can use `rake secret` to generate a secure secret key.
+
+# Make sure your secret_key_base is kept private
+# if you're sharing your code publicly.
+RailsApp::Application.config.secret_key_base = '968ef21e70ebd681a0391ca5175ef3de7ee0ed8a1e25d86b7473e6191a1734edebdc93f530243b6883096d74cc8b27b225a6e720d306bf42aec8b16212743b1d'

data/test/test_helper.rb

@@ -17,6 +17,7 @@ ActiveRecord::Migrator.migrate File.expand_path("../rails_app/db/migrate/", __FI
 require "capybara/rails"
 Capybara.default_driver   = :rack_test
 Capybara.default_selector = :css
+Capybara.match            = :prefer_exact
 
 require 'rails/test_help'
 require 'active_support/test_case'
@@ -31,3 +32,5 @@ require 'support/assertions'
 require 'builders'
 
 ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures/", __FILE__)
+
+I18n.enforce_available_locales = true

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hermes
 version: !ruby/object:Gem::Version
-  version: 0.5.1
-  prerelease: 
+  version: 0.6.0
 platform: ruby
 authors:
 - José Valim
@@ -10,8 +9,50 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-27 00:00:00.000000000 Z
-dependencies: []
+date: 2014-01-31 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: actionpack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
 description: A few testing facilities built on top of Capybara and ActiveSupport::TestCase
 email:
 - developers@plataformatec.com.br
@@ -20,27 +61,26 @@ extensions: []
 extra_rdoc_files:
 - README.rdoc
 files:
+- MIT-LICENSE
+- README.rdoc
+- lib/hermes.rb
 - lib/hermes/actions.rb
 - lib/hermes/assertions.rb
 - lib/hermes/builders.rb
 - lib/hermes/context.rb
 - lib/hermes/integration_case.rb
+- lib/hermes/perf.rb
 - lib/hermes/perf/scrub.rb
 - lib/hermes/perf/shared_connection.rb
-- lib/hermes/perf.rb
 - lib/hermes/rails.rb
-- lib/hermes/scopes.rb
 - lib/hermes/version.rb
-- lib/hermes.rb
-- README.rdoc
-- MIT-LICENSE
 - test/builders.rb
 - test/fixtures/users.yml
 - test/hermes/actions_test.rb
 - test/hermes/assertions_test.rb
 - test/hermes/builders_test.rb
 - test/hermes/context_test.rb
-- test/hermes/scopes_test.rb
+- test/rails_app/Rakefile
 - test/rails_app/app/controllers/application_controller.rb
 - test/rails_app/app/controllers/users_controller.rb
 - test/rails_app/app/helpers/application_helper.rb
@@ -48,6 +88,7 @@ files:
 - test/rails_app/app/views/layouts/application.html.erb
 - test/rails_app/app/views/users/index.html.erb
 - test/rails_app/app/views/users/new.html.erb
+- test/rails_app/config.ru
 - test/rails_app/config/application.rb
 - test/rails_app/config/boot.rb
 - test/rails_app/config/database.yml
@@ -62,13 +103,11 @@ files:
 - test/rails_app/config/initializers/session_store.rb
 - test/rails_app/config/locales/en.yml
 - test/rails_app/config/routes.rb
-- test/rails_app/config.ru
 - test/rails_app/db/migrate/20110228170406_create_users.rb
 - test/rails_app/db/schema.rb
 - test/rails_app/log/development.log
 - test/rails_app/log/production.log
 - test/rails_app/log/server.log
-- test/rails_app/log/test.log
 - test/rails_app/public/404.html
 - test/rails_app/public/422.html
 - test/rails_app/public/500.html
@@ -79,36 +118,34 @@ files:
 - test/rails_app/public/javascripts/effects.js
 - test/rails_app/public/javascripts/prototype.js
 - test/rails_app/public/javascripts/rails.js
-- test/rails_app/Rakefile
 - test/rails_app/script/rails
 - test/support/assertions.rb
 - test/support/models.rb
 - test/test_helper.rb
 homepage: http://github.com/plataformatec/hermes
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options:
-- --main
+- "--main"
 - README.rdoc
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: hermes
-rubygems_version: 1.8.10
+rubygems_version: 2.2.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A few testing facilities built on top of Capybara and ActiveSupport::TestCase
 test_files:
 - test/builders.rb
@@ -117,7 +154,6 @@ test_files:
 - test/hermes/assertions_test.rb
 - test/hermes/builders_test.rb
 - test/hermes/context_test.rb
-- test/hermes/scopes_test.rb
 - test/rails_app/app/controllers/application_controller.rb
 - test/rails_app/app/controllers/users_controller.rb
 - test/rails_app/app/helpers/application_helper.rb
@@ -145,7 +181,6 @@ test_files:
 - test/rails_app/log/development.log
 - test/rails_app/log/production.log
 - test/rails_app/log/server.log
-- test/rails_app/log/test.log
 - test/rails_app/public/404.html
 - test/rails_app/public/422.html
 - test/rails_app/public/500.html