hermann 0.19.0 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
 SHA1: 
-  metadata.gz: df28bdfb07a0ed99d0bd3b2e60bf0a40a078f359
-  data.tar.gz: e5a9810c7e622be6d7aef9f131d7b436ded85771
+  metadata.gz: 27f80221a9a83df130ec4513b8ecd6e1a2fe486e
+  data.tar.gz: 8824cb1f44e17b02e36690f5d0ee20c943a79c57
 SHA512: 
-  metadata.gz: 734f5dd11fc62af1e8777a6a07bf135af0974f6aac12a493318b63dc7b8268c597b1927daf4410d305524b80f4c6a8a05bcf953529ddc59e72a5d08d9ad2d19f
-  data.tar.gz: a4d0de27069f7638c61a66eba2746e0e47a544c9428efa37b737d0471a4fd04ffc1502a325a53177027c74f341994ff821379ea4ad2d79e71814de8ff35405bd
+  metadata.gz: 88ab44fb3a43ab3bcc97e6471ddcb015a7aa828735c3157d04402ab4458053ae390de29e866a6582931c5412c3da8b7a89d96f6bf5b36fd825afd19df9923e4e
+  data.tar.gz: 1d5aa2469ee0cf66963184bc63976e5d353543a7cfae85db852007a9e77227a9e8ab8ea080ece9f59392e923ca9cff5d838191b72a70b87e5c51a0130562e8d8

data/Rakefile

@@ -11,21 +11,25 @@ Rake::ExtensionTask.new do |t|
   t.gem_spec = Gem::Specification.load('hermann.gemspec')
 end
 
-RSpec::Core::RakeTask.new(:spec) do |r|
-  options = ['--tag ~type:integration']
-
+def add_rspec_options(options)
   if RUBY_PLATFORM == 'java'
     options << '--tag ~platform:mri'
   else
     options << '--tag ~platform:java'
   end
+  return options
+end
+
+RSpec::Core::RakeTask.new(:spec) do |r|
+  options = add_rspec_options(['--tag ~type:integration'])
 
   r.rspec_opts = options.join(' ')
 end
 
 namespace :spec do
   RSpec::Core::RakeTask.new(:integration) do |r|
-    r.rspec_opts = '--tag type:integration'
+    options = add_rspec_options(['--tag type:integration'])
+    r.rspec_opts = options.join(' ')
   end
 end
 

data/lib/hermann/discovery/zookeeper.rb

@@ -24,8 +24,7 @@ module Hermann
       #    tickTime (as set in the server configuration) and a maximum
       #    of 20 times the tickTime2 times the tick time set on server"
       #
-      # @return [String] comma separated list of brokers
-      #
+      # @return [Array] List of brokers from ZK
       # @raises [NoBrokersError] if could not discover brokers thru zookeeper
       def get_brokers(timeout=0)
         brokers = []
@@ -35,7 +34,7 @@ module Hermann
         if brokers.empty?
           raise Hermann::Errors::NoBrokersError
         end
-        brokers.join(',')
+        return brokers
       end
 
       private
@@ -82,4 +81,4 @@ module Hermann
         end
     end
   end
-end
+end

data/lib/hermann/errors.rb

@@ -1,8 +1,7 @@
 
 module Hermann
   module Errors
-    # Error for connectivity problems with the Kafka brokers
-    class ConnectivityError < StandardError
+    class GeneralError < StandardError
       attr_reader :java_exception
 
       # Initialize a connectivity error
@@ -11,17 +10,20 @@ module Hermann
       # @param [Hash[ options
       # @option options [Java::Lang::RuntimeException] :java_exception An
       #   underlying Java exception
-      def initialize(message, options={})
+      def initialize(message='', options={})
         super(message)
         @java_exception = options[:java_exception]
       end
     end
 
+    # Error for connectivity problems with the Kafka brokers
+    class ConnectivityError < GeneralError; end
+
     # For passing incorrect config and options to kafka
-    class ConfigurationError < StandardError; end
+    class ConfigurationError < GeneralError; end
 
     # cannot discover brokers from zookeeper
-    class NoBrokersError < StandardError; end
+    class NoBrokersError < GeneralError; end
   end
 end
 

data/lib/hermann/producer.rb

@@ -21,7 +21,7 @@ module Hermann
       @topic = topic
       @brokers = ThreadSafe::Array.new(brokers)
       if Hermann.jruby?
-        @internal = Hermann::Provider::JavaProducer.new(brokers, opts)
+        @internal = Hermann::Provider::JavaProducer.new(brokers.join(','), opts)
       else
         @internal = Hermann::Lib::Producer.new(brokers.join(','))
       end

data/lib/hermann/provider/java_producer.rb

@@ -13,7 +13,6 @@ module Hermann
 
       #default kafka Producer options
       DEFAULTS = {
-                    'serializer.class'      => 'kafka.serializer.StringEncoder',
                     'partitioner.class'     => 'kafka.producer.DefaultPartitioner',
                     'request.required.acks' => '1',
                     'message.send.max.retries' => '0'
@@ -46,12 +45,15 @@ module Hermann
       #   will be set
       def push_single(msg, topic, unused)
         Concurrent::Promise.execute {
-          data = ProducerUtil::KeyedMessage.new(topic, msg)
+          data = ProducerUtil::KeyedMessage.new(topic, msg.to_java_bytes)
           begin
             @producer.send(data)
           rescue Java::KafkaCommon::FailedToSendMessageException => jexc
             raise Hermann::Errors::ConnectivityError.new(jexc.message,
                                                          :java_exception => jexc)
+          rescue => e
+            raise Hermann::Errors::GeneralError.new(e.message,
+                                                         :java_exception => e)
           end
         }
       end

data/lib/hermann/provider/java_simple_consumer.rb

@@ -60,7 +60,8 @@ module Hermann
           stream = get_stream(topic)
           it = stream.iterator
           while it.hasNext do
-            yield it.next.message.to_s
+            message = it.next.message
+            yield String.from_java_bytes(message)
           end
         rescue Exception => e
           puts "#{self.class.name}#consume exception: #{e.class.name}"

data/lib/hermann/version.rb

@@ -1,3 +1,3 @@
 module Hermann
-  VERSION = '0.19.0'
+  VERSION = '0.20.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: hermann
 version: !ruby/object:Gem::Version 
-  version: 0.19.0
+  version: 0.20.0
 platform: ruby
 authors: 
 - R. Tyler Croy
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2014-10-29 00:00:00 Z
+date: 2014-10-31 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: concurrent-ruby