here_places 0.0.2 → 0.1.0

data/spec/fixtures/vcr_cassettes/suggest-bad.yml

@@ -0,0 +1,51 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://places.nlp.nokia.com/places/v1/suggest?app_code=<APP_CODE>&app_id=<APP_ID>&q=berl
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 400
+      message: Bad Request
+    headers:
+      Cache-Control:
+      - no-store, must-revalidate
+      Content-Language:
+      - en
+      Content-Type:
+      - application/json; charset=UTF-8
+      Date:
+      - Sat, 25 Apr 2015 13:25:39 GMT
+      Expires:
+      - Thu, 01 Jan 1970 00:00:00 GMT
+      - Thu, 26 Apr 1970 20:00:00 GMT
+      Pragma:
+      - no-cache
+      Set-Cookie:
+      - NLP.PP=dad5f0b4-00e3-472e-95f0-b400e3272e27;Path=/;Domain=.nlp.nokia.com;Expires=Thu,
+        22-Oct-2015 13:25:39 GMT
+      - NLP.PS=a4e236ba-bed6-41dc-a236-babed6e1dcad;Path=/;Domain=.nlp.nokia.com
+      Vary:
+      - Accept, Accept-Encoding, Accept-Language, X-Map-Viewport, Geolocation, X-Mobility-Mode
+      X-Nlp-Tid:
+      - faa8d50f-5ff1-43cc-a8d5-0f5ff183cc68
+      Content-Length:
+      - '83'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"status":400,"message":"No position or bounding box information."}'
+    http_version: 
+  recorded_at: Sat, 25 Apr 2015 13:25:39 GMT
+recorded_with: VCR 2.9.3

data/spec/fixtures/vcr_cassettes/suggest.yml

@@ -0,0 +1,67 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://places.nlp.nokia.com/places/v1/suggest?app_code=<APP_CODE>&app_id=<APP_ID>&at=52.5159,13.3777&q=berl
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - no-store, must-revalidate
+      Content-Language:
+      - en
+      Content-Type:
+      - application/json; charset=UTF-8
+      Date:
+      - Sat, 25 Apr 2015 13:07:38 GMT
+      Expires:
+      - Thu, 01 Jan 1970 00:00:00 GMT
+      - Thu, 26 Apr 1970 20:00:00 GMT
+      Pragma:
+      - no-cache
+      Set-Cookie:
+      - NLP.PP=4ed71ec3-ba9e-4f3b-971e-c3ba9e5f3bd4;Path=/;Domain=.nlp.nokia.com;Expires=Thu,
+        22-Oct-2015 13:07:38 GMT
+      - NLP.PS=bea27caf-a77b-43c7-a27c-afa77bb3c785;Path=/;Domain=.nlp.nokia.com
+      Vary:
+      - Accept, Accept-Encoding, Accept-Language, X-Map-Viewport, Geolocation, X-Mobility-Mode
+      X-Nlp-Tid:
+      - 1206ebbb-56ed-476f-86eb-bb56ed976f26
+      Content-Length:
+      - '328'
+      Connection:
+      - keep-alive
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        eyJzdWdnZXN0aW9ucyI6WyJCZXJsaW4sIEdlcm1hbnkiLCJDb3JhLUJlcmxp
+        bmVyLVN0cmHDn2UsIDEwMTE3IEJlcmxpbiwgR2VybWFueSIsIkJlcmxpbiBU
+        b3VyaXNtdXMgTWFya2V0aW5nIiwiQmVybGluZXIgU3Bhcmthc3NlIiwiQmVy
+        bGluZXIgRnJlaWhlaXQsIDEwNzg1IEJlcmxpbiwgR2VybWFueSIsIkVtYmFz
+        c3kgb2YgdGhlIFVuaXRlZCBTdGF0ZXMgQmVybGluIiwiTmV1ZW5oYWdlbiBi
+        ZWkgQmVybGluLCBHZXJtYW55IiwiQmVybGluZXIgVm9sa3NiYW5rIiwiQmVy
+        bGluZXIgTWF1ZXJ3ZWcsIDEwMTE3IEJlcmxpbiwgR2VybWFueSIsIkJlcmxp
+        biBUb3VyaXN0IEluZm8iLCJTY2jDtm5laWNoZSBiZWkgQmVybGluLCBHZXJt
+        YW55IiwiQW0gQmVybGluLU11c2V1bSwgMTA5NjkgQmVybGluLCBHZXJtYW55
+        IiwiRsO2cmRlcmtyZWlzIFJhdW0gZGVyIFN0aWxsZSBpbiBCZXJsaW4gZS5W
+        LiIsIkJlcm5hdSBiZWkgQmVybGluLCBHZXJtYW55IiwiQmVybGluIGluZm9z
+        dG9yZSIsIkJlcmxpbmVyIFZvcnN0YWR0LCBQb3RzZGFtLCBHZXJtYW55Iiwi
+        QmVybGljaGluZ2Vuc3RyYcOfZSwgMTA1NTMgQmVybGluLCBHZXJtYW55Iiwi
+        RXZlcnl0aGluZyBBYm91dCBCZXJsaW4iLCJSw7xkZXJzZG9yZiBiZWkgQmVy
+        bGluLCBHZXJtYW55IiwiQmVybGluZXIgU3RyYcOfZSwgMTA3MTUgQmVybGlu
+        LCBHZXJtYW55Il19
+    http_version: 
+  recorded_at: Sat, 25 Apr 2015 13:06:09 GMT
+recorded_with: VCR 2.9.3

data/spec/spec_helper.rb

@@ -1,8 +1,21 @@
 require 'rubygems'
 require 'bundler'
 require 'rspec'
-require 'fakeweb'
 require 'here_places'
+require 'vcr'
+require 'faraday'
+require 'webmock'
 
-BASE_URL = 'http://places.nlp.nokia.com/'
-API_PREFIX = 'places/v1'
+RSpec.configure do |config|
+
+  VCR.configure do |c|
+    c.cassette_library_dir = 'spec/fixtures/vcr_cassettes'
+    c.hook_into :webmock
+    c.filter_sensitive_data('<APP_ID>') { 'APP_ID' }
+    c.filter_sensitive_data('<APP_CODE>') { 'APP_CODE' }
+  end
+
+  config.before(:all) do
+    HerePlaces.set_keys('APP_ID', 'APP_CODE')
+  end
+end

data/spec/suggest_spec.rb

@@ -1,18 +1,13 @@
 require 'spec_helper'
 
 describe HerePlaces::Suggest do
-  before(:each) do
-    app_id = 'APP_ID'
-    app_code = 'APP_CODE'
-    @data = {test: 'stuff'}
-    @h = HerePlaces::Suggest.new(app_id, app_code)
-    @h.stub!(:api)
-  end
+  let(:api) { described_class.new }
+  let(:payload) { { at: '52.5159,13.3777', q: 'berl' } }
 
-  it 'responds correctly to suggest method and delegates to the api call' do
-    resource_url = "#{API_PREFIX}/suggest"
-    @h.should respond_to(:suggest)
-    @h.should_receive(:api).with(resource_url, @data)
-    @h.suggest(@data)
+  it "calls the api and returns results correctly" do
+    VCR.use_cassette("suggest", record: :once) do
+      results = api.suggest(payload)
+      expect(results["suggestions"][0]).to eq "Berlin, Germany"
+    end
   end
-end
+end

data/wercker.yml

@@ -0,0 +1,27 @@
+box: wercker/rvm
+# Build definition
+build:
+    # The steps that will be executed on build
+    # See the Ruby section on the wercker devcenter:
+    # http://devcenter.wercker.com/articles/languages/ruby.html
+    steps:
+        # Uncomment this to force RVM to use a specific Ruby version
+        # - rvm-use:
+        #       version: 2.2.2
+
+        # A step that executes `bundle install` command
+        - bundle-install
+
+        # A custom script step, name value is used in the UI
+        # and the code value contains the command that get executed
+        - script:
+            name: echo ruby information
+            code: |
+                echo "ruby version $(ruby --version) running"
+                echo "from location $(which ruby)"
+                echo -p "gem list: $(gem list)"
+
+        # Add more steps here:
+        - script:
+           name: rspec
+           code: bundle exec rspec

metadata

@@ -1,64 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: here_places
 version: !ruby/object:Gem::Version
-  version: 0.0.2
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Prem Pillai
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-25 00:00:00.000000000 Z
+date: 2015-04-25 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
-  name: fakeweb
+  name: vcr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.9'
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.4
-  type: :runtime
+        version: '1.21'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: '1.21'
 description: A wafer-thin Ruby Wrapper for Nokia's Here Places API
 email:
 - prem.pillai@gmail.com
@@ -66,7 +73,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -77,45 +84,55 @@ files:
 - lib/here_places/category.rb
 - lib/here_places/discover.rb
 - lib/here_places/error.rb
-- lib/here_places/place.rb
 - lib/here_places/suggest.rb
 - lib/here_places/version.rb
-- spec/base_spec.rb
 - spec/category_spec.rb
 - spec/discover_spec.rb
-- spec/place_spec.rb
+- spec/error_spec.rb
+- spec/fixtures/vcr_cassettes/categories.yml
+- spec/fixtures/vcr_cassettes/explore.yml
+- spec/fixtures/vcr_cassettes/here.yml
+- spec/fixtures/vcr_cassettes/places.yml
+- spec/fixtures/vcr_cassettes/search.yml
+- spec/fixtures/vcr_cassettes/suggest-bad.yml
+- spec/fixtures/vcr_cassettes/suggest.yml
 - spec/spec_helper.rb
 - spec/suggest_spec.rb
+- wercker.yml
 homepage: https://github.com/premjg/here_places
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A wafer-thin Ruby Wrapper for Nokia's Here Places API
 test_files:
-- spec/base_spec.rb
 - spec/category_spec.rb
 - spec/discover_spec.rb
-- spec/place_spec.rb
+- spec/error_spec.rb
+- spec/fixtures/vcr_cassettes/categories.yml
+- spec/fixtures/vcr_cassettes/explore.yml
+- spec/fixtures/vcr_cassettes/here.yml
+- spec/fixtures/vcr_cassettes/places.yml
+- spec/fixtures/vcr_cassettes/search.yml
+- spec/fixtures/vcr_cassettes/suggest-bad.yml
+- spec/fixtures/vcr_cassettes/suggest.yml
 - spec/spec_helper.rb
 - spec/suggest_spec.rb
-has_rdoc: 

data/lib/here_places/place.rb

@@ -1,10 +0,0 @@
-module HerePlaces
-  class Place < HerePlaces::Base
-    @@resource = 'places'
-
-    def places(id)
-      url = @@api_prefix + '/' + @@resource + '/' + id.to_s
-      api(url)
-    end
-  end
-end

data/spec/base_spec.rb

@@ -1,49 +0,0 @@
-require 'spec_helper'
-
-describe HerePlaces::Base do
-  before(:each) do
-    @app_id = 'APP_ID'
-    @app_code = 'APP_CODE'
-  end
-
-  context "after initialize" do
-    it 'calls the setup method' do
-      HerePlaces::Base.any_instance.stub(:setup)
-      HerePlaces::Base.any_instance.should_receive(:setup)
-      @h = HerePlaces::Base.new(@app_id, @app_code)
-    end
-  end
-
-  context "the setup method" do
-    it "correctly sets up the Faraday connection object" do
-      @h = HerePlaces::Base.new(@app_id, @app_code)
-      @h.conn.should be_an_instance_of(Faraday::Connection)
-    end
-  end
-
-  context "api method" do
-    before(:each) do
-      @url_fragment = 'some/url/fragment'
-      @data = {test: 'stuff'}
-    end
-
-    after(:each) do
-      FakeWeb.clean_registry
-    end
-
-    it "correctly constructs the API URL and makes calls" do
-      @h = HerePlaces::Base.new(@app_id, @app_code)
-      FakeWeb.register_uri(:get, %r|^http:\/\/places\.nlp\.nokia\.com\/.*|, :body => {stuff: 'test'}.to_json)
-      @h.api(@url_fragment, @data)
-      @parametrized_data = URI.encode_www_form(@data)
-      FakeWeb.last_request.path.should eq("/#{@url_fragment}?app_id=#{@app_id}&app_code=#{@app_code}&#{@parametrized_data}")
-    end
-
-    it "flips out and raises error when it receives an API error" do
-      @h = HerePlaces::Base.new(@app_id, @app_code)
-      FakeWeb.register_uri(:get, %r|^http:\/\/places\.nlp\.nokia\.com\/.*|, :body => {status: 400, stuff: 'test'}.to_json)
-      expect {@h.api(@url_fragment, @data)}.to raise_error(HerePlaces::APIError)
-    end
-  end
-
-end

data/spec/place_spec.rb

@@ -1,18 +0,0 @@
-require 'spec_helper'
-
-describe HerePlaces::Place do
-  before(:each) do
-    app_id = 'APP_ID'
-    app_code = 'APP_CODE'
-    @id = '123asdfa'
-    @h = HerePlaces::Place.new(app_id, app_code)
-    @h.stub!(:api)
-  end
-
-  it 'responds correctly to places method and delegates to the api call' do
-    resource_url = "#{API_PREFIX}/places/#{@id}"
-    @h.should respond_to(:places)
-    @h.should_receive(:api).with(resource_url)
-    @h.places(@id)
-  end
-end