here_or_there 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2296126f2ba3b8020b04bcff88b7b4021101094f
-  data.tar.gz: 486e562e10fab76431d1775169292d5f5d435657
+  metadata.gz: 8a0a6ac5b03e5723003f89c3eafd08a4b29394e8
+  data.tar.gz: 0bfa81657dc8be9b51feab81de3e76263bd05f17
 SHA512:
-  metadata.gz: 4dc59a3f9ca4d2bb794a8d3cb7c0c70b3e012db5f9a9a089ffd1d8050e6e93e187816c10d7ff13fd69bb029b96abafe94414034a405553b39f30564e482ab429
-  data.tar.gz: a789966d16ea7857d23b9d159318b348105e4ea0ccea73632594bf0a677159a6ce694f38d6d0ce5207c3c3955bf939f9f60275c2ce5e2cabd6ed133085486f15
+  metadata.gz: 1c8c951034124752cffc44e5116f9c0415582a45bfdea49ee06293ea221e797ffb8106982dbbb6916d8e6d237d65447c913cba258f7c4b2cc3210a468eee60cd
+  data.tar.gz: 22482b2222600db561e51fa6a5b2061670eb0d51440d33e01f1ac235548c5f7b8d57efe7a57bfba7b95e9a7e2ecd61325616462e97f27ff3cc7c9bd8a3bd8f40

data/lib/here_or_there/remote.rb

@@ -36,10 +36,9 @@ module HereOrThere
         session.exec! command do |channel, response_type, response_data|
 
           if response_type == :stdout
-            stdout = response_data
-            status = true
+            stdout << response_data
           else
-            stderr = response_data
+            stderr << response_data
             status = false
           end
 

data/lib/here_or_there/version.rb

@@ -1,3 +1,3 @@
 module HereOrThere
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/spec/here_or_there/local_spec.rb

@@ -5,7 +5,7 @@ describe HereOrThere::Local do
 
     it "returns a Response instance" do
       ret = HereOrThere::Local.new.run( 'spec/fixtures/hello_stdout')
-      expect( ret.is_a? HereOrThere::Response ).to be_true
+      expect( ret.is_a? HereOrThere::Response ).to be_truthy
     end
     it "returns stdout as return.stdout" do
       ret = HereOrThere::Local.new.run( 'spec/fixtures/hello_stdout' )
@@ -19,12 +19,12 @@ describe HereOrThere::Local do
 
     it "returns a successful status for a successful command" do
       ret_succ = HereOrThere::Local.new.run( 'spec/fixtures/hello_stdout' )
-      expect( ret_succ.success? ).to be_true
+      expect( ret_succ.success? ).to be_truthy
     end
 
     it "returns an unsuccessful status for an unsuccessful command" do
       ret_err  = HereOrThere::Local.new.run( 'spec/fixtures/hello_stderr' )
-      expect( ret_err.success? ).to be_false
+      expect( ret_err.success? ).to be_falsy
     end
   end
 

data/spec/here_or_there/remote_spec.rb

@@ -3,7 +3,8 @@ require 'spec_helper'
 describe HereOrThere::Remote do
 
   before :each do
-    Net::SSH.stub( start: StubbedSession.new )
+    allow( Net::SSH ).to receive(:start)
+                     .and_return( StubbedSession.new )
   end
 
   describe "::session" do
@@ -17,7 +18,7 @@ describe HereOrThere::Remote do
     it "creates an SSH object" do
       expect(
         HereOrThere::Remote.session( hostname: 'foo', user: 'bar' ).is_a?(HereOrThere::Remote::SSH)
-      ).to be_true
+      ).to be_truthy
     end
 
     it "doesn't recreate an instance" do
@@ -40,13 +41,14 @@ describe HereOrThere::Remote do
 
     describe "#run" do
       it "returns a response object" do
-        expect( @ssh.run("foo").is_a? HereOrThere::Response ).to be_true
+        expect( @ssh.run("foo").is_a? HereOrThere::Response ).to be_truthy
       end
 
       context "when response is stdout" do
 
         before :each do
-          StubbedSession.any_instance.stub(:exec!).and_yield("foo", :stdout, "hello stdout")
+          allow_any_instance_of( StubbedSession ).to receive(:exec!)
+                                                 .and_yield("foo", :stdout, "hello stdout")
         end
 
         it "assigns response_data to Response.stdout" do
@@ -62,7 +64,8 @@ describe HereOrThere::Remote do
       context "when response is stderr" do
 
         before :each do
-          StubbedSession.any_instance.stub(:exec!).and_yield("foo", :stderr, "hello stderr")
+          allow_any_instance_of( StubbedSession ).to receive(:exec!)
+                                                 .and_yield("foo", :stderr, "hello stderr")
         end
 
         it "assigns response_data to Response.stderr" do
@@ -75,12 +78,57 @@ describe HereOrThere::Remote do
 
       end
 
+      context "when response gets chunked" do
+        let(:session_double) { instance_double("Net::SSH::Connection::Session", closed?: false) }
+        before :each do
+          allow( Net::SSH ).to receive(:start)
+                           .and_return( session_double )
+         end
+
+        it "returns the full stdout if it gets chunked" do
+          allow( session_double ).to receive(:exec!)
+                                 .and_yield("foo", :stdout, "hello stdout")
+                                 .and_yield("foo", :stdout, "hello stdout")
+
+          expect( @ssh.run("foo").stdout ).to eq "hello stdouthello stdout"
+        end
+
+        it "returns the full stderr if it gets chunked" do
+          allow( session_double ).to receive(:exec!)
+                                 .and_yield("foo", :stderr, "hello stderr")
+                                 .and_yield("foo", :stderr, "hello stderr")
+
+          expect( @ssh.run("foo").stderr ).to eq "hello stderrhello stderr"
+        end
+
+        it "returns false with stdout & stderr if an error is given" do
+          allow( session_double ).to receive(:exec!)
+                                 .and_yield("foo", :stdout, "hello stdout")
+                                 .and_yield("foo", :stderr, "hello stderr")
+
+          resp = @ssh.run("foo")
+          expect( resp.stderr ).to eq "hello stderr"
+          expect( resp.stdout ).to eq "hello stdout"
+          expect( resp ).not_to be_success
+
+          allow( session_double ).to receive(:exec!)
+                                 .and_yield("foo", :stderr, "hello stderr")
+                                 .and_yield("foo", :stdout, "hello stdout")
+
+          resp = @ssh.run("foo")
+          expect( resp.stderr ).to eq "hello stderr"
+          expect( resp.stdout ).to eq "hello stdout"
+          expect( resp ).not_to be_success
+        end
+      end
+
       context "when the block isn't called" do
         # this happens when there is an empty response
         # and no error from the remote
 
         before :each do
-          StubbedSession.any_instance.stub(:exec!).and_return(nil)
+          allow_any_instance_of( StubbedSession ).to receive(:exec!)
+                                                 .and_return(nil)
         end
 
         it "returns an empty successful response" do
@@ -95,7 +143,8 @@ describe HereOrThere::Remote do
       context "when raises Net::SSH::AuthenticationFailed" do
 
         before :each do
-          StubbedSession.any_instance.stub(:exec!).and_raise(Net::SSH::AuthenticationFailed)
+          allow_any_instance_of( StubbedSession ).to receive(:exec!)
+                                                 .and_raise(Net::SSH::AuthenticationFailed)
         end
 
         it "returns an unsucessful response with err as stderr" do

data/spec/here_or_there_spec.rb

@@ -5,24 +5,26 @@ describe HereOrThere do
 
   describe "#run_local" do
     it "passes the command to a Local instance" do
-      HereOrThere::Local.any_instance.should_receive(:run).with("foo")
+      expect_any_instance_of( HereOrThere::Local ).to receive(:run).with("foo")
 
       run_local('foo')
     end
     it "returns a response object" do
-      expect( run_local('spec/fixtures/hello_stdout').is_a? HereOrThere::Response ).to be_true
+      expect( run_local('spec/fixtures/hello_stdout').is_a? HereOrThere::Response ).to be_truthy
     end
   end
 
   describe "#run_remote" do
     it "passes the command to a SSH instance" do
-      HereOrThere::Remote::SSH.any_instance.should_receive(:run).with('ls')
+      expect_any_instance_of( HereOrThere::Remote::SSH ).to receive(:run).with('ls')
 
       run_remote( 'ls', hostname: 'foo', user: 'bar' )
     end
     it "returns a response object" do
-      HereOrThere::Remote::SSH.any_instance.stub( session: StubbedSession.new )
-      expect( run_remote( 'ls', hostname: 'foo', user: 'bar').is_a? HereOrThere::Response ).to be_true
+      allow_any_instance_of( HereOrThere::Remote::SSH ).to receive(:session)
+                                                       .and_return(StubbedSession.new)
+
+      expect( run_remote( 'ls', hostname: 'foo', user: 'bar').is_a? HereOrThere::Response ).to be_truthy
     end
   end
 

data/spec/spec_helper.rb

@@ -41,7 +41,7 @@ describe "fixtures" do
 
     it "returns success code" do
       stdout, stderr, status = Open3.capture3('spec/fixtures/hello_stdout')
-      expect( status.success? ).to be_true
+      expect( status.success? ).to be_truthy
     end
   end
 
@@ -53,7 +53,7 @@ describe "fixtures" do
 
     it "returns error code" do
       stdout, stderr, status = Open3.capture3('spec/fixtures/hello_stderr')
-      expect( status.success? ).to be_false
+      expect( status.success? ).to be_falsy
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: here_or_there
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Steven Sloan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-26 00:00:00.000000000 Z
+date: 2015-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-ssh
@@ -64,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Unified interface for running local and remote commands