herb 0.9.2 → 0.9.4

data/src/analyze/action_view/tag_helpers.c

@@ -3,13 +3,17 @@
 #include "../../include/analyze/action_view/tag_helper_handler.h"
 #include "../../include/analyze/action_view/tag_helper_node_builders.h"
 #include "../../include/analyze/analyze.h"
-#include "../../include/ast_nodes.h"
-#include "../../include/html_util.h"
-#include "../../include/parser_helpers.h"
-#include "../../include/position.h"
-#include "../../include/util/hb_allocator.h"
-#include "../../include/util/hb_array.h"
-#include "../../include/util/hb_string.h"
+#include "../../include/ast/ast_nodes.h"
+#include "../../include/herb.h"
+#include "../../include/lib/hb_allocator.h"
+#include "../../include/lib/hb_array.h"
+#include "../../include/lib/hb_buffer.h"
+#include "../../include/lib/hb_string.h"
+#include "../../include/lib/string.h"
+#include "../../include/location/position.h"
+#include "../../include/parser/parser_helpers.h"
+#include "../../include/util/html_util.h"
+#include "../../include/util/util.h"
 #include "../../include/visitor.h"
 
 #include <prism.h>
@@ -25,8 +29,12 @@ extern bool detect_turbo_frame_tag(pm_call_node_t*, pm_parser_t*);
 extern char* extract_turbo_frame_tag_id(pm_call_node_t*, pm_parser_t*, hb_allocator_T*);
 extern bool detect_javascript_include_tag(pm_call_node_t*, pm_parser_t*);
 extern char* extract_javascript_include_tag_src(pm_call_node_t*, pm_parser_t*, hb_allocator_T*);
-extern char* wrap_in_javascript_path(const char*, size_t, hb_allocator_T*);
+extern char* wrap_in_javascript_path(const char*, size_t, const char*, hb_allocator_T*);
 extern bool javascript_include_tag_source_is_url(const char*, size_t);
+extern bool detect_image_tag(pm_call_node_t*, pm_parser_t*);
+extern char* extract_image_tag_src(pm_call_node_t*, pm_parser_t*, hb_allocator_T*);
+extern char* wrap_in_image_path(const char*, size_t, const char*, hb_allocator_T*);
+extern bool image_tag_source_is_url(const char*, size_t);
 
 typedef struct {
   pm_parser_t parser;
@@ -37,6 +45,8 @@ typedef struct {
   const tag_helper_handler_T* matched_handler;
   const char* original_source;
   size_t erb_content_offset;
+  char* condition_source;
+  char* condition_type;
 } tag_helper_parse_context_T;
 
 static tag_helper_parse_context_T* parse_tag_helper_content(
@@ -66,11 +76,15 @@ static tag_helper_parse_context_T* parse_tag_helper_content(
   }
 
   parse_context->info = tag_helper_info_init(allocator);
+  parse_context->condition_source = NULL;
+  parse_context->condition_type = NULL;
+
   tag_helper_search_data_T search = { .tag_helper_node = NULL,
                                       .source = parse_context->prism_source,
                                       .parser = &parse_context->parser,
                                       .info = parse_context->info,
-                                      .found = false };
+                                      .found = false,
+                                      .postfix_conditional_node = NULL };
   pm_visit_node(parse_context->root, search_tag_helper_node, &search);
 
   if (!search.found) {
@@ -82,6 +96,22 @@ static tag_helper_parse_context_T* parse_tag_helper_content(
     return NULL;
   }
 
+  if (search.postfix_conditional_node) {
+    if (search.postfix_conditional_node->type == PM_IF_NODE) {
+      pm_if_node_t* if_node = (pm_if_node_t*) search.postfix_conditional_node;
+      size_t predicate_length = if_node->predicate->location.end - if_node->predicate->location.start;
+      parse_context->condition_source =
+        hb_allocator_strndup(allocator, (const char*) if_node->predicate->location.start, predicate_length);
+      parse_context->condition_type = hb_allocator_strdup(allocator, "if");
+    } else if (search.postfix_conditional_node->type == PM_UNLESS_NODE) {
+      pm_unless_node_t* unless_node = (pm_unless_node_t*) search.postfix_conditional_node;
+      size_t predicate_length = unless_node->predicate->location.end - unless_node->predicate->location.start;
+      parse_context->condition_source =
+        hb_allocator_strndup(allocator, (const char*) unless_node->predicate->location.start, predicate_length);
+      parse_context->condition_type = hb_allocator_strdup(allocator, "unless");
+    }
+  }
+
   parse_context->matched_handler = search.matched_handler;
   return parse_context;
 }
@@ -101,6 +131,92 @@ static void free_tag_helper_parse_context(tag_helper_parse_context_T* parse_cont
   }
 }
 
+static AST_NODE_T* wrap_in_conditional_if_needed(
+  AST_NODE_T* element,
+  tag_helper_parse_context_T* parse_context,
+  hb_allocator_T* allocator
+) {
+  if (!element || !parse_context || !parse_context->condition_source || !parse_context->condition_type) {
+    return element;
+  }
+
+  position_T start = element->location.start;
+  position_T end = element->location.end;
+
+  hb_buffer_T content_buffer;
+  hb_buffer_init(&content_buffer, 64, allocator);
+  hb_buffer_append(&content_buffer, " ");
+  hb_buffer_append(&content_buffer, parse_context->condition_type);
+  hb_buffer_append(&content_buffer, " ");
+  hb_buffer_append(&content_buffer, parse_context->condition_source);
+  hb_buffer_append(&content_buffer, " ");
+  const char* content_string = hb_buffer_value(&content_buffer);
+
+  token_T* tag_opening = create_synthetic_token(allocator, "<%", TOKEN_ERB_START, start, start);
+  token_T* content_token = create_synthetic_token(allocator, content_string, TOKEN_ERB_CONTENT, start, end);
+  token_T* tag_closing = create_synthetic_token(allocator, "%>", TOKEN_ERB_END, end, end);
+
+  hb_array_T* statements = hb_array_init(1, allocator);
+  hb_array_append(statements, element);
+
+  token_T* end_opening = create_synthetic_token(allocator, "<%", TOKEN_ERB_START, end, end);
+  token_T* end_content = create_synthetic_token(allocator, " end ", TOKEN_ERB_CONTENT, end, end);
+  token_T* end_closing = create_synthetic_token(allocator, "%>", TOKEN_ERB_END, end, end);
+
+  AST_ERB_END_NODE_T* end_node =
+    ast_erb_end_node_init(end_opening, end_content, end_closing, end, end, hb_array_init(0, allocator), allocator);
+
+  herb_prism_node_T empty_prism_node = HERB_PRISM_NODE_EMPTY;
+
+  if (strcmp(parse_context->condition_type, "if") == 0) {
+    AST_ERB_IF_NODE_T* if_node = ast_erb_if_node_init(
+      tag_opening,
+      content_token,
+      tag_closing,
+      NULL,
+      empty_prism_node,
+      statements,
+      NULL,
+      end_node,
+      start,
+      end,
+      hb_array_init(0, allocator),
+      allocator
+    );
+
+    return (AST_NODE_T*) if_node;
+  } else {
+    AST_ERB_UNLESS_NODE_T* unless_node = ast_erb_unless_node_init(
+      tag_opening,
+      content_token,
+      tag_closing,
+      NULL,
+      empty_prism_node,
+      statements,
+      NULL,
+      end_node,
+      start,
+      end,
+      hb_array_init(0, allocator),
+      allocator
+    );
+
+    return (AST_NODE_T*) unless_node;
+  }
+}
+
+static bool is_postfix_if_node(const pm_node_t* node) {
+  if (node->type != PM_IF_NODE) { return false; }
+  pm_if_node_t* if_node = (pm_if_node_t*) node;
+  return if_node->if_keyword_loc.start != NULL && if_node->end_keyword_loc.start == NULL;
+}
+
+static bool is_postfix_unless_node(const pm_node_t* node) {
+  if (node->type != PM_UNLESS_NODE) { return false; }
+  pm_unless_node_t* unless_node = (pm_unless_node_t*) node;
+  return unless_node->keyword_loc.start != NULL && unless_node->end_keyword_loc.start == NULL;
+}
+
 bool search_tag_helper_node(const pm_node_t* node, void* data) {
   tag_helper_search_data_T* search_data = (tag_helper_search_data_T*) data;
 
@@ -124,9 +240,21 @@ bool search_tag_helper_node(const pm_node_t* node, void* data) {
           search_data->info->has_block = handlers[i].supports_block();
         }
 
-        return true;
+        return false;
       }
     }
+
+    return false;
+  }
+
+  if (is_postfix_if_node(node) || is_postfix_unless_node(node)) {
+    const pm_node_t* saved = search_data->postfix_conditional_node;
+    search_data->postfix_conditional_node = node;
+    pm_visit_child_nodes(node, search_tag_helper_node, search_data);
+
+    if (!search_data->found) { search_data->postfix_conditional_node = saved; }
+
+    return search_data->found;
   }
 
   pm_visit_child_nodes(node, search_tag_helper_node, search_data);
@@ -230,6 +358,98 @@ static void calculate_tag_name_positions(
   }
 }
 
+static const char* JAVASCRIPT_INCLUDE_TAG_PATH_OPTIONS[] = { "protocol", "extname", "host", "skip_pipeline", NULL };
+static const char* IMAGE_TAG_PATH_OPTIONS[] = { "skip_pipeline", NULL };
+
+static char* extract_path_options_from_keyword_hash(
+  pm_call_node_t* call_node,
+  const char** option_names,
+  hb_allocator_T* allocator
+) {
+  if (!call_node || !call_node->arguments) { return NULL; }
+
+  pm_arguments_node_t* arguments = call_node->arguments;
+  if (arguments->arguments.size == 0) { return NULL; }
+
+  pm_node_t* last_argument = arguments->arguments.nodes[arguments->arguments.size - 1];
+
+  if (last_argument->type != PM_KEYWORD_HASH_NODE) { return NULL; }
+
+  pm_keyword_hash_node_t* hash = (pm_keyword_hash_node_t*) last_argument;
+  hb_buffer_T buffer;
+  hb_buffer_init(&buffer, 64, allocator);
+  bool first = true;
+
+  for (size_t i = 0; i < hash->elements.size; i++) {
+    pm_node_t* element = hash->elements.nodes[i];
+
+    if (element->type != PM_ASSOC_NODE) { continue; }
+
+    pm_assoc_node_t* assoc = (pm_assoc_node_t*) element;
+
+    if (assoc->key->type != PM_SYMBOL_NODE) { continue; }
+
+    pm_symbol_node_t* key_node = (pm_symbol_node_t*) assoc->key;
+    size_t key_length = pm_string_length(&key_node->unescaped);
+    const char* key_source = (const char*) pm_string_source(&key_node->unescaped);
+
+    bool is_path_option = false;
+
+    for (const char** option = option_names; *option != NULL; option++) {
+      if (key_length == strlen(*option) && strncmp(key_source, *option, key_length) == 0) {
+        is_path_option = true;
+        break;
+      }
+    }
+
+    if (!is_path_option) { continue; }
+
+    if (!first) { hb_buffer_append(&buffer, ", "); }
+    first = false;
+
+    size_t key_source_length = assoc->key->location.end - assoc->key->location.start;
+    hb_buffer_append_with_length(&buffer, (const char*) assoc->key->location.start, key_source_length);
+    hb_buffer_append(&buffer, " ");
+
+    size_t value_source_length = assoc->value->location.end - assoc->value->location.start;
+    hb_buffer_append_with_length(&buffer, (const char*) assoc->value->location.start, value_source_length);
+  }
+
+  if (first) {
+    hb_buffer_free(&buffer);
+    return NULL;
+  }
+
+  char* result = hb_allocator_strdup(allocator, hb_buffer_value(&buffer));
+  hb_buffer_free(&buffer);
+
+  return result;
+}
+
+static AST_NODE_T* remove_attribute_by_name(hb_array_T* attributes, const char* name) {
+  if (!attributes) { return NULL; }
+
+  for (size_t index = 0; index < hb_array_size(attributes); index++) {
+    AST_NODE_T* attribute = hb_array_get(attributes, index);
+
+    if (attribute->type != AST_HTML_ATTRIBUTE_NODE) { continue; }
+
+    AST_HTML_ATTRIBUTE_NODE_T* html_attribute = (AST_HTML_ATTRIBUTE_NODE_T*) attribute;
+
+    if (!html_attribute->name || !html_attribute->name->children || !hb_array_size(html_attribute->name->children)) {
+      continue;
+    }
+
+    AST_LITERAL_NODE_T* literal = (AST_LITERAL_NODE_T*) hb_array_get(html_attribute->name->children, 0);
+
+    if (hb_string_equals(literal->content, hb_string((char*) name))) {
+      hb_array_remove(attributes, index);
+      return attribute;
+    }
+  }
+
+  return NULL;
+}
 static AST_NODE_T* transform_tag_helper_with_attributes(
   AST_ERB_CONTENT_NODE_T* erb_node,
   analyze_ruby_context_T* context,
@@ -261,6 +481,116 @@ static AST_NODE_T* transform_tag_helper_with_attributes(
     );
   }
 
+  if (attributes && handler->name
+      && (strcmp(handler->name, "javascript_include_tag") == 0 || strcmp(handler->name, "javascript_tag") == 0)) {
+    resolve_nonce_attribute(attributes, allocator);
+  }
+
+  char* path_options = NULL;
+
+  if (attributes && handler->name && strcmp(handler->name, "javascript_include_tag") == 0) {
+    path_options = extract_path_options_from_keyword_hash(
+      parse_context->info->call_node,
+      JAVASCRIPT_INCLUDE_TAG_PATH_OPTIONS,
+      allocator
+    );
+
+    remove_attribute_by_name(attributes, "extname");
+    remove_attribute_by_name(attributes, "host");
+    remove_attribute_by_name(attributes, "protocol");
+    remove_attribute_by_name(attributes, "skip-pipeline");
+  }
+
+  if (attributes && handler->name && strcmp(handler->name, "image_tag") == 0) {
+    path_options =
+      extract_path_options_from_keyword_hash(parse_context->info->call_node, IMAGE_TAG_PATH_OPTIONS, allocator);
+    remove_attribute_by_name(attributes, "skip-pipeline");
+
+    AST_NODE_T* size_node = remove_attribute_by_name(attributes, "size");
+
+    if (size_node && size_node->type == AST_HTML_ATTRIBUTE_NODE) {
+      AST_HTML_ATTRIBUTE_NODE_T* size_attribute_node = (AST_HTML_ATTRIBUTE_NODE_T*) size_node;
+
+      if (size_attribute_node->value && size_attribute_node->value->children
+          && hb_array_size(size_attribute_node->value->children) > 0) {
+        AST_NODE_T* value_node = (AST_NODE_T*) hb_array_get(size_attribute_node->value->children, 0);
+        position_T position = size_attribute_node->base.location.start;
+
+        if (value_node->type == AST_LITERAL_NODE) {
+          AST_LITERAL_NODE_T* literal = (AST_LITERAL_NODE_T*) value_node;
+          char* size_string = hb_allocator_strndup(allocator, literal->content.data, literal->content.length);
+
+          if (size_string) {
+            const char* x_position = strchr(size_string, 'x');
+            char width_string[32];
+            char height_string[32];
+
+            if (x_position) {
+              size_t width_length = (size_t) (x_position - size_string);
+              strncpy(width_string, size_string, width_length);
+              width_string[width_length] = '\0';
+              strncpy(height_string, x_position + 1, sizeof(height_string) - 1);
+              height_string[sizeof(height_string) - 1] = '\0';
+            } else {
+              strncpy(width_string, size_string, sizeof(width_string) - 1);
+              width_string[sizeof(width_string) - 1] = '\0';
+              strncpy(height_string, size_string, sizeof(height_string) - 1);
+              height_string[sizeof(height_string) - 1] = '\0';
+            }
+
+            AST_HTML_ATTRIBUTE_NODE_T* width_attribute =
+              create_html_attribute_node("width", width_string, position, position, allocator);
+            AST_HTML_ATTRIBUTE_NODE_T* height_attribute =
+              create_html_attribute_node("height", height_string, position, position, allocator);
+
+            if (width_attribute) { hb_array_append(attributes, (AST_NODE_T*) width_attribute); }
+            if (height_attribute) { hb_array_append(attributes, (AST_NODE_T*) height_attribute); }
+
+            hb_allocator_dealloc(allocator, size_string);
+          }
+        } else if (value_node->type == AST_RUBY_LITERAL_NODE) {
+          AST_RUBY_LITERAL_NODE_T* ruby_literal = (AST_RUBY_LITERAL_NODE_T*) value_node;
+          char* size_expression =
+            hb_allocator_strndup(allocator, ruby_literal->content.data, ruby_literal->content.length);
+
+          if (size_expression) {
+            hb_buffer_T width_buffer;
+            hb_buffer_init(&width_buffer, ruby_literal->content.length + 32, allocator);
+            hb_buffer_append(&width_buffer, size_expression);
+            hb_buffer_append(&width_buffer, ".to_s.split(\"x\", 2)[0]");
+
+            hb_buffer_T height_buffer;
+            hb_buffer_init(&height_buffer, ruby_literal->content.length + 32, allocator);
+            hb_buffer_append(&height_buffer, size_expression);
+            hb_buffer_append(&height_buffer, ".to_s.split(\"x\", 2)[-1]");
+
+            AST_HTML_ATTRIBUTE_NODE_T* width_attribute = create_html_attribute_with_ruby_literal(
+              "width",
+              hb_buffer_value(&width_buffer),
+              position,
+              position,
+              allocator
+            );
+            AST_HTML_ATTRIBUTE_NODE_T* height_attribute = create_html_attribute_with_ruby_literal(
+              "height",
+              hb_buffer_value(&height_buffer),
+              position,
+              position,
+              allocator
+            );
+
+            if (width_attribute) { hb_array_append(attributes, (AST_NODE_T*) width_attribute); }
+            if (height_attribute) { hb_array_append(attributes, (AST_NODE_T*) height_attribute); }
+
+            hb_buffer_free(&width_buffer);
+            hb_buffer_free(&height_buffer);
+            hb_allocator_dealloc(allocator, size_expression);
+          }
+        }
+      }
+    }
+  }
+
   char* helper_content = NULL;
   bool content_is_ruby_expression = false;
 
@@ -340,7 +670,7 @@ static AST_NODE_T* transform_tag_helper_with_attributes(
         quoted_source[quoted_length - 1] = '"';
         quoted_source[quoted_length] = '\0';
 
-        source_attribute_value = wrap_in_javascript_path(quoted_source, quoted_length, allocator);
+        source_attribute_value = wrap_in_javascript_path(quoted_source, quoted_length, path_options, allocator);
         hb_allocator_dealloc(allocator, quoted_source);
       }
 
@@ -356,6 +686,50 @@ static AST_NODE_T* transform_tag_helper_with_attributes(
     }
   }
 
+  if (detect_image_tag(parse_context->info->call_node, &parse_context->parser)
+      && parse_context->info->call_node->arguments && parse_context->info->call_node->arguments->arguments.size >= 1) {
+    char* source_value = extract_image_tag_src(parse_context->info->call_node, &parse_context->parser, allocator);
+
+    if (source_value) {
+      if (!attributes) { attributes = hb_array_init(4, allocator); }
+
+      pm_node_t* first_argument = parse_context->info->call_node->arguments->arguments.nodes[0];
+      position_T source_start, source_end;
+      prism_node_location_to_positions(&first_argument->location, parse_context, &source_start, &source_end);
+      bool source_is_string = (first_argument->type == PM_STRING_NODE);
+      bool source_is_path_helper = is_route_helper_node(first_argument, &parse_context->parser);
+
+      size_t source_length = strlen(source_value);
+      bool is_url = image_tag_source_is_url(source_value, source_length);
+
+      char* source_attribute_value = source_value;
+
+      if (source_is_string && !is_url) {
+        size_t quoted_length = source_length + 2;
+        char* quoted_source = hb_allocator_alloc(allocator, quoted_length + 1);
+        quoted_source[0] = '"';
+        memcpy(quoted_source + 1, source_value, source_length);
+        quoted_source[quoted_length - 1] = '"';
+        quoted_source[quoted_length] = '\0';
+
+        source_attribute_value = wrap_in_image_path(quoted_source, quoted_length, path_options, allocator);
+        hb_allocator_dealloc(allocator, quoted_source);
+      } else if (!source_is_string && !is_url && !source_is_path_helper) {
+        source_attribute_value = wrap_in_image_path(source_value, source_length, path_options, allocator);
+      }
+
+      AST_HTML_ATTRIBUTE_NODE_T* source_attribute =
+        is_url
+          ? create_html_attribute_node("src", source_attribute_value, source_start, source_end, allocator)
+          : create_html_attribute_with_ruby_literal("src", source_attribute_value, source_start, source_end, allocator);
+
+      if (source_attribute) { attributes = prepend_attribute(attributes, (AST_NODE_T*) source_attribute, allocator); }
+      if (source_attribute_value != source_value) { hb_allocator_dealloc(allocator, source_attribute_value); }
+
+      hb_allocator_dealloc(allocator, source_value);
+    }
+  }
+
   token_T* tag_name_token =
     tag_name ? create_synthetic_token(allocator, tag_name, TOKEN_IDENTIFIER, tag_name_start, tag_name_end) : NULL;
 
@@ -374,9 +748,56 @@ static AST_NODE_T* transform_tag_helper_with_attributes(
   );
 
   hb_array_T* body = hb_array_init(1, allocator);
-  bool is_void = tag_name && (strcmp(handler->name, "tag") == 0) && is_void_element(hb_string_from_c_string(tag_name));
+  hb_array_T* element_errors = hb_array_init(0, allocator);
+  bool is_void = tag_name && is_void_element(hb_string_from_c_string(tag_name))
+              && (string_equals(handler->name, "tag") || string_equals(handler->name, "content_tag")
+                  || string_equals(handler->name, "image_tag"));
 
   if (helper_content) {
+    if (is_void && tag_name) {
+      hb_buffer_T helper_name_buffer;
+      hb_buffer_init(&helper_name_buffer, 64, allocator);
+
+      if (string_equals(handler->name, "tag")) {
+        hb_buffer_append(&helper_name_buffer, "tag.");
+        hb_buffer_append(&helper_name_buffer, tag_name);
+      } else {
+        hb_buffer_append(&helper_name_buffer, handler->name);
+        hb_buffer_append(&helper_name_buffer, " :");
+        hb_buffer_append(&helper_name_buffer, tag_name);
+      }
+
+      hb_string_T helper_name = hb_string_from_c_string(hb_buffer_value(&helper_name_buffer));
+
+      position_T content_start = erb_node->base.location.start;
+      position_T content_end = erb_node->base.location.end;
+
+      pm_call_node_t* call = parse_context->info->call_node;
+
+      if (call && call->arguments) {
+        size_t content_arg_index = string_equals(handler->name, "content_tag") ? 1 : 0;
+
+        if (call->arguments->arguments.size > content_arg_index) {
+          pm_node_t* content_node = call->arguments->arguments.nodes[content_arg_index];
+          prism_node_location_to_positions(&content_node->location, parse_context, &content_start, &content_end);
+        }
+      }
+
+      pm_call_node_t* void_call = parse_context->info->call_node;
+      bool content_from_block = void_call && void_call->block && void_call->block->type == PM_BLOCK_NODE;
+      hb_string_T content_type = content_from_block ? hb_string("a block") : hb_string("a positional argument");
+
+      append_void_element_content_error(
+        tag_name_token,
+        helper_name,
+        content_type,
+        content_start,
+        content_end,
+        allocator,
+        element_errors
+      );
+    }
+
     append_body_content_node(
       body,
       helper_content,
@@ -410,7 +831,7 @@ static AST_NODE_T* transform_tag_helper_with_attributes(
     handler->source,
     erb_node->base.location.start,
     erb_node->base.location.end,
-    hb_array_init(0, allocator),
+    element_errors,
     allocator
   );
 
@@ -438,6 +859,7 @@ static AST_NODE_T* create_javascript_include_tag_element(
   tag_helper_parse_context_T* parse_context,
   pm_node_t* source_argument,
   hb_array_T* shared_attributes,
+  const char* path_options,
   hb_allocator_T* allocator
 ) {
   position_T tag_name_start, tag_name_end;
@@ -478,7 +900,7 @@ static AST_NODE_T* create_javascript_include_tag_element(
     quoted_source[quoted_length - 1] = '"';
     quoted_source[quoted_length] = '\0';
 
-    source_attribute_value = wrap_in_javascript_path(quoted_source, quoted_length, allocator);
+    source_attribute_value = wrap_in_javascript_path(quoted_source, quoted_length, path_options, allocator);
     hb_allocator_dealloc(allocator, quoted_source);
   }
 
@@ -551,12 +973,27 @@ static hb_array_T* transform_javascript_include_tag_multi_source(
   );
   if (!shared_attributes) { shared_attributes = hb_array_init(0, allocator); }
 
+  resolve_nonce_attribute(shared_attributes, allocator);
+
+  char* path_options =
+    extract_path_options_from_keyword_hash(call_node, JAVASCRIPT_INCLUDE_TAG_PATH_OPTIONS, allocator);
+  remove_attribute_by_name(shared_attributes, "extname");
+  remove_attribute_by_name(shared_attributes, "host");
+  remove_attribute_by_name(shared_attributes, "protocol");
+  remove_attribute_by_name(shared_attributes, "skip-pipeline");
+
   hb_array_T* elements = hb_array_init(source_count * 2, allocator);
 
   for (size_t i = 0; i < source_count; i++) {
     pm_node_t* source_arg = call_node->arguments->arguments.nodes[i];
-    AST_NODE_T* element =
-      create_javascript_include_tag_element(erb_node, parse_context, source_arg, shared_attributes, allocator);
+    AST_NODE_T* element = create_javascript_include_tag_element(
+      erb_node,
+      parse_context,
+      source_arg,
+      shared_attributes,
+      path_options,
+      allocator
+    );
 
     if (element) {
       if (hb_array_size(elements) > 0) {
@@ -578,6 +1015,42 @@ static hb_array_T* transform_javascript_include_tag_multi_source(
   return elements;
 }
 
+static bool erb_content_is_end_keyword(hb_string_T content) {
+  const char* start = content.data;
+  const char* end = content.data + content.length;
+
+  while (start < end && is_whitespace(*start)) {
+    start++;
+  }
+
+  while (end > start && is_whitespace(*(end - 1))) {
+    end--;
+  }
+
+  return (size_t) (end - start) == 3 && start[0] == 'e' && start[1] == 'n' && start[2] == 'd';
+}
+
+static AST_ERB_CONTENT_NODE_T* find_swallowed_erb_end_node(hb_array_T* nodes) {
+  if (!nodes) { return NULL; }
+
+  for (size_t i = 0; i < hb_array_size(nodes); i++) {
+    AST_NODE_T* node = (AST_NODE_T*) hb_array_get(nodes, i);
+    if (!node) { continue; }
+
+    if (node->type == AST_ERB_CONTENT_NODE) {
+      AST_ERB_CONTENT_NODE_T* erb = (AST_ERB_CONTENT_NODE_T*) node;
+      if (erb->content && erb_content_is_end_keyword(erb->content->value)) { return erb; }
+    }
+
+    if (node->type == AST_HTML_OPEN_TAG_NODE) {
+      AST_ERB_CONTENT_NODE_T* found = find_swallowed_erb_end_node(((AST_HTML_OPEN_TAG_NODE_T*) node)->children);
+      if (found) { return found; }
+    }
+  }
+
+  return NULL;
+}
+
 static AST_NODE_T* transform_erb_block_to_tag_helper(
   AST_ERB_BLOCK_NODE_T* block_node,
   analyze_ruby_context_T* context,
@@ -598,6 +1071,7 @@ static AST_NODE_T* transform_erb_block_to_tag_helper(
   );
 
   hb_array_T* attributes = NULL;
+
   if (parse_context->info->call_node) {
     attributes = extract_html_attributes_from_call_node(
       parse_context->info->call_node,
@@ -608,6 +1082,12 @@ static AST_NODE_T* transform_erb_block_to_tag_helper(
     );
   }
 
+  if (attributes && parse_context->matched_handler && parse_context->matched_handler->name
+      && (strcmp(parse_context->matched_handler->name, "javascript_include_tag") == 0
+          || strcmp(parse_context->matched_handler->name, "javascript_tag") == 0)) {
+    resolve_nonce_attribute(attributes, allocator);
+  }
+
   if (detect_link_to(parse_context->info->call_node, &parse_context->parser)
       && parse_context->info->call_node->arguments && parse_context->info->call_node->arguments->arguments.size >= 1) {
     pm_node_t* first_argument = parse_context->info->call_node->arguments->arguments.nodes[0];
@@ -682,26 +1162,85 @@ static AST_NODE_T* transform_erb_block_to_tag_helper(
   );
 
   hb_array_T* body = block_node->body ? block_node->body : hb_array_init(0, allocator);
+  hb_array_T* element_errors = hb_array_init(0, allocator);
   AST_NODE_T* close_tag = (AST_NODE_T*) block_node->end_node;
+  position_T element_end = block_node->base.location.end;
+
+  bool is_void = tag_name && is_void_element(hb_string_from_c_string(tag_name)) && parse_context->matched_handler
+              && parse_context->matched_handler->name
+              && (string_equals(parse_context->matched_handler->name, "tag")
+                  || string_equals(parse_context->matched_handler->name, "content_tag")
+                  || string_equals(parse_context->matched_handler->name, "image_tag"));
+
+  if (is_void) {
+    hb_buffer_T helper_name_buffer;
+    hb_buffer_init(&helper_name_buffer, 64, allocator);
+
+    if (string_equals(parse_context->matched_handler->name, "tag")) {
+      hb_buffer_append(&helper_name_buffer, "tag.");
+      hb_buffer_append(&helper_name_buffer, tag_name);
+    } else {
+      hb_buffer_append(&helper_name_buffer, parse_context->matched_handler->name);
+      hb_buffer_append(&helper_name_buffer, " :");
+      hb_buffer_append(&helper_name_buffer, tag_name);
+    }
+
+    hb_string_T helper_name = hb_string_from_c_string(hb_buffer_value(&helper_name_buffer));
+
+    append_void_element_content_error(
+      tag_name_token,
+      helper_name,
+      hb_string("a block"),
+      block_node->base.location.start,
+      block_node->base.location.end,
+      allocator,
+      element_errors
+    );
+  }
 
   if (tag_name && parser_is_foreign_content_tag(hb_string_from_c_string(tag_name)) && context->source
       && block_node->body && hb_array_size(block_node->body) > 0) {
     size_t start_offset = block_node->tag_closing->range.to;
-    size_t end_offset = block_node->end_node->tag_opening->range.from;
+    size_t end_offset = 0;
+
+    if (block_node->end_node && block_node->end_node->tag_opening) {
+      end_offset = block_node->end_node->tag_opening->range.from;
+    } else {
+      AST_ERB_CONTENT_NODE_T* swallowed_end = find_swallowed_erb_end_node(block_node->body);
+
+      if (swallowed_end && swallowed_end->tag_opening) {
+        end_offset = swallowed_end->tag_opening->range.from;
+
+        AST_ERB_END_NODE_T* end_node = ast_erb_end_node_init(
+          swallowed_end->tag_opening,
+          swallowed_end->content,
+          swallowed_end->tag_closing,
+          swallowed_end->base.location.start,
+          swallowed_end->base.location.end,
+          hb_array_init(0, allocator),
+          allocator
+        );
+
+        close_tag = (AST_NODE_T*) end_node;
+        element_end = close_tag->location.end;
+      }
+    }
 
     if (end_offset > start_offset) {
       position_T body_start = block_node->tag_closing->location.end;
-      position_T body_end = block_node->end_node->tag_opening->location.start;
 
       size_t content_length = end_offset - start_offset;
       char* raw_copy = hb_allocator_strndup(allocator, context->source + start_offset, content_length);
-      hb_string_T raw_content = { .data = raw_copy, .length = content_length };
 
-      AST_LITERAL_NODE_T* literal_node =
-        ast_literal_node_init(raw_content, body_start, body_end, hb_array_init(0, allocator), allocator);
+      parser_options_T body_options = HERB_DEFAULT_PARSER_OPTIONS;
+      body_options.html = false;
+      body_options.analyze = false;
+      body_options.strict = false;
+      body_options.start_line = body_start.line;
+      body_options.start_column = body_start.column;
 
-      body = hb_array_init(1, allocator);
-      hb_array_append(body, literal_node);
+      AST_DOCUMENT_NODE_T* body_document = herb_parse(raw_copy, &body_options, allocator);
+      body = body_document->children;
     }
   }
 
@@ -709,12 +1248,12 @@ static AST_NODE_T* transform_erb_block_to_tag_helper(
     (AST_NODE_T*) open_tag_node,
     tag_name_token,
     body,
-    close_tag,
-    false,
+    is_void ? NULL : close_tag,
+    is_void,
     parse_context->matched_handler->source,
     block_node->base.location.start,
-    block_node->base.location.end,
-    hb_array_init(0, allocator),
+    element_end,
+    element_errors,
     allocator
   );
 
@@ -763,6 +1302,12 @@ static AST_NODE_T* transform_link_to_helper(
       char* content = hb_allocator_strndup(allocator, (const char*) second_arg->location.start, source_length);
 
       if (content) {
+        hb_buffer_T wrapped;
+        hb_buffer_init(&wrapped, source_length + 32, allocator);
+        hb_buffer_append(&wrapped, "tag.attributes(**");
+        hb_buffer_append(&wrapped, content);
+        hb_buffer_append(&wrapped, ")");
+
         position_T position = prism_location_to_position_with_offset(
           &second_arg->location,
           parse_context->original_source,
@@ -771,7 +1316,7 @@ static AST_NODE_T* transform_link_to_helper(
         );
 
         AST_RUBY_HTML_ATTRIBUTES_SPLAT_NODE_T* splat_node = ast_ruby_html_attributes_splat_node_init(
-          hb_string_from_c_string(content),
+          hb_string_from_c_string(hb_buffer_value(&wrapped)),
           HB_STRING_EMPTY,
           position,
           position,
@@ -781,6 +1326,7 @@ static AST_NODE_T* transform_link_to_helper(
 
         if (splat_node) { hb_array_append(attributes, (AST_NODE_T*) splat_node); }
 
+        hb_buffer_free(&wrapped);
         hb_allocator_dealloc(allocator, content);
       }
     }
@@ -946,21 +1492,8 @@ static AST_NODE_T* transform_link_to_helper(
   return (AST_NODE_T*) element;
 }
 
-void transform_tag_helper_blocks(const AST_NODE_T* node, analyze_ruby_context_T* context) {
-  if (!node || !context) { return; }
-
-  hb_array_T* array = NULL;
-
-  switch (node->type) {
-    case AST_DOCUMENT_NODE: array = ((AST_DOCUMENT_NODE_T*) node)->children; break;
-    case AST_HTML_ELEMENT_NODE: array = ((AST_HTML_ELEMENT_NODE_T*) node)->body; break;
-    case AST_HTML_OPEN_TAG_NODE: array = ((AST_HTML_OPEN_TAG_NODE_T*) node)->children; break;
-    case AST_HTML_ATTRIBUTE_VALUE_NODE: array = ((AST_HTML_ATTRIBUTE_VALUE_NODE_T*) node)->children; break;
-    case AST_ERB_BLOCK_NODE: array = ((AST_ERB_BLOCK_NODE_T*) node)->body; break;
-    default: return;
-  }
-
-  if (!array) { return; }
+void transform_tag_helper_array(hb_array_T* array, analyze_ruby_context_T* context) {
+  if (!array || !context) { return; }
 
   for (size_t i = 0; i < hb_array_size(array); i++) {
     AST_NODE_T* child = hb_array_get(array, i);
@@ -985,6 +1518,7 @@ void transform_tag_helper_blocks(const AST_NODE_T* node, analyze_ruby_context_T*
 
         if (parse_context) {
           replacement = transform_erb_block_to_tag_helper(block_node, context, parse_context);
+          replacement = wrap_in_conditional_if_needed(replacement, parse_context, context->allocator);
           free_tag_helper_parse_context(parse_context);
         }
 
@@ -1042,18 +1576,232 @@ void transform_tag_helper_blocks(const AST_NODE_T* node, analyze_ruby_context_T*
             }
           } else if (strcmp(parse_context->matched_handler->name, "link_to") == 0) {
             replacement = transform_link_to_helper(erb_node, context, parse_context);
+          } else if (string_equals(parse_context->matched_handler->name, "tag") && parse_context->info->tag_name
+                     && string_equals(parse_context->info->tag_name, "attributes")) {
+            hb_array_T* attributes = NULL;
+
+            if (parse_context->info->call_node) {
+              attributes = extract_html_attributes_from_call_node(
+                parse_context->info->call_node,
+                parse_context->prism_source,
+                parse_context->original_source,
+                parse_context->erb_content_offset,
+                context->allocator
+              );
+            }
+
+            if (attributes && hb_array_size(attributes) > 0) {
+              size_t old_size = hb_array_size(array);
+              size_t attributes_size = hb_array_size(attributes);
+              hb_array_T* new_array = hb_array_init(old_size - 1 + attributes_size, context->allocator);
+
+              for (size_t j = 0; j < old_size; j++) {
+                if (j == i) {
+                  for (size_t k = 0; k < attributes_size; k++) {
+                    hb_array_append(new_array, hb_array_get(attributes, k));
+                  }
+                } else {
+                  hb_array_append(new_array, hb_array_get(array, j));
+                }
+              }
+
+              array->items = new_array->items;
+              array->size = new_array->size;
+              array->capacity = new_array->capacity;
+
+              i += attributes_size - 1;
+            }
           } else {
             replacement = transform_tag_helper_with_attributes(erb_node, context, parse_context);
           }
 
+          replacement = wrap_in_conditional_if_needed(replacement, parse_context, context->allocator);
           free_tag_helper_parse_context(parse_context);
         }
 
         free(erb_string);
       }
+    } else if (child->type == AST_HTML_ATTRIBUTE_NODE) {
+      AST_HTML_ATTRIBUTE_NODE_T* attribute_node = (AST_HTML_ATTRIBUTE_NODE_T*) child;
+
+      if (attribute_node->name && !attribute_node->equals && !attribute_node->value && attribute_node->name->children
+          && hb_array_size(attribute_node->name->children) == 1) {
+        AST_NODE_T* name_child = hb_array_get(attribute_node->name->children, 0);
+
+        if (name_child && name_child->type == AST_ERB_CONTENT_NODE) {
+          AST_ERB_CONTENT_NODE_T* erb_node = (AST_ERB_CONTENT_NODE_T*) name_child;
+          token_T* erb_content = erb_node->content;
+
+          if (erb_content && !hb_string_is_empty(erb_content->value)) {
+            char* erb_string = hb_string_to_c_string_using_malloc(erb_content->value);
+            size_t erb_content_offset = 0;
+
+            if (context->source) {
+              erb_content_offset = calculate_byte_offset_from_position(context->source, erb_content->location.start);
+            }
+
+            tag_helper_parse_context_T* parse_context =
+              parse_tag_helper_content(erb_string, context->source, erb_content_offset, context->allocator);
+
+            if (parse_context && string_equals(parse_context->matched_handler->name, "tag")
+                && parse_context->info->tag_name && string_equals(parse_context->info->tag_name, "attributes")) {
+              hb_array_T* attributes = NULL;
+
+              if (parse_context->info->call_node) {
+                attributes = extract_html_attributes_from_call_node(
+                  parse_context->info->call_node,
+                  parse_context->prism_source,
+                  parse_context->original_source,
+                  parse_context->erb_content_offset,
+                  context->allocator
+                );
+              }
+
+              if (attributes && hb_array_size(attributes) > 0) {
+                size_t old_size = hb_array_size(array);
+                size_t attributes_size = hb_array_size(attributes);
+                hb_array_T* new_array = hb_array_init(old_size - 1 + attributes_size, context->allocator);
+
+                for (size_t j = 0; j < old_size; j++) {
+                  if (j == i) {
+                    for (size_t k = 0; k < attributes_size; k++) {
+                      hb_array_append(new_array, hb_array_get(attributes, k));
+                    }
+                  } else {
+                    hb_array_append(new_array, hb_array_get(array, j));
+                  }
+                }
+
+                array->items = new_array->items;
+                array->size = new_array->size;
+                array->capacity = new_array->capacity;
+
+                i += attributes_size - 1;
+              }
+
+              free_tag_helper_parse_context(parse_context);
+            } else if (parse_context) {
+              free_tag_helper_parse_context(parse_context);
+            }
+
+            free(erb_string);
+          }
+        }
+      }
+    }
+
+    if (replacement) {
+      position_T replacement_end = replacement->location.end;
+      position_T original_end = child->location.end;
+      bool has_trailing = replacement_end.line != original_end.line || replacement_end.column != original_end.column;
+
+      if (has_trailing && context->source && child->type == AST_ERB_BLOCK_NODE) {
+        AST_HTML_ELEMENT_NODE_T* element = (AST_HTML_ELEMENT_NODE_T*) replacement;
+
+        if (replacement->type == AST_ERB_IF_NODE) {
+          AST_ERB_IF_NODE_T* if_node = (AST_ERB_IF_NODE_T*) replacement;
+
+          if (if_node->statements && hb_array_size(if_node->statements) > 0) {
+            element = (AST_HTML_ELEMENT_NODE_T*) hb_array_get(if_node->statements, 0);
+          }
+        } else if (replacement->type == AST_ERB_UNLESS_NODE) {
+          AST_ERB_UNLESS_NODE_T* unless_node = (AST_ERB_UNLESS_NODE_T*) replacement;
+
+          if (unless_node->statements && hb_array_size(unless_node->statements) > 0) {
+            element = (AST_HTML_ELEMENT_NODE_T*) hb_array_get(unless_node->statements, 0);
+          }
+        }
+
+        if (element->close_tag && element->close_tag->type == AST_ERB_END_NODE) {
+          AST_ERB_END_NODE_T* close_erb = (AST_ERB_END_NODE_T*) element->close_tag;
+          size_t trailing_start = close_erb->tag_closing->range.to;
+          size_t source_length = strlen(context->source);
+          size_t trailing_end = trailing_start;
+
+          while (trailing_end < source_length) {
+            position_T position = position_from_source_with_offset(context->source, trailing_end);
+
+            if (position.line > original_end.line
+                || (position.line == original_end.line && position.column >= original_end.column)) {
+              break;
+            }
+
+            trailing_end++;
+          }
+
+          if (trailing_end > trailing_start) {
+            hb_string_T trailing_content =
+              hb_string_from_data(context->source + trailing_start, trailing_end - trailing_start);
+            AST_HTML_TEXT_NODE_T* trailing_text = ast_html_text_node_init(
+              trailing_content,
+              replacement_end,
+              original_end,
+              hb_array_init(0, context->allocator),
+              context->allocator
+            );
+
+            size_t old_size = hb_array_size(array);
+            hb_array_T* new_array = hb_array_init(old_size + 1, context->allocator);
+
+            for (size_t j = 0; j < old_size; j++) {
+              if (j == i) {
+                hb_array_append(new_array, replacement);
+                hb_array_append(new_array, trailing_text);
+              } else {
+                hb_array_append(new_array, hb_array_get(array, j));
+              }
+            }
+
+            array->items = new_array->items;
+            array->size = new_array->size;
+            array->capacity = new_array->capacity;
+            i++;
+            continue;
+          }
+        }
+      }
+
+      hb_array_set(array, i, replacement);
     }
+  }
+}
+
+void transform_tag_helper_blocks(const AST_NODE_T* node, analyze_ruby_context_T* context) {
+  if (!node || !context) { return; }
 
-    if (replacement) { hb_array_set(array, i, replacement); }
+  switch (node->type) {
+    case AST_DOCUMENT_NODE: transform_tag_helper_array(((AST_DOCUMENT_NODE_T*) node)->children, context); break;
+    case AST_HTML_ELEMENT_NODE: transform_tag_helper_array(((AST_HTML_ELEMENT_NODE_T*) node)->body, context); break;
+    case AST_HTML_CONDITIONAL_ELEMENT_NODE:
+      transform_tag_helper_array(((AST_HTML_CONDITIONAL_ELEMENT_NODE_T*) node)->body, context);
+      break;
+    case AST_HTML_OPEN_TAG_NODE:
+      transform_tag_helper_array(((AST_HTML_OPEN_TAG_NODE_T*) node)->children, context);
+      break;
+    case AST_HTML_ATTRIBUTE_VALUE_NODE:
+      transform_tag_helper_array(((AST_HTML_ATTRIBUTE_VALUE_NODE_T*) node)->children, context);
+      break;
+    case AST_ERB_BLOCK_NODE: transform_tag_helper_array(((AST_ERB_BLOCK_NODE_T*) node)->body, context); break;
+    case AST_ERB_IF_NODE: transform_tag_helper_array(((AST_ERB_IF_NODE_T*) node)->statements, context); break;
+    case AST_ERB_ELSE_NODE: transform_tag_helper_array(((AST_ERB_ELSE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_UNLESS_NODE: transform_tag_helper_array(((AST_ERB_UNLESS_NODE_T*) node)->statements, context); break;
+    case AST_ERB_CASE_NODE:
+      transform_tag_helper_array(((AST_ERB_CASE_NODE_T*) node)->children, context);
+      transform_tag_helper_array(((AST_ERB_CASE_NODE_T*) node)->conditions, context);
+      break;
+    case AST_ERB_CASE_MATCH_NODE:
+      transform_tag_helper_array(((AST_ERB_CASE_MATCH_NODE_T*) node)->children, context);
+      transform_tag_helper_array(((AST_ERB_CASE_MATCH_NODE_T*) node)->conditions, context);
+      break;
+    case AST_ERB_WHEN_NODE: transform_tag_helper_array(((AST_ERB_WHEN_NODE_T*) node)->statements, context); break;
+    case AST_ERB_WHILE_NODE: transform_tag_helper_array(((AST_ERB_WHILE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_UNTIL_NODE: transform_tag_helper_array(((AST_ERB_UNTIL_NODE_T*) node)->statements, context); break;
+    case AST_ERB_FOR_NODE: transform_tag_helper_array(((AST_ERB_FOR_NODE_T*) node)->statements, context); break;
+    case AST_ERB_BEGIN_NODE: transform_tag_helper_array(((AST_ERB_BEGIN_NODE_T*) node)->statements, context); break;
+    case AST_ERB_RESCUE_NODE: transform_tag_helper_array(((AST_ERB_RESCUE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_ENSURE_NODE: transform_tag_helper_array(((AST_ERB_ENSURE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_IN_NODE: transform_tag_helper_array(((AST_ERB_IN_NODE_T*) node)->statements, context); break;
+    default: break;
   }
 }