her 0.8.4 → 0.8.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0141afc2e4ab0c85094f560968ce2df4913e2424
-  data.tar.gz: 4bd83da38000aeda38136280b4f655ff0343854d
+  metadata.gz: deb396c535f2621118ad4127970ed969edb232c6
+  data.tar.gz: f71fbc8a42a9bdf453512adbf6740542ca7a00c8
 SHA512:
-  metadata.gz: 1ab620f82e7d16a19856b69b44435fec1feb3dac82848ac985e39a4e11a8567627983280bae0f95ca1802c9f6d51a01dff2c5d00cd81406d34c59f4e7f639669
-  data.tar.gz: 8da028cf2f7f736c0b02b78423ac7268100411e216bb05f17ee54ce2c89a58b73104e258e99e064313dce48f713bb5dcd175d33783f6fda7357d2c25a344c67d
+  metadata.gz: 1a7085472d5a1b1dbcd1981e717a02dd66fa64cad301507f384176c9c48713340c938de866c5c59bef729869d50a0c6c9ffcc8b8e6f8bab53f6f9327a1ee0a40
+  data.tar.gz: 48b8ab97ca692b35ec372834e899e8e03123cef0022d91a75ef9058ba96a59fa7321b4bf513865481a35688781151c232b8768a242932db9166d58b594cbd46c

data/README.md

@@ -173,6 +173,24 @@ end
 
 Now, each HTTP request made by Her will have the `X-API-Token` header.
 
+### Basic Http Authentication
+Her can use basic http auth by adding a line to your initializer
+
+```ruby
+# config/initializers/her.rb
+Her::API.setup url: "https://api.example.com" do |c|
+  # Request
+  c.use Faraday::Request::BasicAuthentication, 'myusername', 'mypassword'
+  c.use Faraday::Request::UrlEncoded
+  
+  # Response
+  c.use Her::Middleware::DefaultParseJSON
+
+  # Adapter
+  c.use Faraday::Adapter::NetHttp
+end
+```
+
 ### OAuth
 
 Using the `faraday_middleware` and `simple_oauth` gems, it’s fairly easy to use OAuth authentication with Her.

data/lib/her/model/orm.rb

@@ -80,7 +80,7 @@ module Her
             assign_attributes(self.class.parse(parsed_data[:data])) if parsed_data[:data].any?
             @metadata = parsed_data[:metadata]
             @response_errors = parsed_data[:errors]
-            @destroyed = true
+            @destroyed = response.success?
           end
         end
         self
@@ -163,7 +163,7 @@ module Her
             data = parse(parsed_data[:data])
             metadata = parsed_data[:metadata]
             response_errors = parsed_data[:errors]
-            new(data.merge(:_destroyed => true, :metadata => metadata, :response_errors => response_errors))
+            new(data.merge(:_destroyed => response.success?, :metadata => metadata, :response_errors => response_errors))
           end
         end
 

data/lib/her/version.rb

@@ -1,3 +1,3 @@
 module Her
-  VERSION = "0.8.4"
+  VERSION = "0.8.5"
 end

data/spec/model/orm_spec.rb

@@ -400,13 +400,14 @@ describe Her::Model::ORM do
   end
 
   context "deleting resources" do
+    let(:status) { 200 }
     before do
       Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
         builder.adapter :test do |stub|
           stub.get("/users/1") { [200, {}, { id: 1, fullname: "Tobias Fünke", active: true }.to_json] }
-          stub.delete("/users/1") { [200, {}, { id: 1, fullname: "Lindsay Fünke", active: false }.to_json] }
+          stub.delete("/users/1") { [status, {}, { id: 1, fullname: "Lindsay Fünke", active: false }.to_json] }
         end
       end
 
@@ -426,6 +427,20 @@ describe Her::Model::ORM do
       expect(@user).to be_destroyed
     end
 
+    context "with response_errors" do
+      let(:status) { 422 }
+      it "set user.destroyed to false if errors are present through the .destroy class method" do
+        @user = Foo::User.destroy_existing(1)
+        expect(@user).not_to be_destroyed
+      end
+
+      it "set user.destroyed to false if errors are present through #destroy on an existing resource" do
+        @user = Foo::User.find(1)
+        @user.destroy
+        expect(@user).not_to be_destroyed
+      end
+    end
+
     context "with params" do
       before do
         Her::API.setup url: "https://api.example.com" do |builder|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: her
 version: !ruby/object:Gem::Version
-  version: 0.8.4
+  version: 0.8.5
 platform: ruby
 authors:
 - Rémi Prévost
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-06 00:00:00.000000000 Z
+date: 2017-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake