her 0.8.2 → 0.9.0

data/spec/model/dirty_spec.rb

@@ -4,16 +4,16 @@ require File.join(File.dirname(__FILE__), "../spec_helper.rb")
 describe "Her::Model and ActiveModel::Dirty" do
   context "checking dirty attributes" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |builder|
+      Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
         builder.adapter :test do |stub|
-          stub.get("/users/1") { |env| [200, {}, { :id => 1, :fullname => "Lindsay Fünke" }.to_json] }
-          stub.get("/users/2") { |env| [200, {}, { :id => 2, :fullname => "Maeby Fünke" }.to_json] }
-          stub.get("/users/3") { |env| [200, {}, { :user_id => 3, :fullname => "Maeby Fünke" }.to_json] }
-          stub.put("/users/1") { |env| [200, {}, { :id => 1, :fullname => "Tobias Fünke" }.to_json] }
-          stub.put("/users/2") { |env| [400, {}, { :errors => ["Email cannot be blank"] }.to_json] }
-          stub.post("/users") { |env| [200, {}, { :id => 1, :fullname => "Tobias Fünke" }.to_json] }
+          stub.get("/users/1") { [200, {}, { id: 1, fullname: "Lindsay Fünke" }.to_json] }
+          stub.get("/users/2") { [200, {}, { id: 2, fullname: "Maeby Fünke" }.to_json] }
+          stub.get("/users/3") { [200, {}, { user_id: 3, fullname: "Maeby Fünke" }.to_json] }
+          stub.put("/users/1") { [200, {}, { id: 1, fullname: "Tobias Fünke" }.to_json] }
+          stub.put("/users/2") { [400, {}, { errors: ["Email cannot be blank"] }.to_json] }
+          stub.post("/users")  { [200, {}, { id: 1, fullname: "Tobias Fünke" }.to_json] }
         end
       end
 
@@ -28,36 +28,36 @@ describe "Her::Model and ActiveModel::Dirty" do
     context "for existing resource" do
       let(:user) { Foo::User.find(1) }
       it "has no changes" do
-        user.changes.should be_empty
-        user.should_not be_changed
+        expect(user.changes).to be_empty
+        expect(user).not_to be_changed
       end
       context "with successful save" do
         it "tracks dirty attributes" do
           user.fullname = "Tobias Fünke"
-          user.fullname_changed?.should be_truthy
-          user.email_changed?.should be_falsey
-          user.should be_changed
+          expect(user.fullname_changed?).to be_truthy
+          expect(user.email_changed?).to be_falsey
+          expect(user).to be_changed
           user.save
-          user.should_not be_changed
+          expect(user).not_to be_changed
         end
 
         it "tracks only changed dirty attributes" do
           user.fullname = user.fullname
-          user.fullname_changed?.should be_falsey
+          expect(user.fullname_changed?).to be_falsey
         end
 
         it "tracks previous changes" do
           user.fullname = "Tobias Fünke"
           user.save
-          user.previous_changes.should eq({"fullname"=>"Lindsay Fünke"})
+          expect(user.previous_changes).to eq("fullname" => ["Lindsay Fünke", "Tobias Fünke"])
         end
 
-        it 'tracks dirty attribute for mass assign for dynamic created attributes' do
+        it "tracks dirty attribute for mass assign for dynamic created attributes" do
           user = Dynamic::User.find(3)
-          user.assign_attributes(:fullname => 'New Fullname')
-          user.fullname_changed?.should be_truthy
-          user.should be_changed
-          user.changes.length.should eq(1)
+          user.assign_attributes(fullname: "New Fullname")
+          expect(user.fullname_changed?).to be_truthy
+          expect(user).to be_changed
+          expect(user.changes.length).to eq(1)
         end
       end
 
@@ -65,27 +65,28 @@ describe "Her::Model and ActiveModel::Dirty" do
         it "tracks dirty attributes" do
           user = Foo::User.find(2)
           user.fullname = "Tobias Fünke"
-          user.fullname_changed?.should be_truthy
-          user.email_changed?.should be_falsey
-          user.should be_changed
+          expect(user.fullname_changed?).to be_truthy
+          expect(user.email_changed?).to be_falsey
+          expect(user).to be_changed
           user.save
-          user.should be_changed
+          expect(user).to be_changed
         end
       end
     end
 
     context "for new resource" do
-      let(:user) { Foo::User.new(:fullname => "Lindsay Fünke") }
+      let(:user) { Foo::User.new(fullname: "Lindsay Fünke") }
       it "has changes" do
-        user.should be_changed
+        expect(user).to be_changed
       end
       it "tracks dirty attributes" do
         user.fullname = "Tobias Fünke"
-        user.fullname_changed?.should be_truthy
-        user.should be_changed
+        expect(user.fullname_changed?).to be_truthy
+        expect(user).to be_changed
         user.save
-        user.should_not be_changed
+        expect(user).not_to be_changed
       end
     end
   end
 end
+#

data/spec/model/http_spec.rb

@@ -3,13 +3,13 @@ require File.join(File.dirname(__FILE__), "../spec_helper.rb")
 
 describe Her::Model::HTTP do
   context "binding a model with an API" do
-    let(:api1) { Her::API.new :url => "https://api1.example.com" }
-    let(:api2) { Her::API.new :url => "https://api2.example.com" }
+    let(:api1) { Her::API.new url: "https://api1.example.com" }
+    let(:api2) { Her::API.new url: "https://api2.example.com" }
 
     before do
       spawn_model("Foo::User")
       spawn_model("Foo::Comment")
-      Her::API.setup :url => "https://api.example.com"
+      Her::API.setup url: "https://api.example.com"
     end
 
     context "when binding a model to its superclass' her_api" do
@@ -19,7 +19,7 @@ describe Her::Model::HTTP do
         Foo::Subclass = Class.new(Foo::Superclass)
       end
 
-      specify { Foo::Subclass.her_api.should == Foo::Superclass.her_api }
+      specify { expect(Foo::Subclass.her_api).to eq(Foo::Superclass.her_api) }
     end
 
     context "when changing her_api without changing the parent class' her_api" do
@@ -30,23 +30,23 @@ describe Her::Model::HTTP do
         Foo::Subclass.uses_api api2
       end
 
-      specify { Foo::Subclass.her_api.should_not == Foo::Superclass.her_api }
+      specify { expect(Foo::Subclass.her_api).not_to eq(Foo::Superclass.her_api) }
     end
   end
 
   context "making HTTP requests" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |builder|
+      Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
         builder.adapter :test do |stub|
-          stub.get("/users") { |env| [200, {}, [{ :id => 1 }].to_json] }
-          stub.get("/users/1") { |env| [200, {}, { :id => 1 }.to_json] }
+          stub.get("/users") { [200, {}, [{ id: 1 }].to_json] }
+          stub.get("/users/1") { [200, {}, { id: 1 }.to_json] }
           stub.get("/users/popular") do |env|
             if env[:params]["page"] == "2"
-              [200, {}, [{ :id => 3 }, { :id => 4 }].to_json]
+              [200, {}, [{ id: 3 }, { id: 4 }].to_json]
             else
-              [200, {}, [{ :id => 1 }, { :id => 2 }].to_json]
+              [200, {}, [{ id: 1 }, { id: 2 }].to_json]
             end
           end
         end
@@ -57,61 +57,85 @@ describe Her::Model::HTTP do
 
     describe :get do
       subject { Foo::User.get(:popular) }
-      its(:length) { should == 2 }
-      specify { subject.first.id.should == 1 }
+
+      describe "#length" do
+        subject { super().length }
+        it { is_expected.to eq(2) }
+      end
+      specify { expect(subject.first.id).to eq(1) }
     end
 
     describe :get_raw do
       context "with a block" do
         specify do
-          Foo::User.get_raw("/users") do |parsed_data, response|
-            parsed_data[:data].should == [{ :id => 1 }]
+          Foo::User.get_raw("/users") do |parsed_data, _response|
+            expect(parsed_data[:data]).to eq([{ id: 1 }])
           end
         end
       end
 
       context "with a return value" do
         subject { Foo::User.get_raw("/users") }
-        specify { subject[:parsed_data][:data].should == [{ :id => 1 }] }
+        specify { expect(subject[:parsed_data][:data]).to eq([{ id: 1 }]) }
       end
     end
 
     describe :get_collection do
       context "with a String path" do
         subject { Foo::User.get_collection("/users/popular") }
-        its(:length) { should == 2 }
-        specify { subject.first.id.should == 1 }
+
+        describe "#length" do
+          subject { super().length }
+          it { is_expected.to eq(2) }
+        end
+        specify { expect(subject.first.id).to eq(1) }
       end
 
       context "with a Symbol" do
         subject { Foo::User.get_collection(:popular) }
-        its(:length) { should == 2 }
-        specify { subject.first.id.should == 1 }
+
+        describe "#length" do
+          subject { super().length }
+          it { is_expected.to eq(2) }
+        end
+        specify { expect(subject.first.id).to eq(1) }
       end
 
       context "with extra parameters" do
-        subject { Foo::User.get_collection(:popular, :page => 2) }
-        its(:length) { should == 2 }
-        specify { subject.first.id.should == 3 }
+        subject { Foo::User.get_collection(:popular, page: 2) }
+
+        describe "#length" do
+          subject { super().length }
+          it { is_expected.to eq(2) }
+        end
+        specify { expect(subject.first.id).to eq(3) }
       end
     end
 
     describe :get_resource do
       context "with a String path" do
         subject { Foo::User.get_resource("/users/1") }
-        its(:id) { should == 1 }
+
+        describe "#id" do
+          subject { super().id }
+          it { is_expected.to eq(1) }
+        end
       end
 
       context "with a Symbol" do
         subject { Foo::User.get_resource(:"1") }
-        its(:id) { should == 1 }
+
+        describe "#id" do
+          subject { super().id }
+          it { is_expected.to eq(1) }
+        end
       end
     end
 
     describe :get_raw do
       specify do
-        Foo::User.get_raw(:popular) do |parsed_data, response|
-          parsed_data[:data].should == [{ :id => 1 }, { :id => 2 }]
+        Foo::User.get_raw(:popular) do |parsed_data, _response|
+          expect(parsed_data[:data]).to eq([{ id: 1 }, { id: 2 }])
         end
       end
     end
@@ -119,11 +143,11 @@ describe Her::Model::HTTP do
 
   context "setting custom HTTP requests" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |connection|
+      Her::API.setup url: "https://api.example.com" do |connection|
         connection.use Her::Middleware::FirstLevelParseJSON
         connection.adapter :test do |stub|
-          stub.get("/users/popular") { |env| [200, {}, [{ :id => 1 }, { :id => 2 }].to_json] }
-          stub.post("/users/from_default") { |env| [200, {}, { :id => 4 }.to_json] }
+          stub.get("/users/popular") { [200, {}, [{ id: 1 }, { id: 2 }].to_json] }
+          stub.post("/users/from_default") { [200, {}, { id: 4 }.to_json] }
         end
       end
 
@@ -135,23 +159,31 @@ describe Her::Model::HTTP do
     describe :custom_get do
       context "without cache" do
         before { Foo::User.custom_get :popular, :recent }
-        it { should respond_to(:popular) }
-        it { should respond_to(:recent) }
+        it { is_expected.to respond_to(:popular) }
+        it { is_expected.to respond_to(:recent) }
 
         context "making the HTTP request" do
           subject { Foo::User.popular }
-          its(:length) { should == 2 }
+
+          describe "#length" do
+            subject { super().length }
+            it { is_expected.to eq(2) }
+          end
         end
       end
     end
 
     describe :custom_post do
       before { Foo::User.custom_post :from_default }
-      it { should respond_to(:from_default) }
+      it { is_expected.to respond_to(:from_default) }
 
       context "making the HTTP request" do
-        subject { Foo::User.from_default(:name => "Tobias Fünke") }
-        its(:id) { should == 4 }
+        subject { Foo::User.from_default(name: "Tobias Fünke") }
+
+        describe "#id" do
+          subject { super().id }
+          it { is_expected.to eq(4) }
+        end
       end
     end
   end

data/spec/model/introspection_spec.rb

@@ -4,15 +4,15 @@ require File.join(File.dirname(__FILE__), "../spec_helper.rb")
 describe Her::Model::Introspection do
   context "introspecting a resource" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |builder|
+      Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
         builder.adapter :test do |stub|
-          stub.post("/users")     { |env| [200, {}, { :id => 1, :name => "Tobias Funke" }.to_json] }
-          stub.get("/users/1")    { |env| [200, {}, { :id => 1, :name => "Tobias Funke" }.to_json] }
-          stub.put("/users/1")    { |env| [200, {}, { :id => 1, :name => "Tobias Funke" }.to_json] }
-          stub.delete("/users/1") { |env| [200, {}, { :id => 1, :name => "Tobias Funke" }.to_json] }
-          stub.get("/projects/1/comments") { |env| [200, {}, [{ :id => 1, :body => "Hello!" }].to_json] }
+          stub.post("/users")     { [200, {}, { id: 1, name: "Tobias Funke" }.to_json] }
+          stub.get("/users/1")    { [200, {}, { id: 1, name: "Tobias Funke" }.to_json] }
+          stub.put("/users/1")    { [200, {}, { id: 1, name: "Tobias Funke" }.to_json] }
+          stub.delete("/users/1") { [200, {}, { id: 1, name: "Tobias Funke" }.to_json] }
+          stub.get("/projects/1/comments") { [200, {}, [{ id: 1, body: "Hello!" }].to_json] }
         end
       end
 
@@ -25,33 +25,37 @@ describe Her::Model::Introspection do
     describe "#inspect" do
       it "outputs resource attributes for an existing resource" do
         @user = Foo::User.find(1)
-        ["#<Foo::User(users/1) name=\"Tobias Funke\" id=1>", "#<Foo::User(users/1) id=1 name=\"Tobias Funke\">"].should include(@user.inspect)
+        expect(["#<Foo::User(users/1) name=\"Tobias Funke\" id=1>", "#<Foo::User(users/1) id=1 name=\"Tobias Funke\">"]).to include(@user.inspect)
       end
 
       it "outputs resource attributes for an not-saved-yet resource" do
-        @user = Foo::User.new(:name => "Tobias Funke")
-        @user.inspect.should == "#<Foo::User(users) name=\"Tobias Funke\">"
+        @user = Foo::User.new(name: "Tobias Funke")
+        expect(@user.inspect).to eq("#<Foo::User(users) name=\"Tobias Funke\">")
       end
 
       it "outputs resource attributes using getters" do
-        @user = Foo::User.new(:name => "Tobias Funke", :password => "Funke")
-        @user.instance_eval {def password; 'filtered'; end}
-        @user.inspect.should include("name=\"Tobias Funke\"")
-        @user.inspect.should include("password=\"filtered\"")
-        @user.inspect.should_not include("password=\"Funke\"")
+        @user = Foo::User.new(name: "Tobias Funke", password: "Funke")
+        @user.instance_eval do
+          def password
+            "filtered"
+                             end
+        end
+        expect(@user.inspect).to include("name=\"Tobias Funke\"")
+        expect(@user.inspect).to include("password=\"filtered\"")
+        expect(@user.inspect).not_to include("password=\"Funke\"")
       end
 
       it "support dash on attribute" do
         @user = Foo::User.new(:'life-span' => "3 years")
-        @user.inspect.should include("life-span=\"3 years\"")
+        expect(@user.inspect).to include("life-span=\"3 years\"")
       end
     end
 
     describe "#inspect with errors in resource path" do
       it "prints the resource path as “unknown”" do
-        @comment = Foo::Comment.where(:project_id => 1).first
-        path = '<unknown path, missing `project_id`>'
-        ["#<Foo::Comment(#{path}) body=\"Hello!\" id=1>", "#<Foo::Comment(#{path}) id=1 body=\"Hello!\">"].should include(@comment.inspect)
+        @comment = Foo::Comment.where(project_id: 1).first
+        path = "<unknown path, missing `project_id`>"
+        expect(["#<Foo::Comment(#{path}) body=\"Hello!\" id=1>", "#<Foo::Comment(#{path}) id=1 body=\"Hello!\">"]).to include(@comment.inspect)
       end
     end
   end
@@ -66,10 +70,10 @@ describe Her::Model::Introspection do
       end
 
       it "returns a sibling class, if found" do
-        Foo::User.her_nearby_class("AccessRecord").should == Foo::AccessRecord
-        AccessRecord.her_nearby_class("Log").should == Log
-        Foo::User.her_nearby_class("Log").should == Log
-        Foo::User.her_nearby_class("X").should be_nil
+        expect(Foo::User.her_nearby_class("AccessRecord")).to eq(Foo::AccessRecord)
+        expect(AccessRecord.her_nearby_class("Log")).to eq(Log)
+        expect(Foo::User.her_nearby_class("Log")).to eq(Log)
+        expect(Foo::User.her_nearby_class("X")).to be_nil
       end
     end
   end

data/spec/model/nested_attributes_spec.rb

@@ -4,40 +4,40 @@ require File.join(File.dirname(__FILE__), "../spec_helper.rb")
 describe Her::Model::NestedAttributes do
   context "with a belongs_to association" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |builder|
+      Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
       end
 
       spawn_model "Foo::User" do
-        belongs_to :company, :path => "/organizations/:id", :foreign_key => :organization_id
+        belongs_to :company, path: "/organizations/:id", foreign_key: :organization_id
         accepts_nested_attributes_for :company
       end
 
       spawn_model "Foo::Company"
 
-      @user_with_data_through_nested_attributes = Foo::User.new :name => "Test", :company_attributes => { :name => "Example Company" }
+      @user_with_data_through_nested_attributes = Foo::User.new name: "Test", company_attributes: { name: "Example Company" }
     end
 
     context "when child does not yet exist" do
       it "creates an instance of the associated class" do
-        @user_with_data_through_nested_attributes.company.should be_a(Foo::Company)
-        @user_with_data_through_nested_attributes.company.name.should == "Example Company"
+        expect(@user_with_data_through_nested_attributes.company).to be_a(Foo::Company)
+        expect(@user_with_data_through_nested_attributes.company.name).to eq("Example Company")
       end
     end
 
     context "when child does exist" do
       it "updates the attributes of the associated object" do
-        @user_with_data_through_nested_attributes.company_attributes = { :name => "Fünke's Company" }
-        @user_with_data_through_nested_attributes.company.should be_a(Foo::Company)
-        @user_with_data_through_nested_attributes.company.name.should == "Fünke's Company"
+        @user_with_data_through_nested_attributes.company_attributes = { name: "Fünke's Company" }
+        expect(@user_with_data_through_nested_attributes.company).to be_a(Foo::Company)
+        expect(@user_with_data_through_nested_attributes.company.name).to eq("Fünke's Company")
       end
     end
   end
 
   context "with a has_one association" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |builder|
+      Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
       end
@@ -49,28 +49,28 @@ describe Her::Model::NestedAttributes do
 
       spawn_model "Foo::Pet"
 
-      @user_with_data_through_nested_attributes = Foo::User.new :name => "Test", :pet_attributes => { :name => "Hasi" }
+      @user_with_data_through_nested_attributes = Foo::User.new name: "Test", pet_attributes: { name: "Hasi" }
     end
 
     context "when child does not yet exist" do
       it "creates an instance of the associated class" do
-        @user_with_data_through_nested_attributes.pet.should be_a(Foo::Pet)
-        @user_with_data_through_nested_attributes.pet.name.should == "Hasi"
+        expect(@user_with_data_through_nested_attributes.pet).to be_a(Foo::Pet)
+        expect(@user_with_data_through_nested_attributes.pet.name).to eq("Hasi")
       end
     end
 
     context "when child does exist" do
       it "updates the attributes of the associated object" do
-        @user_with_data_through_nested_attributes.pet_attributes = { :name => "Rodriguez" }
-        @user_with_data_through_nested_attributes.pet.should be_a(Foo::Pet)
-        @user_with_data_through_nested_attributes.pet.name.should == "Rodriguez"
+        @user_with_data_through_nested_attributes.pet_attributes = { name: "Rodriguez" }
+        expect(@user_with_data_through_nested_attributes.pet).to be_a(Foo::Pet)
+        expect(@user_with_data_through_nested_attributes.pet.name).to eq("Rodriguez")
       end
     end
   end
 
   context "with a has_many association" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |builder|
+      Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
       end
@@ -82,23 +82,23 @@ describe Her::Model::NestedAttributes do
 
       spawn_model "Foo::Pet"
 
-      @user_with_data_through_nested_attributes = Foo::User.new :name => "Test", :pets_attributes => [{ :name => "Hasi" }, { :name => "Rodriguez" }]
+      @user_with_data_through_nested_attributes = Foo::User.new name: "Test", pets_attributes: [{ name: "Hasi" }, { name: "Rodriguez" }]
     end
 
     context "when children do not yet exist" do
       it "creates an instance of the associated class" do
-        @user_with_data_through_nested_attributes.pets.length.should == 2
-        @user_with_data_through_nested_attributes.pets[0].should be_a(Foo::Pet)
-        @user_with_data_through_nested_attributes.pets[1].should be_a(Foo::Pet)
-        @user_with_data_through_nested_attributes.pets[0].name.should == "Hasi"
-        @user_with_data_through_nested_attributes.pets[1].name.should == "Rodriguez"
+        expect(@user_with_data_through_nested_attributes.pets.length).to eq(2)
+        expect(@user_with_data_through_nested_attributes.pets[0]).to be_a(Foo::Pet)
+        expect(@user_with_data_through_nested_attributes.pets[1]).to be_a(Foo::Pet)
+        expect(@user_with_data_through_nested_attributes.pets[0].name).to eq("Hasi")
+        expect(@user_with_data_through_nested_attributes.pets[1].name).to eq("Rodriguez")
       end
     end
   end
 
   context "with a has_many association as a Hash" do
     before do
-      Her::API.setup :url => "https://api.example.com" do |builder|
+      Her::API.setup url: "https://api.example.com" do |builder|
         builder.use Her::Middleware::FirstLevelParseJSON
         builder.use Faraday::Request::UrlEncoded
       end
@@ -110,25 +110,25 @@ describe Her::Model::NestedAttributes do
 
       spawn_model "Foo::Pet"
 
-      @user_with_data_through_nested_attributes_as_hash = Foo::User.new :name => "Test", :pets_attributes => { '0' => { :name => "Hasi" }, '1' => { :name => "Rodriguez" }}
+      @user_with_data_through_nested_attributes_as_hash = Foo::User.new name: "Test", pets_attributes: { "0" => { name: "Hasi" }, "1" => { name: "Rodriguez" } }
     end
 
     context "when children do not yet exist" do
       it "creates an instance of the associated class" do
-        @user_with_data_through_nested_attributes_as_hash.pets.length.should == 2
-        @user_with_data_through_nested_attributes_as_hash.pets[0].should be_a(Foo::Pet)
-        @user_with_data_through_nested_attributes_as_hash.pets[1].should be_a(Foo::Pet)
-        @user_with_data_through_nested_attributes_as_hash.pets[0].name.should == "Hasi"
-        @user_with_data_through_nested_attributes_as_hash.pets[1].name.should == "Rodriguez"
+        expect(@user_with_data_through_nested_attributes_as_hash.pets.length).to eq(2)
+        expect(@user_with_data_through_nested_attributes_as_hash.pets[0]).to be_a(Foo::Pet)
+        expect(@user_with_data_through_nested_attributes_as_hash.pets[1]).to be_a(Foo::Pet)
+        expect(@user_with_data_through_nested_attributes_as_hash.pets[0].name).to eq("Hasi")
+        expect(@user_with_data_through_nested_attributes_as_hash.pets[1].name).to eq("Rodriguez")
       end
     end
   end
 
   context "with an unknown association" do
     it "raises an error" do
-      expect {
+      expect do
         spawn_model("Foo::User") { accepts_nested_attributes_for :company }
-      }.to raise_error(Her::Errors::AssociationUnknownError, 'Unknown association name :company')
+      end.to raise_error(Her::Errors::AssociationUnknownError, "Unknown association name :company")
     end
   end
 end