her 0.10.0 → 0.10.1

data/lib/her/version.rb

@@ -1,3 +1,3 @@
 module Her
-  VERSION = "0.10.0"
+  VERSION = "0.10.1"
 end

data/spec/model/associations_spec.rb

@@ -4,101 +4,229 @@ require File.join(File.dirname(__FILE__), "../spec_helper.rb")
 describe Her::Model::Associations do
   context "setting associations without details" do
     before { spawn_model "Foo::User" }
-    subject { Foo::User.associations }
-
-    context "single has_many association" do
-      before { Foo::User.has_many :comments }
+    subject(:associations) { Foo::User.associations }
+
+    describe "has_many associations" do
+      subject { associations[:has_many] }
+
+      context "single" do
+        let(:comments_association) do
+          {
+            name: :comments,
+            data_key: :comments,
+            default: [],
+            class_name: "Comment",
+            path: "/comments",
+            inverse_of: nil
+          }
+        end
+        before { Foo::User.has_many :comments }
 
-      describe "[:has_many]" do
-        subject { super()[:has_many] }
-        it { is_expected.to eql [{ name: :comments, data_key: :comments, default: [], class_name: "Comment", path: "/comments", inverse_of: nil }] }
+        it { is_expected.to eql [comments_association] }
       end
-    end
 
-    context "multiple has_many associations" do
-      before do
-        Foo::User.has_many :comments
-        Foo::User.has_many :posts
-      end
+      context "multiple" do
+        let(:comments_association) do
+          {
+            name: :comments,
+            data_key: :comments,
+            default: [],
+            class_name: "Comment",
+            path: "/comments",
+            inverse_of: nil
+          }
+        end
+        let(:posts_association) do
+          {
+            name: :posts,
+            data_key: :posts,
+            default: [],
+            class_name: "Post",
+            path: "/posts",
+            inverse_of: nil
+          }
+        end
+        before do
+          Foo::User.has_many :comments
+          Foo::User.has_many :posts
+        end
 
-      describe "[:has_many]" do
-        subject { super()[:has_many] }
-        it { is_expected.to eql [{ name: :comments, data_key: :comments, default: [], class_name: "Comment", path: "/comments", inverse_of: nil }, { name: :posts, data_key: :posts, default: [], class_name: "Post", path: "/posts", inverse_of: nil }] }
+        it { is_expected.to eql [comments_association, posts_association] }
       end
     end
 
-    context "single has_one association" do
-      before { Foo::User.has_one :category }
+    describe "has_one associations" do
+      subject { associations[:has_one] }
 
-      describe "[:has_one]" do
-        subject { super()[:has_one] }
-        it { is_expected.to eql [{ name: :category, data_key: :category, default: nil, class_name: "Category", path: "/category" }] }
-      end
-    end
+      context "single" do
+        let(:category_association) do
+          {
+            name: :category,
+            data_key: :category,
+            default: nil,
+            class_name: "Category",
+            path: "/category"
+          }
+        end
+        before { Foo::User.has_one :category }
 
-    context "multiple has_one associations" do
-      before do
-        Foo::User.has_one :category
-        Foo::User.has_one :role
+        it { is_expected.to eql [category_association] }
       end
 
-      describe "[:has_one]" do
-        subject { super()[:has_one] }
-        it { is_expected.to eql [{ name: :category, data_key: :category, default: nil, class_name: "Category", path: "/category" }, { name: :role, data_key: :role, default: nil, class_name: "Role", path: "/role" }] }
+      context "multiple" do
+        let(:category_association) do
+          {
+            name: :category,
+            data_key: :category,
+            default: nil,
+            class_name: "Category",
+            path: "/category"
+          }
+        end
+        let(:role_association) do
+          {
+            name: :role,
+            data_key: :role,
+            default: nil,
+            class_name: "Role",
+            path: "/role"
+          }
+        end
+        before do
+          Foo::User.has_one :category
+          Foo::User.has_one :role
+        end
+
+        it { is_expected.to eql [category_association, role_association] }
       end
     end
 
-    context "single belongs_to association" do
-      before { Foo::User.belongs_to :organization }
+    describe "belongs_to associations" do
+      subject { associations[:belongs_to] }
 
-      describe "[:belongs_to]" do
-        subject { super()[:belongs_to] }
-        it { is_expected.to eql [{ name: :organization, data_key: :organization, default: nil, class_name: "Organization", foreign_key: "organization_id", path: "/organizations/:id" }] }
-      end
-    end
+      context "single" do
+        let(:organization_association) do
+          {
+            name: :organization,
+            data_key: :organization,
+            default: nil,
+            class_name: "Organization",
+            foreign_key: "organization_id",
+            path: "/organizations/:id"
+          }
+        end
+        before { Foo::User.belongs_to :organization }
 
-    context "multiple belongs_to association" do
-      before do
-        Foo::User.belongs_to :organization
-        Foo::User.belongs_to :family
+        it { is_expected.to eql [organization_association] }
       end
 
-      describe "[:belongs_to]" do
-        subject { super()[:belongs_to] }
-        it { is_expected.to eql [{ name: :organization, data_key: :organization, default: nil, class_name: "Organization", foreign_key: "organization_id", path: "/organizations/:id" }, { name: :family, data_key: :family, default: nil, class_name: "Family", foreign_key: "family_id", path: "/families/:id" }] }
+      context "multiple" do
+        let(:organization_association) do
+          {
+            name: :organization,
+            data_key: :organization,
+            default: nil,
+            class_name: "Organization",
+            foreign_key: "organization_id",
+            path: "/organizations/:id"
+          }
+        end
+        let(:family_association) do
+          {
+            name: :family,
+            data_key: :family,
+            default: nil,
+            class_name: "Family",
+            foreign_key: "family_id",
+            path: "/families/:id"
+          }
+        end
+        before do
+          Foo::User.belongs_to :organization
+          Foo::User.belongs_to :family
+        end
+
+        it { is_expected.to eql [organization_association, family_association] }
       end
     end
   end
 
   context "setting associations with details" do
     before { spawn_model "Foo::User" }
-    subject { Foo::User.associations }
+    subject(:associations) { Foo::User.associations }
 
     context "in base class" do
-      context "single has_many association" do
-        before { Foo::User.has_many :comments, class_name: "Post", inverse_of: :admin, data_key: :user_comments, default: {} }
+      describe "has_many associations" do
+        subject { associations[:has_many] }
+
+        context "single" do
+          let(:comments_association) do
+            {
+              name: :comments,
+              data_key: :user_comments,
+              default: {},
+              class_name: "Post",
+              path: "/comments",
+              inverse_of: :admin
+            }
+          end
+          before do
+            Foo::User.has_many :comments, class_name: "Post",
+                                          inverse_of: :admin,
+                                          data_key: :user_comments,
+                                          default: {}
+          end
 
-        describe "[:has_many]" do
-          subject { super()[:has_many] }
-          it { is_expected.to eql [{ name: :comments, data_key: :user_comments, default: {}, class_name: "Post", path: "/comments", inverse_of: :admin }] }
+          it { is_expected.to eql [comments_association] }
         end
       end
 
-      context "single has_one association" do
-        before { Foo::User.has_one :category, class_name: "Topic", foreign_key: "topic_id", data_key: :topic, default: nil }
+      describe "has_one associations" do
+        subject { associations[:has_one] }
 
-        describe "[:has_one]" do
-          subject { super()[:has_one] }
-          it { is_expected.to eql [{ name: :category, data_key: :topic, default: nil, class_name: "Topic", foreign_key: "topic_id", path: "/category" }] }
+        context "single" do
+          let(:category_association) do
+            {
+              name: :category,
+              data_key: :topic,
+              default: nil,
+              class_name: "Topic",
+              foreign_key: "topic_id",
+              path: "/category"
+            }
+          end
+          before do
+            Foo::User.has_one :category, class_name: "Topic",
+                                         foreign_key: "topic_id",
+                                         data_key: :topic, default: nil
+          end
+
+          it { is_expected.to eql [category_association] }
         end
       end
 
-      context "single belongs_to association" do
-        before { Foo::User.belongs_to :organization, class_name: "Business", foreign_key: "org_id", data_key: :org, default: true }
+      describe "belongs_to associations" do
+        subject { associations[:belongs_to] }
 
-        describe "[:belongs_to]" do
-          subject { super()[:belongs_to] }
-          it { is_expected.to eql [{ name: :organization, data_key: :org, default: true, class_name: "Business", foreign_key: "org_id", path: "/organizations/:id" }] }
+        context "single" do
+          let(:organization_association) do
+            {
+              name: :organization,
+              data_key: :org,
+              default: true,
+              class_name: "Business",
+              foreign_key: "org_id",
+              path: "/organizations/:id"
+            }
+          end
+          before do
+            Foo::User.belongs_to :organization, class_name: "Business",
+                                                foreign_key: "org_id",
+                                                data_key: :org,
+                                                default: true
+          end
+
+          it { is_expected.to eql [organization_association] }
         end
       end
     end
@@ -107,16 +235,27 @@ describe Her::Model::Associations do
       before { Foo::User.has_many :comments, class_name: "Post" }
 
       describe "associations accessor" do
-        subject { Class.new(Foo::User).associations }
+        subject(:associations) { Class.new(Foo::User).associations }
 
         describe "#object_id" do
-          subject { super().object_id }
+          subject { associations.object_id }
           it { is_expected.not_to eql Foo::User.associations.object_id }
         end
 
         describe "[:has_many]" do
-          subject { super()[:has_many] }
-          it { is_expected.to eql [{ name: :comments, data_key: :comments, default: [], class_name: "Post", path: "/comments", inverse_of: nil }] }
+          subject { associations[:has_many] }
+          let(:association) do
+            {
+              name: :comments,
+              data_key: :comments,
+              default: [],
+              class_name: "Post",
+              path: "/comments",
+              inverse_of: nil
+            }
+          end
+
+          it { is_expected.to eql [association] }
         end
       end
     end
@@ -124,33 +263,6 @@ describe Her::Model::Associations do
 
   context "handling associations without details" do
     before do
-      Her::API.setup url: "https://api.example.com" do |builder|
-        builder.use Her::Middleware::FirstLevelParseJSON
-        builder.use Faraday::Request::UrlEncoded
-        builder.adapter :test do |stub|
-          stub.get("/users/1") { [200, {}, { id: 1, name: "Tobias Fünke", comments: [{ comment: { id: 2, body: "Tobias, you blow hard!", user_id: 1 } }, { comment: { id: 3, body: "I wouldn't mind kissing that man between the cheeks, so to speak", user_id: 1 } }], role: { id: 1, body: "Admin" }, organization: { id: 1, name: "Bluth Company" }, organization_id: 1 }.to_json] }
-          stub.get("/users/2") { [200, {}, { id: 2, name: "Lindsay Fünke", organization_id: 2 }.to_json] }
-          stub.get("/users/1/comments") { [200, {}, [{ comment: { id: 4, body: "They're having a FIRESALE?" } }].to_json] }
-          stub.get("/users/2/comments") { [200, {}, [{ comment: { id: 4, body: "They're having a FIRESALE?" } }, { comment: { id: 5, body: "Is this the tiny town from Footloose?" } }].to_json] }
-          stub.get("/users/2/comments/5") { [200, {}, { comment: { id: 5, body: "Is this the tiny town from Footloose?" } }.to_json] }
-          stub.get("/users/2/role") { [200, {}, { id: 2, body: "User" }.to_json] }
-          stub.get("/users/1/role") { [200, {}, { id: 3, body: "User" }.to_json] }
-          stub.get("/users/1/posts") { [200, {}, [{ id: 1, body: "blogging stuff", admin_id: 1 }].to_json] }
-          stub.get("/organizations/1") { [200, {}, { organization:  { id: 1, name: "Bluth Company Foo" } }.to_json] }
-          stub.post("/users") { [200, {}, { id: 5, name: "Mr. Krabs", comments: [{ comment: { id: 99, body: "Rodríguez, nasibisibusi?", user_id: 5 } }], role: { id: 1, body: "Admin" }, organization: { id: 3, name: "Krusty Krab" }, organization_id: 3 }.to_json] }
-          stub.put("/users/5") { [200, {}, { id: 5, name: "Clancy Brown", comments: [{ comment: { id: 99, body: "Rodríguez, nasibisibusi?", user_id: 5 } }], role: { id: 1, body: "Admin" }, organization: { id: 3, name: "Krusty Krab" }, organization_id: 3 }.to_json] }
-          stub.delete("/users/5") { [200, {}, { id: 5, name: "Clancy Brown", comments: [{ comment: { id: 99, body: "Rodríguez, nasibisibusi?", user_id: 5 } }], role: { id: 1, body: "Admin" }, organization: { id: 3, name: "Krusty Krab" }, organization_id: 3 }.to_json] }
-
-          stub.get("/organizations/2") do |env|
-            if env[:params]["admin"] == "true"
-              [200, {}, { organization: { id: 2, name: "Bluth Company (admin)" } }.to_json]
-            else
-              [200, {}, { organization: { id: 2, name: "Bluth Company" } }.to_json]
-            end
-          end
-        end
-      end
-
       spawn_model "Foo::User" do
         has_many :comments, class_name: "Foo::Comment"
         has_one :role, class_name: "Foo::Role"
@@ -172,166 +284,243 @@ describe Her::Model::Associations do
       end
 
       spawn_model "Foo::Role"
-
-      @user_with_included_data = Foo::User.find(1)
-      @user_without_included_data = Foo::User.find(2)
-      @user_without_organization_and_not_persisted = Foo::User.new(organization_id: nil, name: "Katlin Fünke")
     end
 
-    let(:user_with_included_data_after_create) { Foo::User.create }
-    let(:user_with_included_data_after_save_existing) { Foo::User.save_existing(5, name: "Clancy Brown") }
-    let(:user_with_included_data_after_destroy) { Foo::User.new(id: 5).destroy }
-    let(:comment_without_included_parent_data) { Foo::Comment.new(id: 7, user_id: 1) }
-    let(:new_user) { Foo::User.new }
-
-    it "maps an array of included data through has_many" do
-      expect(@user_with_included_data.comments.first).to be_a(Foo::Comment)
-      expect(@user_with_included_data.comments.length).to eq(2)
-      expect(@user_with_included_data.comments.first.id).to eq(2)
-      expect(@user_with_included_data.comments.first.body).to eq("Tobias, you blow hard!")
-    end
+    context "with included data" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+          builder.adapter :test do |stub|
+            stub.get("/users/1") { [200, {}, { id: 1, name: "Tobias Fünke", comments: [{ comment: { id: 2, body: "Tobias, you blow hard!", user_id: 1 } }, { comment: { id: 3, body: "I wouldn't mind kissing that man between the cheeks, so to speak", user_id: 1 } }], role: { id: 1, body: "Admin" }, organization: { id: 1, name: "Bluth Company" }, organization_id: 1 }.to_json] }
+            stub.get("/users/1/comments") { [200, {}, [{ comment: { id: 4, body: "They're having a FIRESALE?" } }].to_json] }
+            stub.get("/users/1/role") { [200, {}, { id: 3, body: "User" }.to_json] }
+            stub.get("/users/1/posts") { [200, {}, [{ id: 1, body: "blogging stuff", admin_id: 1 }].to_json] }
+            stub.get("/organizations/1") { [200, {}, { organization:  { id: 1, name: "Bluth Company Foo" } }.to_json] }
+          end
+        end
+      end
 
-    it "does not refetch the parents models data if they have been fetched before" do
-      expect(@user_with_included_data.comments.first.user.object_id).to eq(@user_with_included_data.object_id)
-    end
+      let(:user) { Foo::User.find(1) }
+      let(:user_params) { user.to_params }
 
-    it "does fetch the parent models data only once" do
-      expect(comment_without_included_parent_data.user.object_id).to eq(comment_without_included_parent_data.user.object_id)
-    end
+      it "maps an array of included data through has_many" do
+        expect(user.comments.first).to be_a(Foo::Comment)
+        expect(user.comments.length).to eq(2)
+        expect(user.comments.first.id).to eq(2)
+        expect(user.comments.first.body).to eq("Tobias, you blow hard!")
+      end
 
-    it "does fetch the parent models data that was cached if called with parameters" do
-      expect(comment_without_included_parent_data.user.object_id).not_to eq(comment_without_included_parent_data.user.where(a: 2).object_id)
-    end
+      it "does not refetch the parents models data if they have been fetched before" do
+        expect(user.comments.first.user.object_id).to eq(user.object_id)
+      end
 
-    it "uses the given inverse_of key to set the parent model" do
-      expect(@user_with_included_data.posts.first.admin.object_id).to eq(@user_with_included_data.object_id)
-    end
+      it "uses the given inverse_of key to set the parent model" do
+        expect(user.posts.first.admin.object_id).to eq(user.object_id)
+      end
 
-    it "doesn't attempt to fetch association data for a new resource" do
-      expect(new_user.comments).to eq([])
-      expect(new_user.role).to be_nil
-      expect(new_user.organization).to be_nil
-    end
+      it "fetches has_many data even if it was included, only if called with parameters" do
+        expect(user.comments.where(foo_id: 1).length).to eq(1)
+      end
 
-    it "fetches data that was not included through has_many" do
-      expect(@user_without_included_data.comments.first).to be_a(Foo::Comment)
-      expect(@user_without_included_data.comments.length).to eq(2)
-      expect(@user_without_included_data.comments.first.id).to eq(4)
-      expect(@user_without_included_data.comments.first.body).to eq("They're having a FIRESALE?")
-    end
+      it "maps an array of included data through has_one" do
+        expect(user.role).to be_a(Foo::Role)
+        expect(user.role.object_id).to eq(user.role.object_id)
+        expect(user.role.id).to eq(1)
+        expect(user.role.body).to eq("Admin")
+      end
 
-    it "fetches has_many data even if it was included, only if called with parameters" do
-      expect(@user_with_included_data.comments.where(foo_id: 1).length).to eq(1)
-    end
+      it "fetches has_one data even if it was included, only if called with parameters" do
+        expect(user.role.where(foo_id: 2).id).to eq(3)
+      end
 
-    it "fetches data that was not included through has_many only once" do
-      expect(@user_without_included_data.comments.first.object_id).to eq(@user_without_included_data.comments.first.object_id)
-    end
+      it "maps an array of included data through belongs_to" do
+        expect(user.organization).to be_a(Foo::Organization)
+        expect(user.organization.id).to eq(1)
+        expect(user.organization.name).to eq("Bluth Company")
+      end
 
-    it "fetches data that was cached through has_many if called with parameters" do
-      expect(@user_without_included_data.comments.first.object_id).not_to eq(@user_without_included_data.comments.where(foo_id: 1).first.object_id)
-    end
+      it "fetches belongs_to data even if it was included, only if called with parameters" do
+        expect(user.organization.where(foo_id: 1).name).to eq("Bluth Company Foo")
+      end
 
-    it "fetches data again after being reloaded" do
-      expect { @user_without_included_data.comments.reload }.to change { @user_without_included_data.comments.first.object_id }
-    end
+      it "includes has_many relationships in params by default" do
+        expect(user_params[:comments]).to be_kind_of(Array)
+        expect(user_params[:comments].length).to eq(2)
+      end
 
-    it "maps an array of included data through has_one" do
-      expect(@user_with_included_data.role).to be_a(Foo::Role)
-      expect(@user_with_included_data.role.object_id).to eq(@user_with_included_data.role.object_id)
-      expect(@user_with_included_data.role.id).to eq(1)
-      expect(@user_with_included_data.role.body).to eq("Admin")
-    end
+      it "includes has_one relationship in params by default" do
+        expect(user_params[:role]).to be_kind_of(Hash)
+        expect(user_params[:role]).not_to be_empty
+      end
 
-    it "fetches data that was not included through has_one" do
-      expect(@user_without_included_data.role).to be_a(Foo::Role)
-      expect(@user_without_included_data.role.id).to eq(2)
-      expect(@user_without_included_data.role.body).to eq("User")
+      it "includes belongs_to relationship in params by default" do
+        expect(user_params[:organization]).to be_kind_of(Hash)
+        expect(user_params[:organization]).not_to be_empty
+      end
     end
 
-    it "fetches has_one data even if it was included, only if called with parameters" do
-      expect(@user_with_included_data.role.where(foo_id: 2).id).to eq(3)
-    end
+    context "without included data" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+          builder.adapter :test do |stub|
+            stub.get("/users/2") { [200, {}, { id: 2, name: "Lindsay Fünke", organization_id: 2 }.to_json] }
+            stub.get("/users/2/comments") { [200, {}, [{ comment: { id: 4, body: "They're having a FIRESALE?" } }, { comment: { id: 5, body: "Is this the tiny town from Footloose?" } }].to_json] }
+            stub.get("/users/2/comments/5") { [200, {}, { comment: { id: 5, body: "Is this the tiny town from Footloose?" } }.to_json] }
+            stub.get("/users/2/role") { [200, {}, { id: 2, body: "User" }.to_json] }
+            stub.get("/organizations/2") do |env|
+              if env[:params]["admin"] == "true"
+                [200, {}, { organization: { id: 2, name: "Bluth Company (admin)" } }.to_json]
+              else
+                [200, {}, { organization: { id: 2, name: "Bluth Company" } }.to_json]
+              end
+            end
+          end
+        end
+      end
 
-    it "maps an array of included data through belongs_to" do
-      expect(@user_with_included_data.organization).to be_a(Foo::Organization)
-      expect(@user_with_included_data.organization.id).to eq(1)
-      expect(@user_with_included_data.organization.name).to eq("Bluth Company")
-    end
+      let(:user) { Foo::User.find(2) }
 
-    it "fetches data that was not included through belongs_to" do
-      expect(@user_without_included_data.organization).to be_a(Foo::Organization)
-      expect(@user_without_included_data.organization.id).to eq(2)
-      expect(@user_without_included_data.organization.name).to eq("Bluth Company")
-    end
+      it "fetches data that was not included through has_many" do
+        expect(user.comments.first).to be_a(Foo::Comment)
+        expect(user.comments.length).to eq(2)
+        expect(user.comments.first.id).to eq(4)
+        expect(user.comments.first.body).to eq("They're having a FIRESALE?")
+      end
 
-    it "returns nil if the foreign key is nil" do
-      expect(@user_without_organization_and_not_persisted.organization).to be_nil
-    end
+      it "fetches data that was not included through has_many only once" do
+        expect(user.comments.first.object_id).to eq(user.comments.first.object_id)
+      end
 
-    it "fetches belongs_to data even if it was included, only if called with parameters" do
-      expect(@user_with_included_data.organization.where(foo_id: 1).name).to eq("Bluth Company Foo")
-    end
+      it "fetches data that was cached through has_many if called with parameters" do
+        expect(user.comments.first.object_id).not_to eq(user.comments.where(foo_id: 1).first.object_id)
+      end
 
-    it "can tell if it has a association" do
-      expect(@user_without_included_data.has_association?(:unknown_association)).to be false
-      expect(@user_without_included_data.has_association?(:organization)).to be true
-    end
+      it "fetches data again after being reloaded" do
+        expect { user.comments.reload }.to change { user.comments.first.object_id }
+      end
 
-    it "fetches the resource corresponding to a named association" do
-      expect(@user_without_included_data.get_association(:unknown_association)).to be_nil
-      expect(@user_without_included_data.get_association(:organization).name).to eq("Bluth Company")
-    end
+      it "fetches data that was not included through has_one" do
+        expect(user.role).to be_a(Foo::Role)
+        expect(user.role.id).to eq(2)
+        expect(user.role.body).to eq("User")
+      end
 
-    it "pass query string parameters when additional arguments are passed" do
-      expect(@user_without_included_data.organization.where(admin: true).name).to eq("Bluth Company (admin)")
-      expect(@user_without_included_data.organization.name).to eq("Bluth Company")
-    end
+      it "fetches data that was not included through belongs_to" do
+        expect(user.organization).to be_a(Foo::Organization)
+        expect(user.organization.id).to eq(2)
+        expect(user.organization.name).to eq("Bluth Company")
+      end
 
-    it "fetches data with the specified id when calling find" do
-      comment = @user_without_included_data.comments.find(5)
-      expect(comment).to be_a(Foo::Comment)
-      expect(comment.id).to eq(5)
-    end
+      it "can tell if it has a association" do
+        expect(user.has_association?(:unknown_association)).to be false
+        expect(user.has_association?(:organization)).to be true
+      end
 
-    it "'s associations responds to #empty?" do
-      expect(@user_without_included_data.organization.respond_to?(:empty?)).to be_truthy
-      expect(@user_without_included_data.organization).not_to be_empty
-    end
+      it "fetches the resource corresponding to a named association" do
+        expect(user.get_association(:unknown_association)).to be_nil
+        expect(user.get_association(:organization).name).to eq("Bluth Company")
+      end
+
+      it "pass query string parameters when additional arguments are passed" do
+        expect(user.organization.where(admin: true).name).to eq("Bluth Company (admin)")
+        expect(user.organization.name).to eq("Bluth Company")
+      end
 
-    it "includes has_many relationships in params by default" do
-      params = @user_with_included_data.to_params
-      expect(params[:comments]).to be_kind_of(Array)
-      expect(params[:comments].length).to eq(2)
+      it "fetches data with the specified id when calling find" do
+        comment = user.comments.find(5)
+        expect(comment).to be_a(Foo::Comment)
+        expect(comment.id).to eq(5)
+      end
+
+      it "'s associations responds to #empty?" do
+        expect(user.organization.respond_to?(:empty?)).to be_truthy
+        expect(user.organization).not_to be_empty
+      end
     end
 
-    it "includes has_one relationship in params by default" do
-      params = @user_with_included_data.to_params
-      expect(params[:role]).to be_kind_of(Hash)
-      expect(params[:role]).not_to be_empty
+    context "without included parent data" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+        end
+      end
+
+      let(:comment) { Foo::Comment.new(id: 7, user_id: 1) }
+
+      it "does fetch the parent models data only once" do
+        expect(comment.user.object_id).to eq(comment.user.object_id)
+      end
+
+      it "does fetch the parent models data that was cached if called with parameters" do
+        expect(comment.user.object_id).not_to eq(comment.user.where(a: 2).object_id)
+      end
     end
 
-    it "includes belongs_to relationship in params by default" do
-      params = @user_with_included_data.to_params
-      expect(params[:organization]).to be_kind_of(Hash)
-      expect(params[:organization]).not_to be_empty
+    context "when resource is new" do
+      let(:new_user) { Foo::User.new }
+
+      it "doesn't attempt to fetch association data" do
+        expect(new_user.comments).to eq([])
+        expect(new_user.role).to be_nil
+        expect(new_user.organization).to be_nil
+      end
     end
 
-    [:create, :save_existing, :destroy].each do |type|
-      context "after #{type}" do
-        let(:subject) { send("user_with_included_data_after_#{type}") }
+    context "when foreign_key is nil" do
+      before do
+        spawn_model "Foo::User" do
+          belongs_to :organization, class_name: "Foo::Organization"
+        end
 
-        it "maps an array of included data through has_many" do
-          expect(subject.comments.first).to be_a(Foo::Comment)
-          expect(subject.comments.length).to eq(1)
-          expect(subject.comments.first.id).to eq(99)
-          expect(subject.comments.first.body).to eq("Rodríguez, nasibisibusi?")
+        spawn_model "Foo::Organization" do
+          parse_root_in_json true
         end
+      end
 
-        it "maps an array of included data through has_one" do
-          expect(subject.role).to be_a(Foo::Role)
-          expect(subject.role.id).to eq(1)
-          expect(subject.role.body).to eq("Admin")
+      let(:user) { Foo::User.new(organization_id: nil, name: "Katlin Fünke") }
+
+      it "returns nil" do
+        expect(user.organization).to be_nil
+      end
+    end
+
+    context "after" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+          builder.adapter :test do |stub|
+            stub.post("/users") { [200, {}, { id: 5, name: "Mr. Krabs", comments: [{ comment: { id: 99, body: "Rodríguez, nasibisibusi?", user_id: 5 } }], role: { id: 1, body: "Admin" }, organization: { id: 3, name: "Krusty Krab" }, organization_id: 3 }.to_json] }
+            stub.put("/users/5") { [200, {}, { id: 5, name: "Clancy Brown", comments: [{ comment: { id: 99, body: "Rodríguez, nasibisibusi?", user_id: 5 } }], role: { id: 1, body: "Admin" }, organization: { id: 3, name: "Krusty Krab" }, organization_id: 3 }.to_json] }
+            stub.delete("/users/5") { [200, {}, { id: 5, name: "Clancy Brown", comments: [{ comment: { id: 99, body: "Rodríguez, nasibisibusi?", user_id: 5 } }], role: { id: 1, body: "Admin" }, organization: { id: 3, name: "Krusty Krab" }, organization_id: 3 }.to_json] }
+          end
+        end
+      end
+
+      let(:user_after_create) { Foo::User.create }
+      let(:user_after_save_existing) { Foo::User.save_existing(5, name: "Clancy Brown") }
+      let(:user_after_destroy) { Foo::User.new(id: 5).destroy }
+
+      [:create, :save_existing, :destroy].each do |type|
+        context "after #{type}" do
+          let(:subject) { send("user_after_#{type}") }
+
+          it "maps an array of included data through has_many" do
+            expect(subject.comments.first).to be_a(Foo::Comment)
+            expect(subject.comments.length).to eq(1)
+            expect(subject.comments.first.id).to eq(99)
+            expect(subject.comments.first.body).to eq("Rodríguez, nasibisibusi?")
+          end
+
+          it "maps an array of included data through has_one" do
+            expect(subject.role).to be_a(Foo::Role)
+            expect(subject.role.id).to eq(1)
+            expect(subject.role.body).to eq("Admin")
+          end
         end
       end
     end
@@ -339,19 +528,6 @@ describe Her::Model::Associations do
 
   context "handling associations with details in active_model_serializers format" do
     before do
-      Her::API.setup url: "https://api.example.com" do |builder|
-        builder.use Her::Middleware::FirstLevelParseJSON
-        builder.use Faraday::Request::UrlEncoded
-        builder.adapter :test do |stub|
-          stub.get("/users/1") { [200, {}, { user: { id: 1, name: "Tobias Fünke", comments: [{ id: 2, body: "Tobias, you blow hard!", user_id: 1 }, { id: 3, body: "I wouldn't mind kissing that man between the cheeks, so to speak", user_id: 1 }], role: { id: 1, body: "Admin" }, organization: { id: 1, name: "Bluth Company" }, organization_id: 1 } }.to_json] }
-          stub.get("/users/2") { [200, {}, { user: { id: 2, name: "Lindsay Fünke", organization_id: 1 } }.to_json] }
-          stub.get("/users/1/comments") { [200, {}, { comments: [{ id: 4, body: "They're having a FIRESALE?" }] }.to_json] }
-          stub.get("/users/2/comments") { [200, {}, { comments: [{ id: 4, body: "They're having a FIRESALE?" }, { id: 5, body: "Is this the tiny town from Footloose?" }] }.to_json] }
-          stub.get("/users/2/comments/5") { [200, {}, { comment: { id: 5, body: "Is this the tiny town from Footloose?" } }.to_json] }
-          stub.get("/organizations/1") { [200, {}, { organization:  { id: 1, name: "Bluth Company Foo" } }.to_json] }
-        end
-      end
-
       spawn_model "Foo::User" do
         parse_root_in_json true, format: :active_model_serializers
         has_many :comments, class_name: "Foo::Comment"
@@ -372,118 +548,169 @@ describe Her::Model::Associations do
       spawn_model "Foo::Organization" do
         parse_root_in_json true, format: :active_model_serializers
       end
-
-      @user_with_included_data = Foo::User.find(1)
-      @user_without_included_data = Foo::User.find(2)
     end
 
-    it "maps an array of included data through has_many" do
-      expect(@user_with_included_data.comments.first).to be_a(Foo::Comment)
-      expect(@user_with_included_data.comments.length).to eq(2)
-      expect(@user_with_included_data.comments.first.id).to eq(2)
-      expect(@user_with_included_data.comments.first.body).to eq("Tobias, you blow hard!")
-    end
+    context "with included data" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+          builder.adapter :test do |stub|
+            stub.get("/users/1") { [200, {}, { user: { id: 1, name: "Tobias Fünke", comments: [{ id: 2, body: "Tobias, you blow hard!", user_id: 1 }, { id: 3, body: "I wouldn't mind kissing that man between the cheeks, so to speak", user_id: 1 }], role: { id: 1, body: "Admin" }, organization: { id: 1, name: "Bluth Company" }, organization_id: 1 } }.to_json] }
+            stub.get("/users/1/comments") { [200, {}, { comments: [{ id: 4, body: "They're having a FIRESALE?" }] }.to_json] }
+            stub.get("/organizations/1") { [200, {}, { organization:  { id: 1, name: "Bluth Company Foo" } }.to_json] }
+          end
+        end
+      end
 
-    it "does not refetch the parents models data if they have been fetched before" do
-      expect(@user_with_included_data.comments.first.user.object_id).to eq(@user_with_included_data.object_id)
-    end
+      let(:user) { Foo::User.find(1) }
+      let(:user_params) { user.to_params }
 
-    it "fetches data that was not included through has_many" do
-      expect(@user_without_included_data.comments.first).to be_a(Foo::Comment)
-      expect(@user_without_included_data.comments.length).to eq(2)
-      expect(@user_without_included_data.comments.first.id).to eq(4)
-      expect(@user_without_included_data.comments.first.body).to eq("They're having a FIRESALE?")
-    end
+      it "maps an array of included data through has_many" do
+        expect(user.comments.first).to be_a(Foo::Comment)
+        expect(user.comments.length).to eq(2)
+        expect(user.comments.first.id).to eq(2)
+        expect(user.comments.first.body).to eq("Tobias, you blow hard!")
+      end
 
-    it "fetches has_many data even if it was included, only if called with parameters" do
-      expect(@user_with_included_data.comments.where(foo_id: 1).length).to eq(1)
-    end
+      it "does not refetch the parents models data if they have been fetched before" do
+        expect(user.comments.first.user.object_id).to eq(user.object_id)
+      end
 
-    it "maps an array of included data through belongs_to" do
-      expect(@user_with_included_data.organization).to be_a(Foo::Organization)
-      expect(@user_with_included_data.organization.id).to eq(1)
-      expect(@user_with_included_data.organization.name).to eq("Bluth Company")
-    end
+      it "fetches has_many data even if it was included, only if called with parameters" do
+        expect(user.comments.where(foo_id: 1).length).to eq(1)
+      end
 
-    it "fetches data that was not included through belongs_to" do
-      expect(@user_without_included_data.organization).to be_a(Foo::Organization)
-      expect(@user_without_included_data.organization.id).to eq(1)
-      expect(@user_without_included_data.organization.name).to eq("Bluth Company Foo")
-    end
+      it "maps an array of included data through belongs_to" do
+        expect(user.organization).to be_a(Foo::Organization)
+        expect(user.organization.id).to eq(1)
+        expect(user.organization.name).to eq("Bluth Company")
+      end
 
-    it "fetches belongs_to data even if it was included, only if called with parameters" do
-      expect(@user_with_included_data.organization.where(foo_id: 1).name).to eq("Bluth Company Foo")
-    end
+      it "fetches belongs_to data even if it was included, only if called with parameters" do
+        expect(user.organization.where(foo_id: 1).name).to eq("Bluth Company Foo")
+      end
 
-    it "fetches data with the specified id when calling find" do
-      comment = @user_without_included_data.comments.find(5)
-      expect(comment).to be_a(Foo::Comment)
-      expect(comment.id).to eq(5)
-    end
+      it "includes has_many relationships in params by default" do
+        expect(user_params[:comments]).to be_kind_of(Array)
+        expect(user_params[:comments].length).to eq(2)
+      end
 
-    it "includes has_many relationships in params by default" do
-      params = @user_with_included_data.to_params
-      expect(params[:comments]).to be_kind_of(Array)
-      expect(params[:comments].length).to eq(2)
-    end
+      it "includes has_one relationships in params by default" do
+        expect(user_params[:role]).to be_kind_of(Hash)
+        expect(user_params[:role]).not_to be_empty
+      end
 
-    it "includes has_one relationships in params by default" do
-      params = @user_with_included_data.to_params
-      expect(params[:role]).to be_kind_of(Hash)
-      expect(params[:role]).not_to be_empty
+      it "includes belongs_to relationship in params by default" do
+        expect(user_params[:organization]).to be_kind_of(Hash)
+        expect(user_params[:organization]).not_to be_empty
+      end
     end
 
-    it "includes belongs_to relationship in params by default" do
-      params = @user_with_included_data.to_params
-      expect(params[:organization]).to be_kind_of(Hash)
-      expect(params[:organization]).not_to be_empty
+    context "without included data" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+          builder.adapter :test do |stub|
+            stub.get("/users/2") { [200, {}, { user: { id: 2, name: "Lindsay Fünke", organization_id: 1 } }.to_json] }
+            stub.get("/users/2/comments") { [200, {}, { comments: [{ id: 4, body: "They're having a FIRESALE?" }, { id: 5, body: "Is this the tiny town from Footloose?" }] }.to_json] }
+            stub.get("/users/2/comments/5") { [200, {}, { comment: { id: 5, body: "Is this the tiny town from Footloose?" } }.to_json] }
+            stub.get("/organizations/1") { [200, {}, { organization:  { id: 1, name: "Bluth Company Foo" } }.to_json] }
+          end
+        end
+      end
+
+      let(:user) { Foo::User.find(2) }
+
+      it "fetches data that was not included through has_many" do
+        expect(user.comments.first).to be_a(Foo::Comment)
+        expect(user.comments.length).to eq(2)
+        expect(user.comments.first.id).to eq(4)
+        expect(user.comments.first.body).to eq("They're having a FIRESALE?")
+      end
+
+      it "fetches data that was not included through belongs_to" do
+        expect(user.organization).to be_a(Foo::Organization)
+        expect(user.organization.id).to eq(1)
+        expect(user.organization.name).to eq("Bluth Company Foo")
+      end
+
+      it "fetches data with the specified id when calling find" do
+        comment = user.comments.find(5)
+        expect(comment).to be_a(Foo::Comment)
+        expect(comment.id).to eq(5)
+      end
     end
   end
 
   context "handling associations with details" do
     before do
-      Her::API.setup url: "https://api.example.com" do |builder|
-        builder.use Her::Middleware::FirstLevelParseJSON
-        builder.use Faraday::Request::UrlEncoded
-        builder.adapter :test do |stub|
-          stub.get("/users/1") { [200, {}, { id: 1, name: "Tobias Fünke", organization: { id: 1, name: "Bluth Company Inc." }, organization_id: 1 }.to_json] }
-          stub.get("/users/4") { [200, {}, { id: 1, name: "Tobias Fünke", organization: { id: 1, name: "Bluth Company Inc." } }.to_json] }
-          stub.get("/users/2") { [200, {}, { id: 2, name: "Lindsay Fünke", organization_id: 1 }.to_json] }
-          stub.get("/users/3") { [200, {}, { id: 2, name: "Lindsay Fünke", company: nil }.to_json] }
-          stub.get("/companies/1") { [200, {}, { id: 1, name: "Bluth Company" }.to_json] }
-        end
-      end
-
       spawn_model "Foo::User" do
         belongs_to :company, path: "/organizations/:id", foreign_key: :organization_id, data_key: :organization
       end
 
       spawn_model "Foo::Company"
-
-      @user_with_included_data = Foo::User.find(1)
-      @user_without_included_data = Foo::User.find(2)
-      @user_with_included_nil_data = Foo::User.find(3)
-      @user_with_included_data_but_no_fk = Foo::User.find(4)
     end
 
-    it "maps an array of included data through belongs_to" do
-      expect(@user_with_included_data.company).to be_a(Foo::Company)
-      expect(@user_with_included_data.company.id).to eq(1)
-      expect(@user_with_included_data.company.name).to eq("Bluth Company Inc.")
-    end
+    context "with included data" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+          builder.adapter :test do |stub|
+            stub.get("/users/1") { [200, {}, { id: 1, name: "Tobias Fünke", organization: { id: 1, name: "Bluth Company Inc." }, organization_id: 1 }.to_json] }
+            stub.get("/users/4") { [200, {}, { id: 1, name: "Tobias Fünke", organization: { id: 1, name: "Bluth Company Inc." } }.to_json] }
+            stub.get("/users/3") { [200, {}, { id: 2, name: "Lindsay Fünke", company: nil }.to_json] }
+            stub.get("/companies/1") { [200, {}, { id: 1, name: "Bluth Company" }.to_json] }
+          end
+        end
+      end
 
-    it "does not map included data if it’s nil" do
-      expect(@user_with_included_nil_data.company).to be_nil
-    end
+      let(:user) { Foo::User.find(1) }
 
-    it "fetches data that was not included through belongs_to" do
-      expect(@user_without_included_data.company).to be_a(Foo::Company)
-      expect(@user_without_included_data.company.id).to eq(1)
-      expect(@user_without_included_data.company.name).to eq("Bluth Company")
+      it "maps an array of included data through belongs_to" do
+        expect(user.company).to be_a(Foo::Company)
+        expect(user.company.id).to eq(1)
+        expect(user.company.name).to eq("Bluth Company Inc.")
+      end
+
+      context "when included data is nil" do
+        let(:user) { Foo::User.find(3) }
+
+        it "does not map included data" do
+          expect(user.company).to be_nil
+        end
+      end
+
+      context "when included data has no foreign_key" do
+        let(:user) { Foo::User.find(4) }
+
+        it "maps included data anyway" do
+          expect(user.company.name).to eq("Bluth Company Inc.")
+        end
+      end
     end
 
-    it "does not require foreugn key to have nested object" do
-      expect(@user_with_included_data_but_no_fk.company.name).to eq("Bluth Company Inc.")
+    context "without included data" do
+      before(:context) do
+        Her::API.setup url: "https://api.example.com" do |builder|
+          builder.use Her::Middleware::FirstLevelParseJSON
+          builder.use Faraday::Request::UrlEncoded
+          builder.adapter :test do |stub|
+            stub.get("/users/2") { [200, {}, { id: 2, name: "Lindsay Fünke", organization_id: 1 }.to_json] }
+            stub.get("/companies/1") { [200, {}, { id: 1, name: "Bluth Company" }.to_json] }
+          end
+        end
+      end
+
+      let(:user) { Foo::User.find(2) }
+
+      it "fetches data that was not included through belongs_to" do
+        expect(user.company).to be_a(Foo::Company)
+        expect(user.company.id).to eq(1)
+        expect(user.company.name).to eq("Bluth Company")
+      end
     end
   end
 
@@ -543,14 +770,18 @@ describe Her::Model::Associations do
     end
 
     context "with #build" do
+      let(:comment) { Foo::User.new(id: 10).comments.build(body: "Hello!") }
+
       it "takes the parent primary key" do
-        @comment = Foo::User.new(id: 10).comments.build(body: "Hello!")
-        expect(@comment.body).to eq("Hello!")
-        expect(@comment.user_id).to eq(10)
+        expect(comment.body).to eq("Hello!")
+        expect(comment.user_id).to eq(10)
       end
     end
 
     context "with #create" do
+      let(:user) { Foo::User.find(10) }
+      let(:comment) { user.comments.create(body: "Hello!") }
+
       before do
         Her::API.setup url: "https://api.example.com" do |builder|
           builder.use Her::Middleware::FirstLevelParseJSON
@@ -566,25 +797,30 @@ describe Her::Model::Associations do
       end
 
       it "takes the parent primary key and saves the resource" do
-        @user = Foo::User.find(10)
-        @comment = @user.comments.create(body: "Hello!")
-        expect(@comment.id).to eq(1)
-        expect(@comment.body).to eq("Hello!")
-        expect(@comment.user_id).to eq(10)
-        expect(@user.comments).to eq([@comment])
+        expect(comment.id).to eq(1)
+        expect(comment.body).to eq("Hello!")
+        expect(comment.user_id).to eq(10)
+        expect(user.comments).to eq([comment])
       end
     end
 
     context "with #new" do
-      it "creates nested models from hash attibutes" do
-        user = Foo::User.new(name: "vic", comments: [{ text: "hello" }])
-        expect(user.comments.first.text).to eq("hello")
+      let(:user) { Foo::User.new(name: "vic", comments: [comment]) }
+
+      context "using hash attributes" do
+        let(:comment) { { text: "hello" } }
+
+        it "assigns nested models" do
+          expect(user.comments.first.text).to eq("hello")
+        end
       end
 
-      it "assigns nested models if given as already constructed objects" do
-        bye = Foo::Comment.new(text: "goodbye")
-        user = Foo::User.new(name: "vic", comments: [bye])
-        expect(user.comments.first.text).to eq("goodbye")
+      context "using constructed objects" do
+        let(:comment) { Foo::Comment.new(text: "goodbye") }
+
+        it "assigns nested models" do
+          expect(user.comments.first.text).to eq("goodbye")
+        end
       end
     end
   end