henkei 2.4.0.1 → 2.4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52de171e9cba852d1551459674a12adfca8fd6166cb5e5707f3bc6a7cec9415c
-  data.tar.gz: '08807feea85b577c37153c290331c8f9c4441c2eef6c2600d630948a27b9ba5e'
+  metadata.gz: a039368aaffaee95c3d48c5b56fc30b81babafc7b996986e56c788bb12c20bc0
+  data.tar.gz: d31e08f66e605ea99209911edebbb62fce65e75c328043a9ed3e53f1eac4d80d
 SHA512:
-  metadata.gz: 6481f5588edeb5cf7e806cd9326636d14e936bee95064de49017614e999f295f9683b3cbe6346dbb4d0611753288d7b628435514fe13ff0b039723de55262db1
-  data.tar.gz: 27a33e20e068708563324db99798abf56a81b25386899e41cc4b5e15097df11e7bc61f69b1705a5a0d537ac3488c608e28c6337e6bc8d4fe6af3b2aba6e19416
+  metadata.gz: 1daffbde6948f1e8d9c8003c8ab60a3f86051c307b04a0aa3a654bdf05efd830c3148e17a555fee4cd4f52d85ed80eb6071e4df54754e5458b7e1caa1a9b2474
+  data.tar.gz: a230d09cde52cbedbc0b67ed025a7666119b5c66f7611cb730b1558aba5b77f5f50cc878e17f8d11a14d9840d0b379aeedb00d141fbde924ec30f3fe42414747

data/.github/workflows/test.yml

@@ -14,10 +14,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.6', '2.7', '3.0', '3.1']
+        ruby-version: ['2.7', '3.0', '3.1', '3.2']
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
@@ -32,6 +32,6 @@ jobs:
         run: bundle exec rspec
 
       - name: Test & publish code coverage
-        uses: paambaati/codeclimate-action@v3.0.0
+        uses: paambaati/codeclimate-action@v3.2.0
         env:
           CC_TEST_REPORTER_ID: bb96c1ff9dc66724c38fb4eb54486dd72dc88a7fd6e727c034b9cf8d747d069e

data/.rubocop.yml

@@ -1,6 +1,10 @@
+require:
+  - rubocop-rake
+  - rubocop-rspec
+
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 2.7
 
 Layout/EmptyLinesAroundAttributeAccessor:
   Enabled: true
@@ -30,6 +34,12 @@ Metrics/BlockLength:
 Metrics/MethodLength:
   Max: 15
 
+RSpec/ExampleLength:
+  Max: 10
+
+RSpec/MultipleExpectations:
+  Max: 3
+
 Style/ClassVars:
   Enabled: false
 

data/henkei.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require 'henkei/version'
 
-Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
+Gem::Specification.new do |spec|
   spec.name          = 'henkei'
   spec.version       = Henkei::VERSION
   spec.authors       = ['Erol Fornoles', 'Andrew Bromwich']
@@ -15,7 +15,7 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
                        '(.doc, .docx, .pages, .odt, .rtf, .pdf) using Apache Tika toolkit'
   spec.homepage      = 'https://github.com/abrom/henkei'
   spec.license       = 'MIT'
-  spec.required_ruby_version = ['>= 2.6.0', '< 3.2.0']
+  spec.required_ruby_version = ['>= 2.7.0', '< 3.3.0']
 
   # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
   # delete this section to allow pushing this gem to any host.
@@ -38,7 +38,6 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
   spec.add_development_dependency 'rspec', '~> 3.7'
   spec.add_development_dependency 'rubocop', '~> 1.26'
   spec.add_development_dependency 'rubocop-performance', '~> 1.13'
-  spec.add_development_dependency 'rubocop-rails', '~> 2.14'
   spec.add_development_dependency 'rubocop-rake', '~> 0.6'
   spec.add_development_dependency 'rubocop-rspec', '~> 2.9'
   spec.add_development_dependency 'simplecov', '~> 0.15', '< 0.18'

data/lib/henkei/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Henkei
-  VERSION = '2.4.0.1'
+  VERSION = '2.4.0.2'
 end

data/lib/henkei.rb

@@ -31,8 +31,8 @@ class Henkei # rubocop:disable Metrics/ClassLength
 
   def self.mimetype(content_type)
     if Henkei.configuration.mime_library == 'mime/types' && defined?(MIME::Types)
-      warn '[DEPRECATION] `mime/types` is deprecated. Please use `mini_mime` instead.'\
-           ' Use Henkei.configure and assign "mini_mime" to `mime_library`.'
+      warn '[DEPRECATION] `mime/types` is deprecated. Please use `mini_mime` instead. ' \
+           'Use Henkei.configure and assign "mini_mime" to `mime_library`.'
       MIME::Types[content_type].first
     else
       MiniMime.lookup_by_content_type(content_type).tap do |object|

data/spec/henkei_spec.rb

@@ -20,13 +20,13 @@ describe Henkei do
 
   describe '.read' do
     it 'reads text' do
-      text = Henkei.read :text, data
+      text = described_class.read :text, data
 
       expect(text).to include 'The quick brown fox jumped over the lazy cat.'
     end
 
     it 'reads metadata' do
-      metadata = Henkei.read :metadata, data
+      metadata = described_class.read :metadata, data
 
       expect(metadata['Content-Type']).to(
         eq 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'
@@ -35,13 +35,13 @@ describe Henkei do
 
     it 'reads metadata values with colons as strings' do
       data = File.read 'spec/samples/sample-metadata-values-with-colons.doc'
-      metadata = Henkei.read :metadata, data
+      metadata = described_class.read :metadata, data
 
       expect(metadata['dc:title']).to eq 'problem: test'
     end
 
     it 'reads mimetype' do
-      mimetype = Henkei.read :mimetype, data
+      mimetype = described_class.read :mimetype, data
 
       expect(mimetype.content_type).to(
         eq 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'
@@ -53,7 +53,7 @@ describe Henkei do
       let(:data) { File.read 'spec/samples/pipe-error.png' }
 
       it 'returns an empty result' do
-        text = Henkei.read :text, data
+        text = described_class.read :text, data
 
         expect(text).to eq ''
       end
@@ -61,15 +61,12 @@ describe Henkei do
       unless ci?
         context 'when `include_ocr` is enabled' do
           it 'returns parsed plain text in the image' do
-            text = Henkei.read :text, data, include_ocr: true
+            text = described_class.read :text, data, include_ocr: true
 
             expect(text).to include <<~TEXT
               West Side
 
               Sea Island
-              PP
-
-              Richmond
             TEXT
           end
         end
@@ -79,11 +76,11 @@ describe Henkei do
 
   describe '.new' do
     it 'requires parameters' do
-      expect { Henkei.new }.to raise_error ArgumentError
+      expect { described_class.new }.to raise_error ArgumentError
     end
 
     it 'accepts a root path' do
-      henkei = Henkei.new 'spec/samples/sample.pages'
+      henkei = described_class.new File.join(Henkei::GEM_PATH, 'spec/samples/sample.pages')
 
       expect(henkei).to be_path
       expect(henkei).not_to be_uri
@@ -91,7 +88,7 @@ describe Henkei do
     end
 
     it 'accepts a relative path' do
-      henkei = Henkei.new 'spec/samples/sample.pages'
+      henkei = described_class.new 'spec/samples/sample.pages'
 
       expect(henkei).to be_path
       expect(henkei).not_to be_uri
@@ -99,7 +96,7 @@ describe Henkei do
     end
 
     it 'accepts a path with spaces' do
-      henkei = Henkei.new 'spec/samples/sample filename with spaces.pages'
+      henkei = described_class.new 'spec/samples/sample filename with spaces.pages'
 
       expect(henkei).to be_path
       expect(henkei).not_to be_uri
@@ -107,7 +104,7 @@ describe Henkei do
     end
 
     it 'accepts a URI' do
-      henkei = Henkei.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx'
+      henkei = described_class.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx'
 
       expect(henkei).to be_uri
       expect(henkei).not_to be_path
@@ -116,7 +113,7 @@ describe Henkei do
 
     it 'accepts a stream or object that can be read' do
       File.open 'spec/samples/sample.pages', 'r' do |file|
-        henkei = Henkei.new file
+        henkei = described_class.new file
 
         expect(henkei).to be_stream
         expect(henkei).not_to be_path
@@ -125,38 +122,38 @@ describe Henkei do
     end
 
     it 'refuses a path to a missing file' do
-      expect { Henkei.new 'test/sample/missing.pages' }.to raise_error Errno::ENOENT
+      expect { described_class.new 'test/sample/missing.pages' }.to raise_error Errno::ENOENT
     end
 
     it 'refuses other objects' do
       [nil, 1, 1.1].each do |object|
-        expect { Henkei.new object }.to raise_error TypeError
+        expect { described_class.new object }.to raise_error TypeError
       end
     end
   end
 
   describe '.creation_date' do
-    let(:henkei) { Henkei.new 'spec/samples/sample.pages' }
+    let(:henkei) { described_class.new 'spec/samples/sample.pages' }
 
-    it 'should return Time' do
+    it 'returns a Time' do
       expect(henkei.creation_date).to be_a Time
     end
   end
 
   describe '.java' do
     specify 'with no specified JAVA_HOME' do
-      expect(Henkei.send(:java_path)).to eq 'java'
+      expect(described_class.send(:java_path)).to eq 'java'
     end
 
     specify 'with a specified JAVA_HOME' do
       ENV['JAVA_HOME'] = '/path/to/java/home'
 
-      expect(Henkei.send(:java_path)).to eq '/path/to/java/home/bin/java'
+      expect(described_class.send(:java_path)).to eq '/path/to/java/home/bin/java'
     end
   end
 
-  context 'initialized with a given path' do
-    let(:henkei) { Henkei.new 'spec/samples/sample.pages' }
+  context 'when initialized with a given path' do
+    let(:henkei) { described_class.new 'spec/samples/sample.pages' }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'The quick brown fox jumped over the lazy cat.'
@@ -167,7 +164,7 @@ describe Henkei do
     end
 
     context 'when passing in the `pipe-error.png` test file' do
-      let(:henkei) { Henkei.new 'spec/samples/pipe-error.png' }
+      let(:henkei) { described_class.new 'spec/samples/pipe-error.png' }
 
       it '#text returns an empty result' do
         expect(henkei.text).to eq ''
@@ -189,9 +186,6 @@ describe Henkei do
               West Side
 
               Sea Island
-              PP
-
-              Richmond
             TEXT
           end
 
@@ -199,7 +193,7 @@ describe Henkei do
             expect(henkei.html(include_ocr: true)).to include '<meta name="tiff:ImageWidth" content="792"/>'
 
             html_body = Nokogiri::HTML(henkei.html(include_ocr: true)).at_xpath('//body')
-            ['Anmore', 'Coquitlam', 'West Side', 'Sea Island', 'Richmond', 'Steveston'].each do |location|
+            ['West Side', 'Sea Island', 'Richmond', 'Steveston'].each do |location|
               expect(html_body.text).to include location
             end
           end
@@ -208,8 +202,8 @@ describe Henkei do
     end
   end
 
-  context 'initialized with a given URI' do
-    let(:henkei) { Henkei.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx' }
+  context 'when initialized with a given URI' do
+    let(:henkei) { described_class.new 'http://svn.apache.org/repos/asf/poi/trunk/test-data/document/sample.docx' }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'Lorem ipsum dolor sit amet, consectetuer adipiscing elit.'
@@ -222,8 +216,8 @@ describe Henkei do
     end
   end
 
-  context 'initialized with a given stream' do
-    let(:henkei) { Henkei.new File.open('spec/samples/sample.pages', 'rb') }
+  context 'when initialized with a given stream' do
+    let(:henkei) { described_class.new File.open('spec/samples/sample.pages', 'rb') }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'The quick brown fox jumped over the lazy cat.'
@@ -235,7 +229,7 @@ describe Henkei do
   end
 
   context 'when source is a remote PDF' do
-    let(:henkei) { Henkei.new 'https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf' }
+    let(:henkei) { described_class.new 'https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf' }
 
     specify '#text reads text' do
       expect(henkei.text).to include 'Dummy PDF file'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: henkei
 version: !ruby/object:Gem::Version
-  version: 2.4.0.1
+  version: 2.4.0.2
 platform: ruby
 authors:
 - Erol Fornoles
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-28 00:00:00.000000000 Z
+date: 2023-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -149,20 +149,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.13'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.14'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -259,17 +245,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 2.7.0
   - - "<"
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.4.1
 signing_key:
 specification_version: 4
 summary: Read text and metadata from files and documents (.doc, .docx, .pages, .odt,