helpstation 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6bc387017d0c37a12b74f28b96028cbe0517e32e
-  data.tar.gz: f4adbd59e1b9b9a6578b56af633f3398562d5692
+  metadata.gz: 1737e99497226875f9236ce290876304503b807a
+  data.tar.gz: 29114da9c85c49009349d9994ab7b20c5d935492
 SHA512:
-  metadata.gz: 20eebb79bc3f800b937ff246676e67ca1ca6248bb3a47d27017cbf7b1dea39d2768c815d15d7c1ba236b902f12063e8ba15400d70af696edbbf22ebe34e8804d
-  data.tar.gz: 3b17da6034095a4e9b4d7cd5127e401be16ed2392605108e5c85673f5fc9665e97f24ff57991e4cbf12f1fc33400e9e08d2687e46fd2eb0c61b8cbc9242357dc
+  metadata.gz: 14b07b8f277a40575784e773458ec32cb8896fa20f0b8da27f3c9606effdf512b46b21c47040c32fa0a372ef4ae04d3b646ed78268a40a02e68b8965f84adef7
+  data.tar.gz: 9daa6ca53aafc3e7c90467d9be96a37500d183546aaafb53a668d25a12f1a90e8ea0bbb0e91c7b1daf41fc41b6c747fa22ee0b4fd5a519e78e71a94e823b73fc

data/helpstation.gemspec

@@ -18,4 +18,5 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'substation', '~> 0.0', '>= 0.0.10'
+  spec.add_dependency 'inflecto', '~> 0.0.2'
 end

data/lib/helpstation.rb

@@ -1,4 +1,5 @@
 require 'substation'
+require 'inflecto'
 
 require_relative 'helpstation/version'
 require_relative 'helpstation/evaluator'

data/lib/helpstation/fetchers.rb

@@ -29,10 +29,10 @@ module Helpstation
     end
 
     class ActiveRecordFetcher < ByKeyFetcher
-      def self.build(*)
+      def call
         super
-      rescue ActiveRecord::NotFoundError
-        raise NotFoundError
+      rescue ActiveRecord::RecordNotFound
+        error("#{Inflecto.humanize(output_key)} ##{input[input_key]} not found")
       end
     end
   end

data/lib/helpstation/version.rb

@@ -1,3 +1,3 @@
 module Helpstation
-  VERSION = '0.1.5'
+  VERSION = '0.1.6'
 end

data/spec/helpstation/fetchers/active_record_fetcher_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe Helpstation::Fetchers::ActiveRecordFetcher do
+  subject(:response) { processor.call(Substation::Request.new('my_request', env, input)) }
+
+  let(:env) { { mock_service: :mock_value } }
+  let(:input_key) { :my_input }
+  let(:output_key) { :my_output }
+
+  context 'when record is present' do
+    let(:processor) {
+      described_class.build(input_key, output_key) do |key, env|
+        record
+      end
+    }
+    let(:record) { double }
+    let(:input) { { my_input: input_key } }
+
+    it 'returns the record' do
+      expect(response).to be_a(Substation::Response::Success)
+      expect(response.output).to eq(
+        my_input: input[:my_input],
+        my_output: record
+      )
+    end
+  end
+
+  context 'when record is not found' do
+    # Helpstation does not have AR depndencies, so we mock them out
+    module ActiveRecord
+    end
+
+    class ActiveRecord::RecordNotFound < Exception
+    end
+
+    let(:processor) {
+      described_class.build(input_key, output_key) do |key, env|
+        raise ActiveRecord::RecordNotFound.new "No record"
+      end
+    }
+    let(:input) { { my_input: 'input_key' } }
+
+    it 'returns error response' do
+      expect(response).to be_a(Substation::Response::Failure)
+      expect(response.output).to eq(
+        success: false,
+        error: "My output #input_key not found"
+      )
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: helpstation
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Indrek Juhkam
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-15 00:00:00.000000000 Z
+date: 2016-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: substation
@@ -30,6 +30,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.10
+- !ruby/object:Gem::Dependency
+  name: inflecto
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.2
 description: Helps to unify SaleMove services
 email:
 - indrek@salemove.com
@@ -58,6 +72,7 @@ files:
 - lib/helpstation/renderer.rb
 - lib/helpstation/version.rb
 - spec/helpstation/evaluator_spec.rb
+- spec/helpstation/fetchers/active_record_fetcher_spec.rb
 - spec/helpstation/fetchers/by_key_fetcher_spec.rb
 - spec/helpstation/processors/parallel_processor_spec.rb
 - spec/spec_helper.rb
@@ -87,6 +102,7 @@ specification_version: 4
 summary: ''
 test_files:
 - spec/helpstation/evaluator_spec.rb
+- spec/helpstation/fetchers/active_record_fetcher_spec.rb
 - spec/helpstation/fetchers/by_key_fetcher_spec.rb
 - spec/helpstation/processors/parallel_processor_spec.rb
 - spec/spec_helper.rb