helpstation 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 81341cf8e7e321080c55620575ae4a25cb076ab3
-  data.tar.gz: ae67dc37c863c5c771bd67caf5b95e857c573477
+  metadata.gz: 6bc387017d0c37a12b74f28b96028cbe0517e32e
+  data.tar.gz: f4adbd59e1b9b9a6578b56af633f3398562d5692
 SHA512:
-  metadata.gz: 804aa898d1b18fc6e9fc78d9e9e481318c44afe73ed7123f141fe5cb72d49d6896d0a108b24e2e3739e263218ef614b4372120c5cbd5ff5e377d87709f2cd734
-  data.tar.gz: 9879d023e41c03661a79aee77727da624dc77036185bb87d7ef65fa8952ddc2c5831986dd5b0536f4b0e87a7fdbecc523fc199edb207c494aa10b80349370d4a
+  metadata.gz: 20eebb79bc3f800b937ff246676e67ca1ca6248bb3a47d27017cbf7b1dea39d2768c815d15d7c1ba236b902f12063e8ba15400d70af696edbbf22ebe34e8804d
+  data.tar.gz: 3b17da6034095a4e9b4d7cd5127e401be16ed2392605108e5c85673f5fc9665e97f24ff57991e4cbf12f1fc33400e9e08d2687e46fd2eb0c61b8cbc9242357dc

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 2.2.3
+before_script:
+  - bundle
+script: bundle exec rspec
+sudo: false

data/lib/helpstation.rb

@@ -7,7 +7,9 @@ require_relative 'helpstation/action'
 require_relative 'helpstation/observer'
 require_relative 'helpstation/renderer'
 require_relative 'helpstation/legacy_process'
+
 require_relative 'helpstation/fetchers'
+require_relative 'helpstation/processors'
 
 module Helpstation
   def self.build_substation(env)

data/lib/helpstation/evaluator.rb

@@ -29,8 +29,8 @@ module Helpstation
     attr_reader :env
     attr_reader :input
 
-    def error(data)
-      @request.error(success: false, error: data)
+    def error(error, extra = {})
+      @request.error({success: false, error: error}.merge(extra))
     end
   end
 end

data/lib/helpstation/processors.rb

@@ -0,0 +1,47 @@
+module Helpstation
+  module Processors
+    # Helps to run processors in parallel
+    #
+    # All output from the processors are merged and then returned. This means
+    # that if two fetchers return results with the same key then one will
+    # overwrite the other.
+    #
+    # @example
+    #   process ParallelProcessor[
+    #     OperatorFetcher,
+    #     VisitorFetcher
+    #   ], NOT_FOUND_ERROR
+    #
+    class ParallelProcessor < Processor
+      def self.[](*processors)
+        new(processors)
+      end
+
+      def initialize(processors)
+        @processors = processors
+      end
+
+      def call(request)
+        results = process_parallel(request)
+
+        if first_failure = results.detect {|result| !result.success?}
+          first_failure
+        else
+          request.success(results.reduce(request.input, &method(:compose)))
+        end
+      end
+
+      private
+
+      def process_parallel(request)
+        @processors.map do |processor|
+          Thread.new { processor.call(request) }
+        end.map(&:join).map(&:value)
+      end
+
+      def compose(input, result)
+        input.merge(result.output)
+      end
+    end
+  end
+end

data/lib/helpstation/version.rb

@@ -1,3 +1,3 @@
 module Helpstation
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/spec/helpstation/evaluator_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe Helpstation::Evaluator do
+  subject { target_class.call(request) }
+
+  let(:request) { Substation::Request.new(:name, {}, {}) }
+
+  describe '#error' do
+    let(:target_class) do
+      Class.new(described_class) do
+        def call
+          error('ERROR', message: 'a message')
+        end
+      end
+    end
+
+    it 'returns an error response' do
+      should be_a(Substation::Response::Failure)
+    end
+
+    it 'returns status' do
+      expect(subject.output).to eq(
+        success: false, error: 'ERROR', message: 'a message'
+      )
+    end
+  end
+end

data/spec/helpstation/processors/parallel_processor_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+
+describe Helpstation::Processors::ParallelProcessor do
+  subject { processor.call(request) }
+
+  let(:processor) { described_class[processor1, processor2] }
+
+  let(:processor1) do
+    Proc.new do |request|
+      sleep 0.1
+      request.success(request.input.merge(processor1: 'obj'))
+    end
+  end
+
+  let(:request) { Substation::Request.new(:name, {}, input) }
+  let(:input) { {initial: 'obj'} }
+
+  context 'when successful' do
+    let(:processor2) do
+      Proc.new do |request|
+        sleep 0.1
+        request.success(request.input.merge(processor2: 'obj'))
+      end
+    end
+
+    it 'runs in parallel' do
+      expect {
+        subject
+      }.to change(Time, :now).by_at_most(0.12)
+    end
+
+    it 'merges the results' do
+      should be_a(Substation::Response::Success)
+      expect(subject.output).to eq(
+        initial: 'obj',
+        processor1: 'obj',
+        processor2: 'obj'
+      )
+    end
+  end
+
+  context 'when one processor fails' do
+    let(:processor2) do
+      Proc.new do |request|
+        sleep 0.1
+        request.error(no: 'way')
+      end
+    end
+
+    it 'returns the error response' do
+      should be_a(Substation::Response::Failure)
+      expect(subject.output).to eq(no: 'way')
+    end
+  end
+
+  context 'when one process has an exception' do
+    let(:processor2) do
+      Proc.new do |request|
+        sleep 0.1
+        this_throws_an_exception
+        request.success(processor2: 'obj')
+      end
+    end
+
+    it 'throws the exception' do
+      expect {
+        subject
+      }.to raise_error(NameError)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: helpstation
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Indrek Juhkam
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-18 00:00:00.000000000 Z
+date: 2015-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: substation
@@ -41,6 +41,7 @@ files:
 - ".rspec"
 - ".ruby-gemset"
 - ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -53,9 +54,12 @@ files:
 - lib/helpstation/legacy_process.rb
 - lib/helpstation/observer.rb
 - lib/helpstation/processor.rb
+- lib/helpstation/processors.rb
 - lib/helpstation/renderer.rb
 - lib/helpstation/version.rb
-- spec/helpstation/processors/by_key_fetcher_spec.rb
+- spec/helpstation/evaluator_spec.rb
+- spec/helpstation/fetchers/by_key_fetcher_spec.rb
+- spec/helpstation/processors/parallel_processor_spec.rb
 - spec/spec_helper.rb
 homepage: ''
 licenses:
@@ -82,5 +86,7 @@ signing_key:
 specification_version: 4
 summary: ''
 test_files:
-- spec/helpstation/processors/by_key_fetcher_spec.rb
+- spec/helpstation/evaluator_spec.rb
+- spec/helpstation/fetchers/by_key_fetcher_spec.rb
+- spec/helpstation/processors/parallel_processor_spec.rb
 - spec/spec_helper.rb