help_scout 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb7ba581aa0fce9aca9b69f34bd45d003a832095
-  data.tar.gz: 16e098e8579676e7b127b21e1f0bf38740b02ed6
+  metadata.gz: 81382f7b709606575977992773cbf146b9063a6f
+  data.tar.gz: 9d50c47b51f8beff738cc166ff0f41b66aea5cee
 SHA512:
-  metadata.gz: d47b06f95c503e9537b8578d9774d3d9e05489605ed31cf609730a6febe9c4557a1ebc328cc92c189e45da5d50baacae168481873c8cd8a698a2a2d42cb2475e
-  data.tar.gz: 0a43fa20e176e2e3323c596d3caf1f9f501deaeafd944f2cc6ad3e80eca300c79ac91d4c80f8613e39d67ea75ee7c73d2de475728066a805f7b4cce4ab7a1069
+  metadata.gz: 4c0d08c3dc4e5a25f98b022419c612b92e9008b8ba0fd0649f539dc153982a7b2a6a9a14336e6cade5215226ff34d35ac66dec7c62200c23b07b48da852555db
+  data.tar.gz: 4436eeb10dbb398874b2fa89dd34b7e01fdeeab4f4684e30582dddf4d8820d53925426758f4285316702382ee0c2e62060b4a6feae01342cda47bc6b28cb7256

data/lib/help_scout.rb

@@ -5,7 +5,11 @@ class HelpScout
   class ValidationError < StandardError; end
   class NotImplementedError < StandardError; end
 
+  # Status codes used by Help Scout, not all are implemented in this gem yet.
+  # http://developer.helpscout.net/help-desk-api/status-codes/
+  HTTP_OK = 200
   HTTP_CREATED = 201
+  HTTP_NO_CONTENT = 204
   HTTP_BAD_REQUEST = 400
 
   attr_accessor :last_response
@@ -24,16 +28,9 @@ class HelpScout
   def create_conversation(data)
     post("conversations", { body: data })
 
-    if last_response.code == HTTP_CREATED
-      # Extract ID of created conversation from the Location header
-      conversation_uri = last_response.headers["location"]
-      return conversation_uri.match(/(\d+)\.json$/)[1]
-    elsif last_response.code == HTTP_BAD_REQUEST
-      # Validation failed so return the errors
-      raise ValidationError, last_response.parsed_response["message"]
-    else
-      raise NotImplementedError, "Help Scout returned something that is not implemented by the help_scout gem yet: #{last_response.code}: #{last_response.parsed_response["message"] if last_response.parsed_response}"
-    end
+    # Extract ID of created conversation from the Location header
+    conversation_uri = last_response.headers["location"]
+    conversation_uri.match(/(\d+)\.json$/)[1]
   end
 
   # Public: Get conversation
@@ -195,6 +192,14 @@ class HelpScout
     }.merge(options)
 
     @last_response = HTTParty.send(method, uri, options)
-    @last_response.parsed_response
+
+    case @last_response.code
+    when HTTP_OK, HTTP_CREATED, HTTP_NO_CONTENT
+      @last_response.parsed_response
+    when HTTP_BAD_REQUEST
+      raise ValidationError, last_response.parsed_response["message"]
+    else
+      raise NotImplementedError, "Help Scout returned something that is not implemented by the help_scout gem yet: #{@last_response.code}: #{@last_response.parsed_response["message"] if @last_response.parsed_response}"
+    end
   end
 end

data/lib/help_scout/version.rb

@@ -1,3 +1,3 @@
 class HelpScout
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: help_scout
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Dennis Paagman
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-25 00:00:00.000000000 Z
+date: 2017-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty