helm_upgrade_logs 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5413c44c5fabf6be263e3a827492c64fe16e3551f50c95d12d645a2b77a4fc1b
-  data.tar.gz: 6819b933e6b024192bc105b63e043797b40e65574e489059b89485c21c813ca4
+  metadata.gz: c152efac3e0107333fb8a9101cb06f9eede40e5bfeb747b3815e3aca8a0d02b7
+  data.tar.gz: c6ef07655615775aebbe6bb347873905b9d5a43dc5a1ef3fcbfbfeaeb28c2d77
 SHA512:
-  metadata.gz: a85680b3534a9be3dae6b6cd639ab301343566da90a5aaa902e8804a33eec500b3eea3668f9084e866c3dcd88bc2d7227cb8cbecc1c7277bd1b0adc304cae2be
-  data.tar.gz: 6a27d029fd165bbefd3e94f28f45959f6054b421d0264f866f86191512ab02187889ebc0281d6bd791cc4c2ebfb4db722e7f36677372ce53ccadc9ad33cb4e3f
+  metadata.gz: 8aa9f87875f45d174c337314988546e66d4af1bcb279b471a278eb7d826d4eb21362a9a060466abb7e86e27a9902cb9778593f7102e4fbbd82103a72686e68ed
+  data.tar.gz: 2dc02dc6e520c3997957885f68d180a88889132fbf74e3f4f8f01331b92cf3f6ee382c7e98da87557bde798e2854db7eaa5b28ff25c6670c41a7606fc2b94bdb

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.3.3]
+
+- Run force kill on processes to ensure they stop
+
 ## [0.3.2]
 
 - ADO error and normal error don't need to both be displayed

data/exe/helm_upgrade_logs

@@ -26,8 +26,8 @@ wait_for_pod_to_log
 begin
   Process.waitpid(@helm_pid, Process::WNOHANG)
 rescue Errno::ECHILD
-  `kill #{event_pid}`
-  `kill #{service_pid}`
+  Process.kill("KILL", event_pid)
+  Process.kill("KILL", service_pid)
   raise HelmUpgradeLogs::Error, "Failed to find logs before helm finished"
 end
 
@@ -56,13 +56,14 @@ while Process.waitpid(@helm_pid, Process::WNOHANG).nil?
   end
   sleep 1
 end
+puts "[INFO] Cleaning up loggers after helm upgrade"
 helm_status = $CHILD_STATUS.exitstatus
-`kill #{event_pid}`
-`kill #{service_pid}`
+Process.kill("KILL", event_pid)
+Process.kill("KILL", service_pid)
 puts @pod_pids if ENV["helm_upgrade_logs_debug"] == "true"
 @pod_pids.each do |_pod, pid|
   puts "Terminating #{_pod} #{pid}" if ENV["helm_upgrade_logs_debug"] == "true"
-  `kill #{pid}`
+  Process.kill("KILL", pid)
 end
 
 if ENV["helm_upgrade_logs_error_msg"]

data/lib/helm_upgrade_logs/version.rb

@@ -2,5 +2,5 @@
 
 module HelmUpgradeLogs
   # @return [String] Version of helm upgrade logs
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: helm_upgrade_logs
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Samuel Garratt