hellosign-ruby-sdk 3.6.1 → 3.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9a8ba883a4aa8b3dc4bbefcd44233f4a5ced8219
-  data.tar.gz: 4dd9fd6acdf226d24d85a9cbad67d5ab0fef64a2
+  metadata.gz: b11317ed4e1e95a527c5d32b78a4cc062a4a91e6
+  data.tar.gz: 4ac3eda0924a480bfa5084de4e16e92dd5f5389d
 SHA512:
-  metadata.gz: 6c80dd7943e1ed648a7ade44e4d515bf69db9fd27ecbfb92f8a761634f3e957fae7c3ba6f592558ad65b342f9e038d7b3e03e7a8e742495fc767dfbb7c5e41d3
-  data.tar.gz: adc12154ca8a5faa84ade9bf9644ead026e03ef7db3b9e6e9b65995d90b0e6ac96eb1a889db411e000df902316b0006aace883ad7d004dbc52974fa5dcdde045
+  metadata.gz: f5a6cb919a182c40c9e2a5cf94d7d1afa0d1a80eaa7496bef9e54a14b2e109c3ec52c1b43b7a9ee2e93ce4c4780c89578b0268075596bec0bd8ac4e578c0f4e1
+  data.tar.gz: 4413a6ff196d6f2b11d28c25290a9d0003e65d761a4a7c6c74daa607369bf5e1a380c5be8de4a57f35cdde4ff7c38b3d79817bf93b4f83ba4be3279569e86d4f

data/lib/hello_sign/client.rb

@@ -178,10 +178,10 @@ module HelloSign
     def validate(response)
       if response.status >= 400
         error_class = ERRORS[response.status] || HelloSign::Error::UnknownError
-        error = error_class.new
-        error.response_status = response.status
-        error.response_body = response.body
-        error.request_uri = response.to_hash[:url].to_s
+        error = error_class.new(response.status, response.body, response.to_hash[:url].to_s)
+        # error.response_status = response.status
+        # error.response_body = response.body
+        # error.request_uri = response.to_hash[:url].to_s
         raise error
       end
     end

data/lib/hello_sign/error.rb

@@ -26,19 +26,20 @@ module HelloSign
   module Error
     # Custom error class for rescuing from all HelloSign errors.
     class Error < StandardError;
-      attr_accessor :request_uri
-      attr_accessor :response_body
-      attr_accessor :response_status
+      attr_accessor :request_uri, :response_body, :response_status
 
-      def initialize(message = nil)
-        super(message || human_readable_message)
+      def initialize(response_status, response_body = nil, request_uri)
+        @request_uri = request_uri
+        @response_body = response_body
+        @response_status = response_status
+        super(human_readable_message)
       end
 
       private
       def human_readable_message
-        "Server responded with code #{response_status}\n" \
-          "Request URI: #{request_uri}\n"\
-          "Message: #{response_body}"
+        "Server responded with code #{@response_status}\n" \
+          "Request URI: #{@request_uri}\n"\
+          "Message: #{@response_body}"
       end
     end
 

data/lib/hello_sign/version.rb

@@ -23,5 +23,5 @@
 #
 
 module HelloSign
-  VERSION = '3.6.1'
+  VERSION = '3.6.2'
 end

data/spec/hello_sign/error_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 describe HelloSign::Error do
   # another test to prove backwards compatibility
-  describe 'custom error message' do
-    subject { HelloSign::Error::Error.new('Foo').message }
-    it { is_expected.to eql('Foo') }
+  it 'raises an error with any message' do
+    error = HelloSign::Error::Error.new(404, 'test error message', 'http://www.test.com')
+    expect(error).to be_instance_of(HelloSign::Error::Error)
   end
-end
 
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hellosign-ruby-sdk
 version: !ruby/object:Gem::Version
-  version: 3.6.1
+  version: 3.6.2
 platform: ruby
 authors:
 - HelloSign
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-13 00:00:00.000000000 Z
+date: 2018-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler