hellosign-ruby-sdk 3.0.3 → 3.0.4

data/spec/hello_sign/api/unclaimed_draft_spec.rb

@@ -1,33 +1,33 @@
 require 'spec_helper'
 
 describe HelloSign::Api::UnclaimedDraft do
-  describe "#create_unclaimed_draft" do
-    context "send_document" do
+  describe '#create_unclaimed_draft' do
+    context 'send_document' do
       before do
-        stub_post("/unclaimed_draft/create", 'unclaimed_draft')
-        @unclaimed_draft = HelloSign.create_unclaimed_draft({:type => 'send_document'})
+        stub_post('/unclaimed_draft/create', 'unclaimed_draft')
+        @unclaimed_draft = HelloSign.create_unclaimed_draft({ :type => 'send_document' })
       end
 
-      it "should get the correct resource" do
-        expect(a_post("/unclaimed_draft/create")).to have_been_made
+      it 'should get the correct resource' do
+        expect(a_post('/unclaimed_draft/create')).to have_been_made
       end
 
-      it "should return a UnclaimedDraft" do
+      it 'should return a UnclaimedDraft' do
         expect(@unclaimed_draft).to be_an HelloSign::Resource::UnclaimedDraft
       end
     end
 
-    context "request_signature" do
+    context 'request_signature' do
       before do
-        stub_post("/unclaimed_draft/create", 'unclaimed_draft')
-        @unclaimed_draft = HelloSign.create_unclaimed_draft({:type => 'request_signature'})
+        stub_post('/unclaimed_draft/create', 'unclaimed_draft')
+        @unclaimed_draft = HelloSign.create_unclaimed_draft({ :type => 'request_signature' })
       end
 
-      it "should get the correct resource" do
-        expect(a_post("/unclaimed_draft/create")).to have_been_made
+      it 'should get the correct resource' do
+        expect(a_post('/unclaimed_draft/create')).to have_been_made
       end
 
-      it "should return a UnclaimedDraft" do
+      it 'should return a UnclaimedDraft' do
         expect(@unclaimed_draft).to be_an HelloSign::Resource::UnclaimedDraft
       end
     end

data/spec/hello_sign/client_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
 describe HelloSign::Client do
-  describe "#initialize" do
-    context "with default values" do
-      subject(:client){HelloSign::Client.new}
+  describe '#initialize' do
+    context 'with default values' do
+      subject(:client) { HelloSign::Client.new }
       HelloSign::Configuration::VALID_OPTIONS_KEYS.each do |key|
         it "should set #{key}" do
           expect(client.send(key)).to eql(HelloSign.send(key))
@@ -11,24 +11,24 @@ describe HelloSign::Client do
       end
     end
 
-    context "with custom values" do
+    context 'with custom values' do
       let(:custom_client){
         {
-          :email_address => "email_address",
-          :password => "password",
-          :api_key => "api_key",
-          :user_agent => "user_agent",
-          :end_point => "end_point",
-          :oauth_end_point => "oauth_end_point",
-          :api_version => "api_version",
-          :client_id => "client_id",
-          :client_secret => "client_secret",
-          :auth_token => "auth_token",
+          :email_address => 'email_address',
+          :password => 'password',
+          :api_key => 'api_key',
+          :user_agent => 'user_agent',
+          :end_point => 'end_point',
+          :oauth_end_point => 'oauth_end_point',
+          :api_version => 'api_version',
+          :client_id => 'client_id',
+          :client_secret => 'client_secret',
+          :auth_token => 'auth_token',
           :log_level => 5,
           :logging => false
         }
       }
-      subject(:client){ HelloSign::Client.new custom_client}
+      subject(:client) { HelloSign::Client.new custom_client }
       HelloSign::Configuration::VALID_OPTIONS_KEYS.each do |key|
         it "should set #{key}" do
           expect(client.send(key)).to eql(custom_client[key])
@@ -37,19 +37,18 @@ describe HelloSign::Client do
     end
   end
 
-  describe "#request" do
-    context "when response status >= 400" do
+  describe '#request' do
+    context 'when response status >= 400' do
       HelloSign::Client::ERRORS.keys.each do |key|
         it "raise #{HelloSign::Client::ERRORS[key].to_s} when response status #{key}" do
-
           # raise when post
-          stub_post("/account/create", 'error', key)
+          stub_post('/account/create', 'error', key)
           expect {
-            HelloSign.create_account :email_address => "test@example.com", :password => "password"
+            HelloSign.create_account :email_address => 'test@example.com', :password => 'password'
           }.to raise_error(HelloSign::Client::ERRORS[key])
 
           # raise when get
-          stub_get("/account", 'error', key)
+          stub_get('/account', 'error', key)
           expect {
             HelloSign.get_account
           }.to raise_error(HelloSign::Client::ERRORS[key])
@@ -58,73 +57,73 @@ describe HelloSign::Client do
     end
   end
 
-  describe "prepare" do
-    context "signers" do
-      describe "is an array" do
+  describe 'prepare' do
+    context 'signers' do
+      describe 'is an array' do
         before do
-          stub_post("/signature_request/send", 'signature_request')
+          stub_post('/signature_request/send', 'signature_request')
         end
 
-        it "work correctly" do
-          expect(lambda{HelloSign.send_signature_request(
-            :files_url => ["http://hellosign.com/test.pdf"],
-            :signers => ["sss"]
-          )}).not_to raise_error
+        it 'work correctly' do
+          expect(lambda{ HelloSign.send_signature_request(
+            :files_url => ['http://hellosign.com/test.pdf'],
+            :signers => ['sss']
+          ) }).not_to raise_error
         end
       end
 
-      describe "is an Hash" do
+      describe 'is an Hash' do
         before do
-          stub_post("/signature_request/send", 'signature_request')
+          stub_post('/signature_request/send', 'signature_request')
         end
 
-        it "work correctly" do
-          expect(lambda{HelloSign.send_signature_request(
-            :files_url => ["http://hellosign.com/test.pdf"],
+        it 'work correctly' do
+          expect(lambda{ HelloSign.send_signature_request(
+            :files_url => ['http://hellosign.com/test.pdf'],
             :signers => [{
               :email_address => 'jack@example.com',
               :name => 'Jack',
               :order => 0
-            },{
+            }, {
               :email_address => 'jill@example.com',
               :name => 'Jill',
               :order => 1
             }]
-          )}).not_to raise_error
+          ) }).not_to raise_error
         end
       end
     end
 
-    context "ccs" do
-      describe "is an array" do
+    context 'ccs' do
+      describe 'is an array' do
         before do
-          stub_post("/signature_request/send_with_template", 'signature_request')
+          stub_post('/signature_request/send_with_template', 'signature_request')
         end
 
-        it "work correctly" do
-          expect(lambda{HelloSign.send_signature_request_with_template(
-            :ccs => ["sss"]
-          )}).not_to raise_error
+        it 'work correctly' do
+          expect(lambda{ HelloSign.send_signature_request_with_template(
+            :ccs => ['sss']
+          ) }).not_to raise_error
         end
       end
 
-      describe "is an Hash" do
+      describe 'is an Hash' do
         before do
-          stub_post("/signature_request/send_with_template", 'signature_request')
+          stub_post('/signature_request/send_with_template', 'signature_request')
         end
 
-        it "work correctly" do
-          expect(lambda{HelloSign.send_signature_request_with_template(
+        it 'work correctly' do
+          expect(lambda{ HelloSign.send_signature_request_with_template(
             :ccs => [{
               :email_address => 'jack@example.com',
               :name => 'Jack',
               :role => 'Manager'
-            },{
+            }, {
               :email_address => 'jill@example.com',
               :name => 'Jill',
-              :role => "Client"
+              :role => 'Client'
             }]
-          )}).not_to raise_error
+          ) }).not_to raise_error
         end
       end
     end

data/spec/hello_sign/resource/base_resource_spec.rb

@@ -1,20 +1,22 @@
 require 'spec_helper'
 
 describe HelloSign::Resource::BaseResource do
-  let(:data){{
-        :a => :a1,
-        :b => :b1,
-        :c => { :c1 => :c2},
-        :d => [ :d1, :d2, :d3],
-        :e => [ {:e1 => :e11}, {:e2 => :e21}, {:e3 => :e31}]
-      }}
-
-  describe "methods" do
-    subject(:resource) {HelloSign::Resource::BaseResource.new data }
+  let(:data){
+    {
+      :a => :a1,
+      :b => :b1,
+      :c => { :c1 => :c2 },
+      :d => [:d1, :d2, :d3],
+      :e => [{ :e1 => :e11 }, { :e2 => :e21 }, { :e3 => :e31 }]
+    }
+  }
+
+  describe 'methods' do
+    subject(:resource) { HelloSign::Resource::BaseResource.new data }
 
     it 'can access attributes by calling method with the same name' do
       data.keys.each do |key|
-        expect(resource.send key).not_to be_empty
+        expect(resource.send key).not_to be_nil
       end
     end
 
@@ -32,17 +34,17 @@ describe HelloSign::Resource::BaseResource do
     end
   end
 
-  describe "#initialize" do
+  describe '#initialize' do
     context 'without key params' do
-      subject(:resource) {HelloSign::Resource::BaseResource.new data }
-      it "have correct data" do
+      subject(:resource) { HelloSign::Resource::BaseResource.new data }
+      it 'have correct data' do
         expect(resource.data).to eql(data)
       end
     end
 
     context 'without key params' do
-      subject(:resource) {HelloSign::Resource::BaseResource.new data, :e }
-      it "have correct data" do
+      subject(:resource) { HelloSign::Resource::BaseResource.new data, :e }
+      it 'have correct data' do
         expect(resource.data).to eql(data[:e])
       end
     end

data/spec/hello_sign_spec.rb

@@ -3,13 +3,13 @@ require 'spec_helper'
 describe HelloSign do
   after { HelloSign.reset }
 
-  describe ".client" do
-    it "should be a HelloSign::Client" do
+  describe '.client' do
+    it 'should be a HelloSign::Client' do
       expect(HelloSign.client).to be_a(HelloSign::Client)
     end
   end
 
-  describe ".configure" do
+  describe '.configure' do
     HelloSign::Configuration::VALID_OPTIONS_KEYS.each do |key|
       it "should set #{key}" do
         HelloSign.configure do |config|
@@ -20,15 +20,15 @@ describe HelloSign do
     end
   end
 
-  describe ".user_agent=" do
-    it "should set user_agent" do
+  describe '.user_agent=' do
+    it 'should set user_agent' do
       HelloSign.user_agent = 'Custom User Agent'
       expect(HelloSign.user_agent).to eql('Custom User Agent')
     end
   end
 
-  describe ".user_agent" do
-    it "should return default user_agent" do
+  describe '.user_agent' do
+    it 'should return default user_agent' do
       expect(HelloSign.user_agent).to eql(HelloSign::Configuration::DEFAULT_USER_AGENT)
     end
   end

data/spec/spec_helper.rb

@@ -17,7 +17,6 @@ RSpec.configure do |config|
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hellosign-ruby-sdk
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-10 00:00:00.000000000 Z
+date: 2014-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -187,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.23.2
 signing_key: 
 specification_version: 3
 summary: A Ruby SDK for the HelloSign API.