hellosign-ruby-sdk 3.0.15 → 3.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43c04f0a7b07bda2843fc33ab81fcf426deb0fc4
-  data.tar.gz: 3061262a5c8aa84d8f28b462b37d318b32c6b07d
+  metadata.gz: c29c5c406e64b9107354cfbdfec42409d62a7d16
+  data.tar.gz: 40a9c8b0f5125cadf55539a8838efb3ee0eb74cd
 SHA512:
-  metadata.gz: 8029438438f571a6835f9e7fba105c5358c6dda47f6a71c54571e32e97d206f6aabd528d177812119becf632378088ce790c83be0ff1c5610ba09a6e4634f6da
-  data.tar.gz: 69d32f61077e1db6197c335a5f86bad066a1f991ad71f3ccb9d8f9556b105a36bdfa6f35f231e85f9a6f0cd7f3aeab546e714cd0651428b4ac0bb045ba0b06ba
+  metadata.gz: 05d7aa6a7e6a6210f584219ccf41ed79e3d62a9ff55c55b52c9400239923f707c2c4b6440f3ba4cab42c5d3d32be2e9693b960e89f6ea6aaea9db8a4a53c9e3d
+  data.tar.gz: 6ba06909c1a19f0326e7b020699307722b24839e3e459e395d4425981d1bd3f819877fa86a92b34a2e049fec505e6978d9bd840184f011f4782f1179a39b4958

data/lib/hello_sign/api/signature_request.rb

@@ -1,8 +1,8 @@
 #
 # The MIT License (MIT)
-# 
+#
 # Copyright (C) 2014 hellosign.com
-# 
+#
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
 # in the Software without restriction, including without limitation the rights
@@ -59,6 +59,7 @@ module HelloSign
       def get_signature_requests(opts={})
         path = '/signature_request/list'
         path += opts[:page] ? "?page=#{opts[:page]}" : ''
+        path += opts[:page_size] ? "&page_size=#{opts[:page_size]}" : ''
         HelloSign::Resource::ResourceArray.new get(path, opts), 'signature_requests',  HelloSign::Resource::SignatureRequest
       end
 

data/lib/hello_sign/api/template.rb

@@ -1,8 +1,8 @@
 #
 # The MIT License (MIT)
-# 
+#
 # Copyright (C) 2014 hellosign.com
-# 
+#
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
 # in the Software without restriction, including without limitation the rights
@@ -70,6 +70,7 @@ module HelloSign
       def get_templates(opts={})
         path = '/template/list'
         path += opts[:page] ? "?page=#{opts[:page]}" : ''
+        path += opts[:page_size] ? "&page_size=#{opts[:page_size]}" : ''
         HelloSign::Resource::ResourceArray.new get(path, opts), 'templates', HelloSign::Resource::Template
       end
 

data/lib/hello_sign/client.rb

@@ -166,7 +166,8 @@ module HelloSign
 
     def validate(response)
       if response.status >= 400
-        raise ERRORS[response.status].new error_message(response)
+        error_class = ERRORS[response.status] || HelloSign::Error::UnknownError
+        raise error_class.new error_message(response)
       end
     end
 

data/lib/hello_sign/error.rb

@@ -71,5 +71,8 @@ module HelloSign
 
     # Raised when API endpoint returns the HTTP status code 503.
     class NotSupportedType < Error; end
+
+    # Raised when API endpoint returns error which is not defined in sdk.
+    class UnknownError < Error; end
   end
 end

data/lib/hello_sign/version.rb

@@ -23,5 +23,5 @@
 #
 
 module HelloSign
-  VERSION = '3.0.15'
+  VERSION = '3.0.17'
 end

data/spec/hello_sign/api/oauth_spec.rb

@@ -17,7 +17,7 @@ describe HelloSign::Api::Account do
   describe '#refresh_oauth_token' do
     before do
       stub_post_oauth('/oauth/token', 'token')
-      @oauth_info = HelloSign.refresh_oauth_token 'oauth_token'
+      @oauth_info = HelloSign.refresh_oauth_token refresh_token: 'oauth_token'
     end
 
     it 'should get the correct resource' do

data/spec/hello_sign/client_spec.rb

@@ -38,23 +38,37 @@ describe HelloSign::Client do
   end
 
   describe '#request' do
-    context 'when response status >= 400' do
-      HelloSign::Client::ERRORS.keys.each do |key|
-        it "raise #{HelloSign::Client::ERRORS[key].to_s} when response status #{key}" do
-          # raise when post
-          stub_post('/account/create', 'error', key)
-          expect {
-            HelloSign.create_account :email_address => 'test@example.com'
-          }.to raise_error(HelloSign::Client::ERRORS[key])
-
-          # raise when get
-          stub_get('/account', 'error', key)
-          expect {
-            HelloSign.get_account
-          }.to raise_error(HelloSign::Client::ERRORS[key])
+    def post_request(key)
+      stub_post('/account/create', 'error', key)
+      HelloSign.create_account :email_address => 'test@example.com', :password => 'password'
+    end
+
+    def get_request(key)
+      stub_get('/account', 'error', key)
+      HelloSign.get_account
+    end
+
+    HelloSign::Client::ERRORS.keys.each do |key|
+      context "when response status #{key}" do
+        it "raise #{HelloSign::Client::ERRORS[key].to_s} on post" do
+          expect { post_request(key) }.to raise_error(HelloSign::Client::ERRORS[key])
+        end
+
+        it "raise #{HelloSign::Client::ERRORS[key].to_s} on get" do
+          expect { get_request(key) }.to raise_error(HelloSign::Client::ERRORS[key])
         end
       end
     end
+
+    context 'when response status not listed' do
+      it 'raise UnknownError for post' do
+        expect { post_request(504) }.to raise_error(HelloSign::Error::UnknownError)
+      end
+
+      it 'raise UnknownError for get' do
+        expect { get_request(504) }.to raise_error(HelloSign::Error::UnknownError)
+      end
+    end
   end
 
   describe 'prepare' do

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: hellosign-ruby-sdk
 version: !ruby/object:Gem::Version
-  version: 3.0.15
+  version: 3.0.17
 platform: ruby
 authors:
 - HelloSign
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-01 00:00:00.000000000 Z
+date: 2015-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: ''
@@ -100,9 +100,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .travis.yml
 - Gemfile
 - Guardfile
 - LICENSE
@@ -166,17 +166,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: A Ruby SDK for the HelloSign API.