hello_sign 0.6.0 → 1.0.0

data/spec/unit/proxy/signature_request_spec.rb

@@ -5,9 +5,15 @@ describe HelloSign::Proxy::SignatureRequest do
   let(:client)       { double('client') }
   let(:request_id)   { 'request_id' }
   let(:api_response) { double('API response') }
-  subject(:sr_proxy) { HelloSign::Proxy::SignatureRequest.new(client) }
+  subject(:sr_proxy) { HelloSign::Proxy::SignatureRequest.new(client, request_id) }
 
-  its(:client) { should eq client }
+  before do
+    client.stub(:get).and_return(api_response)
+    client.stub(:post).and_return(api_response)
+  end
+
+  its(:client)     { should eq client }
+  its(:request_id) { should eq request_id }
 
   describe "#deliver" do
     let(:formatted_request_body) { double('formatted request body') }
@@ -17,8 +23,6 @@ describe HelloSign::Proxy::SignatureRequest do
       request_parameters.stub(:foo=)
       request_parameters.stub(:formatted).and_return(formatted_request_body)
       sr_proxy.request_parameters = request_parameters
-
-      client.stub(:post).and_return(api_response)
     end
 
     it "yields the request parameters to the block" do
@@ -28,7 +32,7 @@ describe HelloSign::Proxy::SignatureRequest do
 
     it "sends a signature request" do
       client.should_receive(:post)
-        .with('/signature_request/send', :body => formatted_request_body)
+        .with('/signature_request/send', body: formatted_request_body)
       sr_proxy.deliver { |params| params.foo = 'bar' }
     end
 
@@ -44,31 +48,29 @@ describe HelloSign::Proxy::SignatureRequest do
 
       it "sets the reusable form ID in the request parameters" do
         request_parameters.should_receive(:reusable_form_id=).with('form_id')
-        sr_proxy.deliver(:form => 'form_id') {}
+        sr_proxy.deliver(form: 'form_id') {}
       end
 
       it "sends a reusable form signature request" do
         client.should_receive(:post)
-          .with('/signature_request/send_with_reusable_form', :body => formatted_request_body)
-        sr_proxy.deliver(:form => 'form_id') {}
+          .with('/signature_request/send_with_reusable_form', body: formatted_request_body)
+        sr_proxy.deliver(form: 'form_id') {}
       end
 
       it "returns the response" do
-        expect(sr_proxy.deliver(:form => 'form_id') {}).to eq api_response
+        expect(sr_proxy.deliver(form: 'form_id') {}).to eq api_response
       end
     end
   end
 
   describe "#status" do
     it "fetches the signature request status" do
-      client.should_receive(:get)
-        .with('/signature_request/request_id')
-      sr_proxy.status(request_id)
+      client.should_receive(:get).with("/signature_request/#{request_id}")
+      sr_proxy.status
     end
 
     it "returns the response" do
-      client.stub(:get).and_return(api_response)
-      expect(sr_proxy.status(request_id)).to eq api_response
+      expect(sr_proxy.status).to eq api_response
     end
   end
 
@@ -76,7 +78,7 @@ describe HelloSign::Proxy::SignatureRequest do
     context "when called without a page number" do
       it "fetches the first page of signature requests" do
         client.should_receive(:get)
-          .with('/signature_request/list', :params => {:page => 1})
+          .with('/signature_request/list', params: {page: 1})
         sr_proxy.list
       end
 
@@ -89,13 +91,13 @@ describe HelloSign::Proxy::SignatureRequest do
     context "when called with a page number" do
       it "fetches a list of signature requests from the specified page" do
         client.should_receive(:get)
-          .with('/signature_request/list', :params => {:page => 10})
-        sr_proxy.list(:page => 10)
+          .with('/signature_request/list', params: {page: 10})
+        sr_proxy.list(page: 10)
       end
 
       it "returns the response" do
         client.stub(:get).and_return(api_response)
-        expect(sr_proxy.list(:page => 10)).to eq api_response
+        expect(sr_proxy.list(page: 10)).to eq api_response
       end
     end
   end
@@ -105,39 +107,34 @@ describe HelloSign::Proxy::SignatureRequest do
 
     it "sends a signature request reminder" do
       client.should_receive(:post)
-        .with('/signature_request/remind/request_id', :body => {:email_address => email})
-      sr_proxy.remind(request_id, :email => email)
+        .with("/signature_request/remind/#{request_id}", body: {email_address: email})
+      sr_proxy.remind(email: email)
     end
 
     it "returns the response" do
-      client.stub(:post).and_return(api_response)
-      expect(sr_proxy.remind(request_id, :email => email)).to eq api_response
+      expect(sr_proxy.remind(email: email)).to eq api_response
     end
   end
 
   describe "#cancel" do
     it "cancels a signature request" do
-      client.should_receive(:post)
-        .with('/signature_request/cancel/request_id')
-      sr_proxy.cancel(request_id)
+      client.should_receive(:post).with("/signature_request/cancel/#{request_id}")
+      sr_proxy.cancel
     end
 
     it "returns the response" do
-      client.stub(:post).and_return(api_response)
-      expect(sr_proxy.cancel(request_id)).to eq api_response
+      expect(sr_proxy.cancel).to eq api_response
     end
   end
 
   describe "#final_copy" do
     it "fetches a final copy of the signature request" do
-      client.should_receive(:get)
-        .with('/signature_request/final_copy/request_id')
-      sr_proxy.final_copy(request_id)
+      client.should_receive(:get).with("/signature_request/final_copy/#{request_id}")
+      sr_proxy.final_copy
     end
 
     it "returns the response" do
-      client.stub(:get).and_return(api_response)
-      expect(sr_proxy.final_copy(request_id)).to eq api_response
+      expect(sr_proxy.final_copy).to eq api_response
     end
   end
 end

data/spec/unit/proxy/team_spec.rb

@@ -18,12 +18,12 @@ describe HelloSign::Proxy::Team do
     let(:name) { 'The Browncoats' }
 
     it "sends a request to create a team" do
-      client.should_receive(:post).with('/team/create', :body => {:name => name})
-      team_proxy.create(:name => name)
+      client.should_receive(:post).with('/team/create', body: {name: name})
+      team_proxy.create(name: name)
     end
 
     it "returns the API response" do
-      expect(team_proxy.create(:name => name)).to eq api_response
+      expect(team_proxy.create(name: name)).to eq api_response
     end
 
   end
@@ -46,12 +46,12 @@ describe HelloSign::Proxy::Team do
     let(:new_name) { 'The Bluecoats' }
 
     it "sends a request to update the team information" do
-      client.should_receive(:post).with('/team', :body => {:name => new_name})
-      team_proxy.update(:name => new_name)
+      client.should_receive(:post).with('/team', body: {name: new_name})
+      team_proxy.update(name: new_name)
     end
 
     it "returns the API response" do
-      expect(team_proxy.update(:name => new_name)).to eq api_response
+      expect(team_proxy.update(name: new_name)).to eq api_response
     end
 
   end
@@ -74,12 +74,12 @@ describe HelloSign::Proxy::Team do
     let(:email_address) { 'john@johnson.com' }
 
     it "sends a request to add the member to the team" do
-      client.should_receive(:post).with('/team/add_member', :body => {:email_address => email_address})
-      team_proxy.add_member(:email_address => email_address)
+      client.should_receive(:post).with('/team/add_member', body: {email_address: email_address})
+      team_proxy.add_member(email_address: email_address)
     end
 
     it "returns the API response" do
-      expect(team_proxy.add_member(:email_address => email_address)).to eq api_response
+      expect(team_proxy.add_member(email_address: email_address)).to eq api_response
     end
 
   end
@@ -89,12 +89,12 @@ describe HelloSign::Proxy::Team do
     let(:email_address) { 'john@johnson.com' }
 
     it "sends a request to remove the member from the team" do
-      client.should_receive(:post).with('/team/remove_member', :body => {:email_address => email_address})
-      team_proxy.remove_member(:email_address => email_address)
+      client.should_receive(:post).with('/team/remove_member', body: {email_address: email_address})
+      team_proxy.remove_member(email_address: email_address)
     end
 
     it "returns the API response" do
-      expect(team_proxy.remove_member(:email_address => email_address)).to eq api_response
+      expect(team_proxy.remove_member(email_address: email_address)).to eq api_response
     end
 
   end

data/spec/unit/proxy/unclaimed_draft_spec.rb

@@ -17,7 +17,7 @@ describe HelloSign::Proxy::UnclaimedDraft do
       draft_parameters.stub(:formatted).and_return(formatted_request_body)
       draft_parameters.should_receive(:foo=).with('bar')
       client.should_receive(:post)
-        .with('/unclaimed_draft/create', :body => formatted_request_body)
+        .with('/unclaimed_draft/create', body: formatted_request_body)
         .and_return(api_response)
     end
 

data/spec/unit/upload_io_spec.rb

@@ -0,0 +1,60 @@
+require 'helper'
+require 'hello_sign/upload_io'
+
+describe HelloSign::UploadIO do
+  let(:upload_file) { double('upload file') }
+  let(:io_object)   { double('IO object') }
+  let(:file_converter_source) { double('file converter source') }
+
+  before { HelloSign::UploadIO.any_instance.stub(:file_converter_source).and_return(file_converter_source) }
+
+  it "returns the upload file" do
+    file_converter_source.stub(:new).and_return(upload_file)
+
+    expect(HelloSign::UploadIO.new(filename: 'test.txt').upload).to eq upload_file
+  end
+
+  context "#upload" do
+    specify do
+      file_converter_source.should_receive(:new).with('test.txt', 'text/plain')
+
+      HelloSign::UploadIO.new(filename: 'test.txt').upload
+    end
+
+    specify do
+      file_converter_source.should_receive(:new).with('test.foo', 'text/plain')
+
+      HelloSign::UploadIO.new(filename: 'test.foo').upload
+    end
+
+    specify do
+      file_converter_source.should_receive(:new).with('test.baz', 'fake/mime')
+
+      HelloSign::UploadIO.new(filename: 'test.baz', mime: 'fake/mime').upload
+    end
+
+    specify do
+      file_converter_source.should_receive(:new).with(io_object, 'text/plain')
+
+      HelloSign::UploadIO.new(io: io_object).upload
+    end
+
+    specify do
+      file_converter_source.should_receive(:new).with(io_object, 'fake/mime')
+
+      HelloSign::UploadIO.new(io: io_object, mime: 'fake/mime').upload
+    end
+
+    specify do
+      file_converter_source.should_receive(:new).with(io_object, 'fake/mime', 'test.foo')
+
+      HelloSign::UploadIO.new(filename: 'test.foo', io: io_object, mime: 'fake/mime').upload
+    end
+
+    specify do
+      file_converter_source.should_receive(:new).with(io_object, 'text/plain', 'test.foo')
+
+      HelloSign::UploadIO.new(filename: 'test.foo', io: io_object).upload
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hello_sign
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-19 00:00:00.000000000 Z
+date: 2013-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.8.4
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware-multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -50,7 +50,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.12.0
+        version: '2.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -58,7 +58,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.12.0
+        version: '2.12'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +66,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.9.0
+        version: '1.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -74,7 +74,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.9.0
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -82,7 +82,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 10.0.3
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -90,15 +90,15 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 10.0.3
+        version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: vcr
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -106,7 +106,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '0.6'
 description: A Ruby interface to the HelloSign API.
 email:
 - craiglttl@gmail.com
@@ -127,6 +127,7 @@ files:
 - lib/hello_sign/proxy/team.rb
 - lib/hello_sign/proxy/unclaimed_draft.rb
 - lib/hello_sign/proxy.rb
+- lib/hello_sign/upload_io.rb
 - lib/hello_sign/version.rb
 - lib/hello_sign.rb
 - spec/fixtures/test.jpg
@@ -155,8 +156,10 @@ files:
 - spec/unit/proxy/signature_request_spec.rb
 - spec/unit/proxy/team_spec.rb
 - spec/unit/proxy/unclaimed_draft_spec.rb
+- spec/unit/upload_io_spec.rb
 homepage: http://www.github.com/craiglittle/hello_sign
-licenses: []
+licenses:
+- MIT
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -175,7 +178,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: A Ruby interface to the HelloSign API.
@@ -206,3 +209,4 @@ test_files:
 - spec/unit/proxy/signature_request_spec.rb
 - spec/unit/proxy/team_spec.rb
 - spec/unit/proxy/unclaimed_draft_spec.rb
+- spec/unit/upload_io_spec.rb