hello_sign 0.0.4 → 0.0.5

data/lib/hello_sign/signature_request_proxy.rb

@@ -3,15 +3,26 @@ require 'hello_sign/signature_request_parameters'
 module HelloSign
   class SignatureRequestProxy
     attr_reader :client
+    attr_writer :request_parameters
 
     def initialize(client)
       @client = client
     end
 
     def create(raw_parameters)
-      raw_parameters.call(request_parameters = SignatureRequestParameters.new)
+      raw_parameters.call(request_parameters)
       client.post('/signature_request/send', :body => request_parameters.formatted)
     end
 
+    def status(request_id)
+      client.get("/signature_request/#{request_id}")
+    end
+
+    private
+
+    def request_parameters
+      @request_parameters ||= SignatureRequestParameters.new
+    end
+
   end
 end

data/lib/hello_sign/version.rb

@@ -1,3 +1,3 @@
 module HelloSign
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/lib/hello_sign.rb

@@ -11,8 +11,12 @@ module HelloSign
       AccountProxy.new(client)
     end
 
-    def signature_request(&parameters)
-      SignatureRequestProxy.new(client).create(parameters)
+    def signature_request(request_id = nil, &parameters)
+      if request_id
+        SignatureRequestProxy.new(client).status(request_id)
+      else
+        SignatureRequestProxy.new(client).create(parameters)
+      end
     end
 
     def client

data/spec/integration/signature_request_spec.rb

@@ -29,4 +29,15 @@ describe HelloSign do
       ).to have_been_made
     end
   end
+
+  context "when fetching a signature request" do
+    before do
+      stub_get_with_auth('/signature_request/request_id')
+      HelloSign.signature_request('request_id')
+    end
+
+    it "fetches the signature request information from the HelloSign API" do
+      expect(a_get_with_auth('/signature_request/request_id')).to have_been_made
+    end
+  end
 end

data/spec/unit/hello_sign_spec.rb

@@ -9,15 +9,25 @@ describe HelloSign do
   end
 
   describe "::signature_request" do
-    let(:sr_proxy) { double('signature_request_proxy') }
+    let(:sr_proxy)       { mock }
+    let(:request_result) { stub }
 
-    before do
-      HelloSign::SignatureRequestProxy.stub(:new).and_return(sr_proxy)
-      sr_proxy.should_receive(:create).and_return(@request_result = stub)
+    before { HelloSign::SignatureRequestProxy.stub(:new).and_return(sr_proxy) }
+
+    context "when called without passing a request ID" do
+      before { sr_proxy.should_receive(:create).and_return(request_result) }
+
+      it "calls #create on the signature request proxy and returns the result" do
+        expect(HelloSign.signature_request).to eq request_result
+      end
     end
 
-    it "calls #create on the signature request proxy and returns the result" do
-      expect(HelloSign.signature_request).to eq @request_result
+    context "when called with a signature ID" do
+      before { sr_proxy.should_receive(:status).with('request_id').and_return(request_result) }
+
+      it "calls #status on the signature request proxy and returns the result " do
+        expect(HelloSign.signature_request('request_id')).to eq request_result
+      end
     end
   end
 

data/spec/unit/signature_request_proxy_spec.rb

@@ -2,7 +2,8 @@ require 'helper'
 require 'hello_sign/signature_request_proxy'
 
 describe HelloSign::SignatureRequestProxy do
-  let(:client)       { double('client') }
+  let(:client)       { mock }
+  let(:api_response) { stub }
   subject(:sr_proxy) { HelloSign::SignatureRequestProxy.new(client) }
 
   describe "#client" do
@@ -13,20 +14,32 @@ describe HelloSign::SignatureRequestProxy do
 
   describe "#create" do
     let(:formatted_request_body) { stub }
-    let(:create_response)        { stub }
     let(:raw_parameters)         { Proc.new { |params| params.foo = 'bar' } }
+    let(:request_parameters)     { mock }
 
     before do
-      HelloSign::SignatureRequestParameters.stub(:new).and_return(request_parameters = mock)
+      sr_proxy.request_parameters = request_parameters
       request_parameters.stub(:formatted).and_return(formatted_request_body)
       request_parameters.should_receive(:foo=).with('bar')
       client.should_receive(:post)
         .with('/signature_request/send', :body => formatted_request_body)
-        .and_return(create_response)
+        .and_return(api_response)
     end
 
     it "sends a signature request creation request and returns the result" do
-      expect(sr_proxy.create(raw_parameters)).to eq create_response
+      expect(sr_proxy.create(raw_parameters)).to eq api_response
+    end
+  end
+
+  describe "#status" do
+    let(:request_id) { 'request_id' }
+
+    before do
+      client.should_receive(:get).with('/signature_request/request_id').and_return(api_response)
+    end
+
+    it "fetches the signature request status and returns the result" do
+      expect(sr_proxy.status(request_id)).to eq api_response
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hello_sign
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-24 00:00:00.000000000 Z
+date: 2013-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday