hello-rails 0.5.0 → 0.5.1

data/spec/bdd/hello/management/manage_email_credentials/manage_email_credentials_emails_page_spec.rb

@@ -89,11 +89,11 @@ RSpec.bdd.uic "Emails Page" do
       end
 
       When "I attempt to remove that email" do
-        click_on "Remove"
+        click_nth_button("Remove", 0)
       end
 
       Then "I should see an alert message" do
-        expect_flash_alert "must have at least one credential"
+        expect_flash_alert "Email credentials is too short (minimum is 1 character)"
       end
 
       Then "and I should still see that email on the list" do
@@ -114,21 +114,21 @@ RSpec.bdd.uic "Emails Page" do
       end
 
       When "I attempt to remove that email" do
-        click_nth_button("Remove", 1)
+        click_nth_button("Remove", 0)
       end
 
       Then "I should see a confirmation message" do
-        expect_flash_notice "newemail@provider.com was successfully removed"
+        expect_flash_notice "foo@bar.com was successfully removed"
       end
 
-      Then "and I should no longer see that email on the list" do
+      Then "and I should no longer see the old email on the list" do
         within all("table tr")[1] do
           expect_not_to_see @new_email
         end
       end
 
       Then "nor in the database" do
-        expect(EmailCredential.pluck(:email)).not_to include @new_email
+        expect(EmailCredential.pluck(:email)).not_to include 'foo@bar.com'
       end
     end
   end
@@ -221,7 +221,7 @@ RSpec.bdd.uic "Emails Page" do
 
     def _when_visit_valid
       When "I visit a valid token URL" do
-        @credential = create(:email_credential)
+        @credential = create(:user).email_credentials.first
         token       = @credential.reset_verifying_token!
         visit the_url(@credential.id, token)
       end

data/spec/bdd/hello/management/manage_password_credentials/manage_password_forgot_password_spec.rb

@@ -5,7 +5,7 @@ RSpec.bdd.uic "Forgot Password" do
   story "-" do
 
     before do
-      given_I_have_an_email_credential
+      given_I_have_a_user
     end
 
 

data/spec/bdd/hello/management/manage_password_credentials/manage_password_reset_password_spec.rb

@@ -12,7 +12,7 @@ RSpec.bdd.uic "Reset Password" do
   end
 
   def _I_visit_with_a_valid_token
-    @reset_token ||= given_I_have_an_email_credential_and_forgot_my_password
+    @reset_token ||= given_I_have_a_user_and_forgot_my_password
     p = PasswordCredential.last
     visit hello.reset_password_path(p.id, p.user_id, @reset_token)
   end

data/spec/bdd/hello/management/manage_profile/manage_profile_page_spec.rb

@@ -24,7 +24,6 @@ RSpec.bdd.uic "Profile Page" do
     scenario "Valid" do
       When "I submit new valid values in the form" do
         fill_in 'user_name',     with: (@new_name     = 'James Pinto')
-        fill_in 'user_city',     with: (@new_city     = 'Brasilia')
         fill_in 'user_username', with: (@new_username = 'new_username')
         click_button 'Update'
       end
@@ -40,7 +39,6 @@ RSpec.bdd.uic "Profile Page" do
       Then "and the new values should reflect on the database" do
         user = User.last
         expect(user.name).to eq(@new_name)
-        expect(user.city).to eq(@new_city)
         expect(user.username).to eq(@new_username)
       end
     end

data/spec/bdd/hello/other/create_user_spec.rb

@@ -17,8 +17,7 @@ RSpec.bdd.capability "I can Create Users" do
         end
 
         Given 'I visit New User Webmaster Page with Sudo Mode' do
-          visit '/'
-          click_link 'User List'
+          visit '/users'
           click_link "View User List as a Webmaster"
           fill_in 'user_password', with: '1234'
           click_button 'Confirm'
@@ -28,7 +27,6 @@ RSpec.bdd.capability "I can Create Users" do
         scenario "Success" do
 
           When 'I submit a new user John' do
-            fill_in 'user_city', with: 'Brasilia'
             fill_in 'user_name', with: 'john'
             fill_in 'user_username', with: 'john'
             fill_in 'user_email', with: 'john@test.com'

data/spec/bdd/hello/other/impersonate_user_spec.rb

@@ -18,8 +18,7 @@ RSpec.bdd.capability "I can Impersonate Users" do
 
         scenario "Success" do
           Given 'I visit Users List Webmaster Page with Sudo Mode' do
-            visit '/'
-            click_link 'User List'
+            visit '/users'
             click_link "View User List as a Webmaster"
           end
 

data/spec/bdd/hello/other/list_users_spec.rb

@@ -15,8 +15,7 @@ RSpec.bdd.capability "I can List Users" do
           scenario 'I have access to the page' do
 
             When 'I visit the users page' do
-              visit '/'
-              click_link 'User List'
+              visit '/users'
             end
 
             Then 'I should be on the users page' do
@@ -37,8 +36,7 @@ RSpec.bdd.capability "I can List Users" do
 
             scenario "Via User List Page" do
               When 'I visit james profile from the User List page' do
-                visit '/'
-                click_link 'User List'
+                visit '/users'
                 click_link 'james'
               end
             end # scenario

data/spec/bdd/hello/registration/classic_sign_up_spec.rb

@@ -46,7 +46,7 @@ RSpec.bdd.capability "I can Sign Up With Email" do
       api "API", type: :request do
         scenario "Valid Parameters" do
           When "I sign up with valid parameters" do
-            post "/hello/sign_up.json", sign_up: {email: "foo@bar.com", password: "foobar", name: "Foo Bar", city: "Brasilia", username: "foobar"}
+            post "/hello/sign_up.json", sign_up: {email: "foo@bar.com", password: "foobar", name: "Foo Bar", username: "foobar"}
           end
         end # scenario
 
@@ -168,12 +168,12 @@ RSpec.bdd.capability "I can Sign Up With Email" do
       api "API", type: :request do
         scenario "Valid Parameters" do
           When "I sign up with valid parameters" do
-            post "/hello/sign_up.json", sign_up: {email: "foo@bar.com", password: "foobar", name: "Foo Bar", city: "Brasilia", username: "foobar"}
+            post "/hello/sign_up.json", sign_up: {email: "foo@bar.com", password: "foobar", name: "Foo Bar", username: "foobar"}
           end
 
           Then "I should see the access object" do
             expect(json_response.keys).to match_array ["expires_at", "token", "user", "user_id"]
-            expect(json_response["user"].keys).to match_array ["id", "accesses_count", "city", "created_at", "credentials_count", "locale", "name", "role", "time_zone", "updated_at", "username"]
+            expect(json_response["user"].keys).to match_array ["id", "accesses_count", "created_at", "credentials_count", "locale", "name", "role", "time_zone", "updated_at", "username"]
           end
 
           Then "I should get a 201 response" do
@@ -204,7 +204,6 @@ RSpec.bdd.capability "I can Sign Up With Email" do
               "email"=>["can't be blank"],
               "password"=>["can't be blank"],
               "name"=>["can't be blank"],
-              "city"=>["can't be blank"]
             })
           end
 

data/spec/bdd/hello/support.rb

@@ -5,7 +5,6 @@ def fill_in_registration_form
     fill_in 'sign_up_email',    with: 'foo@bar.com'
     fill_in 'sign_up_username', with: 'foobar'
     fill_in 'sign_up_password', with: '1234'
-    fill_in 'sign_up_city',     with: 'OMG! I can customize Hello!'
   end
 end
 
@@ -26,21 +25,18 @@ end
 
 def sign_in_as_an_onboarding
   u = create(:user_onboarding)
-  create(:email_credential, user: u, email: "#{u.username}@example.com")
   sign_in_with(u.username)
   expect(current_user.role).to eq('onboarding')
 end
 
 def sign_in_as_a_user
   u = create(:user_user)
-  create(:email_credential, user: u, email: "#{u.username}@example.com")
   sign_in_with(u.username)
   expect(current_user.role).to eq('user')
 end
 
 def sign_in_as_a_webmaster
   u = create(:user_webmaster)
-  create(:email_credential, user: u, email: "#{u.username}@example.com")
   sign_in_with(u.username)
   expect(current_user.role).to eq('webmaster')
 end

data/spec/business/hello/registration/sign_up_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module Hello
   describe Business::Registration::SignUp do
     describe '.register(email:string, username:string, password:string)' do
-      let(:valid_attrs) { { city: 'Brasilia', name: 'James Pinto', email: 'foo@bar.com', username: 'foobar', password: 'foobar' } }
+      let(:valid_attrs) { { name: 'James Pinto', email: 'foo@bar.com', username: 'foobar', password: 'foobar' } }
 
       describe 'original state' do
         it('no errors') { expect(subject.errors.messages).to eq({}) }
@@ -13,7 +13,14 @@ module Hello
         before do
           subject.register({})
         end
-        it('a lot of errors') { expect(subject.errors.messages).to eq(email: ["can't be blank"], name: ["can't be blank"], city: ["can't be blank"], password: ["can't be blank"], username: ["can't be blank"]) }
+        it('has a lot of errors') do
+          expect(subject.errors.messages).to eq({
+            email: ["can't be blank"],
+            name: ["can't be blank"],
+            password: ["can't be blank"],
+            username: ["can't be blank"]
+          })
+        end
       end # describe
 
       describe 'by field' do
@@ -252,6 +259,7 @@ module Hello
             end # describe
           end # describe config
         end # describe password
+
       end # describe by field
     end # describe .register
   end # describe Business::SignUp

data/spec/controllers/authentication_spec.rb

@@ -46,7 +46,7 @@ module Hello::Management
           json_body = JSON(response.body)
           expect(response.status).to eq(200)
           expect(response.status_message).to eq('OK')
-          expect(json_body.keys).to match_array(%w(id created_at updated_at name role username locale time_zone credentials_count accesses_count city))
+          expect(json_body.keys).to match_array(%w(id created_at updated_at name role username locale time_zone credentials_count accesses_count))
         end
 
         it 'SESSION' do
@@ -56,7 +56,7 @@ module Hello::Management
           json_body = JSON(response.body)
           expect(response.status).to eq(200)
           expect(response.status_message).to eq('OK')
-          expect(json_body.keys).to match_array(%w(id created_at updated_at name role username locale time_zone credentials_count accesses_count city))
+          expect(json_body.keys).to match_array(%w(id created_at updated_at name role username locale time_zone credentials_count accesses_count))
         end
 
         it 'HEADER' do
@@ -66,7 +66,7 @@ module Hello::Management
           json_body = JSON(response.body)
           expect(response.status).to eq(200)
           expect(response.status_message).to eq('OK')
-          expect(json_body.keys).to match_array(%w(id created_at updated_at name role username locale time_zone credentials_count accesses_count city))
+          expect(json_body.keys).to match_array(%w(id created_at updated_at name role username locale time_zone credentials_count accesses_count))
         end
       end
     end

data/spec/models/create_and_destroy/email_credential_create_and_destroy_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+
+describe EmailCredential do
+
+  describe 'ClassMethods' do
+    describe '#new' do
+      it "is not valid" do
+        expect(subject).to be_invalid
+        expect(subject.errors.messages).to eq({:email => ["can't be blank"]})
+      end
+    end
+
+    describe ".create" do
+      subject { EmailCredential.new(email: 'foo@example.com') }
+
+      describe "invalid examples" do
+
+      end
+
+      describe "valid examples" do
+        describe "does save without a user" do
+          it "does save without a user" do
+            expect(subject.user).to eq(nil)
+            expect(subject.save).to eq(true)
+            expect(Credential.count).to eq(1)
+          end
+
+          it "does save with an invalid user" do
+            subject.user = User.new
+            expect(subject.save).to eq(true)
+            expect(subject.errors.messages).to eq({})
+            expect(Credential.count).to eq(1)
+          end
+        end
+
+        it "saves with a valid user" do
+          user = create(:user)
+          expect(Credential.count).to eq(2)
+          subject.user = user
+          expect(subject.save).to eq(true)
+          expect(Credential.count).to eq(3)
+        end
+
+      end
+    end
+
+    describe ".destroy!" do
+      describe "valid examples" do
+        describe "with 1 email and 1 password" do
+          subject { create(:user) }
+
+          it "works" do
+            subject # touch
+            expect(User.count).to eq(1)
+            expect(Credential.count).to eq(2)
+            subject.destroy!
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+        end
+
+        describe "with 2 emails and 1 password" do
+          subject do
+            u = create(:user)
+            u.email_credentials.create!(email: 'bar@example.com')
+            u
+          end
+
+          it "works" do
+            subject # touch
+            expect(User.count).to eq(1)
+            expect(Credential.count).to eq(3)
+            subject.destroy!
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/create_and_destroy/password_credential_create_and_destroy_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe PasswordCredential do
+
+  describe 'ClassMethods' do
+    describe '#new' do
+      it "is not valid" do
+        expect(subject).to be_invalid
+        expect(subject.errors.messages).to eq({:password => ["can't be blank"]})
+      end
+    end
+
+    describe ".create" do
+      subject { PasswordCredential.new(password: '1234') }
+
+      describe "valid examples" do
+        describe "does  save without a user" do
+          it "does  save without a user" do
+            expect(subject.user).to eq(nil)
+            expect(subject.save).to eq(true)
+            expect(Credential.count).to eq(1)
+          end
+
+          it "does  save with an invalid user" do
+            subject.user = User.new
+            expect(subject.save).to eq(true)
+            expect(subject.errors.messages).to eq({})
+            expect(Credential.count).to eq(1)
+          end
+        end
+
+        it "saves with a valid user" do
+          user = create(:user)
+          expect(Credential.count).to eq(2)
+          subject.user = user
+          expect(subject.save).to eq(true)
+          expect(Credential.count).to eq(3)
+        end
+
+      end
+    end
+
+    describe ".destroy!" do
+      describe "valid examples" do
+        describe "with 1 email and 1 password" do
+          subject { create(:user) }
+
+          it "works" do
+            subject # touch
+            expect(User.count).to eq(1)
+            expect(Credential.count).to eq(2)
+            subject.destroy!
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/create_and_destroy/user_create_and_destroy_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+
+describe User do
+
+  describe 'ClassMethods' do
+    describe '#new' do
+      it "is not valid" do
+        expect(subject).to be_invalid
+        expect(subject.errors.messages).to eq({
+         :locale=>["can't be blank", "is not included in the list"],
+         :time_zone=>["can't be blank", "is not included in the list"],
+         :name=>["can't be blank"],
+         :email_credentials=>["is too short (minimum is 1 character)"],
+         :username => ["can't be blank"],
+         :email => ["can't be blank"],
+         :password => ["can't be blank"],
+        })
+      end
+    end
+
+    describe ".create" do
+      subject do
+        build(:user, :without_credentials)
+      end
+
+      describe "invalid examples" do
+        describe "number of emails" do
+          it "does not save with 0 emails and 0 passwords" do
+            expect(subject.save).to eq(false)
+            expect(User.count).to eq(0)
+          end
+
+          it "does not save with 0 email and 1 password" do
+            subject.password_credentials.build(password: '1234')
+            subject.save
+            expect(subject.errors.messages).to eq({:email => ["can't be blank"], :email_credentials=>["is too short (minimum is 1 character)"]})
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+        end
+
+        describe "number of passwords" do
+          it "does not save with 1 email and 0 passwords" do
+            subject.email_credentials.build(email: 'foo@example.com')
+            subject.save
+            expect(subject.errors.messages).to eq(:password => ["can't be blank"])
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+
+          it "does not save with 1 email and 2 passwords" do
+            subject.email_credentials.build(email: 'foo@example.com')
+            subject.password_credentials.build(password: '1234')
+            subject.password_credentials.build(password: '5678')
+            subject.save
+            expect(subject.errors.messages).to eq(:password_credentials => ["is the wrong length (should be 1 character)"])
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+        end
+      end
+
+      describe "valid examples" do
+        it "save with 1 email and 1 passwords" do
+          subject.email_credentials.build(email: 'foo@example.com')
+          subject.password_credentials.build(password: '1234')
+          subject.save
+          expect(subject.errors.messages).to eq({})
+          expect(User.count).to eq(1)
+          expect(Credential.count).to eq(2)
+        end
+
+        it "save with 2 email and 1 passwords" do
+          subject.email_credentials.build(email: 'foo@example.com')
+          subject.email_credentials.build(email: 'bar@example.com')
+          subject.password_credentials.build(password: '1234')
+          subject.save
+          expect(subject.errors.messages).to eq({})
+          expect(User.count).to eq(1)
+          expect(Credential.count).to eq(3)
+        end
+      end
+    end
+
+    describe ".destroy!" do
+      describe "valid examples" do
+        describe "with 1 email and 1 password" do
+          subject do
+            u = build(:user)
+            u.save!
+            u
+          end
+
+          it "works" do
+            subject # touch
+            expect(User.count).to eq(1)
+            expect(Credential.count).to eq(2)
+            subject.destroy!
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+        end
+        describe "with 2 emails and 1 password" do
+          subject do
+            u = build(:user)
+            u.email_credentials.build(email: 'bar@example.com')
+            u.save!
+            u
+          end
+
+          it "works" do
+            subject # touch
+            expect(User.count).to eq(1)
+            expect(Credential.count).to eq(3)
+            subject.destroy!
+            expect(User.count).to eq(0)
+            expect(Credential.count).to eq(0)
+          end
+        end
+      end
+    end
+  end
+
+end