heller 0.2.0-java → 0.2.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb77b9b32f52f9f8cb4aefbdf3d27af37b402283
-  data.tar.gz: dcf3fbab3d4ee6cb31f0da70e98f18fe3994b2b6
+  metadata.gz: 0baa0412f9823d69c62d8688ef830862fc3d29e8
+  data.tar.gz: 560b7dcbc5b86938368606b3a9cf22caca01ec7a
 SHA512:
-  metadata.gz: 8a4b163c1f7523d3035cf73087b8d26dc366845b66c3c39845e9476fcb9d00b32944a7307a9e746deb833db722605290e2576322116b0a5ccbd65bb68027d6f1
-  data.tar.gz: 9658bb7e731c353d0269bcce8c150c7f47883d21bf0c592d937eaab50c641b0f064037dabe846698443d2acc7987995eb9084152aac60f2d5b06ed9bd4d5fa9d
+  metadata.gz: ae0a5cf3dc94c7e4db90a8fd842ca0a43e5050130e6150d9b9b1d365864d2d7e0927abc5875e6953bdbc55e13e263a83e2f0880644e59705095e834bb23dd4bb
+  data.tar.gz: 4ac4c3b9f0d244ebd16105e15048b8d1c29cb0baae4e5e27ceba1c87a388b0ec76b9d383f0dccbc0bf0ce55a8642125584e4cf0959db4939f86d0f8f2e3dfaf7

data/lib/heller/consumer.rb

@@ -56,6 +56,8 @@ module Heller
 
     def disconnect
       @consumer.close
+      Kafka::Metrics::KafkaMetricsGroup.remove_all_consumer_metrics(client_id)
+      nil
     end
     alias_method :close, :disconnect
 

data/lib/heller/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module Heller
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.2.1'.freeze
 end

data/lib/kafka.rb

@@ -42,6 +42,16 @@ module Kafka
     java_import 'kafka.javaapi.message.ByteBufferMessageSet'
   end
 
+  module Metrics
+    java_import 'kafka.metrics.KafkaMetricsGroup'
+
+    module KafkaMetricsGroup
+      def self.remove_all_consumer_metrics(client_id)
+        self.removeAllConsumerMetrics(client_id)
+      end
+    end
+  end
+
   module Producer
     java_import 'kafka.javaapi.producer.Producer'
     java_import 'kafka.producer.ProducerConfig'

data/spec/heller/consumer_spec.rb

@@ -366,11 +366,29 @@ module Heller
         expect(consumer_spy).to have_received(:close)
       end
 
+      it 'removes any metrics associated with the underlying consumer' do
+        consumer = described_class.new('localhost:9092', client_id: 'metrics-removal')
+        before = Java::ComYammerMetrics::Metrics.default_registry.all_metrics
+        expect(before).to_not be_empty
+        consumer.close
+        after = Java::ComYammerMetrics::Metrics.default_registry.all_metrics
+        expect(after).to be_empty
+      end
+
       it 'is aliased to #close' do
         consumer.close
 
         expect(consumer_spy).to have_received(:close)
       end
+
+      it 'returns nil' do
+        expect(consumer.close).to be_nil
+      end
+
+      it 'is okay to call multiple times' do
+        consumer = described_class.new('localhost:9092', client_id: 'close-multiple')
+        3.times { consumer.close }
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: heller
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: java
 authors:
 - Mathias Söderberg
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-05-13 00:00:00.000000000 Z
+date: 2015-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement