helena 0.3.3 → 1.0.0.rc1

data/app/models/helena/version.rb

@@ -6,18 +6,20 @@ module Helena
     field :version,        type: Integer, default: 0
     field :notes,          type: String
     field :session_report, type: String
+    field :active,         type: Boolean, default: false
+    field :settings,       type: Hash, default: {}
 
-    embedded_in :survey
+    belongs_to :survey
 
-    embeds_many :question_groups, class_name: 'Helena::QuestionGroup'
-    embeds_many :sessions, class_name: 'Helena::Session'
+    has_many :question_groups, inverse_of: :version, dependent: :destroy, class_name: 'Helena::QuestionGroup'
+    has_many :sessions, inverse_of: :version, dependent: :destroy, class_name: 'Helena::Session'
 
     embeds_one :survey_detail, class_name: 'Helena::SurveyDetail'
 
     accepts_nested_attributes_for :survey_detail
     accepts_nested_attributes_for :question_groups
 
-    scope :without_base, -> { where(:version.gt => 0) }
+    scope :active, -> { where active: true }
 
     validates :version, presence: true
     validates :version, uniqueness: { scope: :survey_id }

data/app/views/helena/questions/_static_text.html.slim

@@ -0,0 +1 @@
+= question.default_value.html_safe

data/app/views/helena/sessions/_progressbar.html.slim

@@ -0,0 +1,9 @@
+- page = (@question_group.previous_items.size + 1)
+- total_pages = @version.question_groups.size
+- percent = ((page.to_f / total_pages.to_f)*100).round
+#survey_progress
+  .text-center
+    = t '.count_page', page: page, total_pages: total_pages
+  .progress
+    .progress-bar aria-valuemax="100" aria-valuemin="0" aria-valuenow="#{percent}" role="progressbar" style="width: #{percent}%"
+      = "#{percent}%"

data/app/views/helena/sessions/edit.html.slim

@@ -0,0 +1,18 @@
+= render 'progressbar' if @version.settings && @version.settings[:display_progressbar]
+#survey_content
+  h1.survey_title
+    = @version.survey_detail.title
+  fieldset id="#{dom_id @question_group}"
+    legend= @question_group.title
+    = simple_form_for(@session, url: helena.session_path(@session.token), as: :session) do |f|
+      - @questions.each do |question|
+        = render "#{question.class.to_s.underscore}", form: f, question: question, answers: @answers, errors: @errors
+
+      = hidden_field_tag :question_group, @question_group.id
+
+      - if @question_group.previous_items.any? && @question_group.allow_to_go_back?
+        = link_to t('.back'), edit_session_path(@session.token, question_group: @question_group.previous_item), class: 'btn btn-default'
+
+      = f.submit class: 'btn btn-success pull-right', value: @question_group.last? ? t('.save') : t('.next')
+
+    = t('shared.required') if @questions.map{ |question| question.try :required }.any?

data/app/views/helena/sessions/{end_message.html.haml → end_message.html.slim}

@@ -1,4 +1,4 @@
-%h1.survey_title
+h1.survey_title
   = @version.survey_detail.title
 
 .well

data/config/locales/models/question_group/en.yml

@@ -9,3 +9,4 @@ en:
       'helena/question_group':
         position: Position
         title: Title
+        allow_to_go_back: Allow participants to go back to the previous question group

data/config/locales/models/session/en.yml

@@ -8,3 +8,7 @@ en:
     attributes:
       'helena/session':
         completed: Completed?
+        last_question_group_id: Last viewed question group
+        answers_as_yaml: Answers
+        token: Token
+        view_token: View token

data/config/locales/models/survey/en.yml

@@ -4,3 +4,6 @@ en:
       'helena/survey':
         one: Survey
         other: Surveys
+    attributes:
+      'helena/survey':
+          created_at: Created

data/config/locales/views/sessions/en.yml

@@ -5,5 +5,9 @@ en:
         next: Next
         save: Save
         back: Back
+
       end_message:
         message: Thank you for participating.
+
+      progressbar:
+        count_page: "Page %{page} of %{total_pages}"

data/config/routes.rb

@@ -1,28 +1,4 @@
 Helena::Engine.routes.draw do
   resources :surveys
-  resources :sessions, only: [:show, :edit, :update], param: :token
-
-  scope :admin, as: :admin, module: :admin do
-    concern :movable do
-      patch :move_up, on: :member
-      patch :move_down, on: :member
-    end
-
-    resources :surveys, concerns: :movable do
-      resources :sessions, only: [:index, :destroy]
-      resources :versions
-      resources :question_groups, concerns: :movable do
-        resources :questions, concerns: :movable
-        resource :questions do
-          resources :short_texts, module: 'questions'
-          resources :long_texts, module: 'questions'
-          resources :static_texts, module: 'questions'
-          resources :radio_groups, module: 'questions'
-          resources :checkbox_groups, module: 'questions'
-          resources :radio_matrix, module: 'questions'
-          resources :checkbox_matrix, module: 'questions'
-        end
-      end
-    end
-  end
+  resources :sessions, param: :token
 end

data/db/seeds.rb

@@ -1,167 +1,39 @@
 require 'factory_girl'
 require 'ffaker'
 require 'database_cleaner'
+require 'helena/survey_importer'
 
 include FactoryGirl::Syntax::Methods
 
-# TODO: Codes smells because we have to assign the factory path here
-FactoryGirl.definition_file_paths += ['spec/factories']
-FactoryGirl.find_definitions
-
-puts 'Cleaning database ...'.green
+puts 'Cleaning database ...'
 DatabaseCleaner.strategy = :truncation
 DatabaseCleaner.clean
 
-puts 'Seeding surveys ...'.green
+puts 'Seeding surveys ...'
 
 def create_satisfaction_scale_survey
-  satisfaction_matrix = build :radio_matrix_question, code:          :satisfaction,
-                                                      required:      true,
-                                                      question_text: 'Below are five statements with which you may agree or disagree. Using the 1-7 scale below, indicate your agreement with each item by placing the appropriate number in the line preceding that item. Please be open and honest in your responding.',
-                                                      required:      true,
-                                                      position:      1
-
-  satisfaction_matrix.labels << build(:label, position: 1, text: 'Strongly Disagree', value: 1)
-  satisfaction_matrix.labels << build(:label, position: 2, text: 'Disagree', value: 2)
-  satisfaction_matrix.labels << build(:label, position: 3, text: 'Slightly Disagree', value: 3)
-  satisfaction_matrix.labels << build(:label, position: 4, text: 'Neither Agree or Disagree', value: 4)
-  satisfaction_matrix.labels << build(:label, position: 5, text: 'Slightly Agree', value: 5)
-  satisfaction_matrix.labels << build(:label, position: 6, text: 'Agree', value: 6)
-  satisfaction_matrix.labels << build(:label, position: 7, text: 'Strongly Agree', value: 7)
-
-  satisfaction_matrix.sub_questions << build(:sub_question, text: 'In most ways my life is close to my ideal.', code: 'life_is_ideal', position: 1)
-  satisfaction_matrix.sub_questions << build(:sub_question, text: 'The conditions of my life are excellent.', code: 'condition', position: 2)
-  satisfaction_matrix.sub_questions << build(:sub_question, text: 'I am satisfied with life.', code: 'satisfied_with_life', position: 3)
-  satisfaction_matrix.sub_questions << build(:sub_question, text: 'So far I have gotten the important things I want in life.', code: 'important_things', position: 4)
-  satisfaction_matrix.sub_questions << build(:sub_question, text: 'If I could live my life over, I would change almost nothing.', code: 'nothing_to_change', position: 5)
-
-  satisfaction_details = build :question_group, questions: [satisfaction_matrix]
-
-
-  survey = create :survey, name: 'The Satisfaction with Life Scale', tag_list: 'satisfaction, psychology'
-  base_version = survey.versions.create version: 0
-  base_version.survey_detail = build :survey_detail, title:       'The Satisfaction with Life Scale',
-                                                     description: 'A 5-item scale designed to measure global cognitive judgments of ones life satisfaction.'
-
-  base_version.question_groups << satisfaction_details
-  published_version = publish(base_version)
-
-  generate_sessions(survey, published_version)
- end
-
-def create_restaurant_survey
-  personal_details = build :question_group,title: 'Personal Details', position: 1
-
-  personal_details.questions << build(:short_text_question, code:          :name,
-                                                            question_text: "What's your name?",
-                                                            required:      true,
-                                                            position:      1)
-
-  personal_details.questions << build(:short_text_question, code:          :email,
-                                                            question_text: "What's your E-Mail-Address?",
-                                                            position:      2)
-
-  visit_interval = build :radio_group_question, code:          :visit_interval,
-                                                question_text: 'How often do you visit the Swiss Chees Restaurant?',
-                                                required:      true,
-                                                position:      3
-
-  visit_interval.labels << build(:label, position: 1, text: 'Just once', value: 1)
-  visit_interval.labels << build(:label, position: 2, text: 'Once a year', value: 2)
-  visit_interval.labels << build(:label, position: 3, text: 'Once a Month', value: 3)
-  visit_interval.labels << build(:label, position: 4, text: 'Once a week', value: 4)
-  visit_interval.labels << build(:label, position: 5, text: 'Daily', value:5)
-
-  food_allergy = build :checkbox_group_question, code:           :food_allergy,
-                                                 question_text:  'What kind of food allergy do you have?',
-                                                 position:       4
-
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Garlic', code: 'garlic', position: 1)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Oats', code: 'oat', position: 2)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Meat', code: 'meat', position: 3)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Milk', code: 'milk', position: 4)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Peanut', code: 'peanut', position: 5)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Fish / Shellfish', code: 'fish', position: 6)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Soy', code: 'soy', position: 7)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Wheat', code: 'wheat', position: 9)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Gluten', code: 'gluten', position: 10)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Egg', code: 'egg', position: 11)
-  food_allergy.sub_questions << build(:sub_question, value: 'true', text: 'Sulfites', code: 'sulfites',  position: 12)
-
-  personal_details.questions << visit_interval
-  personal_details.questions << food_allergy
-
-
-  dinner = build :question_group, title: 'About the dinner', position: 2
-  dinner_satisfaction = build :radio_matrix_question, code:          :satisfaction,
-                                                      required:      true,
-                                                      question_text: 'Please rate the quality for each topic',
-                                                      required:      true,
-                                                      position:      1
-
-  dinner_satisfaction.labels << build(:label, position: 1, text: ':-(', value: -1)
-  dinner_satisfaction.labels << build(:label, position: 2, text: ':-|', value: 0, preselected: true)
-  dinner_satisfaction.labels << build(:label, position: 3, text: ':-)', value: 1)
-
-  dinner_satisfaction.sub_questions << build(:sub_question, text: 'Food', code: 'food', position: 1)
-  dinner_satisfaction.sub_questions << build(:sub_question, text: 'Beverages', code: 'beverages', position: 2)
-  dinner_satisfaction.sub_questions << build(:sub_question, text: 'Service', code: 'service', position: 3)
-  dinner_satisfaction.sub_questions << build(:sub_question, text: 'Snacks', code: 'snacks', position: 4)
-  dinner_satisfaction.sub_questions << build(:sub_question, text: 'Cleanliness', code: 'cleanliness', position: 4)
-
-  dinner.questions << dinner_satisfaction
-
-  dinner.questions << build(:short_text_question, code:          :catchphrase,
-                                                  question_text: 'How would you describe the dinner with one word?',
-                                                  required:      true,
-                                                  position:      2)
-
-  dinner.questions << build(:long_text_question, code:             :feedback,
-                                                 question_text:    'Feel free to give us additional feedback ...',
-                                                 position:         3)
-
-  description = <<EOF
-Thank you for your recent stay at our hotel. During your stay you dined at our 5-star Swiss Cheese Restaurant.
-We're conducting a short survey to find out about your dining experience and what we might do to improve.
-Please help us by completing this short survey."
-EOF
-
-  survey = create :survey, name: 'Restaurant customer satisfaction', tag_list: 'restaurant, survey'
-  base_version = survey.versions.create version: 0, question_groups: [personal_details, dinner]
-  base_version.survey_detail = create :survey_detail, title:      '5-star Swiss Cheese Restaurant customer satisfaction',
-                                                      version:     base_version,
-                                                      description: description
-
-  published_version = publish(base_version)
-  generate_sessions(survey, published_version)
-end
-
-def default_session_report
-  haml = File.read(File.dirname(__FILE__) + '/../app/views/helena/admin/versions/default_session_report.html.haml')
-  Haml::Engine.new(haml).render
+  survey_importer = Helena::SurveyImporter.new File.read(File.dirname(__FILE__) + '/swls_survey.en.yml')
+  generate_sessions(survey_importer.survey, survey_importer.survey.newest_version)
 end
 
 def publish(version)
   published_version = Helena::VersionPublisher.publish(version)
   published_version.notes = Faker::Lorem.paragraph(1)
-  published_version.session_report = default_session_report
   published_version.save
   published_version
 end
-
+# rubocop:disable Metrics/MethodLength
 def generate_sessions(survey, version)
-  3.times {
-   survey.sessions << build(:session, version: version, updated_at: DateTime.now - rand(999), completed: false)
-  }
+  3.times { survey.sessions << build(:session, version: version, updated_at: DateTime.now - rand(999), completed: false) }
 
-  3.times {
+  3.times do
     session = build :session, version: version, updated_at: DateTime.now - rand(999), completed: true
     version.question_groups.map(&:questions).flatten.each do |question|
       case question
       when Helena::Questions::ShortText
-        session.answers << build(:string_answer, code: question.code, value: Faker::Skill.tech_skill )
+        session.answers << build(:string_answer, code: question.code, value: Faker::Skill.tech_skill)
       when Helena::Questions::LongText
-        session.answers << build(:string_answer, code: question.code, value: Faker::Skill.tech_skill )
+        session.answers << build(:string_answer, code: question.code, value: Faker::Skill.tech_skill)
       when Helena::Questions::RadioGroup
         session.answers << Helena::Answer.build_generic(question.code, question.labels.sample.value, Faker::Internet.ip_v4_address)
       when Helena::Questions::CheckboxGroup
@@ -175,8 +47,8 @@ def generate_sessions(survey, version)
       end
     end
     survey.sessions << session
-  }
+  end
 end
+# rubocop:enable Metrics/MethodLength
 
 create_satisfaction_scale_survey
-create_restaurant_survey

data/db/swls_survey.en.yml

@@ -0,0 +1,67 @@
+# Helena survey template for "The Satisfaction with Life Scale"
+# http://internal.psychology.illinois.edu/~ediener/SWLS.html
+# Ed Diener, Robert A. Emmons, Randy J. Larsen and Sharon Griffin as noted in the 1985 article in the Journal of Personality Assessment.
+
+name: The Satisfaction with Life Scale
+tags:
+  - others
+language: en
+
+versions:
+  0:
+    notes: initial version
+    survey_detail:
+      title: The Satisfaction with Life Scale
+      description: A 5-item scale designed to measure global cognitive judgments of ones life satisfaction. – Ed Diener
+
+    question_groups:
+      1:
+        questions:
+          1:
+            code: satisfaction
+            _type: Helena::Questions::RadioMatrix
+            required: true
+            question_text: 'Below are five statements with which you may agree or disagree.
+                            Using the 1-7 scale below, indicate your agreement with each item by placing the
+                            appropriate number in the line preceding that item. Please be open and honest in
+                            your responding.'
+            required: true
+            labels:
+              1:
+                text: Strongly Disagree
+                value: 0
+              2:
+                text: Disagree
+                value: 1
+              3:
+                text: Slightly Disagree
+                value: 2
+              4:
+                text: Neither Agree or Disagree
+                value: 3
+              5:
+                text: Slightly Agree
+                value: 4
+              6:
+                text: Agree
+                value: 5
+              7:
+                text: Strongly Agree
+                value: 6
+
+            sub_questions:
+              1:
+                text: In most ways my life is close to my ideal.
+                code: life_is_ideal
+              2:
+                text: The conditions of my life are excellent.
+                code: condition
+              3:
+                text: I am satisfied with life.
+                code: satisfied_with_life
+              4:
+                text: So far I have gotten the important things I want in life.
+                code: important_things
+              5:
+                text: If I could live my life over, I would change almost nothing.
+                code: nothing_to_change

data/helena.gemspec

@@ -24,6 +24,7 @@ survey/test development, longitudinal studies and instant feedback.'
   s.add_dependency 'mongoid_orderable', '~> 4.1'
   s.add_dependency 'mongoid-simple-tags', '~> 0.1'
   s.add_dependency 'haml-rails', '~> 0.5'
+  s.add_dependency 'slim', '~> 2.1.0'
   s.add_dependency 'jquery-rails', '~> 3.1'
   s.add_dependency 'sass-rails', '~> 4.0.3' # version needed here http://stackoverflow.com/questions/22392862/undefined-method-environment-for-nilnilclass-when-importing-bootstrap
   s.add_dependency 'bootstrap-sass', '~> 3.2'

data/lib/helena/engine.rb

@@ -2,5 +2,16 @@ module Helena
   class Engine < ::Rails::Engine
     isolate_namespace Helena
     config.i18n.load_path += Dir[config.root.join('config', 'locales', '**', '*.{rb,yml}').to_s]
+
+    # Thanks to https://github.com/thoughtbot/factory_girl_rails/pull/42
+    initializer 'helena.factories', after: 'factory_girl.set_factory_paths' do
+      FactoryGirl.definition_file_paths << File.expand_path('../../../spec/factories', __FILE__) if defined?(FactoryGirl)
+    end
+
+    config.to_prepare do
+      Dir.glob(Rails.root + 'app/decorators/**/*_decorator*.rb').each do |c|
+        require_dependency c
+      end
+    end
   end
 end

data/lib/helena/survey_importer.rb

@@ -0,0 +1,52 @@
+require 'yaml'
+
+module Helena
+  class SurveyImporter
+    attr_accessor :survey
+
+    def initialize(yaml_string)
+      @parsed = YAML.load yaml_string
+
+      create_survey
+    end
+
+    private
+
+    def create_survey
+      @survey = Helena::Survey.new @parsed.except('versions')
+      return unless @survey.save
+      return unless @parsed['versions']
+      @parsed['versions'].each { |parsed_version| create_version parsed_version }
+    end
+
+    def create_version(parsed_version)
+      version = build_version(parsed_version)
+
+      return unless version.save
+      return unless parsed_version.last['question_groups']
+      parsed_version.last['question_groups'].each { |parsed_question_group| create_question_group version, parsed_question_group }
+    end
+
+    def create_question_group(version, parsed_question_group)
+      question_group = version.question_groups.build parsed_question_group.last.except('questions')
+      question_group.position = parsed_question_group.first
+      return unless question_group.save
+      return unless parsed_question_group.last['questions']
+      parsed_question_group.last['questions'].each { |parsed_question| create_question question_group, parsed_question }
+    end
+
+    def create_question(question_group, parsed_question)
+      question = question_group.questions.build parsed_question.last
+      question.position = parsed_question.first
+      question.save
+      question
+    end
+
+    def build_version(parsed_version)
+      version = @survey.versions.build parsed_version.last.except('question_groups')
+      version.version = parsed_version.first
+      version.survey_detail = parsed_version.last['survey_detail']
+      version
+    end
+  end
+end

data/lib/helena/version.rb

@@ -1,3 +1,3 @@
 module Helena
-  VERSION = '0.3.3'
+  VERSION = '1.0.0.rc1'
 end

data/lib/helena/version_publisher.rb

@@ -1,16 +1,48 @@
 module Helena
   class VersionPublisher
     def self.publish(version)
-      copied_version = version.dup
-      copied_version.survey = version.survey
+      copied_version = create_copied_version_from(version)
+
+      version.question_groups.each do |original_question_group|
+        question_group = copied_version.question_groups.create reset_ids(original_question_group.attributes)
+        original_question_group.questions.each do |original_question|
+          question = question_group.questions.create reset_ids(original_question.attributes)
+          question.labels = original_question.labels
+          question.sub_questions = original_question.sub_questions
+        end
+      end
+      copied_version
+    end
+
+    def self.adjust_copied_attributes(version, copied_version)
       copied_version.version = newest_version_of(version.survey) + 1
       copied_version.created_at = DateTime.now
       copied_version.updated_at = DateTime.now
+      copied_version.active = false
       copied_version
     end
 
     def self.newest_version_of(survey)
       survey.newest_version.version
     end
+
+    def self.create_copied_version_from(version)
+      copied_version = Helena::Version.new reset_ids(version.attributes)
+      copied_version = adjust_copied_attributes(version, copied_version)
+      copied_version.survey_detail = reset_ids(version.survey_detail.attributes) if version.survey_detail
+      copied_version.save
+      copied_version
+    end
+
+    def self.reset_ids(attributes)
+      attributes.each do |key, value|
+        if key == '_id' && value.is_a?(BSON::ObjectId)
+          attributes[key] = BSON::ObjectId.new
+        elsif value.is_a?(Hash) || value.is_a?(Array)
+          attributes[key] = reset_ids(value)
+        end
+      end
+      attributes
+    end
   end
 end

data/lib/helena.rb

@@ -1,10 +1,13 @@
 require 'helena/engine'
 require 'haml'
 require 'helena/version_publisher'
+require 'helena/survey_importer'
 require 'mongoid'
+require 'simple_form' # TODO: Remove this when amdin interface is finally moved
 require 'mongoid_orderable'
 require 'mongoid-simple-tags'
 require 'csv'
+require 'slim'
 
 module Helena
 end

data/spec/controllers/helena/sessions_controller_spec.rb

@@ -4,10 +4,8 @@ describe Helena::SessionsController do
   routes { Helena::Engine.routes }
 
   let(:survey) { create :survey }
+  let(:version) { survey.versions.create version: 0 }
   let(:session) do
-    baseversion = survey.versions.create version: 0
-    version = Helena::VersionPublisher.publish(baseversion)
-    version.save
     create :session, survey: survey, version: version, answers: [
       build(:string_answer, code: 'string_answer_1', value: 'abc'),
       build(:integer_answer, code: 'integer_answer_1', value: '123')
@@ -21,4 +19,11 @@ describe Helena::SessionsController do
     expect(result['answer']['string_answer_1']).to eq 'abc'
     expect(result['answer']['integer_answer_1']).to eq 123
   end
+
+  it 'renders session_report as slim template' do
+    session.version.update_attribute :session_report, 'h1 make it slim!'
+    get :show, token: session.view_token
+
+    expect(response.body).to eq '<h1>make it slim!</h1>'
+  end
 end

data/spec/dummy/app/controllers/application_controller.rb

@@ -2,8 +2,4 @@ class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.
   protect_from_forgery with: :exception
-
-  def can_administer?
-    true
-  end
 end

data/spec/factories/helena/labels.rb

@@ -2,6 +2,5 @@ FactoryGirl.define do
   factory :label, class: Helena::Label do
     sequence(:text)  { |n| "Option #{n}" }
     sequence(:value)
-    sequence(:position)
   end
 end

data/spec/factories/helena/question_groups.rb

@@ -1,6 +1,5 @@
 FactoryGirl.define do
   factory :question_group, class: Helena::QuestionGroup do
     sequence(:title)  { |n| "Page #{n}" }
-    sequence(:position)
   end
 end

data/spec/factories/helena/questions.rb

@@ -1,7 +1,6 @@
 FactoryGirl.define do
   factory :question, class: Helena::Question do
     sequence(:question_text)  { |n| "Question #{n}, #{Faker::Lorem.words(3).join(' ')}?" }
-    sequence(:position)
     sequence(:code) { |n| "x#{n}" }
 
     factory :short_text_question, class: Helena::Questions::ShortText

data/spec/factories/helena/sub_questions.rb

@@ -2,6 +2,5 @@ FactoryGirl.define do
   factory :sub_question, class: Helena::SubQuestion do
     sequence(:text)  { |n| "Question #{n}, #{Faker::Lorem.words(3).join(' ')}?" }
     sequence(:code) { |n| "y#{n}" }
-    sequence(:position)
   end
 end

data/spec/factories/helena/surveys.rb

@@ -1,7 +1,6 @@
 FactoryGirl.define do
   factory :survey, class: Helena::Survey do
     sequence(:name)  { |n| "Survey #{n}" }
-    sequence(:position)
     language 'en'
   end
 end