hecks 3.12.0 → 3.14.0

data/lib/hecks/projections/site/edge.rb

@@ -7,6 +7,7 @@ require_relative "edge/row_reader"
 require_relative "edge/checks"
 require_relative "edge/behaviours"
 require_relative "edge/rules"
+require_relative "edge/function_code"
 
 module Hecks
   module Projections
@@ -16,17 +17,33 @@ module Hecks
       #
       # The routes are the table's own `Route` rows. What a table cannot know, the names a template
       # gives its policies, origins, target groups and listener, a project declares as `member`
-      # rows of four more value objects of the same chapter: `Edge` (the template and listener),
-      # `EdgePolicy`, `EdgeOrigin` and `EdgeRule`. `docs/site-routes.md` lists their fields. A
-      # project that declares none of the four has no edge to project.
+      # rows of five more value objects of the same chapter: `Edge` (the template and listener),
+      # `EdgePolicy`, `EdgeOrigin`, `EdgeRule` and `EdgeFunction` (a viewer-request function a route
+      # names with `edge:`). `docs/site-routes.md` lists their fields. A project that declares none
+      # of the five has no edge to project.
       class Edge
         Setting  = Struct.new(:template, :listener, :secret_header, :secret_value, :alb, keyword_init: true)
         Policy   = Struct.new(:cache_class, :origin, :cache, :origin_request, :response_headers, keyword_init: true)
         Upstream = Struct.new(:origin, :id, :target_group, keyword_init: true)
         Rule     = Struct.new(:rule, :priority, :origin, keyword_init: true)
 
+        # A function the generator writes: `kind` says which, and the rest are its settings, the
+        # lists as comma-separated text.
+        Function = Struct.new(:name, :kind, :host, :aliases, :paths, keyword_init: true) do
+          # @return [Array<String>] the alias hosts that are redirected
+          def alias_list = split(aliases)
+
+          # @return [Array<String>] the exact paths the function watches
+          def path_list = split(paths)
+
+          private
+
+          def split(text) = text.to_s.split(",").map(&:strip).reject(&:empty?)
+        end
+
         # The value objects a project declares its edge rows in, by the kind of record each holds.
-        OBJECTS = { setting: "Edge", policy: "EdgePolicy", upstream: "EdgeOrigin", rule: "EdgeRule" }.freeze
+        OBJECTS = { setting: "Edge", policy: "EdgePolicy", upstream: "EdgeOrigin", rule: "EdgeRule",
+                    function: "EdgeFunction" }.freeze
 
         # The fields each kind of row may carry, with the Ruby class each takes.
         FIELDS = {
@@ -34,14 +51,15 @@ module Hecks
           policy:   { cache_class: String, origin: String, cache: String, origin_request: String,
                     response_headers: String },
           upstream: { origin: String, id: String, target_group: String },
-          rule:     { rule: String, priority: Integer, origin: String }
+          rule:     { rule: String, priority: Integer, origin: String },
+          function: { name: String, kind: String, host: String, aliases: String, paths: String }
         }.freeze
 
         # The fields a row of each kind must carry. The template may instead be named to the tool.
         REQUIRED = { setting: [], policy: %i[cache_class cache], upstream: %i[origin id],
-                     rule: %i[rule priority origin] }.freeze
+                     rule: %i[rule priority origin], function: %i[name kind host aliases paths] }.freeze
 
-        STRUCTS = { setting: Setting, policy: Policy, upstream: Upstream, rule: Rule }.freeze
+        STRUCTS = { setting: Setting, policy: Policy, upstream: Upstream, rule: Rule, function: Function }.freeze
 
         # @return [Setting] the template and the listener
         attr_reader :setting
@@ -51,6 +69,8 @@ module Hecks
         attr_reader :upstreams
         # @return [Array<Rule>] the listener rules
         attr_reader :rules
+        # @return [Array<Function>] the edge functions the generator writes
+        attr_reader :functions
         # @return [Hash{Symbol => Object}] the default behaviour as `Cdn.behavior_lines` takes it
         attr_reader :default_behaviour
         # @return [Array<Hash{Symbol => Object}>] the other behaviours, in matching order
@@ -65,11 +85,12 @@ module Hecks
         # @param vocabulary [Hash{Symbol => Array<String>}] the Site chapter's closed sets
         # @param template [String, nil] the template the caller names, which stands in for the
         #   `Edge` row's own `template:`
-        # @return [Edge, nil] the checked edge, or nil when the chapter declares none
+        # @return [Edge, nil] the checked edge, or nil when the chapter declares none and no route
+        #   names an edge function
         # @raise [Table::Invalid] when a row is refused or the edge contradicts the routes
         def self.read(chapter, table:, vocabulary:, template: nil)
           declared = OBJECTS.transform_values { |name| Table.rows_of(chapter, name) }
-          return nil if declared.values.all?(&:empty?)
+          return nil if declared.values.all?(&:empty?) && table.rows.none?(&:edge)
 
           problems = []
           records = declared.to_h { |kind, members| [kind, build(kind, members, problems)] }
@@ -104,6 +125,7 @@ module Hecks
           @policies = records.fetch(:policy)
           @upstreams = records.fetch(:upstream)
           @rules = records.fetch(:rule)
+          @functions = records.fetch(:function)
         end
         private :assign
 
@@ -119,6 +141,10 @@ module Hecks
         #   unless the `Edge` row says `alb: false`
         def alb? = setting.nil? || setting.alb != false
 
+        # @param name [String] a logical id
+        # @return [Function, nil] the function row of that name
+        def function(name) = functions.find { |candidate| candidate.name == name }
+
         # @param origin [String] an origin of the Origin set
         # @return [Upstream, nil] its CloudFront origin and target group
         def upstream(origin) = upstreams.find { |candidate| candidate.origin == origin }

data/lib/hecks/projections/site/site_cdn.rb

@@ -7,12 +7,14 @@ require_relative "edge"
 module Hecks
   module Projections
     module Site
-      # The edge of a site's route table as the two blocks of a CloudFormation template that depend
-      # on it: the distribution's cache behaviours and the load balancer's listener rules.
+      # The edge of a site's route table as the blocks of a CloudFormation template that depend on
+      # it: the distribution's cache behaviours, the load balancer's listener rules and the
+      # functions the behaviours attach.
       #
-      # The blocks are returned by name, `"behaviors"` and `"listener_rules"`, as text from the
-      # left margin; a project whose `Edge` row says `alb: false` has no load balancer and gets
-      # `"behaviors"` alone. `Regions` puts each between the markers of the same name in the
+      # The blocks are returned by name, `"behaviors"`, `"listener_rules"` and `"edge_functions"`,
+      # as text from the left margin; a project whose `Edge` row says `alb: false` has no load
+      # balancer and gets no `"listener_rules"`, and one with no `EdgeFunction` row gets no
+      # `"edge_functions"`. `Regions` puts each between the markers of the same name in the
       # project's template, at the markers' indentation. The text is a pure function of the table
       # and the edge rows.
       module SiteCdn
@@ -34,9 +36,21 @@ module Hecks
           edge = options[:edge] || Edge.read(bluebook, table: table, vocabulary: Table.vocabulary(registry))
           return {} unless edge
 
-          return { "behaviors" => behaviors(edge) } unless edge.alb?
+          regions(edge)
+        end
 
-          { "behaviors" => behaviors(edge), "listener_rules" => listener_rules(edge) }
+        # @param edge [Edge] a checked edge
+        # @return [Hash{String => String}] the regions the edge needs
+        def regions(edge)
+          { "behaviors" => behaviors(edge) }
+            .merge(edge.alb? ? { "listener_rules" => listener_rules(edge) } : {})
+            .merge(edge.functions.any? ? { "edge_functions" => edge_functions(edge) } : {})
+        end
+
+        # @param edge [Edge] a checked edge
+        # @return [String] one function resource per `EdgeFunction` row, ending in a newline
+        def edge_functions(edge)
+          edge.functions.map { |function| Edge::FunctionCode.resource(function) }.join("\n")
         end
 
         # @param edge [Edge] a checked edge

data/lib/hecks/projections/site/table/row_builder.rb

@@ -11,7 +11,7 @@ module Hecks
                          :indexable, :switch, :off, :preview, :label, :seo, :redirect_to, :aliases,
                          :nav_group, :nav_order, :mobile_order, :footer_column, :footer_order,
                          :admin_key, :admin_order, :compress, :alb_rule, :cdn,
-                         :seo_title, :edge_verbs, :mobile_heading, :explicit_cache, keyword_init: true)
+                         :seo_title, :edge_verbs, :mobile_heading, :explicit_cache, :edge, keyword_init: true)
 
         # Turns a declared member into a `Row`: checks its fields and their types, fills the
         # defaults, and checks each closed-set value against the Site chapter's vocabulary.
@@ -23,7 +23,10 @@ module Hecks
                      aliases: String, nav_group: String, nav_order: Integer, mobile_order: Integer,
                      footer_column: String, footer_order: Integer, admin_key: String,
                      admin_order: Integer, compress: :bool, alb_rule: String, cdn: :bool,
-                     seo_title: String, edge_methods: String, mobile_heading: String }.freeze
+                     seo_title: String, edge_methods: String, mobile_heading: String, edge: String }.freeze
+
+          # What an `edge:` names: the logical id of an `EdgeFunction` row.
+          EDGE_NAME = /\A[A-Za-z][A-Za-z0-9]*\z/
 
           # The value objects of the Site chapter's `Route` aggregate whose members are the closed
           # sets, by the row field each constrains.
@@ -103,6 +106,13 @@ module Hecks
               problem(label, "has #{field} #{row[field].inspect}; #{field} is one of #{@vocabulary.fetch(field).join(", ")}")
             end
             check_verbs(row, label)
+            check_edge(row, label)
+          end
+
+          def check_edge(row, label)
+            return unless row.edge.is_a?(String) && !EDGE_NAME.match?(row.edge)
+
+            problem(label, "has edge #{row.edge.inspect}; an edge is the logical id of an EdgeFunction row")
           end
 
           def check_verbs(row, label)

data/lib/hecks/projections/site/table.rb

@@ -60,7 +60,8 @@ module Hecks
 
         # @param registry [Runtime::Registry] a registry holding the Site chapter
         # @return [Hash{Symbol => Array<String>}] each constrained field to its allowed values, and
-        #   `:http_method` to the verbs a route may answer
+        #   `:http_method` to the verbs a route may answer and `:edge_function_kind` to the kinds of
+        #   `EdgeFunction` row
         # @raise [Invalid] when the registry does not hold the Site chapter
         def self.vocabulary(registry)
           site = registry.bluebook("Site") or
@@ -69,7 +70,8 @@ module Hecks
           members = lambda do |name|
             route.value_objects.find { |object| object.hecks_name == name }.members.map { |member| member.fetch(:value) }
           end
-          RowBuilder::VOCABULARY.transform_values(&members).merge(http_method: members.call("HttpMethod"))
+          closed = RowBuilder::VOCABULARY.transform_values(&members)
+          closed.merge(http_method: members.call("HttpMethod"), edge_function_kind: members.call("EdgeFunctionKind"))
         end
 
         # @param chapter [Bluebook::Chapter] a chapter to search

data/lib/hecks/quality_control/quality_control.bluebook

@@ -54,13 +54,13 @@ Hecks.bluebook "QualityControl" do
     attribute :reason,     TargetReason
 
     value_object "TargetReference" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a target is referenced") { !value.to_s.empty? }
     end
 
     # Required: a name can be disputed, a path can be opened.
     value_object "TargetPath" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a target says where it is") { !value.to_s.empty? }
     end
 
@@ -87,7 +87,7 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "TargetReason" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("shelving a target says why") { !value.to_s.empty? }
     end
 
@@ -99,7 +99,7 @@ Hecks.bluebook "QualityControl" do
 
     # One mode name, as `EligibleFor`'s argument; a query attribute, never stored.
     value_object "Capability" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a mode is named") { !value.to_s.empty? }
     end
 
@@ -300,7 +300,7 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "DomainPath" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a domain is named by its path") { !value.to_s.empty? }
     end
@@ -361,12 +361,12 @@ Hecks.bluebook "QualityControl" do
     attribute :checks,    list_of(Check)
 
     value_object "SweepReference" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a sweep is referenced") { !value.to_s.empty? }
     end
 
     value_object "Engineer" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a sweep says who ran it") { !value.to_s.empty? }
     end
 
@@ -381,13 +381,13 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "SweepNotes" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       # The number is in the sentence because the sentence is the refusal message.
       invariant("a sweep says what it learned, in at least 40 characters") { value.to_s.size >= 40 }
     end
 
     value_object "WaiverReason" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a waived gate says why") { !value.to_s.empty? }
     end
 
@@ -395,7 +395,7 @@ Hecks.bluebook "QualityControl" do
     # literals, so `spec/quality_control_spec.rb` pins the two equal. "nobody" is refused: unsigned
     # is anonymous.
     value_object "WaivedBy" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a gate is waived by a person, never by the loop") { value != "qa_sweep" }
       invariant("a waiver is signed") { value != "nobody" }
     end
@@ -418,13 +418,13 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "Subject" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a check names what it put to the system") { !value.to_s.empty? }
     end
 
     # Written before the answer exists: an expectation fitted to the answer cannot be surprised.
     value_object "Expectation" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a check says what it expected") { !value.to_s.empty? }
     end
 
@@ -637,37 +637,37 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "DomainPath" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a domain is named by its path") { !value.to_s.empty? }
     end
 
     value_object "DataPath" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a data directory is named by its path") { !value.to_s.empty? }
     end
 
     value_object "DatabaseName" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a database is named") { !value.to_s.empty? }
     end
 
     value_object "RoleName" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a role is named") { !value.to_s.empty? }
     end
 
     value_object "SchemaName" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a schema is named") { !value.to_s.empty? }
     end
 
     value_object "StepVerb" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a step names its verb") { !value.to_s.empty? }
     end
@@ -770,7 +770,7 @@ Hecks.bluebook "QualityControl" do
     attribute :window,        StaleAfter
 
     value_object "BugReference" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a bug is referenced") { !value.to_s.empty? }
     end
 
@@ -783,56 +783,56 @@ Hecks.bluebook "QualityControl" do
     # value object sharing a word with any aggregate resolves to that class once the other domain
     # boots.
     value_object "BugTitle" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a bug is titled") { !value.to_s.empty? }
     end
 
     # Required at `Log`, which is what makes the one absolute rule absolute.
     value_object "Demonstration" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a bug is proven by a test somebody can re-run") { !value.to_s.empty? }
     end
 
     value_object "Symptom" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a bug says what actually happened") { !value.to_s.empty? }
     end
 
     value_object "Expectation" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a bug says what should have happened") { !value.to_s.empty? }
     end
 
     value_object "BugSite" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an investigation names where the bug lives") { !value.to_s.empty? }
     end
 
     value_object "BugCause" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an investigation says why the code is wrong") { !value.to_s.empty? }
     end
 
     # 7 to 40 hex: a fix that lives only in a working tree is not a fix.
     value_object "CommitRef" do
-      attribute :value, String, pattern: '^[0-9a-fA-F]{7,40}$'
+      attribute :value, String, matches: :git_sha
     end
 
     # What was actually run, e.g. "rspec --order random, 1335 examples, 0 failures, seed 12345":
     # a count and a seed are checkable, "tests pass" is not.
     value_object "Verification" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a verification says what was actually run") { !value.to_s.empty? }
     end
 
     value_object "BugReason" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("stopping on a bug says why") { !value.to_s.empty? }
     end
 
     # Who decides and what would unblock it, so "deferred" does not become "forgotten".
     value_object "NextStep" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("stopping on a bug says what would move it") { !value.to_s.empty? }
     end
 
@@ -842,14 +842,14 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "WaiverReason" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a waived gate says why") { !value.to_s.empty? }
     end
 
     # Redeclared, as elsewhere in this file; the "qa_sweep" literal is pinned to AUTOMATED_ENGINEER
     # by spec.
     value_object "WaivedBy" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a gate is waived by a person, never by the loop") { value != "qa_sweep" }
       invariant("a waiver is signed") { value != "nobody" }
     end
@@ -881,7 +881,7 @@ Hecks.bluebook "QualityControl" do
     # Not an `Engineer`: that type defaults to "nobody" (an unclaimed bug is held by nobody), which
     # would let a report omit its submitter. This type has no default and refuses "nobody".
     value_object "Submitter" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a bug is reported by somebody") { value != "nobody" }
     end
@@ -1237,27 +1237,27 @@ Hecks.bluebook "QualityControl" do
     attribute :reason,      AngleReason
 
     value_object "AngleReference" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an angle is referenced") { !value.to_s.empty? }
     end
 
     # The number is in the sentence because the sentence is the refusal; 60 characters trips a
     # stub.
     value_object "AnglePremise" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an angle says enough to be acted on without its proposer in the room, in at least 60 characters") { value.to_s.size >= 60 }
     end
 
     # A Bug reference, ADR number or named gap that a reader can check for themselves.
     value_object "AngleCitation" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an angle cites something concrete, not a mood") { !value.to_s.empty? }
     end
 
     # Not an `Engineer`, for the reason `Submitter` is not: that default would let authorship go
     # unrecorded.
     value_object "Proposer" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an angle is proposed by somebody") { value != "nobody" }
     end
 
@@ -1268,13 +1268,13 @@ Hecks.bluebook "QualityControl" do
 
     # What came of it (a Target, a PR number, a domain path); set once, at `Build`.
     value_object "AngleResolution" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a built angle says what actually got built") { !value.to_s.empty? }
     end
 
     # Redeclared as `Target::Shelve` does: a discard with no reason looks like a lead nobody read.
     value_object "AngleReason" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("discarding an angle says why") { !value.to_s.empty? }
     end
 
@@ -1401,7 +1401,7 @@ Hecks.bluebook "QualityControl" do
     attribute :max_attempts, MaxAttempts
 
     value_object "TicketReference" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a ticket is referenced") { !value.to_s.empty? }
     end
 
@@ -1410,7 +1410,7 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "TicketTitle" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a ticket is titled") { !value.to_s.empty? }
     end
 
@@ -1421,7 +1421,7 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "TicketBody" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a ticket says something") { !value.to_s.empty? }
     end
 
@@ -1647,22 +1647,22 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "PatchUrl" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a patch says where it lives") { !value.to_s.empty? }
     end
 
     value_object "PatchBranch" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a patch says which branch it is on") { !value.to_s.empty? }
     end
 
     # Recorded at `Open` so the commit is in hand when the PR needs checking, as `Bug.commit` is.
     value_object "CommitRef" do
-      attribute :value, String, pattern: '^[0-9a-fA-F]{7,40}$'
+      attribute :value, String, matches: :git_sha
     end
 
     value_object "PatchTitle" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a patch is titled") { !value.to_s.empty? }
     end
 
@@ -1840,23 +1840,23 @@ Hecks.bluebook "QualityControl" do
     end
 
     value_object "ImprovementUrl" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an improvement says where it lives") { !value.to_s.empty? }
     end
 
     value_object "ImprovementBranch" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an improvement says which branch it is on") { !value.to_s.empty? }
     end
 
     # Redeclared per aggregate. Absent until `Land`: there is nothing to watch until a commit
     # exists.
     value_object "CommitRef" do
-      attribute :value, String, pattern: '^[0-9a-fA-F]{7,40}$'
+      attribute :value, String, matches: :git_sha
     end
 
     value_object "ImprovementTitle" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("an improvement is titled") { !value.to_s.empty? }
     end
 
@@ -1977,11 +1977,11 @@ Hecks.bluebook "QualityControl" do
     attribute :summary, RunSummary
 
     value_object "CommitRef" do
-      attribute :value, String, pattern: '^[0-9a-fA-F]{7,40}$'
+      attribute :value, String, matches: :git_sha
     end
 
     value_object "RunSummary" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
       invariant("a run says what it ran and what came back") { !value.to_s.empty? }
     end