health_inspector 0.0.4 → 0.0.5

data/HISTORY.md

@@ -1,3 +1,7 @@
+## 0.0.5 ( 2012-04-13 )
+
+* Fix #2, exception when a data bag item json file doesn't exist locally
+
 ## 0.0.4 ( 2012-04-09 )
 
 * Add checks for data bags, data bag items, environments, and roles

data/README.md

@@ -1,6 +1,7 @@
-# Health Inspector
+## Summary
 
-A tool to inspect your chef repo as is compares to what is on your chef server
+`health_inspector` is tool to inspect your chef repo as it compares to what is
+on your chef server.
 
 ## Usage
 
@@ -9,12 +10,20 @@ A tool to inspect your chef repo as is compares to what is on your chef server
 
 Run `health_inspector help` for more options
 
-## What is checks
+## What it does
 
 So far it checks if...
 
-* your chef server has cookbooks you don't have locally
-* your chef server is missing cookbooks you have locally
-* cookbook versions are not the same between server and local chef repo
-* you have uncommitted changes in a cookbook (assuming your cookbook is a git repo)
-* you have commits in a cookbook that haven't been pushed to your remote (assuming your cookbook is a git repo)
+* your cookbooks are in sync
+* you have uncommitted changes in a cookbook (assuming your cookbooks are in
+  their own git repos)
+* you have commits in a cookbook that haven't been pushed to your remote
+  (assuming your cookbooks are in their own git repos)
+* your data bags are in sync
+* your data bag items are in sync
+* your environments are in sync
+* your roles are in sync
+
+## Assumptions
+
+* Your roles and environments are written using the ruby DSL.

data/Rakefile

@@ -1 +1,10 @@
 require "bundler/gem_tasks"
+require 'rake/testtask'
+
+Rake::TestTask.new(:test) do |test|
+  test.libs << 'lib' << 'spec'
+  test.pattern = 'spec/**/*_spec.rb'
+  test.verbose = true
+end
+
+task :default => :test

data/health_inspector.gemspec

@@ -18,9 +18,8 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  # specify any dependencies here; for example:
-  # s.add_development_dependency "rspec"
-  # s.add_runtime_dependency "rest-client"
+  s.add_development_dependency "minitest"
+  s.add_development_dependency "mocha"
   s.add_runtime_dependency "thor"
   s.add_runtime_dependency "chef"
 end

data/lib/health_inspector/checklists/base.rb

@@ -30,7 +30,7 @@ module HealthInspector
         banner "Inspecting #{self.class.title}"
 
         items.each do |item|
-          failures = checks.map { |check| run_check(check, item) }.compact
+          failures = run_checks(item)
 
           if failures.empty?
             print_success(item.name)
@@ -40,6 +40,10 @@ module HealthInspector
         end
       end
 
+      def run_checks(item)
+        checks.map { |check| run_check(check, item) }.compact
+      end
+
       def checks
         self.class.checks
       end

data/lib/health_inspector/checklists/data_bag_items.rb

@@ -62,7 +62,7 @@ module HealthInspector
 
       def load_item_from_local(name)
         JSON.parse( File.read("#{@context.repo_path}/data_bags/#{name}.json") )
-      rescue IOError
+      rescue IOError, Errno::ENOENT
         nil
       end
     end

data/lib/health_inspector/version.rb

@@ -1,3 +1,3 @@
 module HealthInspector
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/chef-repo/.chef/knife.rb

@@ -0,0 +1,7 @@
+chef_repo_dir = File.expand_path( "../", File.dirname(__FILE__) )
+
+client_key               "#{chef_repo_dir}/.chef/client.pem"
+log_level                :info
+log_location             STDOUT
+cache_type               "BasicFile"
+cookbook_path            [ "#{chef_repo_dir}/cookbooks" ]

data/spec/data_bag_item_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe "HealthInspector::Checklists::DataBagItems" do
+  subject do
+    HealthInspector::Checklists::DataBagItems.new(health_inspector_context)
+  end
+
+  it "should detect if a data bag item does not exist locally" do
+    subject.expects(:data_bag_items_on_server).returns( ["apps/app1"] )
+    subject.expects(:load_item_from_server).with("apps/app1").returns({})
+    failures = subject.run_checks(subject.items.first)
+    failures.first.include?("exists on server but not locally").must_equal true
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,21 @@
+require 'rubygems'
+require 'bundler/setup'
+require 'minitest/autorun'
+require 'mocha'
+require 'health_inspector'
+
+module HealthInspector::SpecHelpers
+  def health_inspector_context
+    @health_inspector_context ||= begin
+      repo_path = File.expand_path("../chef-repo", __FILE__)
+
+      HealthInspector::Context.new( repo_path, File.join(repo_path, ".chef/knife.rb") ).tap do |context|
+        context.configure
+      end
+    end
+  end
+end
+
+class MiniTest::Unit::TestCase
+  include HealthInspector::SpecHelpers
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: health_inspector
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,33 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-09 00:00:00.000000000Z
+date: 2012-04-13 00:00:00.000000000Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: &2154652260 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2154652260
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: &2154651840 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2154651840
 - !ruby/object:Gem::Dependency
   name: thor
-  requirement: &2168869000 !ruby/object:Gem::Requirement
+  requirement: &2154651420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2168869000
+  version_requirements: *2154651420
 - !ruby/object:Gem::Dependency
   name: chef
-  requirement: &2168868580 !ruby/object:Gem::Requirement
+  requirement: &2154650960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +54,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2168868580
+  version_requirements: *2154650960
 description: A tool to inspect your chef repo as is compares to what is on your chef
   server
 email:
@@ -63,6 +85,10 @@ files:
 - lib/health_inspector/context.rb
 - lib/health_inspector/inspector.rb
 - lib/health_inspector/version.rb
+- spec/chef-repo/.chef/client.pem
+- spec/chef-repo/.chef/knife.rb
+- spec/data_bag_item_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/bmarini/health_inspector
 licenses: []
 post_install_message: 
@@ -87,5 +113,9 @@ rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: A tool to inspect your chef repo as is compares to what is on your chef server
-test_files: []
+test_files:
+- spec/chef-repo/.chef/client.pem
+- spec/chef-repo/.chef/knife.rb
+- spec/data_bag_item_spec.rb
+- spec/spec_helper.rb
 has_rdoc: