headhunter 0.1.7 → 0.1.8

data/spec/lib/headhunter/html_validator_spec.rb

@@ -0,0 +1,143 @@
+require 'spec_helper'
+
+describe Headhunter::HtmlValidator do
+  describe '#validate' do
+    subject { described_class.new }
+
+    it 'returns a local response when calling the validator succeeds' do
+      expect {
+        subject.validate('invalid.html', read_file('html_validator/invalid.html'))
+      }.to change { subject.responses.count }.by 1
+    end
+
+    it 'throws an exception when calling the validator fails'
+  end
+
+  describe '#x_pages_be' do
+    subject { described_class.new }
+
+    it "creates a grammatically correct sentence when there is no page" do
+      expect(subject.x_pages_be(0)).to eq '0 page is'
+    end
+
+    it "creates a grammatically correct sentence when there is only one page" do
+      expect(subject.x_pages_be(1)).to eq '1 page is'
+    end
+
+    it "creates a grammatically correct sentence when there is more than one page" do
+      expect(subject.x_pages_be(2)).to eq '2 pages are'
+    end
+  end
+
+  describe '#statistics' do
+    context 'for valid HTML' do
+      subject do
+        validator = described_class.new
+        validator.validate('valid.html', read_file('html_validator/valid.html'))
+        validator.statistics
+      end
+
+      it "returns a text with nice statistics" do
+        expect(subject).to match 'Validated 1 page.'
+        expect(subject).to match 'All pages are valid.'
+      end
+    end
+
+    context 'for invalid HTML' do
+      subject do
+        validator = described_class.new
+        validator.validate('invalid.html', read_file('html_validator/invalid.html'))
+        validator.statistics
+      end
+
+      it "returns a text with nice statistics" do
+        expect(subject).to match 'Validated 1 page.'
+        expect(subject).to match '1 page is invalid.'
+        expect(subject).to match 'invalid.html:'
+        expect(subject).to match 'Line 12, column 6: Warning: missing </b> before </p>.'
+        expect(subject).to match 'Line 12, column 54: Warning: discarding unexpected </b>.'
+      end
+    end
+  end
+
+  describe '#valid_responses' do
+    subject do
+      validator = described_class.new
+      validator.validate('valid.html', read_file('html_validator/valid.html'))
+      validator
+    end
+
+    it 'returns all valid responses' do
+      expect(subject.valid_responses.size).to eq 1
+      expect(subject.invalid_responses.size).to eq 0
+    end
+  end
+
+  describe '#invalid_responses' do
+    subject do
+      validator = described_class.new
+      validator.validate('invalid.html', read_file('html_validator/invalid.html'))
+      validator
+    end
+
+    it 'returns all valid responses' do
+      expect(subject.invalid_responses.size).to eq 1
+      expect(subject.valid_responses.size).to eq 0
+    end
+  end
+end
+
+describe Headhunter::HtmlValidator::Response do
+  describe '#initialize' do
+    context 'valid response' do
+      subject { described_class.new(read_file('html_validator/valid_response.txt'), 'some-path.html') }
+
+      it { should be_valid }
+    end
+
+    context 'invalid response' do
+      subject { described_class.new(read_file('html_validator/invalid_response.txt'), 'some-path.html') }
+
+      it { should_not be_valid }
+    end
+  end
+
+  describe '#errors' do
+    context 'valid response' do
+      subject { described_class.new(read_file('html_validator/valid_response.txt'), 'some-path.html') }
+
+      it 'returns an empty array' do
+        expect(subject.errors).to eq []
+      end
+    end
+
+    context 'invalid response' do
+      subject { described_class.new(read_file('html_validator/invalid_response.txt'), 'some-path.html') }
+
+      it 'returns an array of errors' do
+        expect(subject.errors.size).to eq 1
+        expect(subject.errors.first).to be_a Headhunter::HtmlValidator::Response::Error
+      end
+    end
+  end
+
+  describe '#uri' do
+      subject { described_class.new(read_file('html_validator/valid_response.txt'), 'some-path.html') }
+
+    it "returns the validated uri's path" do
+      expect(subject.send :uri).to eq 'some-path.html'
+    end
+  end
+end
+
+describe Headhunter::HtmlValidator::Response::Error do
+  describe '#initialize' do
+    subject { described_class.new(123, "Attribute xyz doesn't exist", context: 'something', anything_else: 'bla') }
+
+    it 'assigns the passed params correctly' do
+      expect(subject.line).to eq 123
+      expect(subject.message).to eq "Attribute xyz doesn't exist"
+      expect(subject.details).to eq context: 'something', anything_else: 'bla'
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,25 @@
+ENV['RAILS_ENV'] ||= 'test'
+
+require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require 'rspec/rails'
+require 'rspec/autorun'
+require 'pry'
+
+Rails.backtrace_cleaner.remove_silencers!
+
+# Load support files
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+RSpec.configure do |config|
+  config.mock_with :rspec
+  config.infer_base_class_for_anonymous_controllers = false
+  config.order = 'random'
+end
+
+def path_to_file(name)
+  File.join(File.dirname(__FILE__), 'files', name)
+end
+
+def read_file(name)
+  File.read(path_to_file(name))
+end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: headhunter
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Joshua Muheim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-13 00:00:00.000000000 Z
+date: 2014-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -38,20 +38,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: 1.2.6
-- !ruby/object:Gem::Dependency
-  name: html_validation
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: colorize
   requirement: !ruby/object:Gem::Requirement
@@ -67,55 +53,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: fuubar
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: coolline
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -123,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: awesome_print
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -137,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: gem-release
+  name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -151,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: jazz_hands
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -164,20 +108,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '2.0'
 description: Headhunter is an HTML and CSS validation tool that injects itself into
   your Rails feature tests and automagically checks all your generated HTML and CSS
   for validity. In addition, it also looks out for unused (and therefore superfluous)
@@ -194,6 +124,7 @@ files:
 - lib/css-validator/lib/velocity-1.7.jar
 - lib/headhunter/css_hunter.rb
 - lib/headhunter/css_validator.rb
+- lib/headhunter/engine.rb
 - lib/headhunter/html_validator.rb
 - lib/headhunter/rack/capturing_middleware.rb
 - lib/headhunter/rails.rb
@@ -202,14 +133,100 @@ files:
 - lib/headhunter/templates/results.html
 - lib/headhunter/version.rb
 - lib/headhunter.rb
-- lib/tidy/tidy
-- Gemfile
-- Gemfile.lock
+- lib/tasks/headhunter_tasks.rake
+- lib/tidy/tidy2
+- MIT-LICENSE
 - Rakefile
-- README.md
-- docs/headhunter.png
-- docs/money.png
-- docs/screenshot.png
+- README.rdoc
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/assets/stylesheets/scaffold.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/posts_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/posts/index.html.erb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/config.ru
+- spec/dummy/Gemfile
+- spec/dummy/Gemfile.lock
+- spec/dummy/log/development.log
+- spec/dummy/log/test.log
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/dummy/Rakefile
+- spec/dummy/README.rdoc
+- spec/dummy/spec/features/bla_spec.rb
+- spec/dummy/spec/spec_helper.rb
+- spec/dummy/tmp/cache/assets/development/sprockets/13fe41fee1fe35b49d145bcc06610705
+- spec/dummy/tmp/cache/assets/development/sprockets/1e8f75a6b5b33970fb8e397347caa0a1
+- spec/dummy/tmp/cache/assets/development/sprockets/24204f742af588c8166d3160b500d20f
+- spec/dummy/tmp/cache/assets/development/sprockets/2f5173deea6c795b8fdde723bb4b63af
+- spec/dummy/tmp/cache/assets/development/sprockets/357970feca3ac29060c1e3861e2c0953
+- spec/dummy/tmp/cache/assets/development/sprockets/371bf96e99717688ed7313a0c53f4212
+- spec/dummy/tmp/cache/assets/development/sprockets/416150dc3ac35079c94273cc46e90aa6
+- spec/dummy/tmp/cache/assets/development/sprockets/510da110ae528e2d22533be39ff696c5
+- spec/dummy/tmp/cache/assets/development/sprockets/5384ad85f52d3272dbc64d46ef3876a4
+- spec/dummy/tmp/cache/assets/development/sprockets/6fc757c2c8329244ca95d6909865bbc2
+- spec/dummy/tmp/cache/assets/development/sprockets/c85016e7bbd4f3adbb7635d01f85d39b
+- spec/dummy/tmp/cache/assets/development/sprockets/cffd775d018f68ce5dba1ee0d951a994
+- spec/dummy/tmp/cache/assets/development/sprockets/d066c004d1fd26ae76a61303a7a18145
+- spec/dummy/tmp/cache/assets/development/sprockets/d771ace226fc8215a3572e0aa35bb0d6
+- spec/dummy/tmp/cache/assets/development/sprockets/f7cbd26ba1d28d48de824f0e94586655
+- spec/dummy/tmp/cache/assets/test/sprockets/13fe41fee1fe35b49d145bcc06610705
+- spec/dummy/tmp/cache/assets/test/sprockets/2f5173deea6c795b8fdde723bb4b63af
+- spec/dummy/tmp/cache/assets/test/sprockets/357970feca3ac29060c1e3861e2c0953
+- spec/dummy/tmp/cache/assets/test/sprockets/371bf96e99717688ed7313a0c53f4212
+- spec/dummy/tmp/cache/assets/test/sprockets/416150dc3ac35079c94273cc46e90aa6
+- spec/dummy/tmp/cache/assets/test/sprockets/5384ad85f52d3272dbc64d46ef3876a4
+- spec/dummy/tmp/cache/assets/test/sprockets/6fc757c2c8329244ca95d6909865bbc2
+- spec/dummy/tmp/cache/assets/test/sprockets/c85016e7bbd4f3adbb7635d01f85d39b
+- spec/dummy/tmp/cache/assets/test/sprockets/cffd775d018f68ce5dba1ee0d951a994
+- spec/dummy/tmp/cache/assets/test/sprockets/d066c004d1fd26ae76a61303a7a18145
+- spec/dummy/tmp/cache/assets/test/sprockets/d771ace226fc8215a3572e0aa35bb0d6
+- spec/dummy/tmp/cache/assets/test/sprockets/f7cbd26ba1d28d48de824f0e94586655
+- spec/files/css_hunter/valid.html
+- spec/files/css_validator/invalid.css
+- spec/files/css_validator/invalid_response.xml
+- spec/files/css_validator/valid.css
+- spec/files/css_validator/valid_response.xml
+- spec/files/html_validator/invalid.html
+- spec/files/html_validator/invalid_response.txt
+- spec/files/html_validator/valid.html
+- spec/files/html_validator/valid_response.txt
+- spec/files/html_with_srcset.html
+- spec/files/html_without_srcset.html
+- spec/files/invalid2.html
+- spec/files/valid-1.css
+- spec/files/valid-2.css
+- spec/files/valid-3.css
+- spec/files/valid.html5
+- spec/files/valid_with_cache_busters.html
+- spec/files/valid_without_cache_busters.html
+- spec/lib/headhunter/css_hunter_spec.rb
+- spec/lib/headhunter/css_validator_spec.rb
+- spec/lib/headhunter/html_validator_spec.rb
+- spec/spec_helper.rb
 homepage: http://github.com/jmuheim/headhunter
 licenses:
 - MIT
@@ -234,4 +251,94 @@ rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Zero config HTML & CSS validation tool for Rails apps
-test_files: []
+test_files:
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/assets/stylesheets/scaffold.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/posts_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/posts/index.html.erb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/config.ru
+- spec/dummy/Gemfile
+- spec/dummy/Gemfile.lock
+- spec/dummy/log/development.log
+- spec/dummy/log/test.log
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/dummy/Rakefile
+- spec/dummy/README.rdoc
+- spec/dummy/spec/features/bla_spec.rb
+- spec/dummy/spec/spec_helper.rb
+- spec/dummy/tmp/cache/assets/development/sprockets/13fe41fee1fe35b49d145bcc06610705
+- spec/dummy/tmp/cache/assets/development/sprockets/1e8f75a6b5b33970fb8e397347caa0a1
+- spec/dummy/tmp/cache/assets/development/sprockets/24204f742af588c8166d3160b500d20f
+- spec/dummy/tmp/cache/assets/development/sprockets/2f5173deea6c795b8fdde723bb4b63af
+- spec/dummy/tmp/cache/assets/development/sprockets/357970feca3ac29060c1e3861e2c0953
+- spec/dummy/tmp/cache/assets/development/sprockets/371bf96e99717688ed7313a0c53f4212
+- spec/dummy/tmp/cache/assets/development/sprockets/416150dc3ac35079c94273cc46e90aa6
+- spec/dummy/tmp/cache/assets/development/sprockets/510da110ae528e2d22533be39ff696c5
+- spec/dummy/tmp/cache/assets/development/sprockets/5384ad85f52d3272dbc64d46ef3876a4
+- spec/dummy/tmp/cache/assets/development/sprockets/6fc757c2c8329244ca95d6909865bbc2
+- spec/dummy/tmp/cache/assets/development/sprockets/c85016e7bbd4f3adbb7635d01f85d39b
+- spec/dummy/tmp/cache/assets/development/sprockets/cffd775d018f68ce5dba1ee0d951a994
+- spec/dummy/tmp/cache/assets/development/sprockets/d066c004d1fd26ae76a61303a7a18145
+- spec/dummy/tmp/cache/assets/development/sprockets/d771ace226fc8215a3572e0aa35bb0d6
+- spec/dummy/tmp/cache/assets/development/sprockets/f7cbd26ba1d28d48de824f0e94586655
+- spec/dummy/tmp/cache/assets/test/sprockets/13fe41fee1fe35b49d145bcc06610705
+- spec/dummy/tmp/cache/assets/test/sprockets/2f5173deea6c795b8fdde723bb4b63af
+- spec/dummy/tmp/cache/assets/test/sprockets/357970feca3ac29060c1e3861e2c0953
+- spec/dummy/tmp/cache/assets/test/sprockets/371bf96e99717688ed7313a0c53f4212
+- spec/dummy/tmp/cache/assets/test/sprockets/416150dc3ac35079c94273cc46e90aa6
+- spec/dummy/tmp/cache/assets/test/sprockets/5384ad85f52d3272dbc64d46ef3876a4
+- spec/dummy/tmp/cache/assets/test/sprockets/6fc757c2c8329244ca95d6909865bbc2
+- spec/dummy/tmp/cache/assets/test/sprockets/c85016e7bbd4f3adbb7635d01f85d39b
+- spec/dummy/tmp/cache/assets/test/sprockets/cffd775d018f68ce5dba1ee0d951a994
+- spec/dummy/tmp/cache/assets/test/sprockets/d066c004d1fd26ae76a61303a7a18145
+- spec/dummy/tmp/cache/assets/test/sprockets/d771ace226fc8215a3572e0aa35bb0d6
+- spec/dummy/tmp/cache/assets/test/sprockets/f7cbd26ba1d28d48de824f0e94586655
+- spec/files/css_hunter/valid.html
+- spec/files/css_validator/invalid.css
+- spec/files/css_validator/invalid_response.xml
+- spec/files/css_validator/valid.css
+- spec/files/css_validator/valid_response.xml
+- spec/files/html_validator/invalid.html
+- spec/files/html_validator/invalid_response.txt
+- spec/files/html_validator/valid.html
+- spec/files/html_validator/valid_response.txt
+- spec/files/html_with_srcset.html
+- spec/files/html_without_srcset.html
+- spec/files/invalid2.html
+- spec/files/valid-1.css
+- spec/files/valid-2.css
+- spec/files/valid-3.css
+- spec/files/valid.html5
+- spec/files/valid_with_cache_busters.html
+- spec/files/valid_without_cache_busters.html
+- spec/lib/headhunter/css_hunter_spec.rb
+- spec/lib/headhunter/css_validator_spec.rb
+- spec/lib/headhunter/html_validator_spec.rb
+- spec/spec_helper.rb
+has_rdoc: