headhunter 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e083d2cf2ed28ecd66e9fd0b7317c39565f996c
-  data.tar.gz: 874442a4314a680b9582be26ff1ac475590b3079
+  metadata.gz: 8d287be5bc2f5e01f890c230b48551f4e5c2e8bd
+  data.tar.gz: 283aca4ad207e9bb2c61521c3d44acfde5a0c3ad
 SHA512:
-  metadata.gz: 3ba8f645a5d4843b2e9e5df932dfe68cc91e2383e0cceb71c85b2c857c0b622e0f476957cadf321614c5302532f764f71056b7e0f6d45b7c2934af15a30c9282
-  data.tar.gz: 7a4e13c8f0df5a84980e24d6ccfe1bd1333152cbbf66b8e754349be72d12a3732d22f6f4b44a31d276e645babef849e00e4eac37c8bde4bb5fd1fb9dd0f8cca2
+  metadata.gz: c101581f77a54f142e17a96b1d981f1bcb2c24f466dd14a03cbd49b541bec26baad1930b12ffd8c40e147443d6e6341b21dccb9523d7c3899468efbc1ed344b8
+  data.tar.gz: a798b94f7f2d39abb98b2ddabe59f9bef8dd2193d7d4ce5d14c78f5b16816da0858ff851a8e4e67d4dc4f8cb2120b66f9bc5d1e97d791057bb1d5a176d2c8394

data/README.md

@@ -26,6 +26,10 @@ Just set the environment variable `HEADHUNTER` to `true` when running your tests
 
 Headhunter doesn't keep your tests from passing if invalid HTML or unused CSS is found. Instead it displays a short statistic after the tests are run.
 
+    $ rake HEADHUNTER=true
+
+    Precompiling assets for Headhunter... done!
+
     30/30 |============================= 100 ==============================>| Time: 00:00:02
 
     Finished in 2.65 seconds
@@ -47,11 +51,9 @@ Headhunter doesn't keep your tests from passing if invalid HTML or unused CSS is
 
 ## How it works
 
-Headhunter registers itself as middleware in the Rack stack and triggers validation for every HTML response.
-
-For every `.css` file, validation is also triggered. In addition, it iterates over every HTML page's selectors to see whether there exist any unused CSS definitions in your `.css` files.
+Headhunter registers itself as middleware in the Rack stack and triggers validation for every HTML response. Headhunter also iterates over every `.css` file and triggers its validation. In addition, it checks which CSS selectors are really used in the HTML pages to see whether there exist any unused CSS definitions.
 
-For being able to validate CSS, `rake assets:precompile` is triggered at the beginning of running tests. This may slow down starting your tests a bit. (Notice: after the tests have finished, the precompiled assets are also removed automatically by running `rake assets:clobber`.)
+For being able to validate CSS, `rake assets:precompile` is triggered at the beginning of running tests. This may slow down starting your tests a bit. **Notice: all precompiled assets will be removed after the tests have finished!**
 
 ## Requirements
 
@@ -74,6 +76,7 @@ You need a working internet connection to run CSS validation. As a Rails applica
 - HTML and CSS sources should not be compressed, to allow more concise error messages
 - Would be really useful to have the concrete URL of every validated HTML page. But can't find a way to extract it from Rack response.
 - There are not tests yet. I first want to see whether this gem would be appreciated by the community, and if so, I will definitely add tests.
+- Didn't try this with AJAX requests yet. Would be great if such responses would be validated, too!
 
 ## Disclaimer
 

data/lib/headhunter/rack/capturing_middleware.rb

@@ -1,4 +1,4 @@
-class Headhunter
+module Headhunter
   module Rack
     class CapturingMiddleware
       def initialize(app, headhunter)

data/lib/headhunter/runner.rb

@@ -1,9 +1,14 @@
+require 'fileutils'
+
 module Headhunter
   class Runner
+    ASSETS_PATH = 'public/assets'
+
     attr_accessor :results
 
     def initialize(root)
-      @root = root
+      @root             = root
+      @temporary_assets = []
 
       precompile_assets!
 
@@ -34,18 +39,18 @@ module Headhunter
     private
 
     def precompile_assets!
-      # Remove existing assets! This seems to be necessary to make sure that they don't exist twice, see http://stackoverflow.com/questions/20938891
-      system 'rake assets:clobber HEADHUNTER=false &> /dev/null'
-
+      log.print "\nPrecompiling assets for Headhunter...".yellow
+      remove_assets! # Remove existing assets! This seems to be necessary to make sure that they don't exist twice, see http://stackoverflow.com/questions/20938891
       system 'rake assets:precompile HEADHUNTER=false &> /dev/null'
+      log.puts " done!\n".yellow
     end
 
     def remove_assets!
-      system 'rake assets:clobber HEADHUNTER=false &> /dev/null'
+      FileUtils.rm_r ASSETS_PATH if File.exist?(ASSETS_PATH)
     end
 
     def stylesheets
-      Dir.chdir(@root) { Dir.glob('public/assets/*.css') }
+      Dir["#{ASSETS_PATH}/*.css"]
     end
   end
 end

data/lib/headhunter/version.rb

@@ -1,3 +1,3 @@
 module Headhunter
-  VERSION = '0.0.5'
+  VERSION = '0.0.7'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: headhunter
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - Joshua Muheim