headdesk 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e812c6195d207316fbcb2e365a7ad4828d12667586ffec08c40d9a61f0c92714
-  data.tar.gz: 817934245dfea92c9b7b05f961272c9286031d18e9861170fe042ca39d5e50ab
+  metadata.gz: 9067a4b373fd01b502fd6cb77fafc2bd1c60e9d18aef42390832e855bf6437e8
+  data.tar.gz: 3eccbb70deffe105e84a5ae0bfd6aecf8977ae9d9399665863570681fa92933a
 SHA512:
-  metadata.gz: 74b4a8e37fa5a3003158611c50cf66687af8f6444c945524beec638baebb2f2e1a1779b61b4602a6325cf6ce31a1d9346e72665cbf6d87a6a725ac3ae9682c70
-  data.tar.gz: 4a9e4b8a17c9fe03e9aa98d9b2a0cba3f3dd67a80157ee153e85256a9e5f8ff91688801c845d86e01ccc85900705c056fb1166711e18da6b36e44ab8e1580b22
+  metadata.gz: 046264add67d0b39f07a5d57eb95372fd5b0ba5278443c17768aade9932a3c2a868454f25a239df242644f61b4ec766370aed860ef8944a64012c8de6726dace
+  data.tar.gz: eac8f28b1aa2ddc80bb30369f9b384dc2c6928a611720b16b914705498d448feaa10e66a90cf19c98e646f64d17595f33df2d3d24e2468f2eeeb3249c0082f87

data/.rubocop.yml

@@ -0,0 +1,5 @@
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false

data/Gemfile

@@ -4,6 +4,7 @@ source 'https://rubygems.org'
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
+gem 'reek'
 gem 'rubocop'
 
 # Specify your gem's dependencies in headdesk.gemspec

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    headdesk (0.9.0)
+    headdesk (0.10.0)
       awesome_print (~> 1.8)
+      gems (~> 1.1)
       nokogiri (~> 1.10)
       oily_png (~> 1.2)
       thor (~> 0.20)
@@ -25,8 +26,11 @@ GEM
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.3)
     equalizer (0.0.11)
+    gems (1.1.1)
+      json
     ice_nine (0.11.2)
     jaro_winkler (1.5.2)
+    json (2.1.0)
     kwalify (0.7.2)
     mini_portile2 (2.4.0)
     nokogiri (1.10.1)
@@ -84,7 +88,7 @@ DEPENDENCIES
   bundler (~> 2.0)
   headdesk!
   rake (~> 10.0)
-  reek (~> 5.2)
+  reek
   rspec (~> 3.8)
   rubocop
 

data/docs/api26.md

@@ -12,3 +12,6 @@ As of November 1, 2018 Google Play requires that all apps, and app updates, targ
 
 > Google Play will require that new apps target at least Android 8.0 (API level 26) from August 1, 2018, and that app updates target Android 8.0 from November 1, 2018.
 Source: https://developer.android.com/distribute/best-practices/develop/target-sdk
+
+## Resolution
+Target API 26 or higher.

data/docs/facebook.md

@@ -28,3 +28,6 @@ Facebook deprecates their SDKs two years after release.
 
 > Core APIs and SDKs are central to the Facebook Platform offered to developers. These elements are subject to a version system, and guarantee that anything considered a core API node, field, edge, dialog, SDK or SDK method will remain available and unchanged for at least two years from the launch of that version.
 Source: https://developers.facebook.com/docs/apps/versions/
+
+## Resolution
+Update the version of the Facebook SDK that your game uses.

data/docs/receiver.md

@@ -26,3 +26,6 @@ The recievers present in `AndroidManifest.xml`
 
 ## Reason
 Frequently, during app updates, build settings will change, or an SDK will be removed but the `<receiver>` inside of the `AndroidManifest.xml` will not get updated or removed. This causes the app to crash.
+
+## Resolution
+Remove the `<receiver>` blocks which are missing implementations, or add the libraries which provide the implementations.

data/docs/teak/api21_icon.md

@@ -35,3 +35,8 @@ The values for `io_teak_small_notification_icon` for less than v21, and v21+.
 
 ## Reason
 Android 5+ uses [Material Design](https://material.io/design/iconography/#notification) and needs a white and transparant icon for proper display of notification icons in the tray.
+
+## Resolution
+**Adobe AIR:** [Set Notification Icons for your Game](https://teak.readthedocs.io/projects/air/en/latest/android.html#set-notification-icons-for-your-game)
+
+**Unity:** [Set Notification Icons for your Game](https://teak.readthedocs.io/projects/unity/en/latest/android.html#set-notification-icons-for-your-game)

data/docs/teak/caching.md

@@ -16,3 +16,9 @@ None.
 The Teak SDK uses [Android HTTP Caching](https://developer.android.com/training/efficient-downloads/redundant_redundant#ResponseCache) to prevent downloading redundant Notification assets.
 
 The `io_teak_enable_caching` setting allows you to disable this behavior, however it should be enabled unless your app, or an SDK that you use, makes uncommon assumptions.
+
+## Resolution
+Upgrade to the Teak 2.0 SDK, or add this to your Android resources XML:
+```xml
+    <bool name="io_teak_enable_caching">true</bool>
+```

data/docs/teak/configuration.md

@@ -26,4 +26,9 @@ The configuration values for the Teak SDK.
 ```
 
 ## Reason
-Build configuration errors can cause
+Teak requires your Teak App Id, Teak API Key, GCM sender id, and Firebase App Id in order to function.
+
+## Resolution
+**Adobe AIR:** [Set up Teak support at the Application level](https://teak.readthedocs.io/projects/air/en/latest/android.html#set-up-teak-support-at-the-application-level)
+
+**Unity:** Use the `Edit/Teak` menu item to configure Teak inside Unity, or [Edit res/values/teak.xml](https://teak.readthedocs.io/projects/unity/en/latest/android.html#edit-res-values-teak-xml).

data/headdesk.gemspec

@@ -15,6 +15,8 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/GoCarrot/headdesk'
   spec.license       = 'MIT'
 
+  spec.post_install_message = 'For breaking change announcements...'
+
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   # if spec.respond_to?(:metadata)
@@ -35,10 +37,10 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'reek', '~> 5.2'
   spec.add_development_dependency 'rspec', '~> 3.8'
 
   spec.add_dependency 'awesome_print', '~> 1.8'
+  spec.add_dependency 'gems', '~> 1.1'
   spec.add_dependency 'nokogiri', '~> 1.10'
   spec.add_dependency 'oily_png', '~> 1.2'
   spec.add_dependency 'thor', '~> 0.20'

data/lib/headdesk/apk/resources.rb

@@ -50,8 +50,6 @@ module Headdesk
           OpenStruct.new(@resources[method_name.to_s])
         end
 
-        private
-
         def self.api_versions(modifiers)
           mods = [nil]
           if modifiers.key?(:v)

data/lib/headdesk/apk.rb

@@ -23,9 +23,7 @@ module Headdesk
       android_manifest_xml = File.join(@path, 'AndroidManifest.xml').freeze
       apktool_yml = File.join(@path, 'apktool.yml').freeze
 
-      unless File.exist?(android_manifest_xml) && File.exist?(apktool_yml)
-        throw CliError.new('Path did not contain AndroidManifest.xml and/or apktool.yml')
-      end
+      throw CliError.new('Path did not contain AndroidManifest.xml and/or apktool.yml') unless File.exist?(android_manifest_xml) && File.exist?(apktool_yml)
 
       @yaml = YAML.load_file(apktool_yml)
       @sdk_info = @yaml['sdkInfo']

data/lib/headdesk/check.rb

@@ -41,6 +41,7 @@ module Headdesk
       end
     end
 
+    # :reek:DuplicateMethodCall and :reek:ManualDispatch
     def initialize(bundle)
       @apk = bundle
       @ipa = bundle

data/lib/headdesk/checks/teak/api21_icon.rb

@@ -13,7 +13,7 @@ module Headdesk
 
         check_name 'api21_icon'
         describe 'Check for API 21+ Teak icons'
-        # :reek:UncommunicativeVariableName { accept: ['icon_v21'] }
+        # :reek:NilCheck and :reek:UncommunicativeVariableName { accept: ['icon_v21'] }
         def call
           skip_check if: -> { apk.min_sdk 21 }
 

data/lib/headdesk/cli.rb

@@ -11,6 +11,12 @@ module Headdesk
   #
   # :reek:TooManyStatements
   class CLI < Thor
+    no_commands do
+      def print_update_message
+        STDOUT.puts format("\e[36m%s\e[0m", "Latest version is #{Headdesk::Versions.latest_version}, please run 'bundle update headdesk'")
+      end
+    end
+
     desc 'unpack FILE [DESTINATION]', 'Unpack an APK or IPA to [DESTINATION] or to the current directory'
     method_option :analyze, type: :boolean, aliases: '-a'
     def unpack(file, destination = nil)
@@ -90,6 +96,7 @@ module Headdesk
           STDOUT.puts report.to_json
         else
           STDOUT.puts report.to_s
+          print_update_message unless Headdesk::Versions.latest_version?
         end
       rescue CliError => cli_err
         STDERR.puts cli_err.message

data/lib/headdesk/version.rb

@@ -2,5 +2,5 @@
 
 module Headdesk
   APKTOOL_VERSION = '2.3.4'
-  VERSION = '0.9.0'
+  VERSION = '0.10.0'
 end

data/lib/headdesk/versions.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require 'gems'
+
+module Headdesk
+  #
+  # Version information from RubyGems.org
+  #
+  class Versions
+    def self.versions
+      Gems.versions('headdesk').collect do |version|
+        Gem::Version.new(version['number'])
+      rescue StandardError
+        nil
+      end
+          .compact
+          .sort
+          .reverse
+    end
+
+    def self.latest_version
+      Gem::Version.new(Gems.latest_version('headdesk')['version'])
+    end
+
+    def self.latest_version?(version = VERSION)
+      latest_version == Gem::Version.new(version)
+    end
+  end
+end

data/lib/headdesk.rb

@@ -2,6 +2,7 @@
 
 require 'headdesk/apktool'
 require 'headdesk/version'
+require 'headdesk/versions'
 require 'headdesk/analyze'
 require 'headdesk/apk'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: headdesk
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Pat Wilson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-17 00:00:00.000000000 Z
+date: 2019-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -39,47 +39,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: reek
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: awesome_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
-  type: :development
+        version: '1.8'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '1.8'
 - !ruby/object:Gem::Dependency
-  name: awesome_print
+  name: gems
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -132,6 +132,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".reek.yml"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
 - Gemfile
@@ -173,11 +174,12 @@ files:
 - lib/headdesk/descriptionator/resources.rb
 - lib/headdesk/report.rb
 - lib/headdesk/version.rb
+- lib/headdesk/versions.rb
 homepage: https://github.com/GoCarrot/headdesk
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: For breaking change announcements...
 rdoc_options: []
 require_paths:
 - lib