headdesk 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eac86940351195bdcb6a319a72aef571a3c81a440845332a15463a32fc231296
-  data.tar.gz: 0a278770a0fdf1d24992a3cd77607c86bcfb203583d27f59741f6c1c30fb61e8
+  metadata.gz: e812c6195d207316fbcb2e365a7ad4828d12667586ffec08c40d9a61f0c92714
+  data.tar.gz: 817934245dfea92c9b7b05f961272c9286031d18e9861170fe042ca39d5e50ab
 SHA512:
-  metadata.gz: 84b726485e45f94c5e573e2fcfc930cb1808e2952ff284f40004fa49eaa281c967671e22ff744fc8e6b78abb5b20e6637967556d97d01d773e01d789106790ca
-  data.tar.gz: dfce5a6b0aff10c0b4287b066b8751eb95cb56eeef8ba8264ae89246cbaab4ba5489e877cbdb68f3c63e70bc05ba3ca259405e6f25a32e0b5406fb45a4999e94
+  metadata.gz: 74b4a8e37fa5a3003158611c50cf66687af8f6444c945524beec638baebb2f2e1a1779b61b4602a6325cf6ce31a1d9346e72665cbf6d87a6a725ac3ae9682c70
+  data.tar.gz: 4a9e4b8a17c9fe03e9aa98d9b2a0cba3f3dd67a80157ee153e85256a9e5f8ff91688801c845d86e01ccc85900705c056fb1166711e18da6b36e44ab8e1580b22

data/Gemfile.lock

@@ -1,9 +1,10 @@
 PATH
   remote: .
   specs:
-    headdesk (0.8.0)
+    headdesk (0.9.0)
       awesome_print (~> 1.8)
       nokogiri (~> 1.10)
+      oily_png (~> 1.2)
       thor (~> 0.20)
 
 GEM
@@ -15,6 +16,7 @@ GEM
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
+    chunky_png (1.3.11)
     codeclimate-engine-rb (0.4.1)
       virtus (~> 1.0)
     coercible (1.0.0)
@@ -29,6 +31,8 @@ GEM
     mini_portile2 (2.4.0)
     nokogiri (1.10.1)
       mini_portile2 (~> 2.4.0)
+    oily_png (1.2.1)
+      chunky_png (~> 1.3.7)
     parallel (1.12.1)
     parser (2.5.3.0)
       ast (~> 2.4.0)

data/docs/teak/api21_icon.md

@@ -1,6 +1,13 @@
 # teak/api21_icon
 Ensures that the APK contains a notification icon for both Android 5+ (API 21+) as well as pre-Android 5, and that these are different icons.
 
+Also verifies following files have the specified image dimensions:
+* drawable-mdpi/[icon_v21].png     24x24
+* drawable-hdpi/[icon_v21].png     36x36
+* drawable-xhdpi/[icon_v21].png    48x48
+* drawable-xxhdpi/[icon_v21].png   72x72
+* drawable-xxxhdpi/[icon_v21].png  96x96
+
 ## Will Skip If
 * The Teak SDK is not present.
 
@@ -8,6 +15,12 @@ Ensures that the APK contains a notification icon for both Android 5+ (API 21+)
 * There is no drawable resource for `io_teak_small_notification_icon`.
 * There is no v21 drawable resource for `io_teak_small_notification_icon`
 * The drawable resources point to the same image.
+* The v21 drawable resources do not exist, or are the incorrect size
+    * `drawable-mdpi/[icon_v21].png` does not exist, or is not 24x24
+    * `drawable-hdpi/[icon_v21].png` does not exist, or is not 36x36
+    * `drawable-xhdpi/[icon_v21].png` does not exist, or is not 48x48
+    * `drawable-xxhdpi/[icon_v21].png` does not exist, or is not 72x72
+    * `drawable-xxxhdpi/[icon_v21].png` does not exist, or is not 96x96
 
 ## Exports
 The values for `io_teak_small_notification_icon` for less than v21, and v21+.

data/headdesk.gemspec

@@ -40,5 +40,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'awesome_print', '~> 1.8'
   spec.add_dependency 'nokogiri', '~> 1.10'
+  spec.add_dependency 'oily_png', '~> 1.2'
   spec.add_dependency 'thor', '~> 0.20'
 end

data/lib/headdesk/apk/resources.rb

@@ -16,6 +16,14 @@ module Headdesk
         XmlCollection.new(@path, 'values', modifiers)
       end
 
+      def file?(file_name)
+        File.exist? path_for(file_name)
+      end
+
+      def path_for(file_name)
+        "#{@path}/#{file_name.sub(%r{^\/}, '')}"
+      end
+
       #
       # Collection of XML values for specific locale/api/etc
       #

data/lib/headdesk/apk.rb

@@ -64,8 +64,9 @@ module Headdesk
       min_sdk_version >= gt_eq
     end
 
+    # :reek:NilCheck
     def class?(decl)
-      find_class(decl) != false
+      !find_class(decl).nil?
     end
 
     def find_class(decl)

data/lib/headdesk/checks/teak/api21_icon.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'oily_png'
+
 module Headdesk
   module Checks
     module Teak
@@ -24,10 +26,21 @@ module Headdesk
           export icon: icon, icon_v21: icon_v21
 
           describe "APK contains a drawable for 'io_teak_small_notification_icon'"
-          fail_check unless: -> { icon && icon_v21 }
+          fail_check if: -> { icon.nil? || icon_v21.nil? }
 
           describe "'io_teak_small_notification_icon' for v21 is different from < v21"
           fail_check unless: -> { icon != icon_v21 }
+
+          resolutions = [['drawable-mdpi', 24], ['drawable-hdpi', 36], ['drawable-xhdpi', 48],
+                         ['drawable-xxhdpi', 72], ['drawable-xxxhdpi', 96]]
+          resolutions.each do |rname, size|
+            resource_file = icon_v21.sub('@drawable', "res/#{rname}") + '.png'
+            fail_check unless: -> { apk.resources.file?(resource_file) }
+
+            describe "'#{resource_file}' is #{size}x#{size}"
+            image = ChunkyPNG::Image.from_file(apk.resources.path_for(resource_file))
+            fail_check unless: -> { size == image.width && size == image.height }
+          end
         end
       end
     end

data/lib/headdesk/descriptionator/resources.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module Headdesk
+  #
+  # Descriptions for APK methods
+  #
+  # :reek:RepeatedConditional
+  class APKResourcesDescriber
+    def initialize(mode_unless)
+      @unless = mode_unless
+    end
+
+    def file?(file_name)
+      "APK #{@unless ? 'contains' : 'does not contain'} resource file '#{file_name}'"
+    end
+  end
+end

data/lib/headdesk/descriptionator.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'headdesk/descriptionator/resources'
+
 module Headdesk
   #
   # Descriptions for APK methods
@@ -21,6 +23,10 @@ module Headdesk
     def min_sdk(gt_eq)
       "APK requires #{@unless ? 'at least' : 'less than'} API #{gt_eq}"
     end
+
+    def resources
+      @resources ||= APKResourcesDescriber.new(@unless)
+    end
   end
 
   #

data/lib/headdesk/version.rb

@@ -2,5 +2,5 @@
 
 module Headdesk
   APKTOOL_VERSION = '2.3.4'
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: headdesk
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Pat Wilson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-16 00:00:00.000000000 Z
+date: 2019-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
+- !ruby/object:Gem::Dependency
+  name: oily_png
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -156,6 +170,7 @@ files:
 - lib/headdesk/cli.rb
 - lib/headdesk/data/facebook_sdk_versions.yaml
 - lib/headdesk/descriptionator.rb
+- lib/headdesk/descriptionator/resources.rb
 - lib/headdesk/report.rb
 - lib/headdesk/version.rb
 homepage: https://github.com/GoCarrot/headdesk