hcloud 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c42658a4a5f9d2281b65fa47b5827e24fff49f5a
-  data.tar.gz: 3f08e48f07f9a04c59b24fd32ac9b095624ea936
+  metadata.gz: 9f78617929469ecee9ebece771e9e5dc5752ba60
+  data.tar.gz: f615021080bdae845cb44e238c612510a77c9df7
 SHA512:
-  metadata.gz: 1f51009f3bbd40127585b309dcdf94fac193942f6f05a68f4ab4f71d474f86f705b9ebc9e313c87935d03cd8c85dded7180550d379ddb50728f1c0b6cbd6a424
-  data.tar.gz: c0a192eee47abd50cdc62bdfb22c98e929a129d15129c70ea4996ec9827eb59ade9909acb81a8d43c395060369fb574347103213524471674c772cb849330589
+  metadata.gz: a4994677850cd19bffcf5934e09b4a29a6be7a52baa5cbf92a8fb139c82ee538a59aa3e4f81b4fc4f4556af67bf1500c137e270ac28d16038fb1df6f48e5c60b
+  data.tar.gz: b6be721c3b66b15a818efdceb5ae630cb684f9f89685ae94ea2f80f5ec20b9ed9b20e6a80f435eb1d84d5ed5846c903c426e46d4b724d765266a27486e2b1f6d

data/.rubocop.yml

@@ -0,0 +1,24 @@
+inherit_from: .rubocop_todo.yml
+
+Style/GlobalVars:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Style/Documentation:
+  Enabled: false
+
+Naming/ConstantName:
+  Enabled: false
+
+Lint/HandleExceptions:
+  Exclude:
+    - 'lib/hcloud/action_resource.rb'
+    - 'lib/hcloud/datacenter_resource.rb'
+    - 'lib/hcloud/floating_ip_resource.rb'
+    - 'lib/hcloud/image_resource.rb'
+    - 'lib/hcloud/iso_resource.rb'
+    - 'lib/hcloud/location_resource.rb'
+    - 'lib/hcloud/server_resource.rb'
+    - 'lib/hcloud/server_type_resource.rb'
+    - 'lib/hcloud/ssh_key_resource.rb'
+

data/.rubocop_todo.yml

@@ -0,0 +1,148 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-02-27 01:17:09 +0100 using RuboCop version 0.52.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Layout/BlockEndNewline:
+  Exclude:
+    - 'spec/fake_service/server.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
+Layout/EmptyLinesAroundModuleBody:
+  Exclude:
+    - 'spec/fake_service/server.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBrackets: space, no_space
+Layout/SpaceInsideArrayLiteralBrackets:
+  Exclude:
+    - 'spec/fake_service/action.rb'
+    - 'spec/fake_service/server.rb'
+    - 'spec/fake_service/ssh_key.rb'
+
+# Offense count: 3
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'lib/hcloud/client.rb'
+    - 'spec/fake_service/server.rb'
+
+# Offense count: 12
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'lib/hcloud/action_resource.rb'
+    - 'lib/hcloud/floating_ip_resource.rb'
+    - 'lib/hcloud/image_resource.rb'
+    - 'lib/hcloud/iso_resource.rb'
+    - 'lib/hcloud/location_resource.rb'
+    - 'lib/hcloud/server_resource.rb'
+    - 'lib/hcloud/ssh_key_resource.rb'
+    - 'spec/fake_service/datacenter.rb'
+    - 'spec/fake_service/location.rb'
+    - 'spec/fake_service/server_type.rb'
+
+# Offense count: 24
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/hcloud/floating_ip_resource.rb'
+    - 'lib/hcloud/image.rb'
+    - 'lib/hcloud/image_resource.rb'
+    - 'lib/hcloud/server.rb'
+    - 'lib/hcloud/server_resource.rb'
+
+# Offense count: 3
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/hcloud/abstract_resource.rb'
+    - 'spec/fake_service/base.rb'
+    - 'spec/hcloud/server_spec.rb'
+
+# Offense count: 12
+Metrics/AbcSize:
+  Max: 35
+
+# Offense count: 20
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 273
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 224
+
+# Offense count: 3
+Metrics/CyclomaticComplexity:
+  Max: 15
+
+# Offense count: 5
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 48
+
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 8
+
+# Offense count: 1
+Metrics/PerceivedComplexity:
+  Max: 8
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect.
+Performance/HashEachMethods:
+  Exclude:
+    - 'lib/hcloud/entry_loader.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect.
+Performance/TimesMap:
+  Exclude:
+    - 'lib/hcloud/abstract_resource.rb'
+
+# Offense count: 7
+Security/Eval:
+  Exclude:
+    - 'lib/hcloud/floating_ip_resource.rb'
+    - 'lib/hcloud/image.rb'
+    - 'lib/hcloud/image_resource.rb'
+    - 'lib/hcloud/server.rb'
+    - 'lib/hcloud/server_resource.rb'
+
+# Offense count: 2
+# Configuration parameters: .
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  EnforcedStyle: unannotated
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/hcloud/abstract_resource.rb'
+    - 'lib/hcloud/entry_loader.rb'
+    - 'spec/fake_service/floating_ip.rb'
+    - 'spec/fake_service/server.rb'
+    - 'spec/fake_service/ssh_key.rb'
+
+# Offense count: 80
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 108

data/.travis.yml

@@ -1,5 +1,7 @@
 language: ruby
-script: "bundle exec rspec"
+script: 
+  - "bundle exec rspec"
+  - "bundle exec rubocop"
 sudo: false
 rvm:
   - 2.3

data/CHANGELOG.md

@@ -0,0 +1,40 @@
+# Change Log
+
+## [v0.1.1](https://github.com/tonobo/hcloud-ruby/tree/v0.1.1) (2018-02-26)
+[Full Changelog](https://github.com/tonobo/hcloud-ruby/compare/v0.1.0...v0.1.1)
+
+**Merged pull requests:**
+
+- Floating IP context [\#4](https://github.com/tonobo/hcloud-ruby/pull/4) ([MarkusFreitag](https://github.com/MarkusFreitag))
+
+## [v0.1.0](https://github.com/tonobo/hcloud-ruby/tree/v0.1.0) (2018-02-25)
+[Full Changelog](https://github.com/tonobo/hcloud-ruby/compare/v0.1.0.pre.alpha4...v0.1.0)
+
+**Closed issues:**
+
+- Documentation for busy waiting [\#2](https://github.com/tonobo/hcloud-ruby/issues/2)
+
+**Merged pull requests:**
+
+- Pagination proposal [\#3](https://github.com/tonobo/hcloud-ruby/pull/3) ([tonobo](https://github.com/tonobo))
+
+## [v0.1.0.pre.alpha4](https://github.com/tonobo/hcloud-ruby/tree/v0.1.0.pre.alpha4) (2018-01-30)
+[Full Changelog](https://github.com/tonobo/hcloud-ruby/compare/v0.1.0.pre.alpha3...v0.1.0.pre.alpha4)
+
+## [v0.1.0.pre.alpha3](https://github.com/tonobo/hcloud-ruby/tree/v0.1.0.pre.alpha3) (2018-01-29)
+[Full Changelog](https://github.com/tonobo/hcloud-ruby/compare/v0.1.0.pre.alpha2...v0.1.0.pre.alpha3)
+
+**Merged pull requests:**
+
+- set needed gems to runtime dependency [\#1](https://github.com/tonobo/hcloud-ruby/pull/1) ([bastelfreak](https://github.com/bastelfreak))
+
+## [v0.1.0.pre.alpha2](https://github.com/tonobo/hcloud-ruby/tree/v0.1.0.pre.alpha2) (2018-01-28)
+[Full Changelog](https://github.com/tonobo/hcloud-ruby/compare/v0.1.0.pre.alpha1...v0.1.0.pre.alpha2)
+
+## [v0.1.0.pre.alpha1](https://github.com/tonobo/hcloud-ruby/tree/v0.1.0.pre.alpha1) (2018-01-28)
+[Full Changelog](https://github.com/tonobo/hcloud-ruby/compare/v0.1.0.pre.alpha0...v0.1.0.pre.alpha1)
+
+## [v0.1.0.pre.alpha0](https://github.com/tonobo/hcloud-ruby/tree/v0.1.0.pre.alpha0) (2018-01-27)
+
+
+\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

data/Gemfile

@@ -1,9 +1,10 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
+gem 'codecov', require: false, group: :test
 gem 'pry'
-gem 'codecov', :require => false, :group => :test
+gem 'rubocop'
 
 # Specify your gem's dependencies in hcloud.gemspec
 gemspec

data/Rakefile

@@ -1,2 +1,2 @@
-require "bundler/gem_tasks"
-task :default => :spec
+require 'bundler/gem_tasks'
+task default: :spec

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "hcloud"
+require 'bundler/setup'
+require 'hcloud'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "hcloud"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/hcloud.gemspec

@@ -1,31 +1,31 @@
-# coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+
+lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "hcloud/version"
+require 'hcloud/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "hcloud"
+  spec.name          = 'hcloud'
   spec.version       = Hcloud::VERSION
-  spec.authors       = ["Tim Foerster"]
-  spec.email         = ["github@moo.gl"]
+  spec.authors       = ['Tim Foerster']
+  spec.email         = ['github@moo.gl']
 
-  spec.summary       = %q{HetznerCloud native Ruby client}
-  spec.homepage      = "https://github.com/tonobo/hcloud"
+  spec.summary       = 'HetznerCloud native Ruby client'
+  spec.homepage      = 'https://github.com/tonobo/hcloud'
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.15"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "grape"
-  spec.add_development_dependency "activesupport"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "webmock"
-  spec.add_runtime_dependency "typhoeus"
-  spec.add_runtime_dependency "oj"
-  spec.add_runtime_dependency "activesupport"
+  spec.add_development_dependency 'activesupport'
+  spec.add_development_dependency 'bundler', '~> 1.15'
+  spec.add_development_dependency 'grape'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'webmock'
+  spec.add_runtime_dependency 'activesupport'
+  spec.add_runtime_dependency 'oj'
+  spec.add_runtime_dependency 'typhoeus'
 end

data/lib/hcloud.rb

@@ -1,4 +1,4 @@
-require "hcloud/version"
+require 'hcloud/version'
 require 'active_support/core_ext/object/to_query'
 
 module Hcloud

data/lib/hcloud/abstract_resource.rb

@@ -4,7 +4,7 @@ module Hcloud
 
     attr_reader :client, :parent, :base_path
 
-    def initialize(client:, parent: nil, base_path: "")
+    def initialize(client:, parent: nil, base_path: '')
       @client = client
       @parent = parent
       @page = 1
@@ -34,17 +34,17 @@ module Hcloud
         when Symbol, String then s.to_s
         when Hash then s.map { |k, v| "#{k}:#{v}" }
         else
-          raise ArgumentError, 
-            "Unable to resolve type for given #{s.inspect} from #{sort}"
+          raise ArgumentError,
+                "Unable to resolve type for given #{s.inspect} from #{sort}"
         end
       end
       self
     end
-    
+
     def mj(path, **o, &block)
-      if !client.nil? and client.auto_pagination
+      if !client.nil? && client.auto_pagination
         requests = __entries__(path, **o)
-        if requests.all?{|x| x.is_a? Hash }
+        if requests.all? { |x| x.is_a? Hash }
           m = MultiReply.new(j: requests, pagination: :auto)
           m.cb = block
           return m
@@ -61,10 +61,10 @@ module Hcloud
       m.cb = block
       m
     end
-    
-    def each(&block)
+
+    def each
       all.each do |member|
-        block.call(member)
+        yield(member)
       end
     end
 
@@ -75,14 +75,14 @@ module Hcloud
     end
 
     def sort_params
-      @order.to_a.map{|x| "sort=#{x}" }.join("&")
+      @order.to_a.map { |x| "sort=#{x}" }.join('&')
     end
 
     def ep(per_page: nil, page: nil)
       r = []
-      (x = page_params(per_page: per_page, page: page)).empty? ? nil : r << x 
+      (x = page_params(per_page: per_page, page: page)).empty? ? nil : r << x
       (x = sort_params).empty? ? nil : r << x
-      r.compact.join("&")
+      r.compact.join('&')
     end
 
     def request(*args)
@@ -91,20 +91,19 @@ module Hcloud
 
     def __entries__(path, **o)
       ret = Oj.load(request(path, o.merge(ep: ep(per_page: 1, page: 1))).run.body)
-      a = ret.dig("meta", "pagination", "total_entries").to_i
-      if a <= 1
-        return [ret]
-      end
+      a = ret.dig('meta', 'pagination', 'total_entries').to_i
+      return [ret] if a <= 1
       unless @limit.nil?
         a = @limit if a > @limit
       end
-      r = a / Client::MAX_ENTRIES_PER_PAGE + (a % Client::MAX_ENTRIES_PER_PAGE)
+      r = a / Client::MAX_ENTRIES_PER_PAGE
+      r += 1 if a % Client::MAX_ENTRIES_PER_PAGE > 0
       requests = r.times.map do |i|
         per_page = Client::MAX_ENTRIES_PER_PAGE
-        if !@limit.nil? and r == (i+1) and a % per_page != 0
+        if !@limit.nil? && (r == (i + 1)) && (a % per_page != 0)
           per_page = a % per_page
         end
-        req = request(path, o.merge(ep: ep(per_page: per_page, page: i+1)))
+        req = request(path, o.merge(ep: ep(per_page: per_page, page: i + 1)))
         client.hydra.queue req
         req
       end

data/lib/hcloud/action.rb

@@ -8,9 +8,9 @@ module Hcloud
       started: :time,
       finished: :time,
       resources: nil,
-      error: nil,
-    }
-    
+      error: nil
+    }.freeze
+
     include EntryLoader
   end
 end

data/lib/hcloud/action_resource.rb

@@ -2,15 +2,15 @@
 module Hcloud
   class ActionResource < AbstractResource
     def all
-      mj(base_path("actions")) do |j|
-        j.flat_map{|x| x["actions"].map{ |x| Action.new(x, self, client) } }
+      mj(base_path('actions')) do |j|
+        j.flat_map { |x| x['actions'].map { |x| Action.new(x, self, client) } }
       end
     end
 
     def find(id)
       Action.new(
-        Oj.load(request(base_path("actions/#{id.to_i}")).run.body)["action"], 
-        self, 
+        Oj.load(request(base_path("actions/#{id.to_i}")).run.body)['action'],
+        self,
         client
       )
     end
@@ -21,8 +21,8 @@ module Hcloud
     end
 
     def where(status: nil)
-      mj(base_path("actions"), q: {status: status}) do |j|
-        j.flat_map{|x| x["actions"].map{ |x| Action.new(x, self, client) }}
+      mj(base_path('actions'), q: { status: status }) do |j|
+        j.flat_map { |x| x['actions'].map { |x| Action.new(x, self, client) } }
       end
     end
 
@@ -31,6 +31,5 @@ module Hcloud
     def base_path(ext)
       [@base_path, ext].reject(&:empty?).join('/')
     end
-
   end
 end