hcl 0.3.1 → 0.3.2

data/CHANGELOG

@@ -1,5 +1,10 @@
 = Recent Changes in HCl
 
+== v0.3.2
+
+* fixed support for modern Rubies
+* it's now possible to provide a message with the stop command
+
 == v0.3.1
 
 * use STDERR instead of STDOUT for error reporting

data/Rakefile

@@ -14,7 +14,6 @@ begin
     gem.email = "zack@opensourcery.com"
     gem.homepage = "http://github.com/zenhob/hcl"
     gem.authors = ["Zack Hobson"]
-    gem.add_dependency "termios"
     gem.add_dependency "trollop", ">= 1.10.2"
     gem.add_dependency "chronic", ">= 0.2.3"
     gem.add_dependency "highline", ">= 1.5.1"

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.3.2

data/lib/hcl/app.rb

@@ -54,7 +54,7 @@ module HCl
     # @param [#to_s] command name of command
     # @return [true, false]
     def command? command
-      Commands.instance_methods.include? command.to_s
+      Commands.method_defined? command
     end
   
     # Start the application.
@@ -64,8 +64,8 @@ module HCl
           if command? @command
             result = send @command, *@args
             if not result.nil?
-              if result.respond_to? :to_a
-                puts result.to_a.join(', ')
+              if result.respond_to? :join
+                puts result.join(', ')
               elsif result.respond_to? :to_s
                 puts result
               end
@@ -80,8 +80,11 @@ module HCl
       rescue RuntimeError => e
         STDERR.puts "Error: #{e}"
         exit 1
+      rescue SocketError => e
+        STDERR.puts "Connection failed. (#{e.message})"
+        exit 1
       rescue TimesheetResource::Failure => e
-        STDERR.puts "Internal failure. #{e}"
+        STDERR.puts "API failure: #{e}"
         exit 1
       end
     end
@@ -133,9 +136,9 @@ EOM
       else
         config = {}
         puts "Please specify your Harvest credentials.\n"
-        config['login'] = ask("Email Address: ")
-        config['password'] = ask("Password: ") { |q| q.echo = false }
-        config['subdomain'] = ask("Subdomain: ")
+        config['login'] = ask("Email Address: ").to_s
+        config['password'] = ask("Password: ") { |q| q.echo = false }.to_s
+        config['subdomain'] = ask("Subdomain: ").to_s
         config['ssl'] = %w(y yes).include?(ask("Use SSL? (y/n): ").downcase)
         TimesheetResource.configure config
         write_config config

data/lib/hcl/commands.rb

@@ -54,9 +54,10 @@ module HCl
       puts "Started timer for #{timer} (at #{current_time})"
     end
     
-    def stop
+    def stop *args
       entry = DayEntry.with_timer
       if entry
+        entry.append_note(*args.join(' ')) if args.any?
         entry.toggle
         puts "Stopped #{entry} (at #{current_time})"
       else

data/lib/hcl/timesheet_resource.rb

@@ -1,6 +1,6 @@
 module HCl
   class TimesheetResource
-    class Failure < Exception; end
+    class Failure < StandardError; end
 
     def self.configure opts = nil
       if opts
@@ -48,9 +48,9 @@ module HCl
       if response.kind_of? Net::HTTPSuccess
         response.body
       elsif response.kind_of? Net::HTTPFound
-        raise "Redirected in the request. Perhaps your ssl configuration variable is set incorrectly?"
+        raise Failure, "Redirected in the request. Perhaps your ssl configuration variable is set incorrectly?"
       else
-        raise 'failure'
+        raise Failure, "Unexpected response from the upstream API"
       end
     end
     

data/test/app_test.rb

@@ -3,6 +3,6 @@ class AppTest < Test::Unit::TestCase
 
   should "permit commands from the HCl::Commands module" do
     app = HCl::App.new
-    assert HCl::Commands.instance_methods.all? { |c| app.command? c  }
+    assert HCl::Commands.instance_methods.all? { |c| app.command? c  }, 'all methods are commands'
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hcl
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 3
-  - 1
-  version: 0.3.1
+  - 2
+  version: 0.3.2
 platform: ruby
 authors: 
 - Zack Hobson
@@ -15,27 +15,13 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-13 00:00:00 -07:00
+date: 2011-12-30 00:00:00 -08:00
 default_executable: hcl
 dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: termios
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  type: :runtime
-  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: trollop
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -47,11 +33,11 @@ dependencies:
         - 2
         version: 1.10.2
   type: :runtime
-  version_requirements: *id002
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: chronic
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -63,11 +49,11 @@ dependencies:
         - 3
         version: 0.2.3
   type: :runtime
-  version_requirements: *id003
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: highline
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -79,11 +65,11 @@ dependencies:
         - 1
         version: 1.5.1
   type: :runtime
-  version_requirements: *id004
+  version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   name: shoulda
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -93,11 +79,11 @@ dependencies:
         - 0
         version: "0"
   type: :development
-  version_requirements: *id005
+  version_requirements: *id004
 - !ruby/object:Gem::Dependency 
   name: mocha
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -107,7 +93,7 @@ dependencies:
         - 0
         version: "0"
   type: :development
-  version_requirements: *id006
+  version_requirements: *id005
 description: HCl is a command-line client for manipulating Harvest time sheets.
 email: zack@opensourcery.com
 executables: