haveapi-client 0.14.2 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9bcb523f6bbbc83aed043d934bed405204f944da508ce27bbbc187789ad2592
-  data.tar.gz: 577821fa05de46f248506925c8d2b50a2da7a6d21dd16f463b0cb6d4873f4c5b
+  metadata.gz: 4ab49346d0209df996a1832992ad1f11bf7bb2f7de6f1f7cd49fb92e4bbc62c0
+  data.tar.gz: a49dc688a464d90e4188d93abcda7d27f252f0c4d44ce7769fb773b68b08e11b
 SHA512:
-  metadata.gz: 9985388b53763b4ce873c02b113c9e3b3577ebf7328993acca91cdbdaee0025a865fb4b7feb65dd55b774c98c5f88d475a8c532c2c94b0d1dfccb72862ef0526
-  data.tar.gz: '0835beabb9c0212930238f502c4f2d2c314321dc1ba080c13e2bcd68261a05053ad74cdd4a9a29d2c4b3707b907610a9f4a517e5458d8ee2f77e5692ec2d0134'
+  metadata.gz: b39a2abebdc41d1480c2cba71ff4440ac320532c1d22885d92aba8d383f3e9e4d2a055114821c76322f90d1c0d135c5233b80f95a3ac366483a8ee6fa6577756
+  data.tar.gz: 768c5ec61c25e4dcfbc99f79f0a788d2237789e8316065fecc766fe60b832852609954ee1bf2c21256aa80116f901aef55314825e4fb42df23c69cbf84dab7d0

data/lib/haveapi/client/action.rb

@@ -12,7 +12,7 @@ module HaveAPI::Client
       apply_args(args)
     end
 
-    def execute(data, *_)
+    def execute(data)
       params_arg = {}
 
       if input
@@ -25,7 +25,7 @@ module HaveAPI::Client
         params_arg = params.to_api
       end
 
-      ret = @api.call(self, params_arg)
+      ret = @api.call(self, params_arg, **{})
       reset
       ret
     end

data/lib/haveapi/client/client.rb

@@ -49,8 +49,8 @@ class HaveAPI::Client::Client
   end
 
   # See Communicator#authenticate.
-  def authenticate(*args, &block)
-    @api.authenticate(*args, &block)
+  def authenticate(auth_method, **options, &block)
+    @api.authenticate(auth_method, options, &block)
   end
 
   # Get uthentication provider

data/lib/haveapi/client/resource.rb

@@ -76,7 +76,7 @@ module HaveAPI::Client
       action.aliases(true).each do |name|
         next unless define_method?(action, name)
 
-        define_singleton_method(name) do |*args, &block|
+        define_singleton_method(name) do |*args, **kwargs, &block|
           client_opts = @client.opts(:block, :block_interval, :block_timeout)
           all_args = @prepared_args + args
 
@@ -89,28 +89,42 @@ module HaveAPI::Client
             end
 
             if action.unresolved_args?
-              raise ArgumentError.new('One or more object ids missing')
+              raise ArgumentError, 'one or more object ids missing'
             end
           end
 
-          if all_args.empty?
-            all_args << default_action_input_params(action)
+          if all_args.length > 1 || (kwargs.any? && all_args.any?)
+            raise ArgumentError, "too many arguments for action #{@name}##{action.name}"
+          end
+
+          arg = all_args.shift
 
-          elsif all_args.last.is_a?(Hash)
-            last = all_args.pop
+          user_params =
+            if kwargs.any? && arg
+              raise ArgumentError,
+                    'pass the input parameters either as a hash or keyword arguments'
+            elsif kwargs.any?
+              kwargs
+            elsif arg
+              arg
+            end
 
-            if last.has_key?(:meta)
-              meta = last[:meta]
+          if user_params.nil?
+            input_params = default_action_input_params(action)
+
+          else
+            if user_params.has_key?(:meta)
+              meta = user_params[:meta]
 
               %i(block block_interval block_timeout).each do |p|
                 client_opts[p] = meta.delete(p) if meta.has_key?(p)
               end
             end
 
-            all_args << default_action_input_params(action).update(last)
+            input_params = default_action_input_params(action).update(user_params)
           end
 
-          ret = Response.new(action, action.execute(*all_args))
+          ret = Response.new(action, action.execute(input_params))
 
           raise ActionFailed.new(ret) unless ret.ok?
 
@@ -137,8 +151,8 @@ module HaveAPI::Client
             }.each do |k, v|
               wait_opts[v] = client_opts[k] if client_opts.has_key?(k)
             end
-            
-            ret.wait_for_completion(wait_opts) do |state|
+
+            ret.wait_for_completion(**wait_opts) do |state|
               block.call(return_value, state) if block
             end
           end

data/lib/haveapi/client/response.rb

@@ -61,10 +61,10 @@ class HaveAPI::Client::Response
   # it is regularly called with the action's state.
   #
   # @see HaveAPI::Client::Action#wait_for_completion
-  def wait_for_completion(*args, &block)
+  def wait_for_completion(**kwargs, &block)
     id = meta[:action_state_id]
     return nil unless id
 
-    HaveAPI::Client::Action.wait_for_completion(@action.client, id, *args, &block)
+    HaveAPI::Client::Action.wait_for_completion(@action.client, id, **kwargs, &block)
   end
 end

data/lib/haveapi/client/version.rb

@@ -1,6 +1,6 @@
 module HaveAPI
   module Client
     PROTOCOL_VERSION = '2.0'
-    VERSION = '0.14.2'
+    VERSION = '0.15.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: haveapi-client
 version: !ruby/object:Gem::Version
-  version: 0.14.2
+  version: 0.15.0
 platform: ruby
 authors:
 - Jakub Skokan