hatch 0.1.0 → 0.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NWIyNzI5OWMyNjA5ZjQ0ZmE1OWExZDIxYWFhMmYxMWQwMTNjNjM0NQ==
+    OTRmYTJkYmNkNDQ1Mzc4YmI0NTI1YTE2MWQ1MGMxNjQ4Y2QyZWY2YQ==
   data.tar.gz: !binary |-
-    MzUwYzM2NzI1YmRiNjNhMjYxMjQwYWUyYzZjODNiM2QyMDE4Nzc2Mw==
+    MzdhNGMzYzIxMGU5ZWZiMWM5MTkzZDAzYjc2M2U1NmU2MTU1ZmQ5ZQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZGIxMWE4YTg3OTEzNTllZjA4YjFlNjY1NmU4ZjhiNWQwMmIzN2Q2ODQ1ZDIw
-    OWZiMDM0MmNjNmRkNTQxZGEzM2QzMDY5YTIxNWExZDFhMjEzYzQzMzg3YWZl
-    OTBkZDgzYTI4Y2Q1NWJkYmVmMmUxNWNhYjEwOTNkYTNiM2QwZjM=
+    NDg3NzVlYTBmM2NlMjA4ZmUxOTFkZDM0ZTM1MDA3ZjM2NjViYzJlMmYzNjA0
+    MDM3NTkyYjE4ODFkZjhiMTYwNTA4OTdkZDY1YmU5MTY4OWNhNjViOTAzMGU5
+    NDAxMTJlNDNjMzJiMDBlM2ZiZGM4MGYyMTFlZTJkYjkxMmYxMGQ=
   data.tar.gz: !binary |-
-    OGU1YmJjYTgzNjY4MGJiMjI4ZDYzOTIxZmVhMmVjMmY0YjcyNTVlNGMyYzJj
-    M2FjYzYwNzQ0MzMwNDcyNmRjYzdiZWZkNjAzMzZmMTU0ZDEzNjY0ZmIwMGEw
-    MjY0NTU2M2M4Yjg2Zjc4YTdjZjVmNzZlYWM4ZmRjYmYxNjA5NzU=
+    MDRjMGNkMmI0ZDExMDBjY2Q0NWI0YzdjYmE5NGE1MDU5YjJlMTc1NjkxZGM5
+    MjM5OGQ1ZjU5ODk0ZmZlODY5NmU2OTA1NzdlYzZkNDUwYzA2YzBlM2FjZmFj
+    YmE4MDIyMTc1MmY2NWYxMzNhODc2OWFkZDRjMjA3Mjc5MDA3M2U=

data/README.md

@@ -12,8 +12,7 @@ Usage
 An address without a street? A person without a name? Those are not valid objects!
 Why should you have them hanging around your system?
 
-Tell `Hatch` how to certify the attributes of your models, and it will give you
-the appropriate object.
+Tell `Hatch` how to certify the attributes of your models, and it will give you the appropriate object.
 
 If you don't hatch your model with all the correct attributes, you'll get an object representing an invalid instance of it.
 
@@ -45,11 +44,9 @@ not_an_address.valid?
 # => false
 ```
 
-Use `certify(:attribute, 'error message', &validation)` to verify when an
-attribute is valid.
+Use `certify(:attribute, 'error message', &validation)` to verify when an attribute is valid.
 
-In case you're wondering, the `Model::InvalidModel` is polymorphic with your
-`Model` in all the reader methods declared by `attr_reader` or `attr_accessor`
+In case you're wondering, the `Model::InvalidModel` is polymorphic with your `Model` in all the reader methods declared by `attr_reader` or `attr_accessor`
 
 `Hatch` also supports some common validations we all like to have!
 `certifies(:attribute, :validation, 'error message')` will do the trick.
@@ -68,8 +65,7 @@ Common validations come in the following flavours (along with default error mess
   * `:presence` - `"must be present"`
   * `:positive_number` - `"must be a positive number"`
 
-Aaand that's it for the moment. I'll keep on adding more as they come to my mind. If they come
-to yours first, feel free to add them and PR.
+Aaand that's it for the moment. I'll keep on adding more as they come to my mind. If they come to yours first, feel free to add them and PR.
 
 Errors
 ------
@@ -94,10 +90,33 @@ not_an_address.errors.empty?
 # => false
 ```
 
+One of the nicest things about `Hatch` is that errors can be any object of your desire! Power to thy user.
+
+```ruby
+class LowAwesomenessError
+  attr_accessor :code, :message
+end
+
+class Address
+  include Hatch
+
+  error = LowAwesomenessError.new
+  # => #<LowAwesomenessError:0x007fdb3458eeb0>
+  error.code, error.message = :moar_awesome_plz, 'this is not awesome enough'
+
+  certifies(:street, :presence, error)
+end
+
+not_an_address = Address.hatch(street: '')
+not_an_address.errors.on(:street)
+# => #<LowAwesomenessError:0x007fdb3458eeb0 @code=:moar_awesome_plz, @message="this is not awesome enough">
+```
+
 Thanks
 ------
 
-To [@pote](https://github.com/pote) for the help, support and company!
+* [@pote](https://github.com/pote) for the help, support and company!
+* [@munshkr](https://github.com/munshkr) for testing and playing around with it.
 
 License
 -------

data/hatch.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'hatch'
-  s.version     = '0.1.0'
+  s.version     = '0.1.1'
   s.date        = Time.now.strftime('%Y-%m-%d')
   s.summary     = 'Keep valid objects only'
   s.description = "An address without a street? A person without a name? You don't need no invalid objects!"

data/lib/hatch.rb

@@ -36,10 +36,10 @@ module Hatch
     def hatch(args = {})
       validated_attributes = []
       @@validations[self.to_s.to_sym].each_pair do |attribute, validation|
-        validated_attributes << Validator.validate(attribute,
-                                                   args[attribute],
-                                                   validation.error,
-                                                   &validation.block)
+        validated_attributes << ValidatedAttribute.validate(attribute,
+                                                            args[attribute],
+                                                            validation.error,
+                                                            &validation.block)
       end
 
       build(validated_attributes)
@@ -61,32 +61,25 @@ module Hatch
     private
 
       def respond_to_instance_methods
-        extended_klass = Kernel.const_get(self.class.to_s.split("Invalid").last)
-        address_instance_methods = extended_klass.instance_methods(false)
-
-        attributes_with_reader = @validated_attributes.select do |validated_attribute|
-          address_instance_methods.include?(validated_attribute.attr)
-        end
-
         attributes_with_reader.each do |attribute|
           self.class.send :define_method, attribute.attr, -> {attribute.value}
         end
       end
-    end
 
-  private
+      def attributes_with_reader
+        extended_klass = Kernel.const_get(self.class.to_s.split("Invalid").last)
+        instance_methods = extended_klass.instance_methods(false)
 
-    def build(validated_attributes)
-      validation = -> do
-        valid = true
-        validated_attributes.each do |validated_attribute|
-          valid = valid && validated_attribute.valid?
+        @validated_attributes.select do |validated_attribute|
+          instance_methods.include?(validated_attribute.attr)
         end
-
-        valid
       end
+    end
+
+  private
 
-      if validation.call
+    def build(validated_attributes)
+      if all_attributes_valid?(validated_attributes)
         set_instance_variables(new, *validated_attributes)
       else
         const_get("Invalid#{self}").new(*validated_attributes)
@@ -99,9 +92,13 @@ module Hatch
       end
       instance
     end
+
+    def all_attributes_valid?(validated_attributes)
+      validated_attributes.map(&:valid?).reduce(true, :&)
+    end
   end
 
-  class Validator
+  class ValidatedAttribute
     attr_reader :attr, :value, :error
 
     def self.validate(attr, value, error, &block)
@@ -125,8 +122,7 @@ module Hatch
     attr_reader :error, :block
 
     def initialize(error, &block)
-      @error = error
-      @block = block
+      @error, @block = error, block
     end
 
     def self.presence(error)
@@ -140,16 +136,7 @@ module Hatch
 
   class Errors < Hash
     def self.build(validated_attributes)
-      errors = new
-      validated_attributes.each do |validated_attribute|
-        if validated_attribute.invalid?
-          errors[validated_attribute.attr] = validated_attribute.error
-        else
-          errors[validated_attribute.attr] = []
-        end
-      end
-
-      errors
+      self[attributes_and_errors(validated_attributes)]
     end
 
     def on(attr)
@@ -157,14 +144,21 @@ module Hatch
     end
 
     def full_messages
-      messages = []
-      values.each {|value| messages << value unless value.empty?}
-      messages
+      values.reject {|value| value.empty?}
     end
 
     def empty?
       full_messages.empty?
     end
+
+  private
+
+    def self.attributes_and_errors(validated_attributes)
+      validated_attributes.map do |validated_attribute|
+        [validated_attribute.attr,
+         validated_attribute.invalid? ? validated_attribute.error : [] ]
+      end
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hatch
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Lucas Tolchinsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-02 00:00:00.000000000 Z
+date: 2013-06-18 00:00:00.000000000 Z
 dependencies: []
 description: An address without a street? A person without a name? You don't need
   no invalid objects!