hasoffersv3 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7453bceffc7ee46496b55fcf566830b784aeafc8
-  data.tar.gz: 4afeea63e581e37b8bbb50a1a604cc23a26ca1ad
+  metadata.gz: 6af628ce4e57076de7db4b320d0014e7add4e822
+  data.tar.gz: 0eb139d1daf9e20975167f4bd39465056ae189c4
 SHA512:
-  metadata.gz: dab7532456120fbcebb9883b4483f87b881f66ce58cfeff716c16a2af6512efac9eb0e23fda14d29c0c9bcd0529118ade4b74c800da97dce17b61a7c604f14a2
-  data.tar.gz: 153a7882dae6d973705dfb6510be90b74fbe66adbd900633f7f1845befb7d88ff42e05103588716ce7f38f62eb545114204b2bb38117396adeb732c53fc2af61
+  metadata.gz: 20e97013eff51bfc4801331a404124417a993db2e72c5beabb43000ff833fa0655b820b0a5d242fdf90a79f8fe69686c9a08ce4f5eafd06300b965aa23a7826e
+  data.tar.gz: a0da382c5b472e8f1de5753ab205b4e7454fa0de447020272d38e9ad2cc7cf5083d2852358f20b9d562e9ec95fd21606f10aa0c90be0423e778496d397e692a0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.2.2
+- Support "Offer/findAllIdsByAffiliateId" method
+- Support "Affiliate_Offer/findMyOffers" method
+
 # 0.2.1
 - Support "Affiliate_Offer/generateTrackingLink" method
 

data/lib/hasoffersv3/affiliate_offer.rb

@@ -1,33 +1,39 @@
 class HasOffersV3
   class AffiliateOffer < Base
+    class << self
 
-    def self.target
-      'Affiliate_Offer'
-    end
+      def target
+        'Affiliate_Offer'
+      end
 
-    def self.find_all(params = {})
-      post_request 'findAll', params
-    end
+      def find_all(params = {})
+        post_request 'findAll', params
+      end
 
-    def self.find_by_id(params = {})
-      requires! params, [:id]
-      post_request 'findById', params
-    end
+      def find_by_id(params = {})
+        requires! params, [:id]
+        post_request 'findById', params
+      end
 
-    def self.get_categories(params = {})
-      requires! params, [:ids]
-      post_request 'getCategories', params
-    end
+      def get_categories(params = {})
+        requires! params, [:ids]
+        post_request 'getCategories', params
+      end
 
-    def self.get_target_countries(params = {})
-      requires! params, [:ids]
-      post_request 'getTargetCountries', params
-    end
+      def get_target_countries(params = {})
+        requires! params, [:ids]
+        post_request 'getTargetCountries', params
+      end
 
-    def self.generate_tracking_link(params = {})
-      requires! params, [:offer_id]
-      post_request 'generateTrackingLink', params
-    end
+      def generate_tracking_link(params = {})
+        requires! params, [:offer_id]
+        post_request 'generateTrackingLink', params
+      end
 
+      def find_my_offers(params = {})
+        post_request 'findMyOffers', params
+      end
+
+    end
   end
 end

data/lib/hasoffersv3/offer.rb

@@ -15,6 +15,11 @@ class HasOffersV3
         post_request 'findAllIdsByAdvertiserId', params
       end
 
+      def find_all_ids_by_affiliate_id(params = {})
+        requires! params, [:affiliate_id]
+        post_request 'findAllIdsByAffiliateId', params
+      end
+
       def find_by_id(params = {})
         requires! params, [:id]
         post_request 'findById', params
@@ -34,6 +39,11 @@ class HasOffersV3
         requires! params, [:id, :affiliate_id]
         post_request 'setPayout', params
       end
+
+      def remove_payout(params = {})
+        requires! params, [:id, :affiliate_id]
+        post_request 'removePayout', params
+      end
     end
   end
 end

data/lib/hasoffersv3/version.rb

@@ -1,3 +1,3 @@
 class HasOffersV3
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

data/spec/lib/advertiser_spec.rb

@@ -9,7 +9,7 @@ describe HasOffersV3::Advertiser do
     it 'should make a proper request call' do
       stub_call
       response = subject.find_all
-      a_request(:post, url).with(body: hash_including({'Method' => 'findAll'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
@@ -18,7 +18,7 @@ describe HasOffersV3::Advertiser do
     it 'should make a proper request call' do
       stub_call
       response = subject.find_all_ids
-      a_request(:post, url).with(body: hash_including({'Method' => 'findAllIds'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllIds'}))).to have_been_made
       validate_call response
     end
   end
@@ -27,7 +27,7 @@ describe HasOffersV3::Advertiser do
     it 'should make a proper request call' do
       stub_call
       response = subject.find_by_id id: 1
-      a_request(:post, url).with(body: hash_including({'Method' => 'findById', 'id' => '1'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findById', 'id' => '1'}))).to have_been_made
       validate_call response
     end
 

data/spec/lib/advertiser_user_spec.rb

@@ -9,7 +9,7 @@ describe HasOffersV3::AdvertiserUser do
     it 'should make a proper request call' do
       stub_call
       response = subject.find_all
-      a_request(:post, url).with(body: hash_including({'Method' => 'findAll'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end

data/spec/lib/affiliate_offer_spec.rb

@@ -91,4 +91,15 @@ describe HasOffersV3::AffiliateOffer do
     end
   end
 
+  describe '.find_my_offers' do
+    it 'should make a proper request call' do
+      stub_call
+      response = subject.find_my_offers
+      request = a_request(:post, url).with(body: hash_including('Method' => 'findMyOffers'))
+      expect(request).to have_been_made
+
+      validate_call response
+    end
+  end
+
 end

data/spec/lib/affiliate_spec.rb

@@ -12,7 +12,7 @@ describe HasOffersV3::Affiliate do
   describe '.find_all' do
     it 'should make a proper request call' do
       response = subject.find_all
-      a_request(:post, url).with(body: hash_including({'Method' => 'findAll'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
@@ -21,7 +21,7 @@ describe HasOffersV3::Affiliate do
     it 'should make a proper request call' do
       stub_call :get, nil, Regexp.new(url)
       response = subject.find_by_id id: 1
-      a_request(:get, url).with(query: hash_including({'Method' => 'findById', 'id' => '1'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'findById', 'id' => '1'}))).to have_been_made
       validate_call response
     end
 
@@ -35,7 +35,7 @@ describe HasOffersV3::Affiliate do
   describe '.update_payment_method_wire' do
     it 'should make a proper request call' do
       response = subject.update_payment_method_wire
-      a_request(:post, url).with(body: hash_including({'Method' => 'updatePaymentMethodWire'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'updatePaymentMethodWire'}))).to have_been_made
       validate_call response
     end
   end
@@ -43,7 +43,7 @@ describe HasOffersV3::Affiliate do
   describe '.update_payment_method_paypal' do
     it 'should make a proper request call' do
       response = subject.update_payment_method_paypal
-      a_request(:post, url).with(body: hash_including({'Method' => 'updatePaymentMethodPaypal'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'updatePaymentMethodPaypal'}))).to have_been_made
       validate_call response
     end
   end

data/spec/lib/base_spec.rb

@@ -34,9 +34,7 @@ describe HasOffersV3::Base do
       it "should make a proper request" do
         stub_call :get
         response = subject.get_request 'test'
-        a_request(:get, url).
-            with(query: hash_including('Method' => 'test')).
-            should have_been_made
+        expect(a_request(:get, url).with(query: hash_including('Method' => 'test'))).to have_been_made
         validate_call response
       end
     end

data/spec/lib/conversion_spec.rb

@@ -12,7 +12,7 @@ describe HasOffersV3::Conversion do
   describe '.find_all' do
     it 'should make a proper request call' do
       response = subject.find_all
-      a_request(:get, url).with(query: hash_including({'Method' => 'findAll'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
@@ -20,7 +20,7 @@ describe HasOffersV3::Conversion do
   describe '.find_added_conversions' do
     it 'should make a proper request call' do
       response = subject.find_added_conversions
-      a_request(:get, url).with(query: hash_including({'Method' => 'findAddedConversions'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'findAddedConversions'}))).to have_been_made
       validate_call response
     end
   end
@@ -28,7 +28,7 @@ describe HasOffersV3::Conversion do
   describe '.find_updated_conversions' do
     it 'should make a proper request call' do
       response = subject.find_updated_conversions
-      a_request(:get, url).with(query: hash_including({'Method' => 'findUpdatedConversions'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'findUpdatedConversions'}))).to have_been_made
       validate_call response
     end
   end
@@ -36,7 +36,7 @@ describe HasOffersV3::Conversion do
   describe '.findAll' do
     it 'should make a proper request call' do
       response = subject.findAll
-      a_request(:get, url).with(query: hash_including({'Method' => 'findAll'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
 

data/spec/lib/offer_spec.rb

@@ -9,7 +9,7 @@ describe HasOffersV3::Offer do
     it 'should make a proper request call' do
       stub_call
       response = HasOffersV3::Offer.find_all
-      a_request(:post, url).with(body: hash_including({'Method' => 'findAll'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
@@ -18,7 +18,7 @@ describe HasOffersV3::Offer do
     it 'should make a proper request call' do
       stub_call
       response = HasOffersV3::Offer.find_all_by_ids ids: [1]
-      a_request(:post, url).with(body: hash_including({'Method' => 'findAllByIds'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllByIds'}))).to have_been_made
       validate_call response
     end
 
@@ -33,7 +33,7 @@ describe HasOffersV3::Offer do
     it 'should make a proper request call' do
       stub_call
       response = HasOffersV3::Offer.find_all_ids_by_advertiser_id advertiser_id: 1
-      a_request(:post, url).with(body: hash_including({'Method' => 'findAllIdsByAdvertiserId', 'advertiser_id' => '1'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllIdsByAdvertiserId', 'advertiser_id' => '1'}))).to have_been_made
       validate_call response
     end
 
@@ -44,11 +44,19 @@ describe HasOffersV3::Offer do
     end
   end
 
+  describe '.find_all_ids_by_affiliate_id' do
+    it 'should make a proper request call' do
+      stub_call
+      response = HasOffersV3::Offer.find_all_ids_by_affiliate_id affiliate_id: 1
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllIdsByAffiliateId', 'affiliate_id' => '1'}))).to have_been_made
+    end
+  end
+
   describe '.find_by_id' do
     it 'should make a proper request call' do
       stub_call
       response = HasOffersV3::Offer.find_by_id id: 1
-      a_request(:post, url).with(body: hash_including({'Method' => 'findById', 'id' => '1'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'findById', 'id' => '1'}))).to have_been_made
       validate_call response
     end
 
@@ -63,7 +71,7 @@ describe HasOffersV3::Offer do
     it 'should make a proper request call' do
       stub_call
       response = HasOffersV3::Offer.get_groups id: 1
-      a_request(:post, url).with(body: hash_including({'Method' => 'getGroups'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'getGroups'}))).to have_been_made
       validate_call response
     end
 
@@ -78,7 +86,7 @@ describe HasOffersV3::Offer do
     it 'makes a proper API request' do
       stub_call
       response = HasOffersV3::Offer.get_approved_affiliate_ids id: 1
-      a_request(:post, url).with(body: hash_including({'Method' => 'getApprovedAffiliateIds'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'getApprovedAffiliateIds'}))).to have_been_made
       validate_call response
     end
 
@@ -93,7 +101,7 @@ describe HasOffersV3::Offer do
     it 'should make a proper request call' do
       stub_call
       response = HasOffersV3::Offer.set_payout id: 1, affiliate_id: 321
-      a_request(:post, url).with(body: hash_including({'Method' => 'setPayout'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'setPayout'}))).to have_been_made
       validate_call response
     end
 
@@ -103,4 +111,19 @@ describe HasOffersV3::Offer do
       end
     end
   end
+
+  describe '.remove_payout' do
+    it 'should make a proper request call' do
+      stub_call
+      response = HasOffersV3::Offer.remove_payout id: 1, affiliate_id: 321
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'removePayout'}))).to have_been_made
+      validate_call response
+    end
+
+    context 'when the id and/or affiliate id parameters are missing' do
+      it 'raises an exception' do
+        expect {  HasOffersV3::Offer.remove_payout }.to raise_error ArgumentError
+      end
+    end
+  end
 end

data/spec/lib/raw_log_spec.rb

@@ -12,7 +12,7 @@ describe HasOffersV3::RawLog do
   describe '.get_download_link' do
     it 'should make a proper request call' do
       response = subject.get_download_link log_type: 'clicks', log_filename: 'xxx'
-      a_request(:get, url).with(query: hash_including({'Method' => 'getDownloadLink'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'getDownloadLink'}))).to have_been_made
       validate_call response
     end
 
@@ -32,7 +32,7 @@ describe HasOffersV3::RawLog do
   describe '.get_log_expirations' do
     it 'should make a proper request call' do
       response = subject.get_log_expirations
-      a_request(:get, url).with(query: hash_including({'Method' => 'getLogExpirations'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'getLogExpirations'}))).to have_been_made
       validate_call response
     end
   end
@@ -40,7 +40,7 @@ describe HasOffersV3::RawLog do
   describe '.list_date_dirs' do
     it 'should make a proper request call' do
       response = subject.list_date_dirs log_type: 'clicks'
-      a_request(:get, url).with(query: hash_including({'Method' => 'listDateDirs'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'listDateDirs'}))).to have_been_made
       validate_call response
     end
 
@@ -54,7 +54,7 @@ describe HasOffersV3::RawLog do
   describe '.list_logs' do
     it 'should make a proper request call' do
       response = subject.list_logs log_type: 'clicks', date_dir: '20140101'
-      a_request(:get, url).with(query: hash_including({'Method' => 'listLogs'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'listLogs'}))).to have_been_made
       validate_call response
     end
 
@@ -70,4 +70,4 @@ describe HasOffersV3::RawLog do
       end
     end
   end
-end
+end

data/spec/lib/report_spec.rb

@@ -9,7 +9,7 @@ describe HasOffersV3::Report do
 
     it 'should make a proper request call' do
       response = subject.get_conversions
-      a_request(:post, url).with(body: hash_including({'Method' => 'getConversions'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'getConversions'}))).to have_been_made
       validate_call response
     end
   end
@@ -19,7 +19,7 @@ describe HasOffersV3::Report do
 
     it 'should make a proper request call' do
       response = subject.getConversions
-      a_request(:post, url).with(body: hash_including({'Method' => 'getConversions'})).should have_been_made
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'getConversions'}))).to have_been_made
       validate_call response
     end
 
@@ -41,7 +41,7 @@ describe HasOffersV3::Report do
 
     it 'should make a proper request call' do
       response = subject.get_mod_summary_logs
-      a_request(:get, url).with(query: hash_including({'Method' => 'getModSummaryLogs'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'getModSummaryLogs'}))).to have_been_made
       validate_call response
     end
   end
@@ -53,7 +53,7 @@ describe HasOffersV3::Report do
 
     it 'should make a proper request call' do
       response = subject.getModSummaryLogs
-      a_request(:get, url).with(query: hash_including({'Method' => 'getModSummaryLogs'})).should have_been_made
+      expect(a_request(:get, url).with(query: hash_including({'Method' => 'getModSummaryLogs'}))).to have_been_made
       validate_call response
     end
 

data/spec/spec_helper.rb

@@ -10,7 +10,6 @@ require 'webmock/rspec'
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hasoffersv3
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Maximilian Seifert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-09 00:00:00.000000000 Z
+date: 2014-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -181,3 +181,4 @@ test_files:
 - spec/lib/raw_log_spec.rb
 - spec/lib/report_spec.rb
 - spec/spec_helper.rb
+has_rdoc: