hasoffersv3 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1f94908bc73b00a0152fbf3ad054a776f268518
-  data.tar.gz: 06dfd698ca5f91d43105207f0638558fc3c2993b
+  metadata.gz: 5e19c9439e228e95df8e9790cc5771bee7ca3442
+  data.tar.gz: fa1150166459c267df061da7cac6901edf39c3c5
 SHA512:
-  metadata.gz: 93bcc4325bda19af9b1c4e3f19443dfdda45fd2fc7999a566b1b0e4ebfc48b4a1036fff65181472f6041ee84824038934ea0cb88b95f8befdce8af3cd28e81a0
-  data.tar.gz: 5436dd964dd12c9f8226710a41787fa6cf27ab18a07157043df963191e655f3ad24c0ae56a4ce722f85373efd4589c3e2dd52498c077b3919f61a503321a5f97
+  metadata.gz: 9d65f052b5c37b02b885608be5edd223f481fc9fafaa52b8ca437b117badf2680853a46f745a35d1c048e5a9f83ce967140b22e190d73ae2c56f1469f5a3edc9
+  data.tar.gz: 0746fc08779f6cc2fff4d13ee66a020b74a184185c3f3cd0783dc031bb370a50b175410ed3f3c565a70e1dcddd55e77250b3d9e30b5d2b567284ff6a1a1facff

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+# 0.1.0
+
+- [#14] added `.find_added_conversions` and `find_updated_conversions` calls
+- [#16] added protocol configuration option for API url (default is `http`)
+- [#13] fixed `get_log_expirations` call
+- [#15] fixed missing tests for `RawLog`
+
+# 0.0.1
+
+- initial release

data/README.md

@@ -1,6 +1,17 @@
-# Ruby wrapper for HasOffers APIv3
+### Overview 
 
-Gem provides wrapper around HasOffers API in version 3, [HasOffers APIv3 Documentation](http://developers.hasoffers.com/#/brand).
+[![Build status](https://api.travis-ci.org/HitFox/hasoffersv3.png?branch=master)](http://travis-ci.org/HitFox/hasoffersv3) 
+
+### Synopsis
+
+This gem provides a wrapper around HasOffers API in version 3, [HasOffers APIv3 Documentation](http://developers.hasoffers.com/#/brand).
+
+### Compatibility
+
+Supported ruby versions:
+
+*   1.9.3
+*   2.0
 
 ## Installation
 

data/lib/hasoffersv3/base.rb

@@ -4,7 +4,7 @@ require 'active_support/core_ext/object/to_query'
 module HasOffersV3
   class Base
     class << self
-      def get_request(method, params, &block)
+      def get_request(method, params = {}, &block)
         if block.nil?
           make_request(:get, method, params)
         else
@@ -17,7 +17,7 @@ module HasOffersV3
         end
       end
 
-      def post_request(method, params, &block)
+      def post_request(method, params = {}, &block)
         if block.nil?
           make_request(:post, method, params)
         else
@@ -52,6 +52,7 @@ module HasOffersV3
 
       def new_http(uri)
         http = Net::HTTP.new(uri.host, uri.port)
+        http.use_ssl      = true if uri.scheme == 'https'
         http.read_timeout = 600
         http
       end

data/lib/hasoffersv3/configuration.rb

@@ -1,9 +1,15 @@
 module HasOffersV3
   class Configuration
-    attr_accessor :network_id, :api_key, :base_uri
+    attr_accessor :network_id, :api_key, :protocol, :host, :base_path
 
     def initialize
-      @base_uri = 'http://api.hasoffers.com/v3'
+      @protocol   = 'http'
+      @host       = 'api.hasoffers.com'
+      @base_path  = '/v3'
+    end
+
+    def base_uri
+      "#{protocol}://#{host}#{base_path}"
     end
   end
 end

data/lib/hasoffersv3/conversion.rb

@@ -9,6 +9,14 @@ module HasOffersV3
       def find_all(params = {})
         get_request 'findAll', params
       end
+
+      def find_added_conversions(params = {})
+        get_request 'findAddedConversions', params
+      end
+
+      def find_updated_conversions(params = {})
+        get_request 'findUpdatedConversions', params
+      end
     end
   end
 end

data/lib/hasoffersv3/raw_log.rb

@@ -6,8 +6,8 @@ module HasOffersV3
         get_request 'getDownloadLink', params
       end
 
-      def get_log_expirations(params = {})
-        get_request 'getLogExpirations', params
+      def get_log_expirations
+        get_request 'getLogExpirations'
       end
 
       def list_date_dirs(params = {})

data/lib/hasoffersv3/version.rb

@@ -1,3 +1,3 @@
 module HasOffersV3
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/spec/lib/base_spec.rb

@@ -1,9 +1,35 @@
 require 'spec_helper'
 
 describe HasOffersV3::Base do
+  subject { HasOffersV3::Base }
+
+  let(:url)  { Regexp.new api_url('Base') }
+
   describe :requires! do
     it 'raise ArgumentError is parameters are missing' do
-      expect { subject.class.requires!({}, [:dummy]) }.to raise_error(ArgumentError)
+      expect { subject.requires!({}, [:dummy]) }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe ".get_request" do
+    it "should make a proper request" do
+      stub_call :get
+      response = subject.get_request 'test'
+      a_request(:get, url).with(query: hash_including({'Method' => 'test'})).should have_been_made
+      validate_call response
+    end
+
+    context "with HTTPS enabled" do
+      before(:each) do
+        HasOffersV3.configuration.protocol = 'https'
+      end
+
+      it "should make a proper request" do
+        stub_call :get
+        response = subject.get_request 'test'
+        a_request(:get, url).with(query: hash_including({'Method' => 'test'})).should have_been_made
+        validate_call response
+      end
     end
   end
 end

data/spec/lib/conversion_spec.rb

@@ -17,6 +17,22 @@ describe HasOffersV3::Conversion do
     end
   end
 
+  describe '.find_added_conversions' do
+    it 'should make a proper request call' do
+      response = subject.find_added_conversions
+      a_request(:get, url).with(query: hash_including({'Method' => 'findAddedConversions'})).should have_been_made
+      validate_call response
+    end
+  end
+
+  describe '.find_updated_conversions' do
+    it 'should make a proper request call' do
+      response = subject.find_updated_conversions
+      a_request(:get, url).with(query: hash_including({'Method' => 'findUpdatedConversions'})).should have_been_made
+      validate_call response
+    end
+  end
+
   describe '.findAll' do
     it 'should make a proper request call' do
       response = subject.findAll

data/spec/lib/raw_log_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+describe HasOffersV3::RawLog do
+  subject { HasOffersV3::RawLog }
+
+  let(:url)  { Regexp.new api_url('RawLog') }
+
+  before :each do
+    stub_call :get
+  end
+
+  describe '.get_download_link' do
+    it 'should make a proper request call' do
+      response = subject.get_download_link log_type: 'clicks', log_filename: 'xxx'
+      a_request(:get, url).with(query: hash_including({'Method' => 'getDownloadLink'})).should have_been_made
+      validate_call response
+    end
+
+    context 'when there is no log_type' do
+      it 'it should raise an exception' do
+        expect { subject.get_download_link log_filename: 'xxx' }.to raise_error ArgumentError
+      end
+    end
+
+    context 'when there is no log_filename' do
+      it 'it should raise an exception' do
+        expect { subject.get_download_link log_type: 'clicks' }.to raise_error ArgumentError
+      end
+    end
+  end
+
+  describe '.get_log_expirations' do
+    it 'should make a proper request call' do
+      response = subject.get_log_expirations
+      a_request(:get, url).with(query: hash_including({'Method' => 'getLogExpirations'})).should have_been_made
+      validate_call response
+    end
+  end
+
+  describe '.list_date_dirs' do
+    it 'should make a proper request call' do
+      response = subject.list_date_dirs log_type: 'clicks'
+      a_request(:get, url).with(query: hash_including({'Method' => 'listDateDirs'})).should have_been_made
+      validate_call response
+    end
+
+    context 'when there is no log_type' do
+      it 'it should raise an exception' do
+        expect { subject.list_date_dirs }.to raise_error ArgumentError
+      end
+    end
+  end
+
+  describe '.list_logs' do
+    it 'should make a proper request call' do
+      response = subject.list_logs log_type: 'clicks', date_dir: '20140101'
+      a_request(:get, url).with(query: hash_including({'Method' => 'listLogs'})).should have_been_made
+      validate_call response
+    end
+
+    context 'when there is no log_type' do
+      it 'it should raise an exception' do
+        expect { subject.list_logs date_dir: '20140101' }.to raise_error ArgumentError
+      end
+    end
+
+    context 'when there is no date_dir' do
+      it 'it should raise an exception' do
+        expect { subject.list_logs log_type: 'clicks' }.to raise_error ArgumentError
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hasoffersv3
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Maximilian Seifert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-19 00:00:00.000000000 Z
+date: 2014-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -107,6 +107,7 @@ files:
 - .rspec
 - .ruby-gemset
 - .ruby-version
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -131,6 +132,7 @@ files:
 - spec/lib/base_spec.rb
 - spec/lib/conversion_spec.rb
 - spec/lib/offer_spec.rb
+- spec/lib/raw_log_spec.rb
 - spec/lib/report_spec.rb
 - spec/spec_helper.rb
 homepage: 
@@ -164,5 +166,6 @@ test_files:
 - spec/lib/base_spec.rb
 - spec/lib/conversion_spec.rb
 - spec/lib/offer_spec.rb
+- spec/lib/raw_log_spec.rb
 - spec/lib/report_spec.rb
 - spec/spec_helper.rb