hasoffers 0.1.5 → 0.1.6

data/CHANGELOG

@@ -1,5 +1,10 @@
+== Version 0.1.6
+* Fix issues with error hash on Response object
+* Fix issues that occur when sending GET requests over a proxy, switched
+  to POST params where possible
+
 == Version 0.1.4
-  * Create a class method to get and set the @@base_uri, with tests
+* Create a class method to get and set the @@base_uri, with tests
 
 == Version 0.1.3
 * Bug fix - it's possible for AffiliateBilling to return an array of nil, instead

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    hasoffers (0.1.4)
+    hasoffers (0.1.6)
       crack
       yajl-ruby
 

data/lib/hasoffers/advertiser.rb

@@ -7,7 +7,7 @@ module HasOffers
     class << self
 
       def find_all(params = {})
-        get_request(Target, 'findAll', params)
+        post_request(Target, 'findAll', params)
       end
 
       def create(data, return_object = false)
@@ -26,4 +26,4 @@ module HasOffers
 
   end
 
-end
+end

data/lib/hasoffers/affiliate_billing.rb

@@ -6,9 +6,12 @@ module HasOffers
 
     class << self
 
+      # Jon Phenow @ 06/13/12
+      # Switched this to use POST because of some weird issues with sending
+      # from behind a proxy
       def find_invoice_stats(params)
         requires!(params, %w[affiliate_id end_date])
-        get_request(Target, 'findInvoiceStats', params)
+        post_request(Target, 'findInvoiceStats', params)
       end
 
       def simplify_response_data data
@@ -22,8 +25,11 @@ module HasOffers
         data.map { |id, invoice_data| invoice_data["AffiliateInvoice"] }
       end
 
+      # Jon Phenow @ 06/13/12
+      # Switched this to use POST because of some weird issues with sending
+      # from behind a proxy
       def find_all_invoices(params)
-        response = get_request(Target, 'findAllInvoices', params)
+        response = post_request(Target, 'findAllInvoices', params)
         if response.success?
           # strip out the clutter
           response.set_data simplify_response_data(response.data)
@@ -31,9 +37,12 @@ module HasOffers
         response
       end
 
+      # Jon Phenow @ 06/13/12
+      # Switched this to use POST because of some weird issues with sending
+      # from behind a proxy
       def find_all_invoices_by_ids(ids, params = {})
         params['ids'] = ids
-        response = get_request(Target, 'findAllInvoicesByIds', params)
+        response = post_request(Target, 'findAllInvoicesByIds', params)
         if response.success?
           # strip out the clutter
           response.set_data simplify_response_data(response.data)
@@ -57,4 +66,4 @@ module HasOffers
 
   end
 
-end
+end

data/lib/hasoffers/report.rb

@@ -6,9 +6,12 @@ module HasOffers
 
     class << self
 
+      # Jon Phenow @ 06/13/12
+      # Switched this to use POST because of some weird issues with sending
+      # from behind a proxy
       def get_stats(params)
         requires!(params, %w[fields])
-        response = get_request(Target, 'getStats', params)
+        response = post_request(Target, 'getStats', params)
         if response.success?
           # strip out the 'Stat' keys which is just extra clutter
           data = response.data.map do |stat|
@@ -19,8 +22,11 @@ module HasOffers
         response
       end
 
+      # Jon Phenow @ 06/13/12
+      # Switched this to use POST because of some weird issues with sending
+      # from behind a proxy
       def get_conversions(params)
-        response = get_request(Target, 'getConversions', params)
+        response = post_request(Target, 'getConversions', params)
         if response.success?
           # strip out the 'Stat' keys which is just extra clutter
           data = response.data.map do |stat|
@@ -35,4 +41,4 @@ module HasOffers
 
   end
   
-end
+end

data/lib/hasoffers/response.rb

@@ -1,7 +1,5 @@
 module HasOffers
-
   class Response
-
     attr_reader :test, :body, :http_status_code, :http_message, :http_headers
 
     def success?
@@ -56,9 +54,9 @@ module HasOffers
 
     def error_messages
       if data.is_a? Hash and data["errors"] and data["errors"]["error"]
-        data["errors"]["error"].map { |error| error["err_msg"] }
+        get_error_values data["errors"]["error"]
       elsif @body["response"]["errors"]
-        @body["response"]["errors"].map { |error| error["err_msg"] }
+        get_error_values @body["response"]["errors"]
       else
         []
       end
@@ -83,6 +81,14 @@ module HasOffers
       @body['response']['data'] and @body['response']['data'].is_a?(Hash) and @body['response']['data'].has_key?('pageCount')
     end
 
-  end
+    private
 
-end
+    def get_error_values(obj)
+      if obj.is_a? Hash
+        obj.values
+      elsif obj.is_a? Array
+        obj.map { |error| error["err_msg"] || error["publicMessage"] }
+      end
+    end
+  end
+end

data/lib/hasoffers/version.rb

@@ -1,3 +1,3 @@
 module Hasoffers
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hasoffers
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-02 00:00:00.000000000 Z
+date: 2012-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crack
-  requirement: &70102351422880 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70102351422880
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70102351438360 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70102351438360
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70102351435880 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +53,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70102351435880
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Implementation of the HasOffers API for affiliate advertising.
 email:
 - luke.ludwig@tstmedia.com
@@ -91,15 +106,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 869840649197282084
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 869840649197282084
 requirements: []
 rubyforge_project: hasoffers
-rubygems_version: 1.8.17
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Implementation of the HasOffers API for affiliate advertising.