hashira 0.7.0 → 0.8.0

data/lib/hashira/smells/refs.rb

@@ -10,23 +10,29 @@ class Hashira::Smells::Refs
     Prism::InstanceVariableOperatorWriteNode, Prism::InstanceVariableTargetNode
   ].freeze
 
-  def initialize(def_node)
-    @tallies = {}
-    Hashira::Smells::Scope.inside(def_node).each { record(it) }
+  def initialize(definition)
+    @node = definition
   end
 
   def ego = lines(:self).size
 
-  def lines(name) = @tallies.fetch(name, [])
+  def lines(name) = tallies.fetch(name, [])
 
   def envious
-    peak = @tallies.values.map(&:size).max
-    names = @tallies.filter_map { |name, sightings| name if sightings.size == peak }
+    peak = tallies.values.map(&:size).max
+    names = tallies.filter_map { |name, sightings| name if sightings.size == peak }
     names.include?(:self) ? [] : names
   end
 
   private
 
+  def tallies
+    return @_tallies if @_tallies
+    @_tallies = {}
+    Hashira::Smells::Scope.inside(@node).each { record(it) }
+    @_tallies
+  end
+
   def record(node)
     return note(:self, node) if selfish?(node)
     case node
@@ -49,5 +55,5 @@ class Hashira::Smells::Refs
     end
   end
 
-  def note(name, node) = (@tallies[name] ||= []) << node.location.start_line
+  def note(name, node) = (@_tallies[name] ||= []) << node.location.start_line
 end

data/lib/hashira/smells/repeated_conditional.rb

@@ -5,14 +5,12 @@ require "prism"
 class Hashira::Smells::RepeatedConditional < Hashira::Smells::Check
   LIMIT = 2
 
-  def self.judge? = true
-
   private
 
   def smelly? = subject.kind == :class && repeats.any?
 
   def repeats
-    @repeats ||= predicates.group_by(&:slice).except("block_given?").select { |_test, nodes| nodes.size > LIMIT }
+    @_repeats ||= predicates.group_by(&:slice).except("block_given?").select { |_test, nodes| nodes.size > LIMIT }
   end
 
   def predicates = Hashira::Smells::Scope.sweep(subject.node).filter_map { predicate(it) }

data/lib/hashira/smells/report.rb

@@ -8,6 +8,7 @@ require_relative "duplicate_method_call"
 require_relative "feature_envy"
 require_relative "foreign"
 require_relative "instance_variable_assumption"
+require_relative "kind"
 require_relative "manual_dispatch"
 require_relative "module_initialize"
 require_relative "nil_check"
@@ -19,22 +20,30 @@ require_relative "utility_function"
 class Hashira::Smells::Report
   CHECKS = Hashira::Smells::Check.subclasses.sort_by(&:name).freeze
 
-  JUDGES = CHECKS.select(&:judge?).freeze
+  JUDGES = [
+    Hashira::Smells::DataClump, Hashira::Smells::InstanceVariableAssumption,
+    Hashira::Smells::ModuleInitialize, Hashira::Smells::RepeatedConditional,
+    Hashira::Smells::TooManyInstanceVariables
+  ].freeze
 
-  PROBES = CHECKS.reject(&:judge?).freeze
+  PROBES = (CHECKS - JUDGES).freeze
 
   def initialize(project, trees)
-    @census = Hashira::Smells::Census.new(project, trees)
-    @types = @census.types
+    @project = project
+    @trees = trees
   end
 
-  def findings = @findings ||= sniff(@types, JUDGES) + sniff(methods, PROBES) + sprawl
+  def findings = @_findings ||= sniff(types, JUDGES) + sniff(methods, PROBES) + sprawl
 
   private
 
-  def methods = @types.flat_map(&:defs)
+  def census = @_census ||= Hashira::Smells::Census.new(@project, @trees)
 
-  def sprawl = Hashira::Smells::BoundarySprawl.new(methods, @census.ownership).findings
+  def types = @_types ||= census.types
+
+  def methods = types.flat_map(&:defs)
+
+  def sprawl = Hashira::Smells::BoundarySprawl.new(methods, census.ownership).findings
 
   def sniff(subjects, checks) = subjects.flat_map { |subject| verdicts(subject, checks) }
 

data/lib/hashira/smells/too_many_instance_variables.rb

@@ -10,14 +10,14 @@ class Hashira::Smells::TooManyInstanceVariables < Hashira::Smells::Check
     Prism::InstanceVariableOperatorWriteNode, Prism::InstanceVariableTargetNode
   ].freeze
 
-  def self.judge? = true
-
   private
 
   def smelly? = subject.kind == :class && names.size > LIMIT
 
   def names
-    @names ||= Hashira::Smells::Scope.sweep(subject.node).select { COUNTED.include?(it.class) }.map(&:name).uniq.sort
+    @_names ||=
+      Hashira::Smells::Scope.sweep(subject.node).select { COUNTED.include?(it.class) }
+        .map(&:name).reject { it.start_with?("@_") }.uniq.sort
   end
 
   def detail = { site:, count: names.size }

data/lib/hashira/smells/visibility.rb

@@ -5,17 +5,24 @@ require "prism"
 class Hashira::Smells::Visibility
   MARKERS = %i[public private protected module_function].freeze
 
-  def initialize(type_node)
-    @section = :public
-    @overrides = {}
-    @found = []
-    scan(statements(type_node))
+  def initialize(type)
+    @node = type
   end
 
-  def entries = @found.map { |node, section| [node, @overrides.fetch(node.name, section)] }
+  def entries
+    blank
+    scan(statements(@node))
+    @_found.map { |node, section| [node, @_overrides.fetch(node.name, section)] }
+  end
 
   private
 
+  def blank
+    @_section = :public
+    @_overrides = {}
+    @_found = []
+  end
+
   def statements(node)
     body = node.body
     body.is_a?(Prism::StatementsNode) ? body.body : []
@@ -25,7 +32,7 @@ class Hashira::Smells::Visibility
 
   def classify(node)
     case node
-    when Prism::DefNode then @found << [node, @section]
+    when Prism::DefNode then @_found << [node, @_section]
     when Prism::CallNode then heed(node)
     else descend(node)
     end
@@ -46,19 +53,19 @@ class Hashira::Smells::Visibility
   def bare?(node) = MARKERS.include?(node.name) && !node.receiver
 
   def switch(name, arguments)
-    arguments ? tag(name, arguments.arguments) : (@section = name)
+    arguments ? tag(name, arguments.arguments) : (@_section = name)
   end
 
   def tag(section, arguments) = arguments.each { note(it, section) }
 
   def note(argument, section)
     case argument
-    when Prism::DefNode then @found << [argument, section]
-    when Prism::SymbolNode then @overrides[argument.unescaped.to_sym] = section
+    when Prism::DefNode then @_found << [argument, section]
+    when Prism::SymbolNode then @_overrides[argument.unescaped.to_sym] = section
     end
   end
 
   def shadow(node)
-    statements(node).each { @found << [it, :singleton] if it.is_a?(Prism::DefNode) }
+    statements(node).each { @_found << [it, :singleton] if it.is_a?(Prism::DefNode) }
   end
 end

data/lib/hashira/trees.rb

@@ -4,17 +4,21 @@ require "prism"
 
 class Hashira::Trees
   def initialize(project)
-    @unparsed = []
-    @all = project.files.to_h { [it, parse(it)] }
+    @project = project
   end
 
-  attr_reader :all, :unparsed
+  def all = @_all ||= @project.files.to_h { [it, parse(it)] }
+
+  def unparsed
+    all
+    @_unparsed ||= []
+  end
 
   private
 
   def parse(path)
     result = Prism.parse_file(path)
-    @unparsed << path if result.failure?
+    (@_unparsed ||= []) << path if result.failure?
     result.value
   rescue SystemCallError => error
     raise(Hashira::Error, "cannot read #{path} (#{error.message})")

data/lib/hashira/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hashira
-  VERSION = "0.7.0"
+  VERSION = "0.8.0"
 end

data/lib/hashira.rb

@@ -34,8 +34,10 @@ require_relative "hashira/analysis/node_walk"
 require_relative "hashira/analysis/syntax"
 require_relative "hashira/analysis/type_walk"
 require_relative "hashira/churn"
+require_relative "hashira/git_log"
 require_relative "hashira/ci/accepted"
 require_relative "hashira/ci/baseline"
+require_relative "hashira/ci/comparison"
 require_relative "hashira/ci/diff"
 require_relative "hashira/ci/edge_diff_report"
 require_relative "hashira/ci/finding_diff_report"
@@ -44,15 +46,19 @@ require_relative "hashira/ci/improvement"
 require_relative "hashira/ci/ratchet"
 require_relative "hashira/ci/ratchet_report"
 require_relative "hashira/ci/scope"
+require_relative "hashira/ci/slice"
 require_relative "hashira/ci/status"
+require_relative "hashira/ci/sweep"
 require_relative "hashira/cli"
 require_relative "hashira/cli/arguments"
+require_relative "hashira/cli/choice"
 require_relative "hashira/cli/command_line"
 require_relative "hashira/cli/fail_on"
 require_relative "hashira/cli/flag"
 require_relative "hashira/cli/flags"
 require_relative "hashira/cli/format"
 require_relative "hashira/cli/needs"
+require_relative "hashira/cli/only"
 require_relative "hashira/cli/options"
 require_relative "hashira/cli/package_by"
 require_relative "hashira/cli/run"
@@ -117,6 +123,7 @@ require_relative "hashira/duplication/similarity"
 require_relative "hashira/duplication/union_find"
 require_relative "hashira/duplication/variance"
 require_relative "hashira/error"
+require_relative "hashira/focus"
 require_relative "hashira/hotspots/file_cost"
 require_relative "hashira/hotspots/rollup"
 require_relative "hashira/pipeline"
@@ -136,6 +143,7 @@ require_relative "hashira/report/text"
 require_relative "hashira/report/view"
 require_relative "hashira/smells/census"
 require_relative "hashira/smells/check"
+require_relative "hashira/smells/kind"
 require_relative "hashira/smells/conditions"
 require_relative "hashira/smells/contexts"
 require_relative "hashira/smells/control_parameter"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hashira
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Giacomo GK
@@ -33,6 +33,7 @@ files:
 - lib/hashira/churn.rb
 - lib/hashira/ci/accepted.rb
 - lib/hashira/ci/baseline.rb
+- lib/hashira/ci/comparison.rb
 - lib/hashira/ci/diff.rb
 - lib/hashira/ci/edge_diff_report.rb
 - lib/hashira/ci/finding_diff_report.rb
@@ -41,15 +42,19 @@ files:
 - lib/hashira/ci/ratchet.rb
 - lib/hashira/ci/ratchet_report.rb
 - lib/hashira/ci/scope.rb
+- lib/hashira/ci/slice.rb
 - lib/hashira/ci/status.rb
+- lib/hashira/ci/sweep.rb
 - lib/hashira/cli.rb
 - lib/hashira/cli/arguments.rb
+- lib/hashira/cli/choice.rb
 - lib/hashira/cli/command_line.rb
 - lib/hashira/cli/fail_on.rb
 - lib/hashira/cli/flag.rb
 - lib/hashira/cli/flags.rb
 - lib/hashira/cli/format.rb
 - lib/hashira/cli/needs.rb
+- lib/hashira/cli/only.rb
 - lib/hashira/cli/options.rb
 - lib/hashira/cli/package_by.rb
 - lib/hashira/cli/run.rb
@@ -115,6 +120,8 @@ files:
 - lib/hashira/duplication/union_find.rb
 - lib/hashira/duplication/variance.rb
 - lib/hashira/error.rb
+- lib/hashira/focus.rb
+- lib/hashira/git_log.rb
 - lib/hashira/hotspots/file_cost.rb
 - lib/hashira/hotspots/rollup.rb
 - lib/hashira/pipeline.rb
@@ -143,6 +150,7 @@ files:
 - lib/hashira/smells/feature_envy.rb
 - lib/hashira/smells/foreign.rb
 - lib/hashira/smells/instance_variable_assumption.rb
+- lib/hashira/smells/kind.rb
 - lib/hashira/smells/manual_dispatch.rb
 - lib/hashira/smells/module_initialize.rb
 - lib/hashira/smells/nil_check.rb