hashira 0.2.0 → 0.4.0

data/lib/hashira/report/json.rb

@@ -2,47 +2,45 @@
 
 require "json"
 
-module Hashira
-  module Report
-    class Json
-      def initialize(view, io: $stdout)
-        @view = view
-        @io = io
-      end
+class Hashira::Report::Json
+  def initialize(view, io: $stdout)
+    @view = view
+    @io = io
+  end
 
-      def print
-        @io.puts JSON.pretty_generate(payload)
-        0
-      end
+  def print
+    @io.puts(JSON.pretty_generate(payload))
+    0
+  end
 
-      private
+  private
 
-      def payload = base.merge(graph_payload).merge(sections.compact)
+  def payload = base.merge(coupling).merge(sections.compact)
 
-      def base = { findings: @view.findings.all.map(&:to_h), accepted: accepted_entries }
+  def base = { findings: @view.findings.all.map(&:to_h), accepted: accepted }
 
-      def graph_payload
-        graph = @view.graph
-        graph ? GraphPayload.new(graph).to_h : {}
-      end
+  def coupling
+    graph = @view.graph
+    graph ? Hashira::Report::GraphPayload.new(graph).to_h : {}
+  end
 
-      def sections
-        { complexity: (complexity_payload if @view.complexity),
-          duplication: (duplication_payload if @view.duplication),
-          hotspots: @view.hotspots&.files&.map(&:to_h) }
-      end
+  def sections
+    {
+      complexity: (complexity if @view.complexity),
+      duplication: (duplication if @view.duplication),
+      hotspots: @view.hotspots&.files&.map(&:to_h)
+    }
+  end
 
-      def accepted_entries
-        @view.findings.accepted.map { |finding, reason| finding.to_h.merge(reason:) }
-      end
+  def accepted
+    @view.findings.accepted.map { |finding, reason| finding.to_h.merge(reason:) }
+  end
 
-      def complexity_payload = { methods: method_scores, classes: class_scores }
+  def complexity = { methods: the_methods, classes: the_classes }
 
-      def method_scores = @view.complexity.methods.map(&:to_h)
+  def the_methods = @view.complexity.methods.map(&:to_h)
 
-      def class_scores = @view.complexity.classes.map(&:to_h)
+  def the_classes = @view.complexity.classes.map(&:to_h)
 
-      def duplication_payload = @view.duplication.clusters.map { Duplication::Delta.new(it).to_h }
-    end
-  end
+  def duplication = @view.duplication.clusters.map { Hashira::Duplication::Delta.new(it).to_h }
 end

data/lib/hashira/report/metrics_table.rb

@@ -1,37 +1,50 @@
 # frozen_string_literal: true
 
-module Hashira
-  module Report
-    class MetricsTable
-      def initialize(graph, io: $stdout)
-        @graph = graph
-        @io = io
-      end
-
-      def print
-        heading
-        by_instability.each { |package, metric| @io.puts row(package, metric) }
-        legend
-      end
-
-      private
-
-      def by_instability = @graph.metrics.sort_by { |_package, metric| metric.instability }
-
-      def heading
-        @io.puts format("%-12s %3s %3s %3s %5s  %-3s", *%w[package TC Ca Ce I Cyc])
-        @io.puts "-" * 40
-      end
-
-      def row(package, metric)
-        cyclic = @graph.cyclic?(package) ? "YES" : "-"
-        format("%-12s %3d %3d %3d %5.2f  %-3s", package, *metric.to_h.values, cyclic)
-      end
-
-      def legend
-        @io.puts "\nLegend: TC total types, Ca afferent (incoming), Ce efferent (outgoing),"
-        @io.puts "        I=Ce/(Ce+Ca) instability (0=maximally stable, 1=maximally unstable)\n\n"
-      end
-    end
+class Hashira::Report::MetricsTable
+  def initialize(graph, io: $stdout)
+    @graph = graph
+    @io = io
+  end
+
+  LIMIT = 25
+
+  def print
+    heading
+    kept.each { |package, metric| @io.puts(row(package, metric)) }
+    note unless spared.empty?
+    legend
+  end
+
+  private
+
+  def ranked = @graph.metrics.sort_by { |_package, metric| metric.instability }
+
+  def split = @split ||= (ranked.size > LIMIT ? ranked.partition { |_package, metric| !leaf?(metric) } : [ranked, []])
+
+  def kept = split.first
+
+  def spared = split.last
+
+  def leaf?(metric) = metric.types <= 1 && metric.efferent.zero? && metric.afferent <= 1
+
+  def note
+    @io.puts("  + #{spared.size} single-type leaf packages (TC ≤ 1, Ca ≤ 1, Ce = 0) — hidden for brevity")
+  end
+
+  def heading
+    @io.puts(format("%-12s %3s %3s %3s %5s  %-3s", *%w[package TC Ca Ce I Cyc]))
+    @io.puts("-" * 40)
+  end
+
+  def row(package, metric)
+    format(
+      "%-12s %3d %3d %3d %5.2f  %-3s", package, *metric.to_h.values,
+      (@graph.cycles.through?(package) ? "YES" : "-")
+    )
+  end
+
+  def legend
+    @io.puts("\nLegend: TC total types, Ca afferent (incoming), Ce efferent (outgoing),")
+    @io.puts("        I=Ce/(Ce+Ca) instability (0=maximally stable, 1=maximally unstable)\n\n")
   end
 end

data/lib/hashira/report/text.rb

@@ -1,68 +1,75 @@
 # frozen_string_literal: true
 
-module Hashira
-  module Report
-    class Text
-      def initialize(view, io: $stdout)
-        @view = view
-        @io = io
-      end
+class Hashira::Report::Text
+  def initialize(view, io: $stdout)
+    @view = view
+    @io = io
+  end
 
-      def print
-        coupling_sections if @view.graph
-        complexity_section if @view.complexity
-        hotspot_section if @view.hotspots
-        findings_section
-        0
-      end
+  def print
+    coupling if @view.graph
+    complexity if @view.complexity
+    hotspots if @view.hotspots
+    findings
+    0
+  end
 
-      private
+  private
 
-      def coupling_sections
-        graph = @view.graph
-        header(graph)
-        MetricsTable.new(graph, io: @io).print
-        DependencyMap.new(graph, io: @io).print
-      end
+  def coupling
+    graph = @view.graph
+    header(graph)
+    Hashira::Report::MetricsTable.new(graph, io: @io).print
+    Hashira::Report::DependencyMap.new(graph, io: @io).print
+    folded(graph.folds)
+  end
+
+  def folded(folds)
+    return if folds.empty?
+    @io.puts("\nFolded (single-type classes joined to their base or domain):")
+    folds.each { @io.puts("  #{it[:from]} -> #{it[:to]} (#{it[:via]})") }
+  end
 
-      def complexity_section = ComplexityTable.new(@view.complexity, io: @io).print
+  def complexity = Hashira::Report::ComplexityTable.new(@view.complexity, io: @io).print
 
-      def hotspot_section = HotspotTable.new(@view.hotspots, io: @io).print
+  def hotspots = Hashira::Report::HotspotTable.new(@view.hotspots, io: @io).print
 
-      def header(graph)
-        project = @view.project
-        packages = graph.packages.size
-        @io.puts "Package (layer) metrics for #{project.label}  " \
-                 "(#{packages} packages, #{project.files.size} files)\n\n"
-        single_package_note if packages == 1
-      end
+  def header(graph)
+    packages = graph.packages.size
+    @io.puts(banner(packages))
+    caveat if packages == 1
+  end
 
-      def single_package_note
-        @io.puts "Only one package found — there are no boundaries to analyze. " \
-                 "Pass subdirectories to set them (e.g. hashira lib/gem/*/).\n\n"
-      end
+  def banner(packages)
+    "Package (layer) metrics for #{@view.project.label}  (#{packages} packages, #{total} files)\n\n"
+  end
 
-      def findings_section
-        all = @view.findings.all
-        @io.puts "\nFindings (#{all.size}):"
-        print_findings(all)
-        accepted_section
-        @io.puts "\n  Full evidence + machine format: hashira --json" unless all.empty?
-      end
+  def total = @view.project.files.size
 
-      def print_findings(all)
-        return @io.puts "  none ✓ — structure is healthy" if all.empty?
+  def caveat
+    @io.puts(
+      "Only one package found — there are no boundaries to analyze. " \
+        "Pass subdirectories to set them (e.g. hashira lib/gem/*/).\n\n"
+    )
+  end
 
-        all.each { FindingLines.new(it, indent: "  ", io: @io).print_with_overflow }
-      end
+  def findings
+    all = @view.findings.all
+    @io.puts("\nFindings (#{all.size}):")
+    list(all)
+    accepted
+    @io.puts("\n  Full evidence + machine format: hashira --json") unless all.empty?
+  end
 
-      def accepted_section
-        accepted = @view.findings.accepted
-        return if accepted.empty?
+  def list(all)
+    return @io.puts("  none ✓ — structure is healthy") if all.empty?
+    all.each { Hashira::Report::FindingLines.new(it, indent: "  ", io: @io).emit }
+  end
 
-        @io.puts "\nAccepted (#{accepted.size}):"
-        accepted.each { |finding, reason| @io.puts "  ~ #{finding.kind}/#{finding.package} — #{reason}" }
-      end
-    end
+  def accepted
+    accepted = @view.findings.accepted
+    return if accepted.empty?
+    @io.puts("\nAccepted (#{accepted.size}):")
+    accepted.each { |finding, reason| @io.puts("  ~ #{finding.kind}/#{finding.package} — #{reason}") }
   end
 end

data/lib/hashira/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hashira
-  VERSION = "0.2.0"
+  VERSION = "0.4.0"
 end

data/lib/hashira.rb

@@ -1,77 +1,114 @@
 # frozen_string_literal: true
 
-require_relative "hashira/version"
-require_relative "hashira/error"
-require_relative "hashira/project"
-require_relative "hashira/churn"
-require_relative "hashira/analysis/syntax"
-require_relative "hashira/analysis/node_walk"
-require_relative "hashira/analysis/type_walk"
-require_relative "hashira/analysis/references"
-require_relative "hashira/analysis/definitions"
-require_relative "hashira/analysis/root_namespace"
+module Hashira
+  module Analysis
+  end
+
+  module CI
+  end
+
+  module Complexity
+  end
+
+  module Diagram
+  end
+
+  module Duplication
+  end
+
+  module Hotspots
+  end
+
+  module Report
+  end
+end
+
+require_relative "hashira/analysis/catalog"
 require_relative "hashira/analysis/census"
+require_relative "hashira/analysis/constant_registry"
+require_relative "hashira/analysis/cycle_findings"
+require_relative "hashira/analysis/cycle_search"
+require_relative "hashira/analysis/cycles"
+require_relative "hashira/analysis/definition"
+require_relative "hashira/analysis/definitions"
 require_relative "hashira/analysis/edge"
 require_relative "hashira/analysis/edge_map"
-require_relative "hashira/analysis/metric"
-require_relative "hashira/analysis/sdp_check"
-require_relative "hashira/analysis/cycle_search"
-require_relative "hashira/analysis/graph"
 require_relative "hashira/analysis/finding"
+require_relative "hashira/analysis/folder_placement"
+require_relative "hashira/analysis/folding"
+require_relative "hashira/analysis/graph"
+require_relative "hashira/analysis/metric"
+require_relative "hashira/analysis/namespace_placement"
+require_relative "hashira/analysis/namespace_prefix"
+require_relative "hashira/analysis/naming"
+require_relative "hashira/analysis/no_folding"
+require_relative "hashira/analysis/node_walk"
+require_relative "hashira/analysis/placement"
+require_relative "hashira/analysis/references"
+require_relative "hashira/analysis/resolver"
+require_relative "hashira/analysis/roster"
 require_relative "hashira/analysis/rule"
-require_relative "hashira/analysis/cycle_findings"
+require_relative "hashira/analysis/sdp_check"
 require_relative "hashira/analysis/sdp_violation_findings"
-require_relative "hashira/complexity/method_score"
-require_relative "hashira/complexity/rollup"
-require_relative "hashira/complexity/if_chain"
+require_relative "hashira/analysis/syntax"
+require_relative "hashira/analysis/type_walk"
+require_relative "hashira/churn"
+require_relative "hashira/ci/accepted"
+require_relative "hashira/ci/baseline"
+require_relative "hashira/ci/diff"
+require_relative "hashira/ci/edge_diff_report"
+require_relative "hashira/ci/finding_diff_report"
+require_relative "hashira/ci/gate"
+require_relative "hashira/ci/improvement"
+require_relative "hashira/ci/ratchet"
+require_relative "hashira/ci/ratchet_report"
+require_relative "hashira/cli"
+require_relative "hashira/cli/arguments"
+require_relative "hashira/cli/command_line"
+require_relative "hashira/cli/fail_on"
+require_relative "hashira/cli/options"
+require_relative "hashira/cli/package_by"
+require_relative "hashira/cli/run"
+require_relative "hashira/cli/skip"
+require_relative "hashira/cli/usage"
+require_relative "hashira/complexity/analyzer"
 require_relative "hashira/complexity/boolean_run"
-require_relative "hashira/complexity/rescue_scan"
 require_relative "hashira/complexity/cognitive_score"
+require_relative "hashira/complexity/if_chain"
 require_relative "hashira/complexity/method_finding"
-require_relative "hashira/complexity/analyzer"
-require_relative "hashira/duplication/fragment"
-require_relative "hashira/duplication/sequence"
-require_relative "hashira/duplication/extractor"
-require_relative "hashira/duplication/similarity"
-require_relative "hashira/duplication/union_find"
+require_relative "hashira/complexity/method_score"
+require_relative "hashira/complexity/rescue_scan"
+require_relative "hashira/complexity/rollup"
+require_relative "hashira/diagram/dot"
+require_relative "hashira/diagram/mermaid"
+require_relative "hashira/diagram/renderer"
+require_relative "hashira/duplication/analyzer"
 require_relative "hashira/duplication/cluster"
+require_relative "hashira/duplication/clusterer"
+require_relative "hashira/duplication/delta"
+require_relative "hashira/duplication/duplication_finding"
+require_relative "hashira/duplication/extractor"
+require_relative "hashira/duplication/fragment"
 require_relative "hashira/duplication/grouping"
 require_relative "hashira/duplication/index"
-require_relative "hashira/duplication/near_miss"
 require_relative "hashira/duplication/maximal"
-require_relative "hashira/duplication/clusterer"
+require_relative "hashira/duplication/near_miss"
+require_relative "hashira/duplication/sequence"
+require_relative "hashira/duplication/similarity"
+require_relative "hashira/duplication/union_find"
 require_relative "hashira/duplication/variance"
-require_relative "hashira/duplication/delta"
-require_relative "hashira/duplication/duplication_finding"
-require_relative "hashira/duplication/analyzer"
-require_relative "hashira/diagram/dot"
-require_relative "hashira/diagram/mermaid"
-require_relative "hashira/diagram/renderer"
-require_relative "hashira/ci/accepted"
-require_relative "hashira/ci/baseline"
-require_relative "hashira/ci/diff"
-require_relative "hashira/ci/improvement"
-require_relative "hashira/ci/edge_diff_report"
-require_relative "hashira/ci/finding_diff_report"
-require_relative "hashira/ci/ratchet_report"
-require_relative "hashira/ci/gate"
-require_relative "hashira/ci/ratchet"
+require_relative "hashira/error"
 require_relative "hashira/hotspots/file_cost"
 require_relative "hashira/hotspots/rollup"
-require_relative "hashira/report/view"
-require_relative "hashira/report/graph_payload"
-require_relative "hashira/report/finding_lines"
-require_relative "hashira/report/dependency_map"
-require_relative "hashira/report/metrics_table"
+require_relative "hashira/pipeline"
+require_relative "hashira/project"
 require_relative "hashira/report/complexity_table"
+require_relative "hashira/report/dependency_map"
+require_relative "hashira/report/finding_lines"
+require_relative "hashira/report/graph_payload"
 require_relative "hashira/report/hotspot_table"
 require_relative "hashira/report/json"
+require_relative "hashira/report/metrics_table"
 require_relative "hashira/report/text"
-require_relative "hashira/pipeline"
-require_relative "hashira/cli"
-require_relative "hashira/cli/fail_on"
-require_relative "hashira/cli/skip"
-require_relative "hashira/cli/options"
-require_relative "hashira/cli/command_line"
-require_relative "hashira/cli/usage"
-require_relative "hashira/cli/run"
+require_relative "hashira/report/view"
+require_relative "hashira/version"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hashira
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Giacomo GK
@@ -26,18 +26,30 @@ files:
 - README.md
 - exe/hashira
 - lib/hashira.rb
+- lib/hashira/analysis/catalog.rb
 - lib/hashira/analysis/census.rb
+- lib/hashira/analysis/constant_registry.rb
 - lib/hashira/analysis/cycle_findings.rb
 - lib/hashira/analysis/cycle_search.rb
+- lib/hashira/analysis/cycles.rb
+- lib/hashira/analysis/definition.rb
 - lib/hashira/analysis/definitions.rb
 - lib/hashira/analysis/edge.rb
 - lib/hashira/analysis/edge_map.rb
 - lib/hashira/analysis/finding.rb
+- lib/hashira/analysis/folder_placement.rb
+- lib/hashira/analysis/folding.rb
 - lib/hashira/analysis/graph.rb
 - lib/hashira/analysis/metric.rb
+- lib/hashira/analysis/namespace_placement.rb
+- lib/hashira/analysis/namespace_prefix.rb
+- lib/hashira/analysis/naming.rb
+- lib/hashira/analysis/no_folding.rb
 - lib/hashira/analysis/node_walk.rb
+- lib/hashira/analysis/placement.rb
 - lib/hashira/analysis/references.rb
-- lib/hashira/analysis/root_namespace.rb
+- lib/hashira/analysis/resolver.rb
+- lib/hashira/analysis/roster.rb
 - lib/hashira/analysis/rule.rb
 - lib/hashira/analysis/sdp_check.rb
 - lib/hashira/analysis/sdp_violation_findings.rb
@@ -54,9 +66,11 @@ files:
 - lib/hashira/ci/ratchet.rb
 - lib/hashira/ci/ratchet_report.rb
 - lib/hashira/cli.rb
+- lib/hashira/cli/arguments.rb
 - lib/hashira/cli/command_line.rb
 - lib/hashira/cli/fail_on.rb
 - lib/hashira/cli/options.rb
+- lib/hashira/cli/package_by.rb
 - lib/hashira/cli/run.rb
 - lib/hashira/cli/skip.rb
 - lib/hashira/cli/usage.rb

data/lib/hashira/analysis/root_namespace.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-module Hashira
-  module Analysis
-    module RootNamespace
-      module_function
-
-      def infer(definitions)
-        definitions.map { |_node, full, _package| full.first }
-                   .tally.max_by { |_name, count| count }&.first
-      end
-    end
-  end
-end