hashie 3.2.0 → 3.3.1

data/spec/hashie/extensions/mash/safe_assignment_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe Hashie::Extensions::Mash::SafeAssignment do
+  class MashWithSafeAssignment < Hashie::Mash
+    include Hashie::Extensions::Mash::SafeAssignment
+  end
+
+  context 'when included in Mash' do
+    subject { MashWithSafeAssignment.new }
+
+    context 'when attempting to override a method' do
+      it 'raises an error' do
+        expect { subject.zip = 'Test' }.to raise_error(ArgumentError)
+      end
+    end
+  end
+end

data/spec/hashie/extensions/method_access_spec.rb

@@ -119,3 +119,58 @@ describe Hashie::Extensions::MethodAccess do
     expect((klass.ancestors & [Hashie::Extensions::MethodReader, Hashie::Extensions::MethodWriter, Hashie::Extensions::MethodQuery]).size).to eq 3
   end
 end
+
+describe Hashie::Extensions::MethodOverridingWriter do
+  class OverridingHash < Hash
+    include Hashie::Extensions::MethodOverridingWriter
+  end
+
+  subject { OverridingHash.new }
+
+  it 'writes from a method call' do
+    subject.awesome = 'sauce'
+    expect(subject['awesome']).to eq 'sauce'
+  end
+
+  it 'convertes the key using the #convert_key method' do
+    allow(subject).to receive(:convert_key).and_return(:awesome)
+    subject.awesome = 'sauce'
+    expect(subject[:awesome]).to eq 'sauce'
+  end
+
+  it 'raises NoMethodError on non equals-ending methods' do
+    expect { subject.awesome }.to raise_error(NoMethodError)
+  end
+
+  it '#respond_to_missing? correctly' do
+    expect(subject).to respond_to(:abc=)
+    expect(subject).not_to respond_to(:abc)
+    expect(subject.method(:abc=)).not_to be_nil
+  end
+
+  context 'when writing a Hash method' do
+    before { subject.zip = 'a-dee-doo-dah' }
+
+    it 'overrides the original method' do
+      expect(subject.zip).to eq 'a-dee-doo-dah'
+    end
+
+    it 'aliases the method with two leading underscores' do
+      expect(subject.__zip).to eq [[%w(zip a-dee-doo-dah)]]
+    end
+
+    it 'does not re-alias when overriding an already overridden method' do
+      subject.zip = 'test'
+      expect(subject.zip).to eq 'test'
+      expect(subject.__zip).to eq [[%w(zip test)]]
+    end
+  end
+end
+
+describe Hashie::Extensions::MethodAccessWithOverride do
+  it 'includes all of the other method mixins' do
+    klass = Class.new(Hash)
+    klass.send :include, Hashie::Extensions::MethodAccessWithOverride
+    expect((klass.ancestors & [Hashie::Extensions::MethodReader, Hashie::Extensions::MethodOverridingWriter, Hashie::Extensions::MethodQuery]).size).to eq 3
+  end
+end

data/spec/hashie/mash_spec.rb

@@ -499,4 +499,96 @@ describe Hashie::Mash do
       end
     end
   end
+
+  describe '.load(filename, options = {})' do
+    let(:config) do
+      {
+        'production' => {
+          'foo' => 'production_foo'
+        }
+      }
+    end
+    let(:path) { 'database.yml' }
+    let(:parser) { double(:parser) }
+
+    subject { described_class.load(path, parser: parser) }
+
+    before do |ex|
+      unless ex.metadata == :test_cache
+        described_class.instance_variable_set('@_mashes', nil) # clean the cached mashes
+      end
+    end
+
+    context 'if the file exists' do
+      before do
+        expect(File).to receive(:file?).with(path).and_return(true)
+        expect(parser).to receive(:perform).with(path).and_return(config)
+      end
+
+      it { is_expected.to be_a(Hashie::Mash) }
+
+      it 'return a Mash from a file' do
+        expect(subject.production).not_to be_nil
+        expect(subject.production.keys).to eq config['production'].keys
+        expect(subject.production.foo).to eq config['production']['foo']
+      end
+
+      it 'freeze the attribtues' do
+        expect { subject.production = {} }.to raise_exception(RuntimeError, /can't modify frozen/)
+      end
+    end
+
+    context 'if the fils does not exists' do
+      before do
+        expect(File).to receive(:file?).with(path).and_return(false)
+      end
+
+      it 'raise an ArgumentError' do
+        expect { subject }.to raise_exception(ArgumentError)
+      end
+    end
+
+    describe 'results are cached' do
+      let(:parser) { double(:parser) }
+
+      subject { described_class.load(path, parser: parser) }
+
+      before do
+        expect(File).to receive(:file?).with(path).and_return(true)
+        expect(File).to receive(:file?).with("#{path}+1").and_return(true)
+        expect(parser).to receive(:perform).once.with(path).and_return(config)
+        expect(parser).to receive(:perform).once.with("#{path}+1").and_return(config)
+      end
+
+      it 'cache the loaded yml file', :test_cache do
+        2.times do
+          expect(subject).to be_a(described_class)
+          expect(described_class.load("#{path}+1", parser: parser)).to be_a(described_class)
+        end
+
+        expect(subject.object_id).to eq subject.object_id
+      end
+    end
+  end
+
+  describe '#to_module(mash_method_name)' do
+    let(:mash) { described_class.new }
+    subject { Class.new.extend mash.to_module }
+
+    it 'defines a settings method on the klass class that extends the module' do
+      expect(subject).to respond_to(:settings)
+      expect(subject.settings).to eq mash
+    end
+
+    context 'when a settings_method_name is set' do
+      let(:mash_method_name) { 'config' }
+
+      subject { Class.new.extend mash.to_module(mash_method_name) }
+
+      it 'defines a settings method on the klass class that extends the module' do
+        expect(subject).to respond_to(mash_method_name.to_sym)
+        expect(subject.send(mash_method_name.to_sym)).to eq mash
+      end
+    end
+  end
 end

data/spec/hashie/rash_spec.rb

@@ -47,4 +47,31 @@ describe Hashie::Rash do
     expect(subject['abcdef']).to eq 'bcd'
     expect(subject['ffffff']).to be_nil
   end
+
+  it 'finds using the find method' do
+    expect(subject.fetch(10.1)).to eq 'rangey'
+    expect(subject.fetch(true)).to be false
+  end
+
+  it 'raises in find unless a key matches' do
+    expect { subject.fetch(1_000_000) }.to raise_error(KeyError)
+  end
+
+  it 'yields in find unless a key matches' do
+    expect { |y| subject.fetch(1_000_000, &y) }.to yield_control
+    expect { |y| subject.fetch(10.1, &y) }.to_not yield_control
+  end
+
+  it 'gives a default value' do
+    expect(subject.fetch(10.1, 'noop')).to eq 'rangey'
+    expect(subject.fetch(1_000_000, 'noop')).to eq 'noop'
+    expect(subject.fetch(1_000_000) { 'noop' }).to eq 'noop'
+    expect(subject.fetch(1_000_000) { |k| k }).to eq 1_000_000
+    expect(subject.fetch(1_000_000, 'noop') { 'op' }).to eq 'op'
+  end
+
+  it 'responds to hash methods' do
+    expect(subject.respond_to?(:to_a)).to be true
+    expect(subject.methods).to_not include(:to_a)
+  end
 end

data/spec/hashie/trash_spec.rb

@@ -29,7 +29,7 @@ describe Hashie::Trash do
     end
 
     it 'maintains translations hash mapping from the original to the translated name' do
-      expect(TrashTest.translations[:firstName]).to eq :first_name
+      expect(TrashTest.translations[:firstName]).to eq(:first_name)
     end
 
     it 'maintains inverse translations hash mapping from the translated to the original name' do
@@ -110,7 +110,7 @@ describe Hashie::Trash do
 
   describe 'translating properties using a proc' do
     class TrashLambdaTest < Hashie::Trash
-      property :first_name, from: :firstName, with: lambda { |value| value.reverse }
+      property :first_name, from: :firstName, with: ->(value) { value.reverse }
     end
 
     let(:lambda_trash) { TrashLambdaTest.new }
@@ -134,9 +134,32 @@ describe Hashie::Trash do
     end
   end
 
+  describe 'translating multiple properties using a proc' do
+    class SomeDataModel < Hashie::Trash
+      property :value_a, from: :config, with: ->(config) { config.a }
+      property :value_b, from: :config, with: ->(config) { config.b }
+    end
+
+    ConfigDataModel = Struct.new(:a, :b)
+
+    subject { SomeDataModel.new(config: ConfigDataModel.new('value in a', 'value in b')) }
+
+    it 'translates the first key' do
+      expect(subject.value_a).to eq 'value in a'
+    end
+
+    it 'translates the second key' do
+      expect(subject.value_b).to eq 'value in b'
+    end
+
+    it 'maintains translations hash mapping from the original to the translated name' do
+      expect(SomeDataModel.translations).to eq(config: [:value_a, :value_b])
+    end
+  end
+
   describe 'uses with or transform_with interchangeably' do
     class TrashLambdaTestTransformWith < Hashie::Trash
-      property :first_name, from: :firstName, transform_with: lambda { |value| value.reverse }
+      property :first_name, from: :firstName, transform_with: ->(value) { value.reverse }
     end
 
     let(:lambda_trash) { TrashLambdaTestTransformWith.new }
@@ -154,7 +177,7 @@ describe Hashie::Trash do
 
   describe 'translating properties without from option using a proc' do
     class TrashLambdaTestWithProperties < Hashie::Trash
-      property :first_name, transform_with: lambda { |value| value.reverse }
+      property :first_name, transform_with: ->(value) { value.reverse }
     end
 
     let(:lambda_trash) { TrashLambdaTestWithProperties.new }
@@ -170,7 +193,7 @@ describe Hashie::Trash do
 
     context 'when :from option is given' do
       class TrashLambdaTest3 < Hashie::Trash
-        property :first_name, from: :firstName, transform_with: lambda { |value| value.reverse }
+        property :first_name, from: :firstName, transform_with: ->(value) { value.reverse }
       end
 
       it 'does not override the :from option in the constructor' do
@@ -186,6 +209,42 @@ describe Hashie::Trash do
     end
   end
 
+  describe 'inheritable transforms' do
+    class TransformA < Hashie::Trash
+      property :some_value, transform_with: ->(v) { v.to_i }
+    end
+
+    class TransformB < TransformA
+      property :some_other_value, transform_with: ->(v) { v.to_i }
+    end
+
+    class TransformC < TransformB
+      property :some_value, transform_with: ->(v) { -v.to_i }
+    end
+
+    it 'inherit properties transforms' do
+      expect(TransformB.new(some_value: '123', some_other_value: '456').some_value).to eq(123)
+    end
+
+    it 'replaces property transform' do
+      expect(TransformC.new(some_value: '123', some_other_value: '456').some_value).to eq(-123)
+    end
+  end
+
+  describe 'inheritable translations' do
+    class TranslationA < Hashie::Trash
+      property :some_value, from: 'someValue', with: ->(v) { v.to_i }
+    end
+
+    class TranslationB < TranslationA
+      property :some_other_value, from: 'someOtherValue'
+    end
+
+    it 'inherit properties translations' do
+      expect(TranslationB.new('someValue' => '123').some_value).to eq(123)
+    end
+  end
+
   it 'raises an error when :from have the same value as property' do
     expect do
       class WrongTrash < Hashie::Trash

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'rubygems'
+require 'pry'
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hashie
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.1
 platform: ruby
 authors:
 - Michael Bleigh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-10 00:00:00.000000000 Z
+date: 2014-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -58,6 +58,7 @@ files:
 - Guardfile
 - LICENSE
 - README.md
+- RELEASING.md
 - Rakefile
 - UPGRADING.md
 - hashie.gemspec
@@ -67,12 +68,15 @@ files:
 - lib/hashie/extensions/coercion.rb
 - lib/hashie/extensions/dash/indifferent_access.rb
 - lib/hashie/extensions/deep_fetch.rb
+- lib/hashie/extensions/deep_find.rb
 - lib/hashie/extensions/deep_merge.rb
 - lib/hashie/extensions/ignore_undeclared.rb
 - lib/hashie/extensions/indifferent_access.rb
 - lib/hashie/extensions/key_conversion.rb
+- lib/hashie/extensions/mash/safe_assignment.rb
 - lib/hashie/extensions/merge_initializer.rb
 - lib/hashie/extensions/method_access.rb
+- lib/hashie/extensions/parsers/yaml_erb_parser.rb
 - lib/hashie/extensions/pretty_inspect.rb
 - lib/hashie/extensions/stringify_keys.rb
 - lib/hashie/extensions/symbolize_keys.rb
@@ -86,11 +90,13 @@ files:
 - spec/hashie/extensions/coercion_spec.rb
 - spec/hashie/extensions/dash/indifferent_access_spec.rb
 - spec/hashie/extensions/deep_fetch_spec.rb
+- spec/hashie/extensions/deep_find_spec.rb
 - spec/hashie/extensions/deep_merge_spec.rb
 - spec/hashie/extensions/ignore_undeclared_spec.rb
 - spec/hashie/extensions/indifferent_access_spec.rb
 - spec/hashie/extensions/indifferent_access_with_rails_hwia_spec.rb
 - spec/hashie/extensions/key_conversion_spec.rb
+- spec/hashie/extensions/mash/safe_assignment_spec.rb
 - spec/hashie/extensions/merge_initializer_spec.rb
 - spec/hashie/extensions/method_access_spec.rb
 - spec/hashie/hash_spec.rb
@@ -129,11 +135,13 @@ test_files:
 - spec/hashie/extensions/coercion_spec.rb
 - spec/hashie/extensions/dash/indifferent_access_spec.rb
 - spec/hashie/extensions/deep_fetch_spec.rb
+- spec/hashie/extensions/deep_find_spec.rb
 - spec/hashie/extensions/deep_merge_spec.rb
 - spec/hashie/extensions/ignore_undeclared_spec.rb
 - spec/hashie/extensions/indifferent_access_spec.rb
 - spec/hashie/extensions/indifferent_access_with_rails_hwia_spec.rb
 - spec/hashie/extensions/key_conversion_spec.rb
+- spec/hashie/extensions/mash/safe_assignment_spec.rb
 - spec/hashie/extensions/merge_initializer_spec.rb
 - spec/hashie/extensions/method_access_spec.rb
 - spec/hashie/hash_spec.rb